Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aws-lc for default rustls #141

Open
clux opened this issue Mar 3, 2024 · 0 comments
Open

Support aws-lc for default rustls #141

clux opened this issue Mar 3, 2024 · 0 comments

Comments

@clux
Copy link
Owner

clux commented Mar 3, 2024

https://github.com/aws/aws-lc is needed for default builds of rustls 0.23.

this is seen in their features
and blog post

spotted via a test error a few days ago:

   Compiling ring v0.17.8
   Compiling aws-lc-sys v0.13.2
   Compiling ring v0.16.20
error: failed to run custom build command for `aws-lc-sys v0.13.2`

Caused by:
  process didn't exit successfully: `/volume/target/debug/build/aws-lc-sys-095b332bc7a90d49/build-script-main` (exit status: 101)
  --- stdout
  cargo:rustc-cfg=use_bindgen_generated

  --- stderr
  thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/aws-lc-sys-0.13.2/builder/main.rs:286:5:
  aws-lc-sys build failed. Please enable the 'bindgen' feature on aws-lc-rs or aws-lc-sys
  stack backtrace:
     0: rust_begin_unwind
               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:645:5
     1: core::panicking::panic_fmt
               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panicking.rs:72:14
     2: build_script_main::main
               at ./builder/main.rs:286:5
     3: core::ops::function::FnOnce::call_once
               at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
  note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
warning: build failed, waiting for other jobs to finish...
error: Recipe `_t` failed on line 27 with exit code 101
Error: Process completed with exit code 101.

judging by their issues it should be possible: aws/aws-lc#384
instructions look simple enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant