Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zlib-ng? #107

Open
bjornharrtell opened this issue Sep 20, 2022 · 4 comments
Open

Add zlib-ng? #107

bjornharrtell opened this issue Sep 20, 2022 · 4 comments

Comments

@bjornharrtell
Copy link

Feature request :)

@clux
Copy link
Owner

clux commented Sep 24, 2022

zlib-ng does seem like a reasonable drop-in replacement - provided it can indeed be made to work for the other consumers of it (i.e. curl and openssl - libpq currently doesn't even compile with zlib..).

Long term I am kind of hoping to have less C dependencies here because of maintenance required, but that requires rustls to iron out some of their last production limiting issues so that means at least some years more of maintaining openssl here.

So.. maybe? I don't really know what benefits this would entail for users of a docker image? I honestly wasn't expecting much movement on zlib at this point, so there probably would have to be some good performance benefits for it to be worth the maintenance overhead.

@bjornharrtell
Copy link
Author

Unfortunately the pure rust impl performs worse than both the classic c zlib and zlib-ng is significatly faster than zlib.

@clux
Copy link
Owner

clux commented Sep 24, 2022

Do you know of any benchmarks around to look at?

@bjornharrtell
Copy link
Author

bjornharrtell commented Sep 24, 2022

There are bits and pieces around, fx. Frommi/miniz_oxide#5. But I see there is stuff like https://lib.rs/crates/simd-adler32.. but seems it is not easily opted in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants