Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify API, instantiate RedisClient instead of Factory #118

Open
clue opened this issue Nov 26, 2021 · 0 comments
Open

Simplify API, instantiate RedisClient instead of Factory #118

clue opened this issue Nov 26, 2021 · 0 comments

Comments

@clue
Copy link
Owner

clue commented Nov 26, 2021

There are plans to simplify the API by removing the Factory and instead replacing it with a simpler RedisClient constructor. In other words, this:

$factory = new Clue\React\Redis\Factory();
$redis = $factory->createLazyClient('localhost');

$redis->incr('counter');

Could potentially look like this:

$redis = new Clue\React\Redis\RedisClient('localhost');

$redis->incr('counter');

Internally, the RedisClient would work similar to what is currently called a "lazy" client, but we'll probably get rid of this wording altogether. This means it would automatically create the underlying connection to Redis only when it's actually needed and will close this connection after a short while when it is not in use anymore. What is currently called "idle" time would probably be reworded to be more of a "keepalive" with much lower defaults.

Additionally, we'll probably fire "open" and "close" events as needed (loosely inspired by https://github.com/clue/reactphp-eventsource). Unlike the current version, my idea is to also keep the instance in a usable state even after calling close() on it. Reusing the same instance at a later time makes a lot more sense in long-running applications instead of locking it in an unusable state.

This is obviously a BC break, but there are no plans to break any of the existing code besides this. Most consumers should be able to upgrade to the new instantiation without issues, actual query APIs etc. would not be affected.

The same API discussion also applies to SQLite (clue/reactphp-sqlite#47), MySQL (friends-of-reactphp/mysql#147) and others
Builds on top of #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant