Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all panics into properly handled errors. #16

Open
THEGOLDENPRO opened this issue Oct 14, 2024 · 1 comment
Open

Replace all panics into properly handled errors. #16

THEGOLDENPRO opened this issue Oct 14, 2024 · 1 comment
Assignees
@THEGOLDENPRO
Labels
enhancement New feature or request

Comments

@THEGOLDENPRO
Copy link
Member

THEGOLDENPRO commented Oct 14, 2024 •
edited
Loading

For example instead of panicking that an image does not exist we return an error which is then handled by the outer scope to simply print to the user that the image path they gave does not exist. Just an example, most errors will need to also be displayed in the window. Maybe we make some sort of error page.
@THEGOLDENPRO THEGOLDENPRO added the enhancement New feature or request label Oct 14, 2024
@THEGOLDENPRO THEGOLDENPRO self-assigned this Oct 14, 2024
@THEGOLDENPRO
Copy link
Member Author

Getting some of this done in feat/click-rose-for-file-dialog.

I'm adding UI notifications on errors. ✨

Screenshot_20241103_171613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@THEGOLDENPRO THEGOLDENPRO

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@THEGOLDENPRO