Downsampling breaks on systems with multiple monitors.

[THEGOLDENPRO]

rdev's display_size() on systems with more than one monitor returns the dimensions of all the monitors combined which breaks the image down-sampling optimization as it gets skipped if those combined monitor dimensions are bigger than the image which is almost always true.

Down-sampling optimization should only occur if the image is quite a bit bigger than ONLY the current monitor in use but display_size() from rdev returns the size of all the monitors combined. This is important as now images that are high res will NOT get down-sampled leading to pixely images and more memory being consumed than normal.

Source code in question:

roseate/src/app.rs

Lines 96 to 104 in 5456d28

	let (width, height) = display_size().expect("Failed to get monitor size!");
	let mut optimizations = Vec::new();
	if mutable_image.image_size.width > width as usize && mutable_image.image_size.height > height as usize {
	optimizations.push(ImageOptimization::Downsample(width as u32, height as u32));
	}
	mutable_image.load_image(&optimizations);

[THEGOLDENPRO]

this might be good: https://crates.io/crates/display-info

[THEGOLDENPRO]

switched over to that display-info crate but this will need testing. idk if it will blow up on other systems

[THEGOLDENPRO]

I wonder how this crate will play on something FreeBSD as I would like Roseate to support that. 🤔

[r3tr0ananas]

display-info doesn't work on freebsd.

[THEGOLDENPRO]

I guess someone will have to add support to display-info for it then.

[THEGOLDENPRO]

it could be a matter of just allowing the linux module in display-info for freebsd too but I don't know that until I can test it or get someone to test it.

https://doc.rust-lang.org/reference/conditional-compilation.html#target_os
https://github.com/nashaofu/display-info/blob/master/src/lib.rs#L18-L21

[THEGOLDENPRO]

@r3tr0ananas if you want something to work on could you possibly try and get display-info to work in FreeBSD. I was having trouble getting x11 in FreeBSD to pick up my mouse under a VM. (I should probably try USB passthrough)

[r3tr0ananas]

I already tried it with adding target_os = "freebsd" and it doesn't work. I get use of declared crate or module xcb and use of declared crate or module smithay_client_toolkit.