fix(pilota-build): keep the leading underscore in idl method name #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Referred to codegen issue, the method name starting with '_' would be removed when using the
ToUpperCamelCase
trait in heck 0.5, which is the first step for the function name. This process is because that in order to generate a struct name that conforms to the rust specification, this step will be performed on the function name to obtain the prefix of the function parameter variable name.Solution
We will keep the beginning underscore of function name string using the
IdentName
trait defined in our own crate, whichto_upper_ident
method would preserve the beginning_
.