Skip to content

Commit

Permalink
docs: add comment for kitex-mux comparison (#60)
Browse files Browse the repository at this point in the history
  • Loading branch information
joway authored Sep 25, 2023
1 parent beba686 commit fbd83a0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,9 @@ The benchmark ensures the caller has sufficient machine resources **overwhelming
![image](docs/images/thrift_tp999.png)

#### Protobuf
Note: the message protocols used by each framework are different. About GRPC, the next part has comparison.
Note:
1. The message protocols used by each framework are different. About GRPC, the next part has comparison.
2. Some frameworks (such as ARPC) use multiplexing, so should refer to the result of KITEX-MUX for comparison.

![image](docs/images/pb_qps.png)
![image](docs/images/pb_tp99.png)
Expand Down
4 changes: 3 additions & 1 deletion README_cn.md
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ sleep=0
![image](docs/images/thrift_tp999.png)

#### Protobuf
注意:各框架使用的消息协议不同,gRPC 下面有专门的对比
注意:
1. 各框架使用的消息协议不同,gRPC 下面有专门的对比
2. 部分框架(如 ARPC) 采用了多路复用方式访问,需要参考 KITEX-MUX 结果对比

![image](docs/images/pb_qps.png)
![image](docs/images/pb_tp99.png)
Expand Down
4 changes: 3 additions & 1 deletion scripts/reports/diff.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ class bcolors:
def diff(from_csv, to_csv):
from_reader = list(csv.reader(open(from_csv)))
to_reader = csv.reader(open(to_csv))
title = ['Kind', 'Concurrency', 'Data Size', 'QPS', 'P99', 'P999']
results = []

for line_num, line in enumerate(to_reader):
Expand All @@ -37,6 +38,8 @@ def diff(from_csv, to_csv):

results.append(result)

results.sort(key=lambda result: result[0])
results.insert(0, title)
print_csv(results)


Expand All @@ -48,7 +51,6 @@ def diff_cell(old, now):


def print_csv(results):
results.sort(key=lambda result: result[0])
cell_size = 15
for line in results:
result = []
Expand Down

0 comments on commit fbd83a0

Please sign in to comment.