Javahashes #341
Merged
Javahashes #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 24, 2017 08:49
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 88.54% 88.63% +0.08%
==========================================
Files 117 120 +3
Lines 4888 4944 +56
==========================================
+ Hits 4328 4382 +54
- Misses 560 562 +2
Continue to review full report at Codecov.
|
tests/unit/test_jar_plugin.py
Outdated
| from plugins.systems.jar_host_crawler import JarHostCrawler | ||
|
|
||
|
|
||
| class GPUPluginTests(unittest.TestCase): |
There was a problem hiding this comment.
Please rename this :)
| # | ||
|
|
||
| sys.path.append('tests/unit/') | ||
| from plugins.systems.jar_host_crawler import JarHostCrawler |
There was a problem hiding this comment.
Can you please also test JarContainerCrawler class with a dummy container?
Signed-off-by: Sastry Duri <[email protected]>
…rawler into javahashes
tests/unit/test_plugins.py
Outdated
| myjar.writestr(ZipInfo('second.class',(1980,1,1,1,1,1)), "second secrets!") | ||
| myjar.writestr(ZipInfo('second.txt',(1980,1,1,1,1,1)), "second secrets!") | ||
|
|
||
| fc = JarHostCrawler() |
There was a problem hiding this comment.
This should be JarContainerCrawler()
|
Also, please squash commits into 1 |
…map_files option in crawler.conf Signed-off-by: Sahil Suneja <[email protected]>
Signed-off-by: Sahil Suneja <[email protected]>
…rawler into javahashes
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
Signed-off-by: Sastry Duri <[email protected]>
|
Thank you! Please squash the commits into one, then we are good to merge. |
sahilsuneja1
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses the need in this issue