Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL dialect support #177

Open
apstndb opened this issue Jul 9, 2024 · 2 comments
Open

PostgreSQL dialect support #177

apstndb opened this issue Jul 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@apstndb
Copy link
Collaborator

apstndb commented Jul 9, 2024

While this is a high hanging fruit and I don't think it's a highly demanded feature, there is a room to support the PostgreSQL database dialect with native RPC(not PostgreSQL wire protocol).

@apstndb apstndb added the enhancement New feature or request label Jul 9, 2024
@yfuruyama
Copy link
Collaborator

I'm not sure if supporting PostgreSQL dialect in spanner-cli is a good approach.

We can use PGAdapter to use psql against Cloud Spanner database, so it should be able to cover most of the statements in PostgreSQL dialect.

@apstndb
Copy link
Collaborator Author

apstndb commented Jul 25, 2024

I have reconsidered potential usecases of this feature.

I suspect that psql with PGAdapter does not support Cloud Spanner's native execution plans. Therefore, it seems that spanner-cli's PostgreSQL interface support has value as a plan viewer.

Of course, this is not a high priority feature, but I think there are use cases that I haven't imagined yet, so I think it's best to leave this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants