Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds snapshot tests to main test utils wrappers #2980

Merged

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Nov 4, 2024

Description

  1. Puts screenshot and functional tests in separate folders.
  2. Adds screenshot tests for the test utils output.

Related links, issue #, if available: Pre-requisite to #2932

How has this been tested?

Tested by running the unit tests

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@orangevolon orangevolon force-pushed the alamiami/adds-screenshot-tests-to-test-utils-wrappers branch from a5cbf28 to cdb32e6 Compare November 4, 2024 16:23
@orangevolon orangevolon changed the title Alamiami/adds screenshot tests to test utils wrappers chore: adds screenshot tests to ElementWrapper from test utils Nov 4, 2024
@orangevolon orangevolon changed the title chore: adds screenshot tests to ElementWrapper from test utils chore: adds screenshot tests to main test utils wrappers Nov 4, 2024
@orangevolon orangevolon force-pushed the alamiami/adds-screenshot-tests-to-test-utils-wrappers branch from cdb32e6 to 9a4f720 Compare November 4, 2024 16:30
@orangevolon orangevolon marked this pull request as ready for review November 4, 2024 16:31
@orangevolon orangevolon requested a review from a team as a code owner November 4, 2024 16:31
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (7175cd1) to head (77a8d98).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2980    +/-   ##
========================================
  Coverage   96.27%   96.27%            
========================================
  Files         769      769            
  Lines       21766    21766            
  Branches     7384     7040   -344     
========================================
  Hits        20955    20955            
- Misses        758      803    +45     
+ Partials       53        8    -45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

just-boris
just-boris previously approved these changes Nov 4, 2024
@orangevolon orangevolon force-pushed the alamiami/adds-screenshot-tests-to-test-utils-wrappers branch from 9a4f720 to 77a8d98 Compare November 5, 2024 07:48
@just-boris just-boris changed the title chore: adds screenshot tests to main test utils wrappers chore: adds snapshot tests to main test utils wrappers Nov 5, 2024
@orangevolon orangevolon added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit d8edc99 Nov 5, 2024
74 checks passed
@orangevolon orangevolon deleted the alamiami/adds-screenshot-tests-to-test-utils-wrappers branch November 5, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants