-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adds snapshot tests to main test utils wrappers #2980
Merged
orangevolon
merged 2 commits into
main
from
alamiami/adds-screenshot-tests-to-test-utils-wrappers
Nov 5, 2024
Merged
chore: adds snapshot tests to main test utils wrappers #2980
orangevolon
merged 2 commits into
main
from
alamiami/adds-screenshot-tests-to-test-utils-wrappers
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangevolon
force-pushed
the
alamiami/adds-screenshot-tests-to-test-utils-wrappers
branch
from
November 4, 2024 16:23
a5cbf28
to
cdb32e6
Compare
orangevolon
changed the title
Alamiami/adds screenshot tests to test utils wrappers
chore: adds screenshot tests to ElementWrapper from test utils
Nov 4, 2024
orangevolon
changed the title
chore: adds screenshot tests to ElementWrapper from test utils
chore: adds screenshot tests to main test utils wrappers
Nov 4, 2024
orangevolon
force-pushed
the
alamiami/adds-screenshot-tests-to-test-utils-wrappers
branch
from
November 4, 2024 16:30
cdb32e6
to
9a4f720
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2980 +/- ##
========================================
Coverage 96.27% 96.27%
========================================
Files 769 769
Lines 21766 21766
Branches 7384 7040 -344
========================================
Hits 20955 20955
- Misses 758 803 +45
+ Partials 53 8 -45 ☔ View full report in Codecov by Sentry. |
just-boris
previously approved these changes
Nov 4, 2024
orangevolon
force-pushed
the
alamiami/adds-screenshot-tests-to-test-utils-wrappers
branch
from
November 5, 2024 07:48
9a4f720
to
77a8d98
Compare
just-boris
changed the title
chore: adds screenshot tests to main test utils wrappers
chore: adds snapshot tests to main test utils wrappers
Nov 5, 2024
just-boris
approved these changes
Nov 5, 2024
orangevolon
deleted the
alamiami/adds-screenshot-tests-to-test-utils-wrappers
branch
November 5, 2024 10:39
This was referenced Nov 5, 2024
timogasda
pushed a commit
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links, issue #, if available: Pre-requisite to #2932
How has this been tested?
Tested by running the unit tests
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.