Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs vs _site for storing the generated Website. #58

Closed
wildintellect opened this issue Sep 15, 2023 · 6 comments
Closed

Docs vs _site for storing the generated Website. #58

wildintellect opened this issue Sep 15, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@wildintellect
Copy link
Contributor

I ran into an issue, when I generate a local preview of the site it now uses the docs folder, and since this folder is not ignored (.gitignore) my local copy wants to be committed to git.

What we had previously was that _site was generated, but on github this was only ever in a gh-pages branch. So the actual website files would never end up in the main and accidentally be direct edited, pushed, or pull.

I'm not sure what the typical layout is for quarto sites on github (the template we use is _stite only in gh-pages).

Suggestions @jedsundwall @abarciauskas-bgse @kylebarron

@wildintellect wildintellect added the enhancement New feature or request label Sep 15, 2023
@kylebarron
Copy link
Member

I agree; I mentioned in #55 (comment) that I was confused that docs was committed to git.

My preference would be to revert to only storing the built form of the docs on the gh-pages branch

@jedsundwall
Copy link
Member

@kylebarron @wildintellect I think I've figured this out and gone back to how you'd had it configured before. Thanks for pointing me in the right direction. Previews appear to work and deploying to the gh-pages branch seems to work properly now.

@wildintellect
Copy link
Contributor Author

Do we plan to remove the docs from the main branch then?

@jedsundwall
Copy link
Member

Yes, #55 will remove docs from the main branch when merged.

@kylebarron
Copy link
Member

https://guide.cloudnativegeo.org/ appears to no longer be served correctly.

@kylebarron
Copy link
Member

Closing this as fixed in #61, which moved the built website back to _site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants