Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid setting configmap name with config.secret=true #157

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

phisco
Copy link
Collaborator

@phisco phisco commented Oct 30, 2023

Fixes #156

with config.secret=false:

$ helm template test --set config.secret=false charts/cloudnative-pg | grep cnpg-controller-manager-config -C 5
# limitations under the License.
#
apiVersion: v1
kind: ConfigMap
metadata:
  name: cnpg-controller-manager-config
  labels:
    helm.sh/chart: cloudnative-pg-0.19.0
    app.kubernetes.io/name: cloudnative-pg
    app.kubernetes.io/instance: test
    app.kubernetes.io/version: "1.21.0"
--
    spec:
      containers:
      - args:
        - controller
        - --leader-elect
        - --config-map-name=cnpg-controller-manager-config
        - --webhook-port=9443
        command:
        - /manager
        env:
        - name: OPERATOR_IMAGE_NAME

with config.secret=true:

$ helm template test --set config.secret=true charts/cloudnative-pg | grep cnpg-controller-manager-config -C 5
#
apiVersion: v1
kind: Secret
type: Opaque
metadata:
  name: cnpg-controller-manager-config
  labels:
    helm.sh/chart: cloudnative-pg-0.19.0
    app.kubernetes.io/name: cloudnative-pg
    app.kubernetes.io/instance: test
    app.kubernetes.io/version: "1.21.0"
--
    spec:
      containers:
      - args:
        - controller
        - --leader-elect
        - --secret-name=cnpg-controller-manager-config
        - --webhook-port=9443
        command:
        - /manager
        env:
        - name: OPERATOR_IMAGE_NAME

@phisco phisco merged commit 0a088b1 into main Oct 30, 2023
3 checks passed
@phisco phisco deleted the fix/respect-config-secret branch October 30, 2023 10:38
@itay-grudev itay-grudev added the chart( operator ) Related to the operator (cloudnative-pg) chart label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart( operator ) Related to the operator (cloudnative-pg) chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cnpg-controller-manager-config breaking issue in 0.19.0
3 participants