Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could npm build errors get reported to the Drizzle UI somehow? #89

Open
freyley opened this issue Aug 31, 2016 · 1 comment
Open

Could npm build errors get reported to the Drizzle UI somehow? #89

freyley opened this issue Aug 31, 2016 · 1 comment

Comments

@freyley
Copy link

freyley commented Aug 31, 2016

We've been building components in Atom on one side of the screen, with the port-3000 Drizzle UI on the left side of the screen. When we had syntax errors, we had to switch to terminal to find the error that npm was spitting out - it'd have been awesome if the Drizzle UI had shown us that npm was erroring somehow.

Here are some examples of syntax errors that didn't kill npm, but did prevent us from seeing any change in Drizzle:

{{embed "patterns.components.pagination.base" }}{{/embed}}
(missing the # on {{# )

{{#embed "pattern.components.pagination.base"}}{{/embed}}
(missing the s on patterns )
{{#embed patterns.components.pagination.base}}{{/embed}}
(missing the "s on the location )

@erikjung
Copy link
Contributor

That sounds like a good idea to me.

Looks like we might be able to leverage Browsersync's notify method: https://www.browsersync.io/docs/api#api-notify

Improved error handling in general is definitely needed. We'll have to make sure errors like this don't interrupt the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants