Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows app availability test #24

Open
sneal opened this issue Dec 9, 2020 · 3 comments
Open

Add Windows app availability test #24

sneal opened this issue Dec 9, 2020 · 3 comments

Comments

@sneal
Copy link

sneal commented Dec 9, 2020

Sometimes I need the ability to test changes that involve Windows diego cells. Perhaps we can add an additional test that can be optionally invoked via:

    "optional_tests": {
      "run_windows_availbility": true
    },

I've spiked some of this out and the amount of additional code is pretty substantial just to add Windows app availability. Therefore I've been reluctant to submit a PR. Is Windows something that would even be entertained?

/cc @zmb3

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/176076639

The labels on this github issue will be updated when the story is started.

@sneal
Copy link
Author

sneal commented Jan 4, 2021

Here's the branch where I spiked this out https://github.com/sneal/uptimer/tree/windows

@heycait
Copy link

heycait commented Mar 25, 2021

Hi @sneal! If you do provide a PR, we'd be happy to review it and merge it in when it's good to go. Unfortunately, given the all the other responsibilities and priorities our team is handling, we wouldn't be able to devote time to adding this ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting on feedback
Development

No branches or pull requests

3 participants