Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the retry_writer retries parsing issues for syslog messages #612

Open
nicklas-dohrn opened this issue Sep 16, 2024 · 0 comments
Open

the retry_writer retries parsing issues for syslog messages #612

nicklas-dohrn opened this issue Sep 16, 2024 · 0 comments

Comments

@nicklas-dohrn
Copy link
Contributor

nicklas-dohrn commented Sep 16, 2024

due to the error propagation from the Writer to the retry_writer,
the call of msgs, err := w.syslogConverter.ToRFC5424(env, w.hostname)
can trigger a retry on a parsing issue, resulting in logs suggesting there where some connection issues, when the issue was indeed a parsing failure.
Retrying a parsing failure will also not resolve on retries, making the loop inefficient in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for Changes | Open for Contribution
Development

No branches or pull requests

1 participant