Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not lookup the service instance when finalizing an UPSI binding #3723

Open
danail-branekov opened this issue Jan 17, 2025 · 0 comments
Open

Comments

@danail-branekov
Copy link
Member

Bacground

Currently we have a main-delegates architecture of the binding controller. The main controller looks up the binding instance and provides it to the appropriate delegate controller.

In the case of UPSI bindings, the delegate controller does not need the service instance when finalizing the binding. It makes no sense finalization to fail if the service instance cannot be looked up

Action to take

Refactor the delegate controllers to

  • Not receinve the instance in their finalize method
  • The managed service binding controller should lookup the service instance itself
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🇪🇺 To do
Development

No branches or pull requests

1 participant