From da77003cf245805aa4488cd9157be360fb118229 Mon Sep 17 00:00:00 2001 From: Carson Long Date: Fri, 13 Oct 2023 14:53:41 -0700 Subject: [PATCH 1/2] chore: Regenerate go files from proto definitions --- assets/grpc/test/test.pb.go | 4 ++-- assets/grpc/test/test_grpc.pb.go | 12 ++++++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/assets/grpc/test/test.pb.go b/assets/grpc/test/test.pb.go index fbadfebcb..cc2b39452 100644 --- a/assets/grpc/test/test.pb.go +++ b/assets/grpc/test/test.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // versions: -// protoc-gen-go v1.27.1 -// protoc v3.15.8 +// protoc-gen-go v1.31.0 +// protoc v4.24.4 // source: test/test.proto package test diff --git a/assets/grpc/test/test_grpc.pb.go b/assets/grpc/test/test_grpc.pb.go index 38bf9a813..3b83a6542 100644 --- a/assets/grpc/test/test_grpc.pb.go +++ b/assets/grpc/test/test_grpc.pb.go @@ -1,4 +1,8 @@ // Code generated by protoc-gen-go-grpc. DO NOT EDIT. +// versions: +// - protoc-gen-go-grpc v1.3.0 +// - protoc v4.24.4 +// source: test/test.proto package test @@ -14,6 +18,10 @@ import ( // Requires gRPC-Go v1.32.0 or later. const _ = grpc.SupportPackageIsVersion7 +const ( + Test_Run_FullMethodName = "/test.Test/Run" +) + // TestClient is the client API for Test service. // // For semantics around ctx use and closing/ending streaming RPCs, please refer to https://pkg.go.dev/google.golang.org/grpc/?tab=doc#ClientConn.NewStream. @@ -31,7 +39,7 @@ func NewTestClient(cc grpc.ClientConnInterface) TestClient { func (c *testClient) Run(ctx context.Context, in *Request, opts ...grpc.CallOption) (*Response, error) { out := new(Response) - err := c.cc.Invoke(ctx, "/test.Test/Run", in, out, opts...) + err := c.cc.Invoke(ctx, Test_Run_FullMethodName, in, out, opts...) if err != nil { return nil, err } @@ -76,7 +84,7 @@ func _Test_Run_Handler(srv interface{}, ctx context.Context, dec func(interface{ } info := &grpc.UnaryServerInfo{ Server: srv, - FullMethod: "/test.Test/Run", + FullMethod: Test_Run_FullMethodName, } handler := func(ctx context.Context, req interface{}) (interface{}, error) { return srv.(TestServer).Run(ctx, req.(*Request)) From 47d08bc137a8a06575283ce7108f9164502cedf3 Mon Sep 17 00:00:00 2001 From: Carson Long Date: Fri, 13 Oct 2023 14:57:09 -0700 Subject: [PATCH 2/2] Fix: Combine go generated code from grpc asset's proto definitions Rather than manually maintaining a duplicate of the generated code under `helpers/assets/test`, we can just import the file directly now that there's a module and go modules will sort it out. This does still mean we have two of the same files, but at least we don't have to maintain the copy by copying and pasting. Now just using go modules commands can update to using the latest version. --- go.mod | 1 + go.sum | 2 + http2_routing/http2_routing.go | 2 +- .../cf-acceptance-tests/assets/grpc/LICENSE | 176 ++++++++++++++++++ .../assets/grpc}/test/test.pb.go | 0 .../assets/grpc/test/test.proto | 15 ++ .../assets/grpc}/test/test_grpc.pb.go | 0 vendor/modules.txt | 3 + 8 files changed, 198 insertions(+), 1 deletion(-) create mode 100644 vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/LICENSE rename {helpers/assets => vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc}/test/test.pb.go (100%) create mode 100644 vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test/test.proto rename {helpers/assets => vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc}/test/test_grpc.pb.go (100%) diff --git a/go.mod b/go.mod index 4c227fa42..04e8e0171 100644 --- a/go.mod +++ b/go.mod @@ -7,6 +7,7 @@ require ( code.cloudfoundry.org/go-log-cache/v2 v2.0.5 code.cloudfoundry.org/go-loggregator/v9 v9.0.8 code.cloudfoundry.org/tlsconfig v0.0.0-20220621140725-0e6fbd869921 + github.com/cloudfoundry/cf-acceptance-tests/assets/grpc v0.0.0-20230824190001-4c85c4bbb446 github.com/cloudfoundry/cf-test-helpers/v2 v2.8.0 github.com/cloudfoundry/noaa/v2 v2.3.0 github.com/cloudfoundry/sonde-go v0.0.0-20230710164515-a0a43d1dbbf8 diff --git a/go.sum b/go.sum index ef392a957..d0ff86958 100644 --- a/go.sum +++ b/go.sum @@ -15,6 +15,8 @@ github.com/apoydence/eachers v0.0.0-20181020210610-23942921fe77 h1:afT88tB6u9JCK github.com/chzyer/logex v1.1.10/go.mod h1:+Ywpsq7O8HXn0nuIou7OrIPyXbp3wmkHB+jjWRnGsAI= github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e/go.mod h1:nSuG5e5PlCu98SY8svDHJxuZscDgtXS6KTTbou5AhLI= github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMnBNeIyt5eFwwo7qiLfzFZmjNmxjkiQlU= +github.com/cloudfoundry/cf-acceptance-tests/assets/grpc v0.0.0-20230824190001-4c85c4bbb446 h1:4facUUCYYaYnim1KjZNAT9sMZQ4R/NZxluF1HZ1+ZOo= +github.com/cloudfoundry/cf-acceptance-tests/assets/grpc v0.0.0-20230824190001-4c85c4bbb446/go.mod h1:gL/bbKHqFbidhYuyA/zRSshyem4vWRzYjMePgf5V9wk= github.com/cloudfoundry/cf-test-helpers/v2 v2.8.0 h1:aEuDiAhQdwwY2tu3ivfm4KHQBG0Kzp2m+qCNjaWDB+0= github.com/cloudfoundry/cf-test-helpers/v2 v2.8.0/go.mod h1:wrmHE+cHE6J72feYGE98GmsyLkYEUbK9OOkD96XK7FA= github.com/cloudfoundry/noaa/v2 v2.3.0 h1:+f//s7zTaiTtjz/Vf1LFKKfJb/6x2hRenTXlSb4dU5g= diff --git a/http2_routing/http2_routing.go b/http2_routing/http2_routing.go index f931f0dd0..8a6a4ea72 100644 --- a/http2_routing/http2_routing.go +++ b/http2_routing/http2_routing.go @@ -5,7 +5,7 @@ import ( "crypto/tls" "time" - protobuff "github.com/cloudfoundry/cf-acceptance-tests/helpers/assets/test" + protobuff "github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test" . "github.com/cloudfoundry/cf-acceptance-tests/helpers/v3_helpers" "google.golang.org/grpc" "google.golang.org/grpc/credentials" diff --git a/vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/LICENSE b/vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/LICENSE new file mode 100644 index 000000000..e434046f6 --- /dev/null +++ b/vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/LICENSE @@ -0,0 +1,176 @@ + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation against any entity (including a + cross-claim or counterclaim in a lawsuit) alleging that the Work + or a Contribution incorporated within the Work constitutes direct + or contributory patent infringement, then any patent licenses + granted to You under this License for that Work shall terminate + as of the date such litigation is filed. + + 4. Redistribution. You may reproduce and distribute copies of the + Work or Derivative Works thereof in any medium, with or without + modifications, and in Source or Object form, provided that You + meet the following conditions: + + (a) You must give any other recipients of the Work or + Derivative Works a copy of this License; and + + (b) You must cause any modified files to carry prominent notices + stating that You changed the files; and + + (c) You must retain, in the Source form of any Derivative Works + that You distribute, all copyright, patent, trademark, and + attribution notices from the Source form of the Work, + excluding those notices that do not pertain to any part of + the Derivative Works; and + + (d) If the Work includes a "NOTICE" text file as part of its + distribution, then any Derivative Works that You distribute must + include a readable copy of the attribution notices contained + within such NOTICE file, excluding those notices that do not + pertain to any part of the Derivative Works, in at least one + of the following places: within a NOTICE text file distributed + as part of the Derivative Works; within the Source form or + documentation, if provided along with the Derivative Works; or, + within a display generated by the Derivative Works, if and + wherever such third-party notices normally appear. The contents + of the NOTICE file are for informational purposes only and + do not modify the License. You may add Your own attribution + notices within Derivative Works that You distribute, alongside + or as an addendum to the NOTICE text from the Work, provided + that such additional attribution notices cannot be construed + as modifying the License. + + You may add Your own copyright statement to Your modifications and + may provide additional or different license terms and conditions + for use, reproduction, or distribution of Your modifications, or + for any such Derivative Works as a whole, provided Your use, + reproduction, and distribution of the Work otherwise complies with + the conditions stated in this License. + + 5. Submission of Contributions. Unless You explicitly state otherwise, + any Contribution intentionally submitted for inclusion in the Work + by You to the Licensor shall be under the terms and conditions of + this License, without any additional terms or conditions. + Notwithstanding the above, nothing herein shall supersede or modify + the terms of any separate license agreement you may have executed + with Licensor regarding such Contributions. + + 6. Trademarks. This License does not grant permission to use the trade + names, trademarks, service marks, or product names of the Licensor, + except as required for reasonable and customary use in describing the + origin of the Work and reproducing the content of the NOTICE file. + + 7. Disclaimer of Warranty. Unless required by applicable law or + agreed to in writing, Licensor provides the Work (and each + Contributor provides its Contributions) on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied, including, without limitation, any warranties or conditions + of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A + PARTICULAR PURPOSE. You are solely responsible for determining the + appropriateness of using or redistributing the Work and assume any + risks associated with Your exercise of permissions under this License. + + 8. Limitation of Liability. In no event and under no legal theory, + whether in tort (including negligence), contract, or otherwise, + unless required by applicable law (such as deliberate and grossly + negligent acts) or agreed to in writing, shall any Contributor be + liable to You for damages, including any direct, indirect, special, + incidental, or consequential damages of any character arising as a + result of this License or out of the use or inability to use the + Work (including but not limited to damages for loss of goodwill, + work stoppage, computer failure or malfunction, or any and all + other commercial damages or losses), even if such Contributor + has been advised of the possibility of such damages. + + 9. Accepting Warranty or Additional Liability. While redistributing + the Work or Derivative Works thereof, You may choose to offer, + and charge a fee for, acceptance of support, warranty, indemnity, + or other liability obligations and/or rights consistent with this + License. However, in accepting such obligations, You may act only + on Your own behalf and on Your sole responsibility, not on behalf + of any other Contributor, and only if You agree to indemnify, + defend, and hold each Contributor harmless for any liability + incurred by, or claims asserted against, such Contributor by reason + of your accepting any such warranty or additional liability. + + END OF TERMS AND CONDITIONS \ No newline at end of file diff --git a/helpers/assets/test/test.pb.go b/vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test/test.pb.go similarity index 100% rename from helpers/assets/test/test.pb.go rename to vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test/test.pb.go diff --git a/vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test/test.proto b/vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test/test.proto new file mode 100644 index 000000000..5d6b931d2 --- /dev/null +++ b/vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test/test.proto @@ -0,0 +1,15 @@ +syntax = "proto3"; + +option go_package = "github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test"; + +package test; + +service Test { + rpc Run(Request) returns (Response) {} +} + +message Request {} + +message Response { + string body = 1; +} diff --git a/helpers/assets/test/test_grpc.pb.go b/vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test/test_grpc.pb.go similarity index 100% rename from helpers/assets/test/test_grpc.pb.go rename to vendor/github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test/test_grpc.pb.go diff --git a/vendor/modules.txt b/vendor/modules.txt index 1257d6098..3b8d5f5a8 100644 --- a/vendor/modules.txt +++ b/vendor/modules.txt @@ -18,6 +18,9 @@ code.cloudfoundry.org/tlsconfig/certtest # github.com/andybalholm/brotli v1.0.1 ## explicit; go 1.12 github.com/andybalholm/brotli +# github.com/cloudfoundry/cf-acceptance-tests/assets/grpc v0.0.0-20230824190001-4c85c4bbb446 +## explicit; go 1.20 +github.com/cloudfoundry/cf-acceptance-tests/assets/grpc/test # github.com/cloudfoundry/cf-test-helpers/v2 v2.8.0 ## explicit; go 1.18 github.com/cloudfoundry/cf-test-helpers/v2/cf