-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI router unsafe assignment with fromHono
#183
Comments
Seeing this as well - seems like a bug? |
Hey there, I've just published a new release (v2.1.0) that removes the any from the adapters, can you confirm the issue is fixed? |
@G4brym - it seems the middleware registration typing is still wrong, I can't register middleware: |
Honestly, I just went ahead and migrated away from itty-router and went straight to Hono with Zod OpenAPI Hono. Was able to reuse a lot of our existing code, just had to change the class based routes to the Hono way; no longer depending on Chanfana. |
I am getting a typescript error when trying to use
fromHono()
.I took a look at the types and saw this:
Whats the reasoning for the
any
at the end of the return type? Same thing forfromIttyRouter
as well... I'd have to disable a bunch of eslint rules for this file to get it working, but then I am losing all my type safety that I had before v2.The text was updated successfully, but these errors were encountered: