Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect version for latest 3.0.3 release #107

Open
justinpjose opened this issue Jun 21, 2021 · 1 comment
Open

incorrect version for latest 3.0.3 release #107

justinpjose opened this issue Jun 21, 2021 · 1 comment

Comments

@justinpjose
Copy link

justinpjose commented Jun 21, 2021

certmgr version is showing the version v3.0.1-15-gec8c2be instead of v3.0.3

FYI, using certmgr-linux-amd64-v3.0.3.tar.gz

@ChrisChoke
Copy link

they get the version from git describe from here for the building process:

- GOFLAGS=-mod=vendor gox -output="{{.Dir}}-{{.OS}}-{{.Arch}}-${TRAVIS_TAG:-${TRAVIS_COMMIT}}" -os='darwin dragonfly freebsd linux netbsd openbsd solaris' -osarch='!dragonfly/386 !darwin/arm64 !darwin/arm !linux/mips !linux/mipsle' -gcflags="-trimpath=${GOPATH}" -ldflags="-X github.com/cloudflare/certmgr/certmgr/cmd.currentVersion=$(git describe)" ./certmgr/

it seems that the tag of 3.0.2 and 3.0.3 are lightweight tags. so that git describe will refer to the last annotated tag which ist version 3.0.1.
i think git describe --tags will solve this for the future building processes.

Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants