Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook_url is not mandatory in garm v0.1.4 but needed by updating to v0.1.5 #311

Open
bavarianbidi opened this issue Nov 20, 2024 · 1 comment

Comments

@bavarianbidi
Copy link
Contributor

in garm v0.1.4 it's not mandatory to have webhook_url set.

By updating garm from v0.1.4 to v0.1.5, the /controller-info endpoint will fail as webhook_url got not converted into the database.

garm-cli-v0.1.5 controller show
Error: [GET /controller-info][409] controllerInfoConflict {"error":"urls_required","details":"Missing required URLs. Make sure you update the metadata, callback and webhook URLs"}
@gabriel-samfira
Copy link
Member

Right. In it's current form (no scale sets yet), the webhook_url is kind of mandatory. We should probably relax this, as it won't really be mandatory once we have scale sets. It will only be mandatory for the current pools. So we can probably set this to optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants