Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug? only 3 of 4 of Adapter features are used #2

Open
amandaluof opened this issue Mar 17, 2023 · 1 comment
Open

bug? only 3 of 4 of Adapter features are used #2

amandaluof opened this issue Mar 17, 2023 · 1 comment

Comments

@amandaluof
Copy link

amandaluof commented Mar 17, 2023 •
edited
Loading

Hi! Thanks for the great work, but I guess there may be a bug. The length of adapter feature list is 4. But only the top3 are added to the unet(unet_2d_condition.py line582).

Best wishes!
@amandaluof amandaluof changed the title only 3 of 4 of Adapter features are used bug? only 3 of 4 of Adapter features are used Mar 17, 2023
@nyp0x
Copy link

nyp0x commented Apr 5, 2023

Can confirm that using all 4 down blocks improves quality (first row: only CrossAttnDownBlock2D, second row: CrossAttnDownBlock2D and DownBlock2D)

blocks

However, it seems the use of adapter features in samplers is also necessary to further improve quality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nyp0x @amandaluof