-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PARKED] Highlight all the occurrences for the selected frame #76
base: main
Are you sure you want to change the base?
Conversation
Absolutely |
This reverts commit 888adf1.
Great work, very interesting. It's great to be able to explore how common multiple occurrences are. As discussed last week the UX needs some refining so it's a bit less surprising - will experiment with this and make some suggestions. Really awesome to be able to explore the possibilities like this. My first thought is to maybe only show the same occurrences on the flamegraph strongly on selecting a frame, so there's a bit less noise while hovering around, and to use a subtle background and/or a little marker triangle in the corner rather than strong outlines, but it needs some experimentation. |
This dropdown is super cool. My first thoughts from playing with this are similar; the outline can be hard to see so a light background similar to what the search does may be better (and there's precedent for it, so) I feel like one option for the button/dropdown combo is to split it up, the dropdown can still be useful even if other occurences aren't being highlighted right now. I'd perhaps also like to see the dropdown labelled with something like '16 occurences' instead of just '16' to clarify what it's for without having to hover, if that doesn't take too much space |
This PR won't be merged but we'll keep it as a proof of concept |
This PR won't be merged but we'll keep it as a proof of concept
This PR allows the user to quickly see how many other occurrences of the selected function are displayed in the graph.
When hovering over a frame, the new component (sitting just next to the selection-controls) shows the number of other occurrences of the hovered frame, as well as the total % of the time spent by the function.
Clicking on the button triggers an overlay (tooltip) containing the list of all the other occurrences (not including the selected frame) and the % of time spent running them.
On hover, the corresponding frame on the graph gets highlighted.
On click, the corresponding frame on the graph gets selected