Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor _AbstractView, Camera And LookAt #261

Closed
cleder opened this issue Oct 30, 2023 · 0 comments · Fixed by #268
Closed

Refactor _AbstractView, Camera And LookAt #261

cleder opened this issue Oct 30, 2023 · 0 comments · Fixed by #268
Assignees
@cleder
Labels
improvement
Milestone
Version 1.0

Comments

@cleder
Copy link
Owner

cleder commented Oct 30, 2023 •
edited
Loading

see #257
add __repr__
add @classmethod _get_kwargs
remove from_element

Make sure all tests are passing
has to be done after #260
@cleder cleder changed the title Refactor TimeStamp And TimeSpan Refactor _AbstractView, Camera And LookAt Oct 30, 2023
@cleder cleder added this to the Version 1.0 milestone Oct 30, 2023
@cleder cleder added this to FastKML Nov 2, 2023
@cleder cleder moved this to Todo in FastKML Nov 2, 2023
@cleder cleder linked a pull request Nov 11, 2023 that will close this issue
Refactor views.py to use classmethod for parsing XML elements #268
Merged
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in FastKML Nov 11, 2023
@cleder cleder self-assigned this Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cleder cleder

Labels
improvement
Projects
FastKML
Status: Done
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

Refactor views.py to use classmethod for parsing XML elements cleder/fastkml
1 participant
@cleder