From 568b643369912b6389c5b5f4775fba4b7b3781ca Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Mon, 20 Nov 2023 22:31:49 +0000
Subject: [PATCH 01/25] Refactor code

---
 fastkml/kml.py | 74 ++++++++++++++++++++++++++++++--------------------
 1 file changed, 44 insertions(+), 30 deletions(-)

diff --git a/fastkml/kml.py b/fastkml/kml.py
index 2d3b02b9..d01e1ba7 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -29,6 +29,7 @@
 from datetime import datetime
 from typing import Any
 from typing import Dict
+from typing import Iterable
 from typing import Iterator
 from typing import List
 from typing import Optional
@@ -86,41 +87,41 @@ class _Feature(TimeMixin, _BaseObject):
         * NetworkLink.
     """
 
-    name = None
+    name: Optional[str]
     # User-defined text displayed in the 3D viewer as the label for the
     # object (for example, for a Placemark, Folder, or NetworkLink).
 
-    visibility = 1
+    visibility: bool
     # Boolean value. Specifies whether the feature is drawn in the 3D
     # viewer when it is initially loaded. In order for a feature to be
     # visible, the <visibility> tag of all its ancestors must also be
     # set to 1.
 
-    isopen = 0
+    isopen: bool
     # Boolean value. Specifies whether a Document or Folder appears
     # closed or open when first loaded into the Places panel.
     # 0=collapsed (the default), 1=expanded.
 
-    _atom_author = None
+    _atom_author: Optional[atom.Author]
     # KML 2.2 supports new elements for including data about the author
     # and related website in your KML file. This information is displayed
     # in geo search results, both in Earth browsers such as Google Earth,
     # and in other applications such as Google Maps.
 
-    _atom_link = None
+    _atom_link: Optional[atom.Link]
     # Specifies the URL of the website containing this KML or KMZ file.
 
-    _address = None
+    _address: Optional[str]
     # A string value representing an unstructured address written as a
     # standard street, city, state address, and/or as a postal code.
     # You can use the <address> tag to specify the location of a point
     # instead of using latitude and longitude coordinates.
 
-    _phone_number = None
+    _phone_number: Optional[str]
     # A string value representing a telephone number.
     # This element is used by Google Maps Mobile only.
 
-    _snippet = None  # XXX
+    _snippet: Optional[Union[str, Dict[str, Any]]]
     # _snippet is either a tuple of a string Snippet.text and an integer
     # Snippet.maxLines or a string
     #
@@ -134,16 +135,16 @@ class _Feature(TimeMixin, _BaseObject):
     # support HTML markup. <Snippet> has a maxLines attribute, an integer
     # that specifies the maximum number of lines to display.
 
-    description = None
+    description: Optional[str]
     # User-supplied content that appears in the description balloon.
 
-    _style_url = None
+    _style_url: Optional[Union[Style, StyleMap]]
     # URL of a <Style> or <StyleMap> defined in a Document.
     # If the style is in the same file, use a # reference.
     # If the style is defined in an external file, use a full URL
     # along with # referencing.
 
-    _styles = None
+    _styles: List[Union[Style, StyleMap]]
     # One or more Styles and StyleMaps can be defined to customize the
     # appearance of any element derived from Feature or of the Geometry
     # in a Placemark.
@@ -157,14 +158,14 @@ class _Feature(TimeMixin, _BaseObject):
     # Placemark, or ScreenOverlay—the value for the Feature's inline
     # style takes precedence over the value for the shared style.
 
-    _timespan = None
+    _timespan: Optional[TimeSpan]
     # Associates this Feature with a period of time.
-    _timestamp = None
+    _timestamp: Optional[TimeStamp]
     # Associates this Feature with a point in time.
 
-    _camera = None
+    _camera: Optional[Camera]
 
-    _look_at = None
+    _look_at: Optional[LookAt]
 
     # TODO Region = None
     # Features and geometry associated with a Region are drawn only when
@@ -181,11 +182,12 @@ class _Feature(TimeMixin, _BaseObject):
     # (2) is already implemented, see UntypedExtendedData
     #
     # <Metadata> (deprecated in KML 2.2; use <ExtendedData> instead)
-    extended_data = None
+    extended_data: Optional[ExtendedData]
 
     def __init__(
         self,
         ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         name: Optional[str] = None,
@@ -194,7 +196,7 @@ def __init__(
         style_url: Optional[str] = None,
         extended_data: None = None,
     ) -> None:
-        super().__init__(ns=ns, id=id, target_id=target_id)
+        super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
         self.name = name
         self.description = description
         self.style_url = style_url
@@ -538,18 +540,19 @@ class Icon(_BaseObject):
 
     __name__ = "Icon"
 
-    _href = None
+    _href: Optional[str]
     _refresh_mode: Optional[RefreshMode]
-    _refresh_interval = None
+    _refresh_interval: Optional[float]
     _view_refresh_mode: Optional[ViewRefreshMode]
-    _view_refresh_time = None
-    _view_bound_scale = None
-    _view_format = None
-    _http_query = None
+    _view_refresh_time: Optional[float]
+    _view_bound_scale: Optional[float]
+    _view_format: Optional[str]
+    _http_query: Optional[str]
 
     def __init__(
         self,
         ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         href: Optional[str] = None,
@@ -562,7 +565,7 @@ def __init__(
         http_query: Optional[str] = None,
     ) -> None:
         """Initialize the KML Icon Object."""
-        super().__init__(ns=ns, id=id, target_id=target_id)
+        super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
         self._href = href
         self._refresh_mode = refresh_mode
         self._refresh_interval = refresh_interval
@@ -843,6 +846,7 @@ class _Container(_Feature):
     def __init__(
         self,
         ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         name: Optional[str] = None,
@@ -853,6 +857,7 @@ def __init__(
     ) -> None:
         super().__init__(
             ns=ns,
+            name_spaces=name_spaces,
             id=id,
             target_id=target_id,
             name=name,
@@ -910,18 +915,18 @@ class _Overlay(_Feature):
     nested hierarchies.
     """
 
-    _color = None
+    _color: Optional[str]
     # Color values expressed in hexadecimal notation, including opacity (alpha)
     # values. The order of expression is alphaOverlay, blue, green, red
     # (AABBGGRR). The range of values for any one color is 0 to 255 (00 to ff).
     # For opacity, 00 is fully transparent and ff is fully opaque.
 
-    _draw_order = None
+    _draw_order: Optional[str]
     # Defines the stacking order for the images in overlapping overlays.
     # Overlays with higher <drawOrder> values are drawn on top of those with
     # lower <drawOrder> values.
 
-    _icon = None
+    _icon: Optional[Icon]
     # Defines the image associated with the overlay. Contains an <href> html
     # tag which defines the location of the image to be used as the overlay.
     # The location can be either on a local file system or on a webserver. If
@@ -931,6 +936,7 @@ class _Overlay(_Feature):
     def __init__(
         self,
         ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         name: Optional[str] = None,
@@ -941,6 +947,7 @@ def __init__(
     ) -> None:
         super().__init__(
             ns=ns,
+            name_spaces=name_spaces,
             id=id,
             target_id=target_id,
             name=name,
@@ -1094,7 +1101,7 @@ class PhotoOverlay(_Overlay):
     # A value of lowerLeft specifies that row 1, column 1 of each layer is in
     # the bottom left corner of the grid.
 
-    _point = None
+    _point: Optional[Point]
     # The <Point> element acts as a <Point> inside a <Placemark> element.
     # It draws an icon to mark the position of the PhotoOverlay.
     # The icon drawn is specified by the <styleUrl> and <StyleSelector> fields,
@@ -1694,6 +1701,7 @@ class Placemark(_Feature):
     def __init__(
         self,
         ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         name: Optional[str] = None,
@@ -1705,6 +1713,7 @@ def __init__(
     ) -> None:
         super().__init__(
             ns=ns,
+            name_spaces=name_spaces,
             id=id,
             target_id=target_id,
             name=name,
@@ -1801,14 +1810,19 @@ class KML:
     _features = []
     ns = None
 
-    def __init__(self, ns: Optional[str] = None) -> None:
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        features: Iterable[Union[Folder, Document, Placemark]] = None,
+    ) -> None:
         """
         The namespace (ns) may be empty ('') if the 'kml:' prefix is
         undesired. Note that all child elements like Document or Placemark need
         to be initialized with empty namespace as well in this case.
 
         """
-        self._features = []
+        self._features = list(features) if features is not None else []
 
         self.ns = config.KMLNS if ns is None else ns
 

From 37c914c0951e45451b33fda269cf7438e5423e4c Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Tue, 21 Nov 2023 10:25:22 +0000
Subject: [PATCH 02/25] WIP move Icon into links.py

---
 fastkml/kml.py     | 336 ++++-----------------------------------------
 fastkml/links.py   | 331 ++++++++++++++++++++++++++++++++++++++++++++
 tests/data_test.py |  13 +-
 3 files changed, 362 insertions(+), 318 deletions(-)
 create mode 100644 fastkml/links.py

diff --git a/fastkml/kml.py b/fastkml/kml.py
index d01e1ba7..2f818af8 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -42,16 +42,15 @@
 from fastkml.data import ExtendedData
 from fastkml.data import Schema
 from fastkml.enums import GridOrigin
-from fastkml.enums import RefreshMode
 from fastkml.enums import Shape
 from fastkml.enums import Verbosity
-from fastkml.enums import ViewRefreshMode
 from fastkml.geometry import AnyGeometryType
 from fastkml.geometry import LinearRing
 from fastkml.geometry import LineString
 from fastkml.geometry import MultiGeometry
 from fastkml.geometry import Point
 from fastkml.geometry import Polygon
+from fastkml.links import Icon
 from fastkml.mixins import TimeMixin
 from fastkml.styles import Style
 from fastkml.styles import StyleMap
@@ -91,13 +90,13 @@ class _Feature(TimeMixin, _BaseObject):
     # User-defined text displayed in the 3D viewer as the label for the
     # object (for example, for a Placemark, Folder, or NetworkLink).
 
-    visibility: bool
+    visibility: Optional[bool]
     # Boolean value. Specifies whether the feature is drawn in the 3D
     # viewer when it is initially loaded. In order for a feature to be
     # visible, the <visibility> tag of all its ancestors must also be
     # set to 1.
 
-    isopen: bool
+    isopen: Optional[bool]
     # Boolean value. Specifies whether a Document or Folder appears
     # closed or open when first loaded into the Places panel.
     # 0=collapsed (the default), 1=expanded.
@@ -192,15 +191,33 @@ def __init__(
         target_id: Optional[str] = None,
         name: Optional[str] = None,
         description: Optional[str] = None,
+        snippet: Optional[Union[str, Dict[str, Any]]] = None,
+        atom_author: Optional[atom.Author] = None,
+        atom_link: Optional[atom.Link] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
         styles: Optional[List[Style]] = None,
         style_url: Optional[str] = None,
         extended_data: None = None,
+        camera: Optional[Camera] = None,
+        look_at: Optional[LookAt] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
     ) -> None:
         super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
         self.name = name
         self.description = description
         self.style_url = style_url
         self._styles = []
+        self._camera = camera
+        self._look_at = look_at
+        self.visibility = visibility
+        self.isopen = isopen
+        self.snippet = snippet
+        self._atom_author = atom_author
+        self._atom_link = atom_link
+        self.address = address
+        self.phone_number = phone_number
         if styles:
             for style in styles:
                 self.append_style(style)
@@ -525,312 +542,6 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             self.camera = s
 
 
-class Icon(_BaseObject):
-    """
-    Represents an <Icon> element used in Overlays.
-
-    Defines an image associated with an Icon style or overlay.
-    The required <href> child element defines the location
-    of the image to be used as the overlay or as the icon for the placemark.
-    This location can either be on a local file system or a remote web server.
-    The <gx:x>, <gx:y>, <gx:w>, and <gx:h> elements are used to select one
-    icon from an image that contains multiple icons
-    (often referred to as an icon palette).
-    """
-
-    __name__ = "Icon"
-
-    _href: Optional[str]
-    _refresh_mode: Optional[RefreshMode]
-    _refresh_interval: Optional[float]
-    _view_refresh_mode: Optional[ViewRefreshMode]
-    _view_refresh_time: Optional[float]
-    _view_bound_scale: Optional[float]
-    _view_format: Optional[str]
-    _http_query: Optional[str]
-
-    def __init__(
-        self,
-        ns: Optional[str] = None,
-        name_spaces: Optional[Dict[str, str]] = None,
-        id: Optional[str] = None,
-        target_id: Optional[str] = None,
-        href: Optional[str] = None,
-        refresh_mode: Optional[RefreshMode] = None,
-        refresh_interval: Optional[float] = None,
-        view_refresh_mode: Optional[ViewRefreshMode] = None,
-        view_refresh_time: Optional[float] = None,
-        view_bound_scale: Optional[float] = None,
-        view_format: Optional[str] = None,
-        http_query: Optional[str] = None,
-    ) -> None:
-        """Initialize the KML Icon Object."""
-        super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
-        self._href = href
-        self._refresh_mode = refresh_mode
-        self._refresh_interval = refresh_interval
-        self._view_refresh_mode = view_refresh_mode
-        self._view_refresh_time = view_refresh_time
-        self._view_bound_scale = view_bound_scale
-        self._view_format = view_format
-        self._http_query = http_query
-
-    @property
-    def href(self) -> Optional[str]:
-        """An HTTP address or a local file specification used to load an icon."""
-        return self._href
-
-    @href.setter
-    def href(self, href) -> None:
-        if isinstance(href, str):
-            self._href = href
-        elif href is None:
-            self._href = None
-        else:
-            raise ValueError
-
-    @property
-    def refresh_mode(self) -> Optional[RefreshMode]:
-        """
-        Specifies a time-based refresh mode.
-
-        Can be one of the following:
-          - onChange - refresh when the file is loaded and whenever the Link
-            parameters change (the default).
-          - onInterval - refresh every n seconds (specified in <refreshInterval>).
-          - onExpire - refresh the file when the expiration time is reached.
-        """
-        return self._refresh_mode
-
-    @refresh_mode.setter
-    def refresh_mode(self, refresh_mode: Optional[RefreshMode]) -> None:
-        self._refresh_mode = refresh_mode
-
-    @property
-    def refresh_interval(self) -> Optional[float]:
-        """Indicates to refresh the file every n seconds."""
-        return self._refresh_interval
-
-    @refresh_interval.setter
-    def refresh_interval(self, refresh_interval: Optional[float]) -> None:
-        if isinstance(refresh_interval, float):
-            self._refresh_interval = refresh_interval
-        elif refresh_interval is None:
-            self._refresh_interval = None
-        else:
-            raise ValueError
-
-    @property
-    def view_refresh_mode(self) -> Optional[ViewRefreshMode]:
-        """
-        Specifies how the link is refreshed when the "camera" changes.
-
-        Can be one of the following:
-         - never (default) - Ignore changes in the view.
-           Also ignore <viewFormat> parameters, if any.
-         - onStop - Refresh the file n seconds after movement stops,
-           where n is specified in <viewRefreshTime>.
-         - onRequest - Refresh the file only when the user explicitly requests it.
-           (For example, in Google Earth, the user right-clicks and selects Refresh
-            in the Context menu.)
-         - onRegion - Refresh the file when the Region becomes active.
-        """
-        return self._view_refresh_mode
-
-    @view_refresh_mode.setter
-    def view_refresh_mode(self, view_refresh_mode: Optional[ViewRefreshMode]) -> None:
-        self._view_refresh_mode = view_refresh_mode
-
-    @property
-    def view_refresh_time(self):
-        """
-        After camera movement stops, specifies the number of seconds to
-        wait before refreshing the view.
-        """
-        return self._view_refresh_time
-
-    @view_refresh_time.setter
-    def view_refresh_time(self, view_refresh_time: Optional[float]) -> None:
-        if isinstance(view_refresh_time, float):
-            self._view_refresh_time = view_refresh_time
-        elif view_refresh_time is None:
-            self._view_refresh_time = None
-        else:
-            raise ValueError
-
-    @property
-    def view_bound_scale(self) -> Optional[float]:
-        """
-        Scales the BBOX parameters before sending them to the server.
-
-        A value less than 1 specifies to use less than the full view (screen).
-        A value greater than 1 specifies to fetch an area that extends beyond
-        the edges of the current view.
-        """
-        return self._view_bound_scale
-
-    @view_bound_scale.setter
-    def view_bound_scale(self, view_bound_scale: Optional[float]) -> None:
-        if isinstance(view_bound_scale, float):
-            self._view_bound_scale = view_bound_scale
-        elif view_bound_scale is None:
-            self._view_bound_scale = None
-        else:
-            raise ValueError
-
-    @property
-    def view_format(self):
-        """
-        Specifies the format of the query string that is appended to the
-        Link's <href> before the file is fetched.
-        (If the <href> specifies a local file, this element is ignored.).
-
-        This information matches the Web Map Service (WMS) bounding box specification.
-        If you specify an empty <viewFormat> tag, no information is appended to the
-        query string.
-        You can also specify a custom set of viewing parameters to add to the query
-        string. If you supply a format string, it is used instead of the BBOX
-        information. If you also want the BBOX information, you need to add those
-        parameters along with the custom parameters.
-        You can use any of the following parameters in your format string:
-         - [lookatLon], [lookatLat] - longitude and latitude of the point that
-           <LookAt> is viewing
-         - [lookatRange], [lookatTilt], [lookatHeading] - values used by the
-           <LookAt> element (see descriptions of <range>, <tilt>, and <heading>
-           in <LookAt>)
-         - [lookatTerrainLon], [lookatTerrainLat], [lookatTerrainAlt] - point on the
-           terrain in degrees/meters that <LookAt> is viewing
-         - [cameraLon], [cameraLat], [cameraAlt] - degrees/meters of the eyepoint for
-           the camera
-         - [horizFov], [vertFov] - horizontal, vertical field of view for the camera
-         - [horizPixels], [vertPixels] - size in pixels of the 3D viewer
-         - [terrainEnabled] - indicates whether the 3D viewer is showing terrain (1)
-           or not (0)
-        """
-        return self._view_format
-
-    @view_format.setter
-    def view_format(self, view_format) -> None:
-        if isinstance(view_format, str):
-            self._view_format = view_format
-        elif view_format is None:
-            self._view_format = None
-        else:
-            raise ValueError
-
-    @property
-    def http_query(self):
-        """
-        Appends information to the query string, based on the parameters specified.
-
-        The following parameters are supported:
-         - [clientVersion]
-         - [kmlVersion]
-         - [clientName]
-         - [language]
-        """
-        return self._http_query
-
-    @http_query.setter
-    def http_query(self, http_query) -> None:
-        if isinstance(http_query, str):
-            self._http_query = http_query
-        elif http_query is None:
-            self._http_query = None
-        else:
-            raise ValueError
-
-    def etree_element(
-        self,
-        precision: Optional[int] = None,
-        verbosity: Verbosity = Verbosity.normal,
-    ) -> Element:
-        element = super().etree_element(precision=precision, verbosity=verbosity)
-
-        if self._href:
-            href = config.etree.SubElement(element, f"{self.ns}href")
-            href.text = self._href
-        if self._refresh_mode:
-            refresh_mode = config.etree.SubElement(element, f"{self.ns}refreshMode")
-            refresh_mode.text = self._refresh_mode.value
-        if self._refresh_interval:
-            refresh_interval = config.etree.SubElement(
-                element,
-                f"{self.ns}refreshInterval",
-            )
-            refresh_interval.text = str(self._refresh_interval)
-        if self._view_refresh_mode:
-            view_refresh_mode = config.etree.SubElement(
-                element,
-                f"{self.ns}viewRefreshMode",
-            )
-            view_refresh_mode.text = self._view_refresh_mode.value
-        if self._view_refresh_time:
-            view_refresh_time = config.etree.SubElement(
-                element,
-                f"{self.ns}viewRefreshTime",
-            )
-            view_refresh_time.text = str(self._view_refresh_time)
-        if self._view_bound_scale:
-            view_bound_scale = config.etree.SubElement(
-                element,
-                f"{self.ns}viewBoundScale",
-            )
-            view_bound_scale.text = str(self._view_bound_scale)
-        if self._view_format:
-            view_format = config.etree.SubElement(element, f"{self.ns}viewFormat")
-            view_format.text = self._view_format
-        if self._http_query:
-            http_query = config.etree.SubElement(element, f"{self.ns}httpQuery")
-            http_query.text = self._http_query
-
-        return element
-
-    def from_element(self, element: Element) -> None:
-        super().from_element(element)
-
-        href = element.find(f"{self.ns}href")
-        if href is not None:
-            self.href = href.text
-
-        refresh_mode = element.find(f"{self.ns}refreshMode")
-        if refresh_mode is not None:
-            self.refresh_mode = RefreshMode(refresh_mode.text)
-
-        refresh_interval = element.find(f"{self.ns}refreshInterval")
-        if refresh_interval is not None:
-            try:
-                self.refresh_interval = float(refresh_interval.text)
-            except ValueError:
-                self.refresh_interval = None
-
-        view_refresh_mode = element.find(f"{self.ns}viewRefreshMode")
-        if view_refresh_mode is not None:
-            self.view_refresh_mode = ViewRefreshMode(view_refresh_mode.text)
-
-        view_refresh_time = element.find(f"{self.ns}viewRefreshTime")
-        if view_refresh_time is not None:
-            try:
-                self.view_refresh_time = float(view_refresh_time.text)
-            except ValueError:
-                self.view_refresh_time = None
-
-        view_bound_scale = element.find(f"{self.ns}viewBoundScale")
-        if view_bound_scale is not None:
-            try:
-                self.view_bound_scale = float(view_bound_scale.text)
-            except ValueError:
-                self.view_bound_scale = None
-
-        view_format = element.find(f"{self.ns}viewFormat")
-        if view_format is not None:
-            self.view_format = view_format.text
-
-        http_query = element.find(f"{self.ns}httpQuery")
-        if http_query is not None:
-            self.http_query = http_query.text
-
-
 class _Container(_Feature):
     """
     abstract element; do not create
@@ -941,8 +652,10 @@ def __init__(
         target_id: Optional[str] = None,
         name: Optional[str] = None,
         description: Optional[str] = None,
+        color: Optional[str] = None,
         styles: None = None,
         style_url: Optional[str] = None,
+        draw_order: Optional[str] = None,
         icon: Optional[Icon] = None,
     ) -> None:
         super().__init__(
@@ -956,6 +669,8 @@ def __init__(
             style_url=style_url,
         )
         self._icon = icon
+        self._color = color
+        self._draw_order = draw_order
 
     @property
     def color(self):
@@ -1931,7 +1646,6 @@ def append(self, kmlobj: Union[Folder, Document, Placemark]) -> None:
 __all__ = [
     "Document",
     "Folder",
-    "Icon",
     "PhotoOverlay",
     "GroundOverlay",
     "KML",
diff --git a/fastkml/links.py b/fastkml/links.py
new file mode 100644
index 00000000..47ec08ea
--- /dev/null
+++ b/fastkml/links.py
@@ -0,0 +1,331 @@
+# Copyright (C) 2012-2022  Christian Ledermann
+#
+# This library is free software; you can redistribute it and/or modify it under
+# the terms of the GNU Lesser General Public License as published by the Free
+# Software Foundation; either version 2.1 of the License, or (at your option)
+# any later version.
+#
+# This library is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more
+# details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this library; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+
+from typing import Dict
+from typing import Optional
+
+from fastkml import config
+from fastkml.base import _BaseObject
+from fastkml.enums import RefreshMode
+from fastkml.enums import Verbosity
+from fastkml.enums import ViewRefreshMode
+from fastkml.types import Element
+
+
+class Icon(_BaseObject):
+    """
+    Represents an <Icon> element used in Overlays.
+
+    Defines an image associated with an Icon style or overlay.
+    The required <href> child element defines the location
+    of the image to be used as the overlay or as the icon for the placemark.
+    This location can either be on a local file system or a remote web server.
+    The <gx:x>, <gx:y>, <gx:w>, and <gx:h> elements are used to select one
+    icon from an image that contains multiple icons
+    (often referred to as an icon palette).
+    """
+
+    __name__ = "Icon"
+
+    _href: Optional[str]
+    _refresh_mode: Optional[RefreshMode]
+    _refresh_interval: Optional[float]
+    _view_refresh_mode: Optional[ViewRefreshMode]
+    _view_refresh_time: Optional[float]
+    _view_bound_scale: Optional[float]
+    _view_format: Optional[str]
+    _http_query: Optional[str]
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        href: Optional[str] = None,
+        refresh_mode: Optional[RefreshMode] = None,
+        refresh_interval: Optional[float] = None,
+        view_refresh_mode: Optional[ViewRefreshMode] = None,
+        view_refresh_time: Optional[float] = None,
+        view_bound_scale: Optional[float] = None,
+        view_format: Optional[str] = None,
+        http_query: Optional[str] = None,
+    ) -> None:
+        """Initialize the KML Icon Object."""
+        super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
+        self._href = href
+        self._refresh_mode = refresh_mode
+        self._refresh_interval = refresh_interval
+        self._view_refresh_mode = view_refresh_mode
+        self._view_refresh_time = view_refresh_time
+        self._view_bound_scale = view_bound_scale
+        self._view_format = view_format
+        self._http_query = http_query
+
+    @property
+    def href(self) -> Optional[str]:
+        """An HTTP address or a local file specification used to load an icon."""
+        return self._href
+
+    @href.setter
+    def href(self, href) -> None:
+        if isinstance(href, str):
+            self._href = href
+        elif href is None:
+            self._href = None
+        else:
+            raise ValueError
+
+    @property
+    def refresh_mode(self) -> Optional[RefreshMode]:
+        """
+        Specifies a time-based refresh mode.
+
+        Can be one of the following:
+          - onChange - refresh when the file is loaded and whenever the Link
+            parameters change (the default).
+          - onInterval - refresh every n seconds (specified in <refreshInterval>).
+          - onExpire - refresh the file when the expiration time is reached.
+        """
+        return self._refresh_mode
+
+    @refresh_mode.setter
+    def refresh_mode(self, refresh_mode: Optional[RefreshMode]) -> None:
+        self._refresh_mode = refresh_mode
+
+    @property
+    def refresh_interval(self) -> Optional[float]:
+        """Indicates to refresh the file every n seconds."""
+        return self._refresh_interval
+
+    @refresh_interval.setter
+    def refresh_interval(self, refresh_interval: Optional[float]) -> None:
+        if isinstance(refresh_interval, float):
+            self._refresh_interval = refresh_interval
+        elif refresh_interval is None:
+            self._refresh_interval = None
+        else:
+            raise ValueError
+
+    @property
+    def view_refresh_mode(self) -> Optional[ViewRefreshMode]:
+        """
+        Specifies how the link is refreshed when the "camera" changes.
+
+        Can be one of the following:
+         - never (default) - Ignore changes in the view.
+           Also ignore <viewFormat> parameters, if any.
+         - onStop - Refresh the file n seconds after movement stops,
+           where n is specified in <viewRefreshTime>.
+         - onRequest - Refresh the file only when the user explicitly requests it.
+           (For example, in Google Earth, the user right-clicks and selects Refresh
+            in the Context menu.)
+         - onRegion - Refresh the file when the Region becomes active.
+        """
+        return self._view_refresh_mode
+
+    @view_refresh_mode.setter
+    def view_refresh_mode(self, view_refresh_mode: Optional[ViewRefreshMode]) -> None:
+        self._view_refresh_mode = view_refresh_mode
+
+    @property
+    def view_refresh_time(self):
+        """
+        After camera movement stops, specifies the number of seconds to
+        wait before refreshing the view.
+        """
+        return self._view_refresh_time
+
+    @view_refresh_time.setter
+    def view_refresh_time(self, view_refresh_time: Optional[float]) -> None:
+        if isinstance(view_refresh_time, float):
+            self._view_refresh_time = view_refresh_time
+        elif view_refresh_time is None:
+            self._view_refresh_time = None
+        else:
+            raise ValueError
+
+    @property
+    def view_bound_scale(self) -> Optional[float]:
+        """
+        Scales the BBOX parameters before sending them to the server.
+
+        A value less than 1 specifies to use less than the full view (screen).
+        A value greater than 1 specifies to fetch an area that extends beyond
+        the edges of the current view.
+        """
+        return self._view_bound_scale
+
+    @view_bound_scale.setter
+    def view_bound_scale(self, view_bound_scale: Optional[float]) -> None:
+        if isinstance(view_bound_scale, float):
+            self._view_bound_scale = view_bound_scale
+        elif view_bound_scale is None:
+            self._view_bound_scale = None
+        else:
+            raise ValueError
+
+    @property
+    def view_format(self):
+        """
+        Specifies the format of the query string that is appended to the
+        Link's <href> before the file is fetched.
+        (If the <href> specifies a local file, this element is ignored.).
+
+        This information matches the Web Map Service (WMS) bounding box specification.
+        If you specify an empty <viewFormat> tag, no information is appended to the
+        query string.
+        You can also specify a custom set of viewing parameters to add to the query
+        string. If you supply a format string, it is used instead of the BBOX
+        information. If you also want the BBOX information, you need to add those
+        parameters along with the custom parameters.
+        You can use any of the following parameters in your format string:
+         - [lookatLon], [lookatLat] - longitude and latitude of the point that
+           <LookAt> is viewing
+         - [lookatRange], [lookatTilt], [lookatHeading] - values used by the
+           <LookAt> element (see descriptions of <range>, <tilt>, and <heading>
+           in <LookAt>)
+         - [lookatTerrainLon], [lookatTerrainLat], [lookatTerrainAlt] - point on the
+           terrain in degrees/meters that <LookAt> is viewing
+         - [cameraLon], [cameraLat], [cameraAlt] - degrees/meters of the eyepoint for
+           the camera
+         - [horizFov], [vertFov] - horizontal, vertical field of view for the camera
+         - [horizPixels], [vertPixels] - size in pixels of the 3D viewer
+         - [terrainEnabled] - indicates whether the 3D viewer is showing terrain (1)
+           or not (0)
+        """
+        return self._view_format
+
+    @view_format.setter
+    def view_format(self, view_format) -> None:
+        if isinstance(view_format, str):
+            self._view_format = view_format
+        elif view_format is None:
+            self._view_format = None
+        else:
+            raise ValueError
+
+    @property
+    def http_query(self):
+        """
+        Appends information to the query string, based on the parameters specified.
+
+        The following parameters are supported:
+         - [clientVersion]
+         - [kmlVersion]
+         - [clientName]
+         - [language]
+        """
+        return self._http_query
+
+    @http_query.setter
+    def http_query(self, http_query) -> None:
+        if isinstance(http_query, str):
+            self._http_query = http_query
+        elif http_query is None:
+            self._http_query = None
+        else:
+            raise ValueError
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+
+        if self._href:
+            href = config.etree.SubElement(element, f"{self.ns}href")
+            href.text = self._href
+        if self._refresh_mode:
+            refresh_mode = config.etree.SubElement(element, f"{self.ns}refreshMode")
+            refresh_mode.text = self._refresh_mode.value
+        if self._refresh_interval:
+            refresh_interval = config.etree.SubElement(
+                element,
+                f"{self.ns}refreshInterval",
+            )
+            refresh_interval.text = str(self._refresh_interval)
+        if self._view_refresh_mode:
+            view_refresh_mode = config.etree.SubElement(
+                element,
+                f"{self.ns}viewRefreshMode",
+            )
+            view_refresh_mode.text = self._view_refresh_mode.value
+        if self._view_refresh_time:
+            view_refresh_time = config.etree.SubElement(
+                element,
+                f"{self.ns}viewRefreshTime",
+            )
+            view_refresh_time.text = str(self._view_refresh_time)
+        if self._view_bound_scale:
+            view_bound_scale = config.etree.SubElement(
+                element,
+                f"{self.ns}viewBoundScale",
+            )
+            view_bound_scale.text = str(self._view_bound_scale)
+        if self._view_format:
+            view_format = config.etree.SubElement(element, f"{self.ns}viewFormat")
+            view_format.text = self._view_format
+        if self._http_query:
+            http_query = config.etree.SubElement(element, f"{self.ns}httpQuery")
+            http_query.text = self._http_query
+
+        return element
+
+    def from_element(self, element: Element) -> None:
+        super().from_element(element)
+
+        href = element.find(f"{self.ns}href")
+        if href is not None:
+            self.href = href.text
+
+        refresh_mode = element.find(f"{self.ns}refreshMode")
+        if refresh_mode is not None:
+            self.refresh_mode = RefreshMode(refresh_mode.text)
+
+        refresh_interval = element.find(f"{self.ns}refreshInterval")
+        if refresh_interval is not None:
+            try:
+                self.refresh_interval = float(refresh_interval.text)
+            except ValueError:
+                self.refresh_interval = None
+
+        view_refresh_mode = element.find(f"{self.ns}viewRefreshMode")
+        if view_refresh_mode is not None:
+            self.view_refresh_mode = ViewRefreshMode(view_refresh_mode.text)
+
+        view_refresh_time = element.find(f"{self.ns}viewRefreshTime")
+        if view_refresh_time is not None:
+            try:
+                self.view_refresh_time = float(view_refresh_time.text)
+            except ValueError:
+                self.view_refresh_time = None
+
+        view_bound_scale = element.find(f"{self.ns}viewBoundScale")
+        if view_bound_scale is not None:
+            try:
+                self.view_bound_scale = float(view_bound_scale.text)
+            except ValueError:
+                self.view_bound_scale = None
+
+        view_format = element.find(f"{self.ns}viewFormat")
+        if view_format is not None:
+            self.view_format = view_format.text
+
+        http_query = element.find(f"{self.ns}httpQuery")
+        if http_query is not None:
+            self.http_query = http_query.text
diff --git a/tests/data_test.py b/tests/data_test.py
index 392bf327..ac540b5d 100644
--- a/tests/data_test.py
+++ b/tests/data_test.py
@@ -17,7 +17,6 @@
 import pytest
 
 import fastkml as kml
-from fastkml import config
 from fastkml import data
 from fastkml.enums import DataType
 from fastkml.exceptions import KMLSchemaError
@@ -78,16 +77,16 @@ def test_schema_from_string(self) -> None:
         assert s1.simple_fields[1].name == "TrailLength"
         assert s1.simple_fields[2].display_name == "<i>change in altitude</i>"
         assert s.to_string() == s1.to_string()
-        doc1 = f"""<kml xmlns="http://www.opengis.net/kml/2.2">
+        doc1 = f"""<kml>
             <Document>
             {doc}
         </Document>
         </kml>"""
-        k = kml.KML()
+        k = kml.KML(ns="")
         k.from_string(doc1)
         d = next(iter(k.features()))
         s2 = next(iter(d.schemata()))
-        s.ns = config.KMLNS
+        # s.ns = config.KMLNS
         assert s.to_string() == s2.to_string()
         k1 = kml.KML()
         k1.from_string(k.to_string())
@@ -121,7 +120,7 @@ def test_untyped_extended_data(self) -> None:
         ns = "{http://www.opengis.net/kml/2.2}"
         k = kml.KML(ns=ns)
 
-        p = kml.Placemark(ns, "id", "name", "description")
+        p = kml.Placemark(ns, id="id", name="name", description="description")
         p.extended_data = kml.ExtendedData(
             ns=ns,
             elements=[
@@ -156,13 +155,13 @@ def test_untyped_extended_data_nested(self) -> None:
         ns = "{http://www.opengis.net/kml/2.2}"
         k = kml.KML(ns=ns)
 
-        d = kml.Document(ns, "docid", "doc name", "doc description")
+        d = kml.Document(ns, id="docid", name="doc name", description="doc description")
         d.extended_data = kml.ExtendedData(
             ns=ns,
             elements=[data.Data(ns=ns, name="type", value="Document")],
         )
 
-        f = kml.Folder(ns, "fid", "f name", "f description")
+        f = kml.Folder(ns, id="fid", name="f name", description="f description")
         f.extended_data = kml.ExtendedData(
             ns=ns,
             elements=[data.Data(ns=ns, name="type", value="Folder")],

From 84103d97bf18bb9b426a50ef380d9b3ae4d204a7 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Tue, 21 Nov 2023 19:10:07 +0000
Subject: [PATCH 03/25] fix visibility and tests

---
 .github/workflows/run-all-tests.yml |  4 +--
 fastkml/about.py                    |  2 +-
 fastkml/kml.py                      | 13 ++++----
 fastkml/links.py                    | 47 +++++++++++++++------------
 tests/data_test.py                  |  5 ++-
 tests/oldunit_test.py               | 50 ++++++++++++++---------------
 6 files changed, 65 insertions(+), 56 deletions(-)

diff --git a/.github/workflows/run-all-tests.yml b/.github/workflows/run-all-tests.yml
index 69cf74d2..29863e77 100644
--- a/.github/workflows/run-all-tests.yml
+++ b/.github/workflows/run-all-tests.yml
@@ -128,13 +128,13 @@ jobs:
           --outdir dist/
       - name: Publish distribution 📦 to Test PyPI for tags
         if: startsWith(github.ref, 'refs/tags')
-        uses: pypa/gh-action-pypi-publish@master
+        uses: pypa/gh-action-pypi-publish@release/v1
         with:
           password: ${{ secrets.TEST_PYPI_API_TOKEN }}
           repository_url: https://test.pypi.org/legacy/
       - name: Publish distribution 📦 to PyPI for push to main
         if: github.event_name == 'push' && github.ref == 'refs/heads/main'
-        uses: pypa/gh-action-pypi-publish@master
+        uses: pypa/gh-action-pypi-publish@release/v1
         with:
           password: ${{ secrets.PYPI_API_TOKEN }}
 ...
diff --git a/fastkml/about.py b/fastkml/about.py
index 5496fedc..5d5b4b67 100644
--- a/fastkml/about.py
+++ b/fastkml/about.py
@@ -3,4 +3,4 @@
 
 The only purpose of this module is to provide a version number for the package.
 """
-__version__ = "1.0.a7"
+__version__ = "1.0.a8"
diff --git a/fastkml/kml.py b/fastkml/kml.py
index 2f818af8..5d6a9b47 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -405,8 +405,9 @@ def etree_element(
             element.append(self._camera.etree_element())
         elif self.look_at is not None:
             element.append(self._look_at.etree_element())
-        visibility = config.etree.SubElement(element, f"{self.ns}visibility")
-        visibility.text = str(self.visibility)
+        if self.visibility is not None:
+            visibility = config.etree.SubElement(element, f"{self.ns}visibility")
+            visibility.text = str(self.visibility)
         if self.isopen:
             isopen = config.etree.SubElement(element, f"{self.ns}open")
             isopen.text = str(self.isopen)
@@ -453,7 +454,7 @@ def from_element(self, element: Element, strict: bool = False) -> None:
         if description is not None:
             self.description = description.text
         visibility = element.find(f"{self.ns}visibility")
-        if visibility is not None:
+        if visibility is not None and visibility.text:
             self.visibility = 1 if visibility.text in ["1", "true"] else 0
         isopen = element.find(f"{self.ns}open")
         if isopen is not None:
@@ -1367,7 +1368,7 @@ def etree_element(
                 element.append(schema.etree_element())
         return element
 
-    def get_style_by_url(self, style_url: str) -> Union[Style, StyleMap]:
+    def get_style_by_url(self, style_url: str) -> Optional[Union[Style, StyleMap]]:
         id = urlparse.urlparse(style_url).fragment
         for style in self.styles():
             if style.id == id:
@@ -1529,7 +1530,7 @@ def __init__(
         self,
         ns: Optional[str] = None,
         name_spaces: Optional[Dict[str, str]] = None,
-        features: Iterable[Union[Folder, Document, Placemark]] = None,
+        features: Optional[Iterable[Union[Folder, Document, Placemark]]] = None,
     ) -> None:
         """
         The namespace (ns) may be empty ('') if the 'kml:' prefix is
@@ -1596,7 +1597,7 @@ def etree_element(
             try:
                 root = config.etree.Element(
                     f"{self.ns}kml",
-                    nsmap={None: self.ns[1:-1]},
+                    # nsmap={None: self.ns[1:-1]},
                 )
             except TypeError:
                 root = config.etree.Element(f"{self.ns}kml")
diff --git a/fastkml/links.py b/fastkml/links.py
index 47ec08ea..28180589 100644
--- a/fastkml/links.py
+++ b/fastkml/links.py
@@ -81,13 +81,8 @@ def href(self) -> Optional[str]:
         return self._href
 
     @href.setter
-    def href(self, href) -> None:
-        if isinstance(href, str):
-            self._href = href
-        elif href is None:
-            self._href = None
-        else:
-            raise ValueError
+    def href(self, href: Optional[str]) -> None:
+        self._href = href
 
     @property
     def refresh_mode(self) -> Optional[RefreshMode]:
@@ -142,7 +137,7 @@ def view_refresh_mode(self, view_refresh_mode: Optional[ViewRefreshMode]) -> Non
         self._view_refresh_mode = view_refresh_mode
 
     @property
-    def view_refresh_time(self):
+    def view_refresh_time(self) -> Optional[float]:
         """
         After camera movement stops, specifies the number of seconds to
         wait before refreshing the view.
@@ -179,7 +174,7 @@ def view_bound_scale(self, view_bound_scale: Optional[float]) -> None:
             raise ValueError
 
     @property
-    def view_format(self):
+    def view_format(self) -> Optional[str]:
         """
         Specifies the format of the query string that is appended to the
         Link's <href> before the file is fetched.
@@ -210,7 +205,7 @@ def view_format(self):
         return self._view_format
 
     @view_format.setter
-    def view_format(self, view_format) -> None:
+    def view_format(self, view_format: Optional[str]) -> None:
         if isinstance(view_format, str):
             self._view_format = view_format
         elif view_format is None:
@@ -219,7 +214,7 @@ def view_format(self, view_format) -> None:
             raise ValueError
 
     @property
-    def http_query(self):
+    def http_query(self) -> Optional[str]:
         """
         Appends information to the query string, based on the parameters specified.
 
@@ -232,7 +227,7 @@ def http_query(self):
         return self._http_query
 
     @http_query.setter
-    def http_query(self, http_query) -> None:
+    def http_query(self, http_query: Optional[str]) -> None:
         if isinstance(http_query, str):
             self._http_query = http_query
         elif http_query is None:
@@ -248,40 +243,52 @@ def etree_element(
         element = super().etree_element(precision=precision, verbosity=verbosity)
 
         if self._href:
-            href = config.etree.SubElement(element, f"{self.ns}href")
+            href = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}href",
+            )
             href.text = self._href
         if self._refresh_mode:
-            refresh_mode = config.etree.SubElement(element, f"{self.ns}refreshMode")
+            refresh_mode = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}refreshMode",
+            )
             refresh_mode.text = self._refresh_mode.value
         if self._refresh_interval:
-            refresh_interval = config.etree.SubElement(
+            refresh_interval = config.etree.SubElement(  # type: ignore[attr-defined]
                 element,
                 f"{self.ns}refreshInterval",
             )
             refresh_interval.text = str(self._refresh_interval)
         if self._view_refresh_mode:
-            view_refresh_mode = config.etree.SubElement(
+            view_refresh_mode = config.etree.SubElement(  # type: ignore[attr-defined]
                 element,
                 f"{self.ns}viewRefreshMode",
             )
             view_refresh_mode.text = self._view_refresh_mode.value
         if self._view_refresh_time:
-            view_refresh_time = config.etree.SubElement(
+            view_refresh_time = config.etree.SubElement(  # type: ignore[attr-defined]
                 element,
                 f"{self.ns}viewRefreshTime",
             )
             view_refresh_time.text = str(self._view_refresh_time)
         if self._view_bound_scale:
-            view_bound_scale = config.etree.SubElement(
+            view_bound_scale = config.etree.SubElement(  # type: ignore[attr-defined]
                 element,
                 f"{self.ns}viewBoundScale",
             )
             view_bound_scale.text = str(self._view_bound_scale)
         if self._view_format:
-            view_format = config.etree.SubElement(element, f"{self.ns}viewFormat")
+            view_format = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}viewFormat",
+            )
             view_format.text = self._view_format
         if self._http_query:
-            http_query = config.etree.SubElement(element, f"{self.ns}httpQuery")
+            http_query = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}httpQuery",
+            )
             http_query.text = self._http_query
 
         return element
diff --git a/tests/data_test.py b/tests/data_test.py
index ac540b5d..fabc6484 100644
--- a/tests/data_test.py
+++ b/tests/data_test.py
@@ -92,7 +92,10 @@ def test_schema_from_string(self) -> None:
         k1.from_string(k.to_string())
         assert "Schema" in k1.to_string()
         assert "SimpleField" in k1.to_string()
-        assert k1.to_string() == k.to_string()
+        assert k1.to_string().replace("kml:", "").replace(
+            ":kml",
+            "",
+        ) == k.to_string().replace("kml:", "").replace(":kml", "")
 
     def test_schema_data(self) -> None:
         ns = "{http://www.opengis.net/kml/2.2}"
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index d0fca0c0..44d8117e 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -79,8 +79,8 @@ def test_feature(self) -> None:
         f = kml._Feature(name="A Feature")
         pytest.raises(NotImplementedError, f.etree_element)
         assert f.name == "A Feature"
-        assert f.visibility == 1
-        assert f.isopen == 0
+        assert f.visibility is None
+        assert f.isopen is None
         assert f._atom_author is None
         assert f._atom_link is None
         assert f.address is None
@@ -140,11 +140,16 @@ def test_folder(self) -> None:
         """KML file with folders."""
         ns = "{http://www.opengis.net/kml/2.2}"
         k = kml.KML()
-        f = kml.Folder(ns, "id", "name", "description")
-        nf = kml.Folder(ns, "nested-id", "nested-name", "nested-description")
+        f = kml.Folder(ns, id="id", name="name", description="description")
+        nf = kml.Folder(
+            ns,
+            id="nested-id",
+            name="nested-name",
+            description="nested-description",
+        )
         f.append(nf)
         k.append(f)
-        f2 = kml.Folder(ns, "id2", "name2", "description2")
+        f2 = kml.Folder(ns, id="id2", name="name2", description="description2")
         k.append(f2)
         assert len(list(k.features())) == 2
         assert len(list(next(iter(k.features())).features())) == 1
@@ -156,9 +161,9 @@ def test_folder(self) -> None:
     def test_placemark(self) -> None:
         ns = "{http://www.opengis.net/kml/2.2}"
         k = kml.KML(ns=ns)
-        p = kml.Placemark(ns, "id", "name", "description")
+        p = kml.Placemark(ns, id="id", name="name", description="description")
         # XXX p.geometry = Point(0.0, 0.0, 0.0)
-        p2 = kml.Placemark(ns, "id2", "name2", "description2")
+        p2 = kml.Placemark(ns, id="id2", name="name2", description="description2")
         # XXX p2.geometry = LineString([(0, 0, 0), (1, 1, 1)])
         k.append(p)
         k.append(p2)
@@ -170,17 +175,22 @@ def test_placemark(self) -> None:
     def test_document(self) -> None:
         k = kml.KML()
         ns = "{http://www.opengis.net/kml/2.2}"
-        d = kml.Document(ns, "docid", "doc name", "doc description")
-        f = kml.Folder(ns, "fid", "f name", "f description")
+        d = kml.Document(ns, id="docid", name="doc name", description="doc description")
+        f = kml.Folder(ns, id="fid", name="f name", description="f description")
         k.append(d)
         d.append(f)
-        nf = kml.Folder(ns, "nested-fid", "nested f name", "nested f description")
+        nf = kml.Folder(
+            ns,
+            id="nested-fid",
+            name="nested f name",
+            description="nested f description",
+        )
         f.append(nf)
-        f2 = kml.Folder(ns, "id2", "name2", "description2")
+        f2 = kml.Folder(ns, id="id2", name="name2", description="description2")
         d.append(f2)
-        p = kml.Placemark(ns, "id", "name", "description")
+        p = kml.Placemark(ns, id="id", name="name", description="description")
         # XXX p.geometry = Polygon([(0, 0, 0), (1, 1, 0), (1, 0, 1)])
-        p2 = kml.Placemark(ns, "id2", "name2", "description2")
+        p2 = kml.Placemark(ns, id="id2", name="name2", description="description2")
         # p2 does not have a geometry!
         f2.append(p)
         nf.append(p2)
@@ -715,7 +725,7 @@ def test_create_document_style(self) -> None:
 
         expected = """
             <kml:Document xmlns:kml="http://www.opengis.net/kml/2.2">
-              <kml:visibility>1</kml:visibility>
+              <kml:visibility/>
                 <kml:Style>
                   <kml:PolyStyle>
                     <kml:color>7f000000</kml:color>
@@ -743,7 +753,6 @@ def test_create_placemark_style(self) -> None:
 
         expected = """
             <kml:Placemark xmlns:kml="http://www.opengis.net/kml/2.2">
-              <kml:visibility>1</kml:visibility>
                 <kml:Style>
                   <kml:PolyStyle>
                     <kml:color>7f000000</kml:color>
@@ -1527,7 +1536,6 @@ def test_default_to_string(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "</kml:GroundOverlay>",
         )
         assert g.to_string() == expected.to_string()
@@ -1542,7 +1550,6 @@ def test_to_string(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:color>00010203</kml:color>"
             "<kml:drawOrder>1</kml:drawOrder>"
             "<kml:Icon>"
@@ -1560,7 +1567,6 @@ def test_altitude_from_int(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:altitude>123</kml:altitude>"
             "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
             "</kml:GroundOverlay>",
@@ -1575,7 +1581,6 @@ def test_altitude_from_float(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:altitude>123.4</kml:altitude>"
             "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
             "</kml:GroundOverlay>",
@@ -1590,7 +1595,6 @@ def test_altitude_from_string(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:altitude>123.4</kml:altitude>"
             "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
             "</kml:GroundOverlay>",
@@ -1606,7 +1610,6 @@ def test_altitude_mode_absolute(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:altitude>123.4</kml:altitude>"
             "<kml:altitudeMode>absolute</kml:altitudeMode>"
             "</kml:GroundOverlay>",
@@ -1622,7 +1625,6 @@ def test_altitude_mode_unknown_string(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:altitude>123.4</kml:altitude>"
             "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
             "</kml:GroundOverlay>",
@@ -1638,7 +1640,6 @@ def test_altitude_mode_value(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:altitude>123.4</kml:altitude>"
             "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
             "</kml:GroundOverlay>",
@@ -1653,7 +1654,6 @@ def test_latlonbox_no_rotation(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:LatLonBox>"
             "<kml:north>10</kml:north>"
             "<kml:south>20</kml:south>"
@@ -1673,7 +1673,6 @@ def test_latlonbox_rotation(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:LatLonBox>"
             "<kml:north>10</kml:north>"
             "<kml:south>20</kml:south>"
@@ -1697,7 +1696,6 @@ def test_latlonbox_nswer(self) -> None:
         expected = kml.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:visibility>1</kml:visibility>"
             "<kml:LatLonBox>"
             "<kml:north>10</kml:north>"
             "<kml:south>20</kml:south>"

From 3f3b36792e24ac73aa0fd1d11aa91937e372aef1 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Tue, 21 Nov 2023 22:30:12 +0000
Subject: [PATCH 04/25] Refactor Icon class to use classmethod for element
 parsing

---
 fastkml/kml.py    |   9 ++--
 fastkml/links.py  | 110 +++++++++++++++++++---------------------------
 tests/kml_test.py |   6 +--
 3 files changed, 53 insertions(+), 72 deletions(-)

diff --git a/fastkml/kml.py b/fastkml/kml.py
index 5d6a9b47..4881406b 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -738,9 +738,12 @@ def from_element(self, element: Element) -> None:
             self.draw_order = draw_order.text
         icon = element.find(f"{self.ns}Icon")
         if icon is not None:
-            s = Icon(self.ns)
-            s.from_element(icon)
-            self._icon = s
+            self._icon = Icon.class_from_element(
+                ns=self.ns,
+                name_spaces=self.name_spaces,
+                element=icon,
+                strict=False,
+            )
 
 
 class PhotoOverlay(_Overlay):
diff --git a/fastkml/links.py b/fastkml/links.py
index 28180589..4a70bfad 100644
--- a/fastkml/links.py
+++ b/fastkml/links.py
@@ -14,6 +14,8 @@
 # along with this library; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
 
+import contextlib
+from typing import Any
 from typing import Dict
 from typing import Optional
 
@@ -33,6 +35,9 @@ class Icon(_BaseObject):
     The required <href> child element defines the location
     of the image to be used as the overlay or as the icon for the placemark.
     This location can either be on a local file system or a remote web server.
+
+    Todo:
+    ----
     The <gx:x>, <gx:y>, <gx:w>, and <gx:h> elements are used to select one
     icon from an image that contains multiple icons
     (often referred to as an icon palette).
@@ -108,12 +113,7 @@ def refresh_interval(self) -> Optional[float]:
 
     @refresh_interval.setter
     def refresh_interval(self, refresh_interval: Optional[float]) -> None:
-        if isinstance(refresh_interval, float):
-            self._refresh_interval = refresh_interval
-        elif refresh_interval is None:
-            self._refresh_interval = None
-        else:
-            raise ValueError
+        self._refresh_interval = refresh_interval
 
     @property
     def view_refresh_mode(self) -> Optional[ViewRefreshMode]:
@@ -146,12 +146,7 @@ def view_refresh_time(self) -> Optional[float]:
 
     @view_refresh_time.setter
     def view_refresh_time(self, view_refresh_time: Optional[float]) -> None:
-        if isinstance(view_refresh_time, float):
-            self._view_refresh_time = view_refresh_time
-        elif view_refresh_time is None:
-            self._view_refresh_time = None
-        else:
-            raise ValueError
+        self._view_refresh_time = view_refresh_time
 
     @property
     def view_bound_scale(self) -> Optional[float]:
@@ -166,12 +161,7 @@ def view_bound_scale(self) -> Optional[float]:
 
     @view_bound_scale.setter
     def view_bound_scale(self, view_bound_scale: Optional[float]) -> None:
-        if isinstance(view_bound_scale, float):
-            self._view_bound_scale = view_bound_scale
-        elif view_bound_scale is None:
-            self._view_bound_scale = None
-        else:
-            raise ValueError
+        self._view_bound_scale = view_bound_scale
 
     @property
     def view_format(self) -> Optional[str]:
@@ -206,12 +196,7 @@ def view_format(self) -> Optional[str]:
 
     @view_format.setter
     def view_format(self, view_format: Optional[str]) -> None:
-        if isinstance(view_format, str):
-            self._view_format = view_format
-        elif view_format is None:
-            self._view_format = None
-        else:
-            raise ValueError
+        self._view_format = view_format
 
     @property
     def http_query(self) -> Optional[str]:
@@ -228,12 +213,7 @@ def http_query(self) -> Optional[str]:
 
     @http_query.setter
     def http_query(self, http_query: Optional[str]) -> None:
-        if isinstance(http_query, str):
-            self._http_query = http_query
-        elif http_query is None:
-            self._http_query = None
-        else:
-            raise ValueError
+        self._http_query = http_query
 
     def etree_element(
         self,
@@ -293,46 +273,46 @@ def etree_element(
 
         return element
 
-    def from_element(self, element: Element) -> None:
-        super().from_element(element)
-
-        href = element.find(f"{self.ns}href")
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        href = element.find(f"{ns}href")
         if href is not None:
-            self.href = href.text
-
-        refresh_mode = element.find(f"{self.ns}refreshMode")
+            kwargs["href"] = href.text
+        refresh_mode = element.find(f"{ns}refreshMode")
         if refresh_mode is not None:
-            self.refresh_mode = RefreshMode(refresh_mode.text)
-
-        refresh_interval = element.find(f"{self.ns}refreshInterval")
+            kwargs["refresh_mode"] = RefreshMode(refresh_mode.text)
+        refresh_interval = element.find(f"{ns}refreshInterval")
         if refresh_interval is not None:
-            try:
-                self.refresh_interval = float(refresh_interval.text)
-            except ValueError:
-                self.refresh_interval = None
-
-        view_refresh_mode = element.find(f"{self.ns}viewRefreshMode")
+            with contextlib.suppress(ValueError):
+                kwargs["refresh_interval"] = float(refresh_interval.text)
+        view_refresh_mode = element.find(f"{ns}viewRefreshMode")
         if view_refresh_mode is not None:
-            self.view_refresh_mode = ViewRefreshMode(view_refresh_mode.text)
-
-        view_refresh_time = element.find(f"{self.ns}viewRefreshTime")
+            kwargs["view_refresh_mode"] = ViewRefreshMode(view_refresh_mode.text)
+        view_refresh_time = element.find(f"{ns}viewRefreshTime")
         if view_refresh_time is not None:
-            try:
-                self.view_refresh_time = float(view_refresh_time.text)
-            except ValueError:
-                self.view_refresh_time = None
-
-        view_bound_scale = element.find(f"{self.ns}viewBoundScale")
+            with contextlib.suppress(ValueError):
+                kwargs["view_refresh_time"] = float(view_refresh_time.text)
+        view_bound_scale = element.find(f"{ns}viewBoundScale")
         if view_bound_scale is not None:
-            try:
-                self.view_bound_scale = float(view_bound_scale.text)
-            except ValueError:
-                self.view_bound_scale = None
-
-        view_format = element.find(f"{self.ns}viewFormat")
+            with contextlib.suppress(ValueError):
+                kwargs["view_bound_scale"] = float(view_bound_scale.text)
+        view_format = element.find(f"{ns}viewFormat")
         if view_format is not None:
-            self.view_format = view_format.text
-
-        http_query = element.find(f"{self.ns}httpQuery")
+            kwargs["view_format"] = view_format.text
+        http_query = element.find(f"{ns}httpQuery")
         if http_query is not None:
-            self.http_query = http_query.text
+            kwargs["http_query"] = http_query.text
+        return kwargs
diff --git a/tests/kml_test.py b/tests/kml_test.py
index f3b83ba9..c371d846 100644
--- a/tests/kml_test.py
+++ b/tests/kml_test.py
@@ -51,8 +51,7 @@ def test_icon(self) -> None:
 
     def test_icon_read(self) -> None:
         """Test the Icon class."""
-        icon = kml.Icon()
-        icon.from_string(
+        icon = kml.Icon.class_from_string(
             """
             <kml:Icon xmlns:kml="http://www.opengis.net/kml/2.2" id="icon-01">
             <kml:href>http://maps.google.com/mapfiles/kml/paddle/red-circle.png</kml:href>
@@ -77,8 +76,7 @@ def test_icon_read(self) -> None:
         assert icon.view_format == "BBOX=[bboxWest],[bboxSouth],[bboxEast],[bboxNorth]"
         assert icon.http_query == "clientName=fastkml"
 
-        icon2 = kml.Icon()
-        icon2.from_string(icon.to_string())
+        icon2 = kml.Icon.class_from_string(icon.to_string())
 
         assert icon2.to_string() == icon.to_string()
 

From d9ed7010a35ea24ffce8d046340aa192ddfd961c Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Wed, 22 Nov 2023 11:43:24 +0000
Subject: [PATCH 05/25] Split features, containers, overlays from kml.py

---
 fastkml/containers.py |  202 ++++++
 fastkml/features.py   |  634 ++++++++++++++++++
 fastkml/kml.py        | 1491 +----------------------------------------
 fastkml/overlays.py   |  732 ++++++++++++++++++++
 4 files changed, 1574 insertions(+), 1485 deletions(-)
 create mode 100644 fastkml/containers.py
 create mode 100644 fastkml/features.py
 create mode 100644 fastkml/overlays.py

diff --git a/fastkml/containers.py b/fastkml/containers.py
new file mode 100644
index 00000000..b0285a6c
--- /dev/null
+++ b/fastkml/containers.py
@@ -0,0 +1,202 @@
+"""
+Container classes for KML elements.
+"""
+import logging
+import urllib.parse as urlparse
+from typing import Dict
+from typing import Iterator
+from typing import List
+from typing import Optional
+from typing import Union
+
+from fastkml import gx
+from fastkml.data import Schema
+from fastkml.enums import Verbosity
+from fastkml.features import Placemark
+from fastkml.features import _Feature
+from fastkml.geometry import LinearRing
+from fastkml.geometry import LineString
+from fastkml.geometry import MultiGeometry
+from fastkml.geometry import Point
+from fastkml.geometry import Polygon
+from fastkml.overlays import _Overlay
+from fastkml.styles import Style
+from fastkml.styles import StyleMap
+from fastkml.types import Element
+
+logger = logging.getLogger(__name__)
+
+KmlGeometry = Union[
+    Point,
+    LineString,
+    LinearRing,
+    Polygon,
+    MultiGeometry,
+    gx.MultiTrack,
+    gx.Track,
+]
+
+
+class _Container(_Feature):
+    """
+    abstract element; do not create
+    A Container element holds one or more Features and allows the
+    creation of nested hierarchies.
+    subclasses are:
+    Document,
+    Folder.
+    """
+
+    _features = []
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        name: Optional[str] = None,
+        description: Optional[str] = None,
+        styles: Optional[List[Style]] = None,
+        style_url: Optional[str] = None,
+        features: None = None,
+    ) -> None:
+        super().__init__(
+            ns=ns,
+            name_spaces=name_spaces,
+            id=id,
+            target_id=target_id,
+            name=name,
+            description=description,
+            styles=styles,
+            style_url=style_url,
+        )
+        self._features = features or []
+
+    def features(self) -> Iterator[_Feature]:
+        """Iterate over features."""
+        for feature in self._features:
+            if isinstance(feature, (Folder, Placemark, Document, _Overlay)):
+                yield feature
+            else:
+                msg = (
+                    "Features must be instances of "
+                    "(Folder, Placemark, Document, Overlay)"
+                )
+                raise TypeError(
+                    msg,
+                )
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        for feature in self.features():
+            element.append(feature.etree_element())
+        return element
+
+    def append(self, kmlobj: _Feature) -> None:
+        """Append a feature."""
+        if id(kmlobj) == id(self):
+            msg = "Cannot append self"
+            raise ValueError(msg)
+        if isinstance(kmlobj, (Folder, Placemark, Document, _Overlay)):
+            self._features.append(kmlobj)
+        else:
+            msg = "Features must be instances of (Folder, Placemark, Document, Overlay)"
+            raise TypeError(
+                msg,
+            )
+
+
+class Folder(_Container):
+    """
+    A Folder is used to arrange other Features hierarchically
+    (Folders, Placemarks, #NetworkLinks, or #Overlays).
+    """
+
+    __name__ = "Folder"
+
+    def from_element(self, element: Element) -> None:
+        super().from_element(element)
+        folders = element.findall(f"{self.ns}Folder")
+        for folder in folders:
+            feature = Folder(self.ns)
+            feature.from_element(folder)
+            self.append(feature)
+        placemarks = element.findall(f"{self.ns}Placemark")
+        for placemark in placemarks:
+            feature = Placemark(self.ns)
+            feature.from_element(placemark)
+            self.append(feature)
+        documents = element.findall(f"{self.ns}Document")
+        for document in documents:
+            feature = Document(self.ns)
+            feature.from_element(document)
+            self.append(feature)
+
+
+class Document(_Container):
+    """
+    A Document is a container for features and styles. This element is
+    required if your KML file uses shared styles or schemata for typed
+    extended data.
+    """
+
+    __name__ = "Document"
+    _schemata = None
+
+    def schemata(self) -> Iterator["Schema"]:
+        if self._schemata:
+            yield from self._schemata
+
+    def append_schema(self, schema: "Schema") -> None:
+        if self._schemata is None:
+            self._schemata = []
+        if isinstance(schema, Schema):
+            self._schemata.append(schema)
+        else:
+            s = Schema(schema)
+            self._schemata.append(s)
+
+    def from_element(self, element: Element, strict: bool = False) -> None:
+        super().from_element(element)
+        documents = element.findall(f"{self.ns}Document")
+        for document in documents:
+            feature = Document(self.ns)
+            feature.from_element(document)
+            self.append(feature)
+        folders = element.findall(f"{self.ns}Folder")
+        for folder in folders:
+            feature = Folder(self.ns)
+            feature.from_element(folder)
+            self.append(feature)
+        placemarks = element.findall(f"{self.ns}Placemark")
+        for placemark in placemarks:
+            feature = Placemark(self.ns)
+            feature.from_element(placemark)
+            self.append(feature)
+        schemata = element.findall(f"{self.ns}Schema")
+        for schema in schemata:
+            s = Schema.class_from_element(ns=self.ns, element=schema, strict=strict)
+            self.append_schema(s)
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        if self._schemata is not None:
+            for schema in self._schemata:
+                element.append(schema.etree_element())
+        return element
+
+    def get_style_by_url(self, style_url: str) -> Optional[Union[Style, StyleMap]]:
+        id = urlparse.urlparse(style_url).fragment
+        for style in self.styles():
+            if style.id == id:
+                return style
+        return None
diff --git a/fastkml/features.py b/fastkml/features.py
new file mode 100644
index 00000000..b911f359
--- /dev/null
+++ b/fastkml/features.py
@@ -0,0 +1,634 @@
+"""
+Feature base, Placemark and NetworkLink.
+
+These are the objects that can be added to a KML file.
+"""
+
+import logging
+from datetime import datetime
+from typing import Any
+from typing import Dict
+from typing import Iterator
+from typing import List
+from typing import Optional
+from typing import Union
+
+from fastkml import atom
+from fastkml import config
+from fastkml import gx
+from fastkml.base import _BaseObject
+from fastkml.data import ExtendedData
+from fastkml.enums import Verbosity
+from fastkml.geometry import AnyGeometryType
+from fastkml.geometry import LinearRing
+from fastkml.geometry import LineString
+from fastkml.geometry import MultiGeometry
+from fastkml.geometry import Point
+from fastkml.geometry import Polygon
+from fastkml.mixins import TimeMixin
+from fastkml.styles import Style
+from fastkml.styles import StyleMap
+from fastkml.styles import StyleUrl
+from fastkml.styles import _StyleSelector
+from fastkml.times import TimeSpan
+from fastkml.times import TimeStamp
+from fastkml.types import Element
+from fastkml.views import Camera
+from fastkml.views import LookAt
+
+logger = logging.getLogger(__name__)
+
+KmlGeometry = Union[
+    Point,
+    LineString,
+    LinearRing,
+    Polygon,
+    MultiGeometry,
+    gx.MultiTrack,
+    gx.Track,
+]
+
+
+class _Feature(TimeMixin, _BaseObject):
+    """
+    abstract element; do not create
+    subclasses are:
+        * Container (Document, Folder)
+        * Placemark
+        * Overlay
+    Not Implemented Yet:
+        * NetworkLink.
+    """
+
+    name: Optional[str]
+    # User-defined text displayed in the 3D viewer as the label for the
+    # object (for example, for a Placemark, Folder, or NetworkLink).
+
+    visibility: Optional[bool]
+    # Boolean value. Specifies whether the feature is drawn in the 3D
+    # viewer when it is initially loaded. In order for a feature to be
+    # visible, the <visibility> tag of all its ancestors must also be
+    # set to 1.
+
+    isopen: Optional[bool]
+    # Boolean value. Specifies whether a Document or Folder appears
+    # closed or open when first loaded into the Places panel.
+    # 0=collapsed (the default), 1=expanded.
+
+    _atom_author: Optional[atom.Author]
+    # KML 2.2 supports new elements for including data about the author
+    # and related website in your KML file. This information is displayed
+    # in geo search results, both in Earth browsers such as Google Earth,
+    # and in other applications such as Google Maps.
+
+    _atom_link: Optional[atom.Link]
+    # Specifies the URL of the website containing this KML or KMZ file.
+
+    _address: Optional[str]
+    # A string value representing an unstructured address written as a
+    # standard street, city, state address, and/or as a postal code.
+    # You can use the <address> tag to specify the location of a point
+    # instead of using latitude and longitude coordinates.
+
+    _phone_number: Optional[str]
+    # A string value representing a telephone number.
+    # This element is used by Google Maps Mobile only.
+
+    _snippet: Optional[Union[str, Dict[str, Any]]]
+    # _snippet is either a tuple of a string Snippet.text and an integer
+    # Snippet.maxLines or a string
+    #
+    # A short description of the feature. In Google Earth, this
+    # description is displayed in the Places panel under the name of the
+    # feature. If a Snippet is not supplied, the first two lines of
+    # the <description> are used. In Google Earth, if a Placemark
+    # contains both a description and a Snippet, the <Snippet> appears
+    # beneath the Placemark in the Places panel, and the <description>
+    # appears in the Placemark's description balloon. This tag does not
+    # support HTML markup. <Snippet> has a maxLines attribute, an integer
+    # that specifies the maximum number of lines to display.
+
+    description: Optional[str]
+    # User-supplied content that appears in the description balloon.
+
+    _style_url: Optional[Union[Style, StyleMap]]
+    # URL of a <Style> or <StyleMap> defined in a Document.
+    # If the style is in the same file, use a # reference.
+    # If the style is defined in an external file, use a full URL
+    # along with # referencing.
+
+    _styles: List[Union[Style, StyleMap]]
+    # One or more Styles and StyleMaps can be defined to customize the
+    # appearance of any element derived from Feature or of the Geometry
+    # in a Placemark.
+    # A style defined within a Feature is called an "inline style" and
+    # applies only to the Feature that contains it. A style defined as
+    # the child of a <Document> is called a "shared style." A shared
+    # style must have an id defined for it. This id is referenced by one
+    # or more Features within the <Document>. In cases where a style
+    # element is defined both in a shared style and in an inline style
+    # for a Feature—that is, a Folder, GroundOverlay, NetworkLink,
+    # Placemark, or ScreenOverlay—the value for the Feature's inline
+    # style takes precedence over the value for the shared style.
+
+    _timespan: Optional[TimeSpan]
+    # Associates this Feature with a period of time.
+    _timestamp: Optional[TimeStamp]
+    # Associates this Feature with a point in time.
+
+    _camera: Optional[Camera]
+
+    _look_at: Optional[LookAt]
+
+    # TODO Region = None
+    # Features and geometry associated with a Region are drawn only when
+    # the Region is active.
+
+    # TODO ExtendedData = None
+    # Allows you to add custom data to a KML file. This data can be
+    # (1) data that references an external XML schema,
+    # (2) untyped data/value pairs, or
+    # (3) typed data.
+    # A given KML Feature can contain a combination of these types of
+    # custom data.
+    #
+    # (2) is already implemented, see UntypedExtendedData
+    #
+    # <Metadata> (deprecated in KML 2.2; use <ExtendedData> instead)
+    extended_data: Optional[ExtendedData]
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        name: Optional[str] = None,
+        description: Optional[str] = None,
+        snippet: Optional[Union[str, Dict[str, Any]]] = None,
+        atom_author: Optional[atom.Author] = None,
+        atom_link: Optional[atom.Link] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
+        styles: Optional[List[Style]] = None,
+        style_url: Optional[str] = None,
+        extended_data: None = None,
+        camera: Optional[Camera] = None,
+        look_at: Optional[LookAt] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
+    ) -> None:
+        super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
+        self.name = name
+        self.description = description
+        self.style_url = style_url
+        self._styles = []
+        self._camera = camera
+        self._look_at = look_at
+        self.visibility = visibility
+        self.isopen = isopen
+        self.snippet = snippet
+        self._atom_author = atom_author
+        self._atom_link = atom_link
+        self.address = address
+        self.phone_number = phone_number
+        if styles:
+            for style in styles:
+                self.append_style(style)
+        self.extended_data = extended_data
+
+    @property
+    def style_url(self) -> Optional[str]:
+        """
+        Returns the url only, not a full StyleUrl object.
+        if you need the full StyleUrl object use _style_url.
+        """
+        if isinstance(self._style_url, StyleUrl):
+            return self._style_url.url
+        return None
+
+    @style_url.setter
+    def style_url(self, styleurl: Union[str, StyleUrl, None]) -> None:
+        """You may pass a StyleUrl Object, a string or None."""
+        if isinstance(styleurl, StyleUrl):
+            self._style_url = styleurl
+        elif isinstance(styleurl, str):
+            s = StyleUrl(self.ns, url=styleurl)
+            self._style_url = s
+        elif styleurl is None:
+            self._style_url = None
+        else:
+            raise ValueError
+
+    @property
+    def camera(self):
+        return self._camera
+
+    @camera.setter
+    def camera(self, camera) -> None:
+        if isinstance(camera, Camera):
+            self._camera = camera
+
+    @property
+    def look_at(self) -> datetime:
+        return self._look_at
+
+    @look_at.setter
+    def look_at(self, look_at) -> None:
+        if isinstance(look_at, LookAt):
+            self._look_at = look_at
+
+    @property
+    def link(self):
+        return self._atom_link.href
+
+    @link.setter
+    def link(self, url) -> None:
+        if isinstance(url, str):
+            self._atom_link = atom.Link(href=url)
+        elif isinstance(url, atom.Link):
+            self._atom_link = url
+        elif url is None:
+            self._atom_link = None
+        else:
+            raise TypeError
+
+    @property
+    def author(self) -> None:
+        if self._atom_author:
+            return self._atom_author.name
+        return None
+
+    @author.setter
+    def author(self, name) -> None:
+        if isinstance(name, atom.Author):
+            self._atom_author = name
+        elif isinstance(name, str):
+            if self._atom_author is None:
+                self._atom_author = atom.Author(ns=config.ATOMNS, name=name)
+            else:
+                self._atom_author.name = name
+        elif name is None:
+            self._atom_author = None
+        else:
+            raise TypeError
+
+    def append_style(self, style: Union[Style, StyleMap]) -> None:
+        """Append a style to the feature."""
+        if isinstance(style, _StyleSelector):
+            self._styles.append(style)
+        else:
+            raise TypeError
+
+    def styles(self) -> Iterator[Union[Style, StyleMap]]:
+        """Iterate over the styles of this feature."""
+        for style in self._styles:
+            if isinstance(style, _StyleSelector):
+                yield style
+            else:
+                raise TypeError
+
+    @property
+    def snippet(self) -> Optional[Dict[str, Any]]:
+        if not self._snippet:
+            return None
+        if isinstance(self._snippet, dict):
+            text = self._snippet.get("text")
+            if text:
+                assert isinstance(text, str)
+                max_lines = self._snippet.get("maxLines", None)
+                if max_lines is None:
+                    return {"text": text}
+                elif int(max_lines) > 0:
+                    # if maxLines <=0 ignore it
+                    return {"text": text, "maxLines": max_lines}
+                return None
+            return None
+        elif isinstance(self._snippet, str):
+            return self._snippet
+        else:
+            msg = "Snippet must be dict of {'text':t, 'maxLines':i} or string"
+            raise ValueError(
+                msg,
+            )
+
+    @snippet.setter
+    def snippet(self, snip=None) -> None:
+        self._snippet = {}
+        if isinstance(snip, dict):
+            self._snippet["text"] = snip.get("text")
+            max_lines = snip.get("maxLines")
+            if max_lines is not None:
+                self._snippet["maxLines"] = int(snip["maxLines"])
+        elif isinstance(snip, str):
+            self._snippet["text"] = snip
+        elif snip is None:
+            self._snippet = None
+        else:
+            msg = "Snippet must be dict of {'text':t, 'maxLines':i} or string"
+            raise ValueError(
+                msg,
+            )
+
+    @property
+    def address(self) -> None:
+        if self._address:
+            return self._address
+        return None
+
+    @address.setter
+    def address(self, address) -> None:
+        if isinstance(address, str):
+            self._address = address
+        elif address is None:
+            self._address = None
+        else:
+            raise ValueError
+
+    @property
+    def phone_number(self) -> None:
+        if self._phone_number:
+            return self._phone_number
+        return None
+
+    @phone_number.setter
+    def phone_number(self, phone_number) -> None:
+        if isinstance(phone_number, str):
+            self._phone_number = phone_number
+        elif phone_number is None:
+            self._phone_number = None
+        else:
+            raise ValueError
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        if self.name:
+            name = config.etree.SubElement(element, f"{self.ns}name")
+            name.text = self.name
+        if self.description:
+            description = config.etree.SubElement(element, f"{self.ns}description")
+            description.text = self.description
+        if (self.camera is not None) and (self.look_at is not None):
+            msg = "Either Camera or LookAt can be defined, not both"
+            raise ValueError(msg)
+        if self.camera is not None:
+            element.append(self._camera.etree_element())
+        elif self.look_at is not None:
+            element.append(self._look_at.etree_element())
+        if self.visibility is not None:
+            visibility = config.etree.SubElement(element, f"{self.ns}visibility")
+            visibility.text = str(self.visibility)
+        if self.isopen:
+            isopen = config.etree.SubElement(element, f"{self.ns}open")
+            isopen.text = str(self.isopen)
+        if self._style_url is not None:
+            element.append(self._style_url.etree_element())
+        for style in self.styles():
+            element.append(style.etree_element())
+        if self.snippet:
+            snippet = config.etree.SubElement(element, f"{self.ns}Snippet")
+            if isinstance(self.snippet, str):
+                snippet.text = self.snippet
+            else:
+                assert isinstance(self.snippet["text"], str)
+                snippet.text = self.snippet["text"]
+                if self.snippet.get("maxLines"):
+                    snippet.set("maxLines", str(self.snippet["maxLines"]))
+        if (self._timespan is not None) and (self._timestamp is not None):
+            msg = "Either Timestamp or Timespan can be defined, not both"
+            raise ValueError(msg)
+        elif self._timespan is not None:
+            element.append(self._timespan.etree_element())
+        elif self._timestamp is not None:
+            element.append(self._timestamp.etree_element())
+        if self._atom_link is not None:
+            element.append(self._atom_link.etree_element())
+        if self._atom_author is not None:
+            element.append(self._atom_author.etree_element())
+        if self.extended_data is not None:
+            element.append(self.extended_data.etree_element())
+        if self._address is not None:
+            address = config.etree.SubElement(element, f"{self.ns}address")
+            address.text = self._address
+        if self._phone_number is not None:
+            phone_number = config.etree.SubElement(element, f"{self.ns}phoneNumber")
+            phone_number.text = self._phone_number
+        return element
+
+    def from_element(self, element: Element, strict: bool = False) -> None:
+        super().from_element(element)
+        name = element.find(f"{self.ns}name")
+        if name is not None:
+            self.name = name.text
+        description = element.find(f"{self.ns}description")
+        if description is not None:
+            self.description = description.text
+        visibility = element.find(f"{self.ns}visibility")
+        if visibility is not None and visibility.text:
+            self.visibility = 1 if visibility.text in ["1", "true"] else 0
+        isopen = element.find(f"{self.ns}open")
+        if isopen is not None:
+            self.isopen = 1 if isopen.text in ["1", "true"] else 0
+        styles = element.findall(f"{self.ns}Style")
+        for style in styles:
+            s = Style.class_from_element(
+                ns=self.ns,
+                name_spaces=self.name_spaces,
+                element=style,
+                strict=strict,
+            )
+            self.append_style(s)
+        styles = element.findall(f"{self.ns}StyleMap")
+        for style in styles:
+            s = StyleMap.class_from_element(
+                ns=self.ns,
+                name_spaces=self.name_spaces,
+                element=style,
+                strict=strict,
+            )
+            self.append_style(s)
+        style_url = element.find(f"{self.ns}styleUrl")
+        if style_url is not None:
+            self._style_url = StyleUrl.class_from_element(
+                ns=self.ns,
+                name_spaces=self.name_spaces,
+                element=style_url,
+                strict=strict,
+            )
+        snippet = element.find(f"{self.ns}Snippet")
+        if snippet is not None:
+            _snippet = {"text": snippet.text}
+            if snippet.get("maxLines"):
+                _snippet["maxLines"] = int(snippet.get("maxLines"))
+            self.snippet = _snippet
+        timespan = element.find(f"{self.ns}TimeSpan")
+        if timespan is not None:
+            self._timespan = TimeSpan.class_from_element(
+                ns=self.ns,
+                name_spaces=self.name_spaces,
+                element=timespan,
+                strict=strict,
+            )
+        timestamp = element.find(f"{self.ns}TimeStamp")
+        if timestamp is not None:
+            self._timestamp = TimeStamp.class_from_element(
+                ns=self.ns,
+                name_spaces=self.name_spaces,
+                element=timestamp,
+                strict=strict,
+            )
+        atom_link = element.find(f"{atom.NS}link")
+        if atom_link is not None:
+            self._atom_link = atom.Link.class_from_element(
+                ns=atom.NS,
+                name_spaces=self.name_spaces,
+                element=atom_link,
+                strict=strict,
+            )
+        atom_author = element.find(f"{atom.NS}author")
+        if atom_author is not None:
+            self._atom_author = atom.Author.class_from_element(
+                ns=atom.NS,
+                name_spaces=self.name_spaces,
+                element=atom_author,
+                strict=strict,
+            )
+        extended_data = element.find(f"{self.ns}ExtendedData")
+        if extended_data is not None:
+            self.extended_data = ExtendedData.class_from_element(
+                ns=self.ns,
+                element=extended_data,
+                strict=strict,
+            )
+        address = element.find(f"{self.ns}address")
+        if address is not None:
+            self.address = address.text
+        phone_number = element.find(f"{self.ns}phoneNumber")
+        if phone_number is not None:
+            self.phone_number = phone_number.text
+        camera = element.find(f"{self.ns}Camera")
+        if camera is not None:
+            s = Camera(self.ns)
+            s.from_element(camera)
+            self.camera = s
+
+
+class Placemark(_Feature):
+    """
+    A Placemark is a Feature with associated Geometry.
+    In Google Earth, a Placemark appears as a list item in the Places
+    panel. A Placemark with a Point has an icon associated with it that
+    marks a point on the Earth in the 3D viewer.
+    """
+
+    __name__ = "Placemark"
+    _geometry = None
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        name: Optional[str] = None,
+        description: Optional[str] = None,
+        styles: Optional[List[Style]] = None,
+        style_url: Optional[str] = None,
+        extended_data: None = None,
+        geometry: Optional[KmlGeometry] = None,
+    ) -> None:
+        super().__init__(
+            ns=ns,
+            name_spaces=name_spaces,
+            id=id,
+            target_id=target_id,
+            name=name,
+            description=description,
+            styles=styles,
+            style_url=style_url,
+            extended_data=extended_data,
+        )
+        self._geometry = geometry
+
+    @property
+    def geometry(self) -> Optional[AnyGeometryType]:
+        if self._geometry is not None:
+            return self._geometry.geometry
+        return None
+
+    def from_element(self, element: Element, strict=False) -> None:
+        super().from_element(element)
+        point = element.find(f"{self.ns}Point")
+        if point is not None:
+            self._geometry = Point.class_from_element(
+                ns=self.ns,
+                element=point,
+                strict=strict,
+            )
+            return
+        line = element.find(f"{self.ns}LineString")
+        if line is not None:
+            self._geometry = LineString.class_from_element(
+                ns=self.ns,
+                element=line,
+                strict=strict,
+            )
+            return
+        polygon = element.find(f"{self.ns}Polygon")
+        if polygon is not None:
+            self._geometry = Polygon.class_from_element(
+                ns=self.ns,
+                element=polygon,
+                strict=strict,
+            )
+            return
+        linearring = element.find(f"{self.ns}LinearRing")
+        if linearring is not None:
+            self._geometry = LinearRing.class_from_element(
+                ns=self.ns,
+                element=linearring,
+                strict=strict,
+            )
+            return
+        multigeometry = element.find(f"{self.ns}MultiGeometry")
+        if multigeometry is not None:
+            self._geometry = MultiGeometry.class_from_element(
+                ns=self.ns,
+                element=multigeometry,
+                strict=strict,
+            )
+            return
+        track = element.find(f"{self.ns}Track")
+        if track is not None:
+            self._geometry = gx.Track.class_from_element(
+                ns=config.GXNS,
+                element=track,
+                strict=strict,
+            )
+            return
+        multitrack = element.find(f"{self.ns}MultiTrack")
+        if multitrack is not None:
+            self._geometry = gx.MultiTrack.class_from_element(
+                ns=config.GXNS,
+                element=multitrack,
+                strict=strict,
+            )
+            return
+        logger.warning("No geometries found")
+        logger.debug("Problem with element: %", config.etree.tostring(element))
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        if self._geometry is not None:
+            element.append(self._geometry.etree_element())
+        else:
+            logger.error("Object does not have a geometry")
+        return element
diff --git a/fastkml/kml.py b/fastkml/kml.py
index 4881406b..c8dae9da 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -25,1503 +25,24 @@
 
 """
 import logging
-import urllib.parse as urlparse
-from datetime import datetime
-from typing import Any
 from typing import Dict
 from typing import Iterable
 from typing import Iterator
-from typing import List
 from typing import Optional
 from typing import Union
 
-from fastkml import atom
 from fastkml import config
-from fastkml import gx
-from fastkml.base import _BaseObject
-from fastkml.data import ExtendedData
-from fastkml.data import Schema
-from fastkml.enums import GridOrigin
-from fastkml.enums import Shape
+from fastkml.containers import Document
+from fastkml.containers import Folder
 from fastkml.enums import Verbosity
-from fastkml.geometry import AnyGeometryType
-from fastkml.geometry import LinearRing
-from fastkml.geometry import LineString
-from fastkml.geometry import MultiGeometry
-from fastkml.geometry import Point
-from fastkml.geometry import Polygon
-from fastkml.links import Icon
-from fastkml.mixins import TimeMixin
-from fastkml.styles import Style
-from fastkml.styles import StyleMap
-from fastkml.styles import StyleUrl
-from fastkml.styles import _StyleSelector
-from fastkml.times import TimeSpan
-from fastkml.times import TimeStamp
+from fastkml.features import Placemark
+from fastkml.overlays import GroundOverlay
+from fastkml.overlays import PhotoOverlay
+from fastkml.overlays import _Overlay
 from fastkml.types import Element
-from fastkml.views import Camera
-from fastkml.views import LookAt
 
 logger = logging.getLogger(__name__)
 
-KmlGeometry = Union[
-    Point,
-    LineString,
-    LinearRing,
-    Polygon,
-    MultiGeometry,
-    gx.MultiTrack,
-    gx.Track,
-]
-
-
-class _Feature(TimeMixin, _BaseObject):
-    """
-    abstract element; do not create
-    subclasses are:
-        * Container (Document, Folder)
-        * Placemark
-        * Overlay
-    Not Implemented Yet:
-        * NetworkLink.
-    """
-
-    name: Optional[str]
-    # User-defined text displayed in the 3D viewer as the label for the
-    # object (for example, for a Placemark, Folder, or NetworkLink).
-
-    visibility: Optional[bool]
-    # Boolean value. Specifies whether the feature is drawn in the 3D
-    # viewer when it is initially loaded. In order for a feature to be
-    # visible, the <visibility> tag of all its ancestors must also be
-    # set to 1.
-
-    isopen: Optional[bool]
-    # Boolean value. Specifies whether a Document or Folder appears
-    # closed or open when first loaded into the Places panel.
-    # 0=collapsed (the default), 1=expanded.
-
-    _atom_author: Optional[atom.Author]
-    # KML 2.2 supports new elements for including data about the author
-    # and related website in your KML file. This information is displayed
-    # in geo search results, both in Earth browsers such as Google Earth,
-    # and in other applications such as Google Maps.
-
-    _atom_link: Optional[atom.Link]
-    # Specifies the URL of the website containing this KML or KMZ file.
-
-    _address: Optional[str]
-    # A string value representing an unstructured address written as a
-    # standard street, city, state address, and/or as a postal code.
-    # You can use the <address> tag to specify the location of a point
-    # instead of using latitude and longitude coordinates.
-
-    _phone_number: Optional[str]
-    # A string value representing a telephone number.
-    # This element is used by Google Maps Mobile only.
-
-    _snippet: Optional[Union[str, Dict[str, Any]]]
-    # _snippet is either a tuple of a string Snippet.text and an integer
-    # Snippet.maxLines or a string
-    #
-    # A short description of the feature. In Google Earth, this
-    # description is displayed in the Places panel under the name of the
-    # feature. If a Snippet is not supplied, the first two lines of
-    # the <description> are used. In Google Earth, if a Placemark
-    # contains both a description and a Snippet, the <Snippet> appears
-    # beneath the Placemark in the Places panel, and the <description>
-    # appears in the Placemark's description balloon. This tag does not
-    # support HTML markup. <Snippet> has a maxLines attribute, an integer
-    # that specifies the maximum number of lines to display.
-
-    description: Optional[str]
-    # User-supplied content that appears in the description balloon.
-
-    _style_url: Optional[Union[Style, StyleMap]]
-    # URL of a <Style> or <StyleMap> defined in a Document.
-    # If the style is in the same file, use a # reference.
-    # If the style is defined in an external file, use a full URL
-    # along with # referencing.
-
-    _styles: List[Union[Style, StyleMap]]
-    # One or more Styles and StyleMaps can be defined to customize the
-    # appearance of any element derived from Feature or of the Geometry
-    # in a Placemark.
-    # A style defined within a Feature is called an "inline style" and
-    # applies only to the Feature that contains it. A style defined as
-    # the child of a <Document> is called a "shared style." A shared
-    # style must have an id defined for it. This id is referenced by one
-    # or more Features within the <Document>. In cases where a style
-    # element is defined both in a shared style and in an inline style
-    # for a Feature—that is, a Folder, GroundOverlay, NetworkLink,
-    # Placemark, or ScreenOverlay—the value for the Feature's inline
-    # style takes precedence over the value for the shared style.
-
-    _timespan: Optional[TimeSpan]
-    # Associates this Feature with a period of time.
-    _timestamp: Optional[TimeStamp]
-    # Associates this Feature with a point in time.
-
-    _camera: Optional[Camera]
-
-    _look_at: Optional[LookAt]
-
-    # TODO Region = None
-    # Features and geometry associated with a Region are drawn only when
-    # the Region is active.
-
-    # TODO ExtendedData = None
-    # Allows you to add custom data to a KML file. This data can be
-    # (1) data that references an external XML schema,
-    # (2) untyped data/value pairs, or
-    # (3) typed data.
-    # A given KML Feature can contain a combination of these types of
-    # custom data.
-    #
-    # (2) is already implemented, see UntypedExtendedData
-    #
-    # <Metadata> (deprecated in KML 2.2; use <ExtendedData> instead)
-    extended_data: Optional[ExtendedData]
-
-    def __init__(
-        self,
-        ns: Optional[str] = None,
-        name_spaces: Optional[Dict[str, str]] = None,
-        id: Optional[str] = None,
-        target_id: Optional[str] = None,
-        name: Optional[str] = None,
-        description: Optional[str] = None,
-        snippet: Optional[Union[str, Dict[str, Any]]] = None,
-        atom_author: Optional[atom.Author] = None,
-        atom_link: Optional[atom.Link] = None,
-        visibility: Optional[bool] = None,
-        isopen: Optional[bool] = None,
-        styles: Optional[List[Style]] = None,
-        style_url: Optional[str] = None,
-        extended_data: None = None,
-        camera: Optional[Camera] = None,
-        look_at: Optional[LookAt] = None,
-        address: Optional[str] = None,
-        phone_number: Optional[str] = None,
-    ) -> None:
-        super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
-        self.name = name
-        self.description = description
-        self.style_url = style_url
-        self._styles = []
-        self._camera = camera
-        self._look_at = look_at
-        self.visibility = visibility
-        self.isopen = isopen
-        self.snippet = snippet
-        self._atom_author = atom_author
-        self._atom_link = atom_link
-        self.address = address
-        self.phone_number = phone_number
-        if styles:
-            for style in styles:
-                self.append_style(style)
-        self.extended_data = extended_data
-
-    @property
-    def style_url(self) -> Optional[str]:
-        """
-        Returns the url only, not a full StyleUrl object.
-        if you need the full StyleUrl object use _style_url.
-        """
-        if isinstance(self._style_url, StyleUrl):
-            return self._style_url.url
-        return None
-
-    @style_url.setter
-    def style_url(self, styleurl: Union[str, StyleUrl, None]) -> None:
-        """You may pass a StyleUrl Object, a string or None."""
-        if isinstance(styleurl, StyleUrl):
-            self._style_url = styleurl
-        elif isinstance(styleurl, str):
-            s = StyleUrl(self.ns, url=styleurl)
-            self._style_url = s
-        elif styleurl is None:
-            self._style_url = None
-        else:
-            raise ValueError
-
-    @property
-    def camera(self):
-        return self._camera
-
-    @camera.setter
-    def camera(self, camera) -> None:
-        if isinstance(camera, Camera):
-            self._camera = camera
-
-    @property
-    def look_at(self) -> datetime:
-        return self._look_at
-
-    @look_at.setter
-    def look_at(self, look_at) -> None:
-        if isinstance(look_at, LookAt):
-            self._look_at = look_at
-
-    @property
-    def link(self):
-        return self._atom_link.href
-
-    @link.setter
-    def link(self, url) -> None:
-        if isinstance(url, str):
-            self._atom_link = atom.Link(href=url)
-        elif isinstance(url, atom.Link):
-            self._atom_link = url
-        elif url is None:
-            self._atom_link = None
-        else:
-            raise TypeError
-
-    @property
-    def author(self) -> None:
-        if self._atom_author:
-            return self._atom_author.name
-        return None
-
-    @author.setter
-    def author(self, name) -> None:
-        if isinstance(name, atom.Author):
-            self._atom_author = name
-        elif isinstance(name, str):
-            if self._atom_author is None:
-                self._atom_author = atom.Author(ns=config.ATOMNS, name=name)
-            else:
-                self._atom_author.name = name
-        elif name is None:
-            self._atom_author = None
-        else:
-            raise TypeError
-
-    def append_style(self, style: Union[Style, StyleMap]) -> None:
-        """Append a style to the feature."""
-        if isinstance(style, _StyleSelector):
-            self._styles.append(style)
-        else:
-            raise TypeError
-
-    def styles(self) -> Iterator[Union[Style, StyleMap]]:
-        """Iterate over the styles of this feature."""
-        for style in self._styles:
-            if isinstance(style, _StyleSelector):
-                yield style
-            else:
-                raise TypeError
-
-    @property
-    def snippet(self) -> Optional[Dict[str, Any]]:
-        if not self._snippet:
-            return None
-        if isinstance(self._snippet, dict):
-            text = self._snippet.get("text")
-            if text:
-                assert isinstance(text, str)
-                max_lines = self._snippet.get("maxLines", None)
-                if max_lines is None:
-                    return {"text": text}
-                elif int(max_lines) > 0:
-                    # if maxLines <=0 ignore it
-                    return {"text": text, "maxLines": max_lines}
-                return None
-            return None
-        elif isinstance(self._snippet, str):
-            return self._snippet
-        else:
-            msg = "Snippet must be dict of {'text':t, 'maxLines':i} or string"
-            raise ValueError(
-                msg,
-            )
-
-    @snippet.setter
-    def snippet(self, snip=None) -> None:
-        self._snippet = {}
-        if isinstance(snip, dict):
-            self._snippet["text"] = snip.get("text")
-            max_lines = snip.get("maxLines")
-            if max_lines is not None:
-                self._snippet["maxLines"] = int(snip["maxLines"])
-        elif isinstance(snip, str):
-            self._snippet["text"] = snip
-        elif snip is None:
-            self._snippet = None
-        else:
-            msg = "Snippet must be dict of {'text':t, 'maxLines':i} or string"
-            raise ValueError(
-                msg,
-            )
-
-    @property
-    def address(self) -> None:
-        if self._address:
-            return self._address
-        return None
-
-    @address.setter
-    def address(self, address) -> None:
-        if isinstance(address, str):
-            self._address = address
-        elif address is None:
-            self._address = None
-        else:
-            raise ValueError
-
-    @property
-    def phone_number(self) -> None:
-        if self._phone_number:
-            return self._phone_number
-        return None
-
-    @phone_number.setter
-    def phone_number(self, phone_number) -> None:
-        if isinstance(phone_number, str):
-            self._phone_number = phone_number
-        elif phone_number is None:
-            self._phone_number = None
-        else:
-            raise ValueError
-
-    def etree_element(
-        self,
-        precision: Optional[int] = None,
-        verbosity: Verbosity = Verbosity.normal,
-    ) -> Element:
-        element = super().etree_element(precision=precision, verbosity=verbosity)
-        if self.name:
-            name = config.etree.SubElement(element, f"{self.ns}name")
-            name.text = self.name
-        if self.description:
-            description = config.etree.SubElement(element, f"{self.ns}description")
-            description.text = self.description
-        if (self.camera is not None) and (self.look_at is not None):
-            msg = "Either Camera or LookAt can be defined, not both"
-            raise ValueError(msg)
-        if self.camera is not None:
-            element.append(self._camera.etree_element())
-        elif self.look_at is not None:
-            element.append(self._look_at.etree_element())
-        if self.visibility is not None:
-            visibility = config.etree.SubElement(element, f"{self.ns}visibility")
-            visibility.text = str(self.visibility)
-        if self.isopen:
-            isopen = config.etree.SubElement(element, f"{self.ns}open")
-            isopen.text = str(self.isopen)
-        if self._style_url is not None:
-            element.append(self._style_url.etree_element())
-        for style in self.styles():
-            element.append(style.etree_element())
-        if self.snippet:
-            snippet = config.etree.SubElement(element, f"{self.ns}Snippet")
-            if isinstance(self.snippet, str):
-                snippet.text = self.snippet
-            else:
-                assert isinstance(self.snippet["text"], str)
-                snippet.text = self.snippet["text"]
-                if self.snippet.get("maxLines"):
-                    snippet.set("maxLines", str(self.snippet["maxLines"]))
-        if (self._timespan is not None) and (self._timestamp is not None):
-            msg = "Either Timestamp or Timespan can be defined, not both"
-            raise ValueError(msg)
-        elif self._timespan is not None:
-            element.append(self._timespan.etree_element())
-        elif self._timestamp is not None:
-            element.append(self._timestamp.etree_element())
-        if self._atom_link is not None:
-            element.append(self._atom_link.etree_element())
-        if self._atom_author is not None:
-            element.append(self._atom_author.etree_element())
-        if self.extended_data is not None:
-            element.append(self.extended_data.etree_element())
-        if self._address is not None:
-            address = config.etree.SubElement(element, f"{self.ns}address")
-            address.text = self._address
-        if self._phone_number is not None:
-            phone_number = config.etree.SubElement(element, f"{self.ns}phoneNumber")
-            phone_number.text = self._phone_number
-        return element
-
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element)
-        name = element.find(f"{self.ns}name")
-        if name is not None:
-            self.name = name.text
-        description = element.find(f"{self.ns}description")
-        if description is not None:
-            self.description = description.text
-        visibility = element.find(f"{self.ns}visibility")
-        if visibility is not None and visibility.text:
-            self.visibility = 1 if visibility.text in ["1", "true"] else 0
-        isopen = element.find(f"{self.ns}open")
-        if isopen is not None:
-            self.isopen = 1 if isopen.text in ["1", "true"] else 0
-        styles = element.findall(f"{self.ns}Style")
-        for style in styles:
-            s = Style.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=style,
-                strict=strict,
-            )
-            self.append_style(s)
-        styles = element.findall(f"{self.ns}StyleMap")
-        for style in styles:
-            s = StyleMap.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=style,
-                strict=strict,
-            )
-            self.append_style(s)
-        style_url = element.find(f"{self.ns}styleUrl")
-        if style_url is not None:
-            self._style_url = StyleUrl.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=style_url,
-                strict=strict,
-            )
-        snippet = element.find(f"{self.ns}Snippet")
-        if snippet is not None:
-            _snippet = {"text": snippet.text}
-            if snippet.get("maxLines"):
-                _snippet["maxLines"] = int(snippet.get("maxLines"))
-            self.snippet = _snippet
-        timespan = element.find(f"{self.ns}TimeSpan")
-        if timespan is not None:
-            self._timespan = TimeSpan.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=timespan,
-                strict=strict,
-            )
-        timestamp = element.find(f"{self.ns}TimeStamp")
-        if timestamp is not None:
-            self._timestamp = TimeStamp.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=timestamp,
-                strict=strict,
-            )
-        atom_link = element.find(f"{atom.NS}link")
-        if atom_link is not None:
-            self._atom_link = atom.Link.class_from_element(
-                ns=atom.NS,
-                name_spaces=self.name_spaces,
-                element=atom_link,
-                strict=strict,
-            )
-        atom_author = element.find(f"{atom.NS}author")
-        if atom_author is not None:
-            self._atom_author = atom.Author.class_from_element(
-                ns=atom.NS,
-                name_spaces=self.name_spaces,
-                element=atom_author,
-                strict=strict,
-            )
-        extended_data = element.find(f"{self.ns}ExtendedData")
-        if extended_data is not None:
-            self.extended_data = ExtendedData.class_from_element(
-                ns=self.ns,
-                element=extended_data,
-                strict=strict,
-            )
-        address = element.find(f"{self.ns}address")
-        if address is not None:
-            self.address = address.text
-        phone_number = element.find(f"{self.ns}phoneNumber")
-        if phone_number is not None:
-            self.phone_number = phone_number.text
-        camera = element.find(f"{self.ns}Camera")
-        if camera is not None:
-            s = Camera(self.ns)
-            s.from_element(camera)
-            self.camera = s
-
-
-class _Container(_Feature):
-    """
-    abstract element; do not create
-    A Container element holds one or more Features and allows the
-    creation of nested hierarchies.
-    subclasses are:
-    Document,
-    Folder.
-    """
-
-    _features = []
-
-    def __init__(
-        self,
-        ns: Optional[str] = None,
-        name_spaces: Optional[Dict[str, str]] = None,
-        id: Optional[str] = None,
-        target_id: Optional[str] = None,
-        name: Optional[str] = None,
-        description: Optional[str] = None,
-        styles: Optional[List[Style]] = None,
-        style_url: Optional[str] = None,
-        features: None = None,
-    ) -> None:
-        super().__init__(
-            ns=ns,
-            name_spaces=name_spaces,
-            id=id,
-            target_id=target_id,
-            name=name,
-            description=description,
-            styles=styles,
-            style_url=style_url,
-        )
-        self._features = features or []
-
-    def features(self) -> Iterator[_Feature]:
-        """Iterate over features."""
-        for feature in self._features:
-            if isinstance(feature, (Folder, Placemark, Document, _Overlay)):
-                yield feature
-            else:
-                msg = (
-                    "Features must be instances of "
-                    "(Folder, Placemark, Document, Overlay)"
-                )
-                raise TypeError(
-                    msg,
-                )
-
-    def etree_element(
-        self,
-        precision: Optional[int] = None,
-        verbosity: Verbosity = Verbosity.normal,
-    ) -> Element:
-        element = super().etree_element(precision=precision, verbosity=verbosity)
-        for feature in self.features():
-            element.append(feature.etree_element())
-        return element
-
-    def append(self, kmlobj: _Feature) -> None:
-        """Append a feature."""
-        if id(kmlobj) == id(self):
-            msg = "Cannot append self"
-            raise ValueError(msg)
-        if isinstance(kmlobj, (Folder, Placemark, Document, _Overlay)):
-            self._features.append(kmlobj)
-        else:
-            msg = "Features must be instances of (Folder, Placemark, Document, Overlay)"
-            raise TypeError(
-                msg,
-            )
-
-
-class _Overlay(_Feature):
-    """
-    abstract element; do not create.
-
-    Base type for image overlays drawn on the planet surface or on the screen
-
-    A Container element holds one or more Features and allows the creation of
-    nested hierarchies.
-    """
-
-    _color: Optional[str]
-    # Color values expressed in hexadecimal notation, including opacity (alpha)
-    # values. The order of expression is alphaOverlay, blue, green, red
-    # (AABBGGRR). The range of values for any one color is 0 to 255 (00 to ff).
-    # For opacity, 00 is fully transparent and ff is fully opaque.
-
-    _draw_order: Optional[str]
-    # Defines the stacking order for the images in overlapping overlays.
-    # Overlays with higher <drawOrder> values are drawn on top of those with
-    # lower <drawOrder> values.
-
-    _icon: Optional[Icon]
-    # Defines the image associated with the overlay. Contains an <href> html
-    # tag which defines the location of the image to be used as the overlay.
-    # The location can be either on a local file system or on a webserver. If
-    # this element is omitted or contains no <href>, a rectangle is drawn using
-    # the color and size defined by the ground or screen overlay.
-
-    def __init__(
-        self,
-        ns: Optional[str] = None,
-        name_spaces: Optional[Dict[str, str]] = None,
-        id: Optional[str] = None,
-        target_id: Optional[str] = None,
-        name: Optional[str] = None,
-        description: Optional[str] = None,
-        color: Optional[str] = None,
-        styles: None = None,
-        style_url: Optional[str] = None,
-        draw_order: Optional[str] = None,
-        icon: Optional[Icon] = None,
-    ) -> None:
-        super().__init__(
-            ns=ns,
-            name_spaces=name_spaces,
-            id=id,
-            target_id=target_id,
-            name=name,
-            description=description,
-            styles=styles,
-            style_url=style_url,
-        )
-        self._icon = icon
-        self._color = color
-        self._draw_order = draw_order
-
-    @property
-    def color(self):
-        return self._color
-
-    @color.setter
-    def color(self, color) -> None:
-        if isinstance(color, str):
-            self._color = color
-        elif color is None:
-            self._color = None
-        else:
-            raise ValueError
-
-    @property
-    def draw_order(self) -> Optional[str]:
-        return self._draw_order
-
-    @draw_order.setter
-    def draw_order(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._draw_order = str(value)
-        elif value is None:
-            self._draw_order = None
-        else:
-            raise ValueError
-
-    @property
-    def icon(self) -> Optional[Icon]:
-        return self._icon
-
-    @icon.setter
-    def icon(self, value) -> None:
-        if isinstance(value, Icon):
-            self._icon = value
-        elif value is None:
-            self._icon = None
-        else:
-            raise ValueError
-
-    def etree_element(
-        self,
-        precision: Optional[int] = None,
-        verbosity: Verbosity = Verbosity.normal,
-    ) -> Element:
-        element = super().etree_element(precision=precision, verbosity=verbosity)
-        if self._color:
-            color = config.etree.SubElement(element, f"{self.ns}color")
-            color.text = self._color
-        if self._draw_order:
-            draw_order = config.etree.SubElement(element, f"{self.ns}drawOrder")
-            draw_order.text = self._draw_order
-        if self._icon:
-            element.append(self._icon.etree_element())
-        return element
-
-    def from_element(self, element: Element) -> None:
-        super().from_element(element)
-        color = element.find(f"{self.ns}color")
-        if color is not None:
-            self.color = color.text
-        draw_order = element.find(f"{self.ns}drawOrder")
-        if draw_order is not None:
-            self.draw_order = draw_order.text
-        icon = element.find(f"{self.ns}Icon")
-        if icon is not None:
-            self._icon = Icon.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=icon,
-                strict=False,
-            )
-
-
-class PhotoOverlay(_Overlay):
-    """
-    The <PhotoOverlay> element allows you to geographically locate a photograph
-    on the Earth and to specify viewing parameters for this PhotoOverlay.
-    The PhotoOverlay can be a simple 2D rectangle, a partial or full cylinder,
-    or a sphere (for spherical panoramas). The overlay is placed at the
-    specified location and oriented toward the viewpoint.
-
-    Because <PhotoOverlay> is derived from <Feature>, it can contain one of
-    the two elements derived from <AbstractView>—either <Camera> or <LookAt>.
-    The Camera (or LookAt) specifies a viewpoint and a viewing direction (also
-    referred to as a view vector). The PhotoOverlay is positioned in relation
-    to the viewpoint. Specifically, the plane of a 2D rectangular image is
-    orthogonal (at right angles to) the view vector. The normal of this
-    plane—that is, its front, which is the part
-    with the photo—is oriented toward the viewpoint.
-
-    The URL for the PhotoOverlay image is specified in the <Icon> tag,
-    which is inherited from <Overlay>. The <Icon> tag must contain an <href>
-    element that specifies the image file to use for the PhotoOverlay.
-    In the case of a very large image, the <href> is a special URL that
-    indexes into a pyramid of images of varying resolutions (see ImagePyramid).
-    """
-
-    __name__ = "PhotoOverlay"
-
-    _rotation = None
-    # Adjusts how the photo is placed inside the field of view. This element is
-    # useful if your photo has been rotated and deviates slightly from a desired
-    # horizontal view.
-
-    # - ViewVolume -
-    # Defines how much of the current scene is visible. Specifying the field of
-    # view is analogous to specifying the lens opening in a physical camera.
-    # A small field of view, like a telephoto lens, focuses on a small part of
-    # the scene. A large field of view, like a wide-angle lens, focuses on a
-    # large part of the scene.
-
-    _left_fow = None
-    # Angle, in degrees, between the camera's viewing direction and the left side
-    # of the view volume.
-
-    _right_fov = None
-    # Angle, in degrees, between the camera's viewing direction and the right side
-    # of the view volume.
-
-    _bottom_fov = None
-    # Angle, in degrees, between the camera's viewing direction and the bottom side
-    # of the view volume.
-
-    _top_fov = None
-    # Angle, in degrees, between the camera's viewing direction and the top side
-    # of the view volume.
-
-    _near = None
-    # Measurement in meters along the viewing direction from the camera viewpoint
-    # to the PhotoOverlay shape.
-
-    _tile_size = "256"
-    # Size of the tiles, in pixels. Tiles must be square, and <tileSize> must
-    # be a power of 2. A tile size of 256 (the default) or 512 is recommended.
-    # The original image is divided into tiles of this size, at varying resolutions.
-
-    _max_width = None
-    # Width in pixels of the original image.
-
-    _max_height = None
-    # Height in pixels of the original image.
-
-    _grid_origin: Optional[GridOrigin]
-    # Specifies where to begin numbering the tiles in each layer of the pyramid.
-    # A value of lowerLeft specifies that row 1, column 1 of each layer is in
-    # the bottom left corner of the grid.
-
-    _point: Optional[Point]
-    # The <Point> element acts as a <Point> inside a <Placemark> element.
-    # It draws an icon to mark the position of the PhotoOverlay.
-    # The icon drawn is specified by the <styleUrl> and <StyleSelector> fields,
-    # just as it is for <Placemark>.
-
-    _shape: Optional[Shape]
-    # The PhotoOverlay is projected onto the <shape>.
-    # The <shape> can be one of the following:
-    #   rectangle (default) -
-    #       for an ordinary photo
-    #   cylinder -
-    #       for panoramas, which can be either partial or full cylinders
-    #   sphere -
-    #       for spherical panoramas
-
-    @property
-    def rotation(self) -> Optional[str]:
-        return self._rotation
-
-    @rotation.setter
-    def rotation(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._rotation = str(value)
-        elif value is None:
-            self._rotation = None
-        else:
-            raise ValueError
-
-    @property
-    def left_fov(self) -> Optional[str]:
-        return self._left_fow
-
-    @left_fov.setter
-    def left_fov(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._left_fow = str(value)
-        elif value is None:
-            self._left_fow = None
-        else:
-            raise ValueError
-
-    @property
-    def right_fov(self) -> Optional[str]:
-        return self._right_fov
-
-    @right_fov.setter
-    def right_fov(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._right_fov = str(value)
-        elif value is None:
-            self._right_fov = None
-        else:
-            raise ValueError
-
-    @property
-    def bottom_fov(self) -> Optional[str]:
-        return self._bottom_fov
-
-    @bottom_fov.setter
-    def bottom_fov(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._bottom_fov = str(value)
-        elif value is None:
-            self._bottom_fov = None
-        else:
-            raise ValueError
-
-    @property
-    def top_fov(self) -> Optional[str]:
-        return self._top_fov
-
-    @top_fov.setter
-    def top_fov(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._top_fov = str(value)
-        elif value is None:
-            self._top_fov = None
-        else:
-            raise ValueError
-
-    @property
-    def near(self) -> Optional[str]:
-        return self._near
-
-    @near.setter
-    def near(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._near = str(value)
-        elif value is None:
-            self._near = None
-        else:
-            raise ValueError
-
-    @property
-    def tile_size(self) -> Optional[str]:
-        return self._tile_size
-
-    @tile_size.setter
-    def tile_size(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._tile_size = str(value)
-        elif value is None:
-            self._tile_size = None
-        else:
-            raise ValueError
-
-    @property
-    def max_width(self) -> Optional[str]:
-        return self._max_width
-
-    @max_width.setter
-    def max_width(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._max_width = str(value)
-        elif value is None:
-            self._max_width = None
-        else:
-            raise ValueError
-
-    @property
-    def max_height(self) -> Optional[str]:
-        return self._max_height
-
-    @max_height.setter
-    def max_height(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._max_height = str(value)
-        elif value is None:
-            self._max_height = None
-        else:
-            raise ValueError
-
-    @property
-    def grid_origin(self) -> Optional[GridOrigin]:
-        return self._grid_origin
-
-    @grid_origin.setter
-    def grid_origin(self, value: Optional[GridOrigin]) -> None:
-        self._grid_origin = value
-
-    @property
-    def point(self) -> str:
-        return self._point
-
-    @point.setter
-    def point(self, value) -> None:
-        if isinstance(value, (str, tuple)):
-            self._point = str(value)
-        else:
-            raise ValueError
-
-    @property
-    def shape(self) -> Optional[Shape]:
-        return self._shape
-
-    @shape.setter
-    def shape(self, value: Optional[Shape]) -> None:
-        self._shape = value
-
-    def view_volume(self, left_fov, right_fov, bottom_fov, top_fov, near) -> None:
-        self.left_fov = left_fov
-        self.right_fov = right_fov
-        self.bottom_fov = bottom_fov
-        self.top_fov = top_fov
-        self.near = near
-
-    def image_pyramid(self, tile_size, max_width, max_height, grid_origin) -> None:
-        self.tile_size = tile_size
-        self.max_width = max_width
-        self.max_height = max_height
-        self.grid_origin = grid_origin
-
-    def etree_element(
-        self,
-        precision: Optional[int] = None,
-        verbosity: Verbosity = Verbosity.normal,
-    ) -> Element:
-        element = super().etree_element(precision=precision, verbosity=verbosity)
-        if self._rotation:
-            rotation = config.etree.SubElement(element, f"{self.ns}rotation")
-            rotation.text = self._rotation
-        if all(
-            [
-                self._left_fow,
-                self._right_fov,
-                self._bottom_fov,
-                self._top_fov,
-                self._near,
-            ],
-        ):
-            view_volume = config.etree.SubElement(element, f"{self.ns}ViewVolume")
-            left_fov = config.etree.SubElement(view_volume, f"{self.ns}leftFov")
-            left_fov.text = self._left_fow
-            right_fov = config.etree.SubElement(view_volume, f"{self.ns}rightFov")
-            right_fov.text = self._right_fov
-            bottom_fov = config.etree.SubElement(view_volume, f"{self.ns}bottomFov")
-            bottom_fov.text = self._bottom_fov
-            top_fov = config.etree.SubElement(view_volume, f"{self.ns}topFov")
-            top_fov.text = self._top_fov
-            near = config.etree.SubElement(view_volume, f"{self.ns}near")
-            near.text = self._near
-        if all([self._tile_size, self._max_width, self._max_height, self._grid_origin]):
-            image_pyramid = config.etree.SubElement(element, f"{self.ns}ImagePyramid")
-            tile_size = config.etree.SubElement(image_pyramid, f"{self.ns}tileSize")
-            tile_size.text = self._tile_size
-            max_width = config.etree.SubElement(image_pyramid, f"{self.ns}maxWidth")
-            max_width.text = self._max_width
-            max_height = config.etree.SubElement(image_pyramid, f"{self.ns}maxHeight")
-            max_height.text = self._max_height
-            grid_origin = config.etree.SubElement(image_pyramid, f"{self.ns}gridOrigin")
-            grid_origin.text = self._grid_origin
-        return element
-
-    def from_element(self, element) -> None:
-        super().from_element(element)
-        rotation = element.find(f"{self.ns}rotation")
-        if rotation is not None:
-            self.rotation = rotation.text
-        view_volume = element.find(f"{self.ns}ViewVolume")
-        if view_volume is not None:
-            left_fov = view_volume.find(f"{self.ns}leftFov")
-            if left_fov is not None:
-                self.left_fov = left_fov.text
-            right_fov = view_volume.find(f"{self.ns}rightFov")
-            if right_fov is not None:
-                self.right_fov = right_fov.text
-            bottom_fov = view_volume.find(f"{self.ns}bottomFov")
-            if bottom_fov is not None:
-                self.bottom_fov = bottom_fov.text
-            top_fov = view_volume.find(f"{self.ns}topFov")
-            if top_fov is not None:
-                self.top_fov = top_fov.text
-            near = view_volume.find(f"{self.ns}near")
-            if near is not None:
-                self.near = near.text
-        image_pyramid = element.find(f"{self.ns}ImagePyramid")
-        if image_pyramid is not None:
-            tile_size = image_pyramid.find(f"{self.ns}tileSize")
-            if tile_size is not None:
-                self.tile_size = tile_size.text
-            max_width = image_pyramid.find(f"{self.ns}maxWidth")
-            if max_width is not None:
-                self.max_width = max_width.text
-            max_height = image_pyramid.find(f"{self.ns}maxHeight")
-            if max_height is not None:
-                self.max_height = max_height.text
-            grid_origin = image_pyramid.find(f"{self.ns}gridOrigin")
-            if grid_origin is not None:
-                self.grid_origin = grid_origin.text
-        point = element.find(f"{self.ns}Point")
-        if point is not None:
-            self.point = point.text
-        shape = element.find(f"{self.ns}shape")
-        if shape is not None:
-            self.shape = shape.text
-
-
-class GroundOverlay(_Overlay):
-    """
-    This element draws an image overlay draped onto the terrain. The <href>
-    child of <Icon> specifies the image to be used as the overlay. This file
-    can be either on a local file system or on a web server. If this element
-    is omitted or contains no <href>, a rectangle is drawn using the color and
-    LatLonBox bounds defined by the ground overlay.
-    """
-
-    __name__ = "GroundOverlay"
-
-    _altitude = None
-    # Specifies the distance above the earth's surface, in meters, and is
-    # interpreted according to the altitude mode.
-
-    _altitude_mode = "clampToGround"
-    # Specifies how the <altitude> is interpreted. Possible values are:
-    #   clampToGround -
-    #       (default) Indicates to ignore the altitude specification and drape
-    #       the overlay over the terrain.
-    #   absolute -
-    #       Sets the altitude of the overlay relative to sea level, regardless
-    #       of the actual elevation of the terrain beneath the element. For
-    #       example, if you set the altitude of an overlay to 10 meters with an
-    #       absolute altitude mode, the overlay will appear to be at ground
-    #       level if the terrain beneath is also 10 meters above sea level. If
-    #       the terrain is 3 meters above sea level, the overlay will appear
-    #       elevated above the terrain by 7 meters.
-
-    # - LatLonBox -
-    # TODO: Convert this to it's own class?
-    # Specifies where the top, bottom, right, and left sides of a bounding box
-    # for the ground overlay are aligned. Also, optionally the rotation of the
-    # overlay.
-
-    _north = None
-    # Specifies the latitude of the north edge of the bounding box, in decimal
-    # degrees from 0 to ±90.
-
-    _south = None
-    # Specifies the latitude of the south edge of the bounding box, in decimal
-    # degrees from 0 to ±90.
-
-    _east = None
-    # Specifies the longitude of the east edge of the bounding box, in decimal
-    # degrees from 0 to ±180. (For overlays that overlap the meridian of 180°
-    # longitude, values can extend beyond that range.)
-
-    _west = None
-    # Specifies the longitude of the west edge of the bounding box, in decimal
-    # degrees from 0 to ±180. (For overlays that overlap the meridian of 180°
-    # longitude, values can extend beyond that range.)
-
-    _rotation = None
-    # Specifies a rotation of the overlay about its center, in degrees. Values
-    # can be ±180. The default is 0 (north). Rotations are specified in a
-    # counterclockwise direction.
-
-    # TODO: <gx:LatLonQuad>
-    # Used for nonrectangular quadrilateral ground overlays.
-    _lat_lon_quad = None
-
-    @property
-    def altitude(self) -> Optional[str]:
-        return self._altitude
-
-    @altitude.setter
-    def altitude(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._altitude = str(value)
-        elif value is None:
-            self._altitude = None
-        else:
-            raise ValueError
-
-    @property
-    def altitude_mode(self) -> str:
-        return self._altitude_mode
-
-    @altitude_mode.setter
-    def altitude_mode(self, mode) -> None:
-        if mode in ("clampToGround", "absolute"):
-            self._altitude_mode = str(mode)
-        else:
-            self._altitude_mode = "clampToGround"
-
-    @property
-    def north(self) -> Optional[str]:
-        return self._north
-
-    @north.setter
-    def north(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._north = str(value)
-        elif value is None:
-            self._north = None
-        else:
-            raise ValueError
-
-    @property
-    def south(self) -> Optional[str]:
-        return self._south
-
-    @south.setter
-    def south(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._south = str(value)
-        elif value is None:
-            self._south = None
-        else:
-            raise ValueError
-
-    @property
-    def east(self) -> Optional[str]:
-        return self._east
-
-    @east.setter
-    def east(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._east = str(value)
-        elif value is None:
-            self._east = None
-        else:
-            raise ValueError
-
-    @property
-    def west(self) -> Optional[str]:
-        return self._west
-
-    @west.setter
-    def west(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._west = str(value)
-        elif value is None:
-            self._west = None
-        else:
-            raise ValueError
-
-    @property
-    def rotation(self) -> Optional[str]:
-        return self._rotation
-
-    @rotation.setter
-    def rotation(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._rotation = str(value)
-        elif value is None:
-            self._rotation = None
-        else:
-            raise ValueError
-
-    def lat_lon_box(
-        self,
-        north: int,
-        south: int,
-        east: int,
-        west: int,
-        rotation: int = 0,
-    ) -> None:
-        if -90 <= float(north) <= 90:
-            self.north = north
-        else:
-            raise ValueError
-        if -90 <= float(south) <= 90:
-            self.south = south
-        else:
-            raise ValueError
-        if -180 <= float(east) <= 180:
-            self.east = east
-        else:
-            raise ValueError
-        if -180 <= float(west) <= 180:
-            self.west = west
-        else:
-            raise ValueError
-        if -180 <= float(rotation) <= 180:
-            self.rotation = rotation
-        else:
-            raise ValueError
-
-    def etree_element(
-        self,
-        precision: Optional[int] = None,
-        verbosity: Verbosity = Verbosity.normal,
-    ) -> Element:
-        element = super().etree_element(precision=precision, verbosity=verbosity)
-        if self._altitude:
-            altitude = config.etree.SubElement(element, f"{self.ns}altitude")
-            altitude.text = self._altitude
-            if self._altitude_mode:
-                altitude_mode = config.etree.SubElement(
-                    element,
-                    f"{self.ns}altitudeMode",
-                )
-                altitude_mode.text = self._altitude_mode
-        if all([self._north, self._south, self._east, self._west]):
-            lat_lon_box = config.etree.SubElement(element, f"{self.ns}LatLonBox")
-            north = config.etree.SubElement(lat_lon_box, f"{self.ns}north")
-            north.text = self._north
-            south = config.etree.SubElement(lat_lon_box, f"{self.ns}south")
-            south.text = self._south
-            east = config.etree.SubElement(lat_lon_box, f"{self.ns}east")
-            east.text = self._east
-            west = config.etree.SubElement(lat_lon_box, f"{self.ns}west")
-            west.text = self._west
-            if self._rotation:
-                rotation = config.etree.SubElement(lat_lon_box, f"{self.ns}rotation")
-                rotation.text = self._rotation
-        return element
-
-    def from_element(self, element: Element) -> None:
-        super().from_element(element)
-        altitude = element.find(f"{self.ns}altitude")
-        if altitude is not None:
-            self.altitude = altitude.text
-        altitude_mode = element.find(f"{self.ns}altitudeMode")
-        if altitude_mode is not None:
-            self.altitude_mode = altitude_mode.text
-        lat_lon_box = element.find(f"{self.ns}LatLonBox")
-        if lat_lon_box is not None:
-            north = lat_lon_box.find(f"{self.ns}north")
-            if north is not None:
-                self.north = north.text
-            south = lat_lon_box.find(f"{self.ns}south")
-            if south is not None:
-                self.south = south.text
-            east = lat_lon_box.find(f"{self.ns}east")
-            if east is not None:
-                self.east = east.text
-            west = lat_lon_box.find(f"{self.ns}west")
-            if west is not None:
-                self.west = west.text
-            rotation = lat_lon_box.find(f"{self.ns}rotation")
-            if rotation is not None:
-                self.rotation = rotation.text
-
-
-class Document(_Container):
-    """
-    A Document is a container for features and styles. This element is
-    required if your KML file uses shared styles or schemata for typed
-    extended data.
-    """
-
-    __name__ = "Document"
-    _schemata = None
-
-    def schemata(self) -> Iterator["Schema"]:
-        if self._schemata:
-            yield from self._schemata
-
-    def append_schema(self, schema: "Schema") -> None:
-        if self._schemata is None:
-            self._schemata = []
-        if isinstance(schema, Schema):
-            self._schemata.append(schema)
-        else:
-            s = Schema(schema)
-            self._schemata.append(s)
-
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element)
-        documents = element.findall(f"{self.ns}Document")
-        for document in documents:
-            feature = Document(self.ns)
-            feature.from_element(document)
-            self.append(feature)
-        folders = element.findall(f"{self.ns}Folder")
-        for folder in folders:
-            feature = Folder(self.ns)
-            feature.from_element(folder)
-            self.append(feature)
-        placemarks = element.findall(f"{self.ns}Placemark")
-        for placemark in placemarks:
-            feature = Placemark(self.ns)
-            feature.from_element(placemark)
-            self.append(feature)
-        schemata = element.findall(f"{self.ns}Schema")
-        for schema in schemata:
-            s = Schema.class_from_element(ns=self.ns, element=schema, strict=strict)
-            self.append_schema(s)
-
-    def etree_element(
-        self,
-        precision: Optional[int] = None,
-        verbosity: Verbosity = Verbosity.normal,
-    ) -> Element:
-        element = super().etree_element(precision=precision, verbosity=verbosity)
-        if self._schemata is not None:
-            for schema in self._schemata:
-                element.append(schema.etree_element())
-        return element
-
-    def get_style_by_url(self, style_url: str) -> Optional[Union[Style, StyleMap]]:
-        id = urlparse.urlparse(style_url).fragment
-        for style in self.styles():
-            if style.id == id:
-                return style
-        return None
-
-
-class Folder(_Container):
-    """
-    A Folder is used to arrange other Features hierarchically
-    (Folders, Placemarks, #NetworkLinks, or #Overlays).
-    """
-
-    __name__ = "Folder"
-
-    def from_element(self, element: Element) -> None:
-        super().from_element(element)
-        folders = element.findall(f"{self.ns}Folder")
-        for folder in folders:
-            feature = Folder(self.ns)
-            feature.from_element(folder)
-            self.append(feature)
-        placemarks = element.findall(f"{self.ns}Placemark")
-        for placemark in placemarks:
-            feature = Placemark(self.ns)
-            feature.from_element(placemark)
-            self.append(feature)
-        documents = element.findall(f"{self.ns}Document")
-        for document in documents:
-            feature = Document(self.ns)
-            feature.from_element(document)
-            self.append(feature)
-
-
-class Placemark(_Feature):
-    """
-    A Placemark is a Feature with associated Geometry.
-    In Google Earth, a Placemark appears as a list item in the Places
-    panel. A Placemark with a Point has an icon associated with it that
-    marks a point on the Earth in the 3D viewer.
-    """
-
-    __name__ = "Placemark"
-    _geometry = None
-
-    def __init__(
-        self,
-        ns: Optional[str] = None,
-        name_spaces: Optional[Dict[str, str]] = None,
-        id: Optional[str] = None,
-        target_id: Optional[str] = None,
-        name: Optional[str] = None,
-        description: Optional[str] = None,
-        styles: Optional[List[Style]] = None,
-        style_url: Optional[str] = None,
-        extended_data: None = None,
-        geometry: Optional[KmlGeometry] = None,
-    ) -> None:
-        super().__init__(
-            ns=ns,
-            name_spaces=name_spaces,
-            id=id,
-            target_id=target_id,
-            name=name,
-            description=description,
-            styles=styles,
-            style_url=style_url,
-            extended_data=extended_data,
-        )
-        self._geometry = geometry
-
-    @property
-    def geometry(self) -> Optional[AnyGeometryType]:
-        if self._geometry is not None:
-            return self._geometry.geometry
-        return None
-
-    def from_element(self, element: Element, strict=False) -> None:
-        super().from_element(element)
-        point = element.find(f"{self.ns}Point")
-        if point is not None:
-            self._geometry = Point.class_from_element(
-                ns=self.ns,
-                element=point,
-                strict=strict,
-            )
-            return
-        line = element.find(f"{self.ns}LineString")
-        if line is not None:
-            self._geometry = LineString.class_from_element(
-                ns=self.ns,
-                element=line,
-                strict=strict,
-            )
-            return
-        polygon = element.find(f"{self.ns}Polygon")
-        if polygon is not None:
-            self._geometry = Polygon.class_from_element(
-                ns=self.ns,
-                element=polygon,
-                strict=strict,
-            )
-            return
-        linearring = element.find(f"{self.ns}LinearRing")
-        if linearring is not None:
-            self._geometry = LinearRing.class_from_element(
-                ns=self.ns,
-                element=linearring,
-                strict=strict,
-            )
-            return
-        multigeometry = element.find(f"{self.ns}MultiGeometry")
-        if multigeometry is not None:
-            self._geometry = MultiGeometry.class_from_element(
-                ns=self.ns,
-                element=multigeometry,
-                strict=strict,
-            )
-            return
-        track = element.find(f"{self.ns}Track")
-        if track is not None:
-            self._geometry = gx.Track.class_from_element(
-                ns=config.GXNS,
-                element=track,
-                strict=strict,
-            )
-            return
-        multitrack = element.find(f"{self.ns}MultiTrack")
-        if multitrack is not None:
-            self._geometry = gx.MultiTrack.class_from_element(
-                ns=config.GXNS,
-                element=multitrack,
-                strict=strict,
-            )
-            return
-        logger.warning("No geometries found")
-        logger.debug("Problem with element: %", config.etree.tostring(element))
-
-    def etree_element(
-        self,
-        precision: Optional[int] = None,
-        verbosity: Verbosity = Verbosity.normal,
-    ) -> Element:
-        element = super().etree_element(precision=precision, verbosity=verbosity)
-        if self._geometry is not None:
-            element.append(self._geometry.etree_element())
-        else:
-            logger.error("Object does not have a geometry")
-        return element
-
 
 class KML:
     """represents a KML File."""
diff --git a/fastkml/overlays.py b/fastkml/overlays.py
new file mode 100644
index 00000000..49946c75
--- /dev/null
+++ b/fastkml/overlays.py
@@ -0,0 +1,732 @@
+"""
+Overlays.
+"""
+
+import logging
+from typing import Dict
+from typing import Optional
+from typing import Union
+
+from fastkml import config
+from fastkml import gx
+from fastkml.enums import GridOrigin
+from fastkml.enums import Shape
+from fastkml.enums import Verbosity
+from fastkml.features import _Feature
+from fastkml.geometry import LinearRing
+from fastkml.geometry import LineString
+from fastkml.geometry import MultiGeometry
+from fastkml.geometry import Point
+from fastkml.geometry import Polygon
+from fastkml.links import Icon
+from fastkml.types import Element
+
+logger = logging.getLogger(__name__)
+
+KmlGeometry = Union[
+    Point,
+    LineString,
+    LinearRing,
+    Polygon,
+    MultiGeometry,
+    gx.MultiTrack,
+    gx.Track,
+]
+
+
+class _Overlay(_Feature):
+    """
+    abstract element; do not create.
+
+    Base type for image overlays drawn on the planet surface or on the screen
+
+    A Container element holds one or more Features and allows the creation of
+    nested hierarchies.
+    """
+
+    _color: Optional[str]
+    # Color values expressed in hexadecimal notation, including opacity (alpha)
+    # values. The order of expression is alphaOverlay, blue, green, red
+    # (AABBGGRR). The range of values for any one color is 0 to 255 (00 to ff).
+    # For opacity, 00 is fully transparent and ff is fully opaque.
+
+    _draw_order: Optional[str]
+    # Defines the stacking order for the images in overlapping overlays.
+    # Overlays with higher <drawOrder> values are drawn on top of those with
+    # lower <drawOrder> values.
+
+    _icon: Optional[Icon]
+    # Defines the image associated with the overlay. Contains an <href> html
+    # tag which defines the location of the image to be used as the overlay.
+    # The location can be either on a local file system or on a webserver. If
+    # this element is omitted or contains no <href>, a rectangle is drawn using
+    # the color and size defined by the ground or screen overlay.
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        name: Optional[str] = None,
+        description: Optional[str] = None,
+        color: Optional[str] = None,
+        styles: None = None,
+        style_url: Optional[str] = None,
+        draw_order: Optional[str] = None,
+        icon: Optional[Icon] = None,
+    ) -> None:
+        super().__init__(
+            ns=ns,
+            name_spaces=name_spaces,
+            id=id,
+            target_id=target_id,
+            name=name,
+            description=description,
+            styles=styles,
+            style_url=style_url,
+        )
+        self._icon = icon
+        self._color = color
+        self._draw_order = draw_order
+
+    @property
+    def color(self):
+        return self._color
+
+    @color.setter
+    def color(self, color) -> None:
+        if isinstance(color, str):
+            self._color = color
+        elif color is None:
+            self._color = None
+        else:
+            raise ValueError
+
+    @property
+    def draw_order(self) -> Optional[str]:
+        return self._draw_order
+
+    @draw_order.setter
+    def draw_order(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._draw_order = str(value)
+        elif value is None:
+            self._draw_order = None
+        else:
+            raise ValueError
+
+    @property
+    def icon(self) -> Optional[Icon]:
+        return self._icon
+
+    @icon.setter
+    def icon(self, value) -> None:
+        if isinstance(value, Icon):
+            self._icon = value
+        elif value is None:
+            self._icon = None
+        else:
+            raise ValueError
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        if self._color:
+            color = config.etree.SubElement(element, f"{self.ns}color")
+            color.text = self._color
+        if self._draw_order:
+            draw_order = config.etree.SubElement(element, f"{self.ns}drawOrder")
+            draw_order.text = self._draw_order
+        if self._icon:
+            element.append(self._icon.etree_element())
+        return element
+
+    def from_element(self, element: Element) -> None:
+        super().from_element(element)
+        color = element.find(f"{self.ns}color")
+        if color is not None:
+            self.color = color.text
+        draw_order = element.find(f"{self.ns}drawOrder")
+        if draw_order is not None:
+            self.draw_order = draw_order.text
+        icon = element.find(f"{self.ns}Icon")
+        if icon is not None:
+            self._icon = Icon.class_from_element(
+                ns=self.ns,
+                name_spaces=self.name_spaces,
+                element=icon,
+                strict=False,
+            )
+
+
+class PhotoOverlay(_Overlay):
+    """
+    The <PhotoOverlay> element allows you to geographically locate a photograph
+    on the Earth and to specify viewing parameters for this PhotoOverlay.
+    The PhotoOverlay can be a simple 2D rectangle, a partial or full cylinder,
+    or a sphere (for spherical panoramas). The overlay is placed at the
+    specified location and oriented toward the viewpoint.
+
+    Because <PhotoOverlay> is derived from <Feature>, it can contain one of
+    the two elements derived from <AbstractView>—either <Camera> or <LookAt>.
+    The Camera (or LookAt) specifies a viewpoint and a viewing direction (also
+    referred to as a view vector). The PhotoOverlay is positioned in relation
+    to the viewpoint. Specifically, the plane of a 2D rectangular image is
+    orthogonal (at right angles to) the view vector. The normal of this
+    plane—that is, its front, which is the part
+    with the photo—is oriented toward the viewpoint.
+
+    The URL for the PhotoOverlay image is specified in the <Icon> tag,
+    which is inherited from <Overlay>. The <Icon> tag must contain an <href>
+    element that specifies the image file to use for the PhotoOverlay.
+    In the case of a very large image, the <href> is a special URL that
+    indexes into a pyramid of images of varying resolutions (see ImagePyramid).
+    """
+
+    __name__ = "PhotoOverlay"
+
+    _rotation = None
+    # Adjusts how the photo is placed inside the field of view. This element is
+    # useful if your photo has been rotated and deviates slightly from a desired
+    # horizontal view.
+
+    # - ViewVolume -
+    # Defines how much of the current scene is visible. Specifying the field of
+    # view is analogous to specifying the lens opening in a physical camera.
+    # A small field of view, like a telephoto lens, focuses on a small part of
+    # the scene. A large field of view, like a wide-angle lens, focuses on a
+    # large part of the scene.
+
+    _left_fow = None
+    # Angle, in degrees, between the camera's viewing direction and the left side
+    # of the view volume.
+
+    _right_fov = None
+    # Angle, in degrees, between the camera's viewing direction and the right side
+    # of the view volume.
+
+    _bottom_fov = None
+    # Angle, in degrees, between the camera's viewing direction and the bottom side
+    # of the view volume.
+
+    _top_fov = None
+    # Angle, in degrees, between the camera's viewing direction and the top side
+    # of the view volume.
+
+    _near = None
+    # Measurement in meters along the viewing direction from the camera viewpoint
+    # to the PhotoOverlay shape.
+
+    _tile_size = "256"
+    # Size of the tiles, in pixels. Tiles must be square, and <tileSize> must
+    # be a power of 2. A tile size of 256 (the default) or 512 is recommended.
+    # The original image is divided into tiles of this size, at varying resolutions.
+
+    _max_width = None
+    # Width in pixels of the original image.
+
+    _max_height = None
+    # Height in pixels of the original image.
+
+    _grid_origin: Optional[GridOrigin]
+    # Specifies where to begin numbering the tiles in each layer of the pyramid.
+    # A value of lowerLeft specifies that row 1, column 1 of each layer is in
+    # the bottom left corner of the grid.
+
+    _point: Optional[Point]
+    # The <Point> element acts as a <Point> inside a <Placemark> element.
+    # It draws an icon to mark the position of the PhotoOverlay.
+    # The icon drawn is specified by the <styleUrl> and <StyleSelector> fields,
+    # just as it is for <Placemark>.
+
+    _shape: Optional[Shape]
+    # The PhotoOverlay is projected onto the <shape>.
+    # The <shape> can be one of the following:
+    #   rectangle (default) -
+    #       for an ordinary photo
+    #   cylinder -
+    #       for panoramas, which can be either partial or full cylinders
+    #   sphere -
+    #       for spherical panoramas
+
+    @property
+    def rotation(self) -> Optional[str]:
+        return self._rotation
+
+    @rotation.setter
+    def rotation(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._rotation = str(value)
+        elif value is None:
+            self._rotation = None
+        else:
+            raise ValueError
+
+    @property
+    def left_fov(self) -> Optional[str]:
+        return self._left_fow
+
+    @left_fov.setter
+    def left_fov(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._left_fow = str(value)
+        elif value is None:
+            self._left_fow = None
+        else:
+            raise ValueError
+
+    @property
+    def right_fov(self) -> Optional[str]:
+        return self._right_fov
+
+    @right_fov.setter
+    def right_fov(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._right_fov = str(value)
+        elif value is None:
+            self._right_fov = None
+        else:
+            raise ValueError
+
+    @property
+    def bottom_fov(self) -> Optional[str]:
+        return self._bottom_fov
+
+    @bottom_fov.setter
+    def bottom_fov(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._bottom_fov = str(value)
+        elif value is None:
+            self._bottom_fov = None
+        else:
+            raise ValueError
+
+    @property
+    def top_fov(self) -> Optional[str]:
+        return self._top_fov
+
+    @top_fov.setter
+    def top_fov(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._top_fov = str(value)
+        elif value is None:
+            self._top_fov = None
+        else:
+            raise ValueError
+
+    @property
+    def near(self) -> Optional[str]:
+        return self._near
+
+    @near.setter
+    def near(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._near = str(value)
+        elif value is None:
+            self._near = None
+        else:
+            raise ValueError
+
+    @property
+    def tile_size(self) -> Optional[str]:
+        return self._tile_size
+
+    @tile_size.setter
+    def tile_size(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._tile_size = str(value)
+        elif value is None:
+            self._tile_size = None
+        else:
+            raise ValueError
+
+    @property
+    def max_width(self) -> Optional[str]:
+        return self._max_width
+
+    @max_width.setter
+    def max_width(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._max_width = str(value)
+        elif value is None:
+            self._max_width = None
+        else:
+            raise ValueError
+
+    @property
+    def max_height(self) -> Optional[str]:
+        return self._max_height
+
+    @max_height.setter
+    def max_height(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._max_height = str(value)
+        elif value is None:
+            self._max_height = None
+        else:
+            raise ValueError
+
+    @property
+    def grid_origin(self) -> Optional[GridOrigin]:
+        return self._grid_origin
+
+    @grid_origin.setter
+    def grid_origin(self, value: Optional[GridOrigin]) -> None:
+        self._grid_origin = value
+
+    @property
+    def point(self) -> str:
+        return self._point
+
+    @point.setter
+    def point(self, value) -> None:
+        if isinstance(value, (str, tuple)):
+            self._point = str(value)
+        else:
+            raise ValueError
+
+    @property
+    def shape(self) -> Optional[Shape]:
+        return self._shape
+
+    @shape.setter
+    def shape(self, value: Optional[Shape]) -> None:
+        self._shape = value
+
+    def view_volume(self, left_fov, right_fov, bottom_fov, top_fov, near) -> None:
+        self.left_fov = left_fov
+        self.right_fov = right_fov
+        self.bottom_fov = bottom_fov
+        self.top_fov = top_fov
+        self.near = near
+
+    def image_pyramid(self, tile_size, max_width, max_height, grid_origin) -> None:
+        self.tile_size = tile_size
+        self.max_width = max_width
+        self.max_height = max_height
+        self.grid_origin = grid_origin
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        if self._rotation:
+            rotation = config.etree.SubElement(element, f"{self.ns}rotation")
+            rotation.text = self._rotation
+        if all(
+            [
+                self._left_fow,
+                self._right_fov,
+                self._bottom_fov,
+                self._top_fov,
+                self._near,
+            ],
+        ):
+            view_volume = config.etree.SubElement(element, f"{self.ns}ViewVolume")
+            left_fov = config.etree.SubElement(view_volume, f"{self.ns}leftFov")
+            left_fov.text = self._left_fow
+            right_fov = config.etree.SubElement(view_volume, f"{self.ns}rightFov")
+            right_fov.text = self._right_fov
+            bottom_fov = config.etree.SubElement(view_volume, f"{self.ns}bottomFov")
+            bottom_fov.text = self._bottom_fov
+            top_fov = config.etree.SubElement(view_volume, f"{self.ns}topFov")
+            top_fov.text = self._top_fov
+            near = config.etree.SubElement(view_volume, f"{self.ns}near")
+            near.text = self._near
+        if all([self._tile_size, self._max_width, self._max_height, self._grid_origin]):
+            image_pyramid = config.etree.SubElement(element, f"{self.ns}ImagePyramid")
+            tile_size = config.etree.SubElement(image_pyramid, f"{self.ns}tileSize")
+            tile_size.text = self._tile_size
+            max_width = config.etree.SubElement(image_pyramid, f"{self.ns}maxWidth")
+            max_width.text = self._max_width
+            max_height = config.etree.SubElement(image_pyramid, f"{self.ns}maxHeight")
+            max_height.text = self._max_height
+            grid_origin = config.etree.SubElement(image_pyramid, f"{self.ns}gridOrigin")
+            grid_origin.text = self._grid_origin
+        return element
+
+    def from_element(self, element) -> None:
+        super().from_element(element)
+        rotation = element.find(f"{self.ns}rotation")
+        if rotation is not None:
+            self.rotation = rotation.text
+        view_volume = element.find(f"{self.ns}ViewVolume")
+        if view_volume is not None:
+            left_fov = view_volume.find(f"{self.ns}leftFov")
+            if left_fov is not None:
+                self.left_fov = left_fov.text
+            right_fov = view_volume.find(f"{self.ns}rightFov")
+            if right_fov is not None:
+                self.right_fov = right_fov.text
+            bottom_fov = view_volume.find(f"{self.ns}bottomFov")
+            if bottom_fov is not None:
+                self.bottom_fov = bottom_fov.text
+            top_fov = view_volume.find(f"{self.ns}topFov")
+            if top_fov is not None:
+                self.top_fov = top_fov.text
+            near = view_volume.find(f"{self.ns}near")
+            if near is not None:
+                self.near = near.text
+        image_pyramid = element.find(f"{self.ns}ImagePyramid")
+        if image_pyramid is not None:
+            tile_size = image_pyramid.find(f"{self.ns}tileSize")
+            if tile_size is not None:
+                self.tile_size = tile_size.text
+            max_width = image_pyramid.find(f"{self.ns}maxWidth")
+            if max_width is not None:
+                self.max_width = max_width.text
+            max_height = image_pyramid.find(f"{self.ns}maxHeight")
+            if max_height is not None:
+                self.max_height = max_height.text
+            grid_origin = image_pyramid.find(f"{self.ns}gridOrigin")
+            if grid_origin is not None:
+                self.grid_origin = grid_origin.text
+        point = element.find(f"{self.ns}Point")
+        if point is not None:
+            self.point = point.text
+        shape = element.find(f"{self.ns}shape")
+        if shape is not None:
+            self.shape = shape.text
+
+
+class GroundOverlay(_Overlay):
+    """
+    This element draws an image overlay draped onto the terrain. The <href>
+    child of <Icon> specifies the image to be used as the overlay. This file
+    can be either on a local file system or on a web server. If this element
+    is omitted or contains no <href>, a rectangle is drawn using the color and
+    LatLonBox bounds defined by the ground overlay.
+    """
+
+    __name__ = "GroundOverlay"
+
+    _altitude = None
+    # Specifies the distance above the earth's surface, in meters, and is
+    # interpreted according to the altitude mode.
+
+    _altitude_mode = "clampToGround"
+    # Specifies how the <altitude> is interpreted. Possible values are:
+    #   clampToGround -
+    #       (default) Indicates to ignore the altitude specification and drape
+    #       the overlay over the terrain.
+    #   absolute -
+    #       Sets the altitude of the overlay relative to sea level, regardless
+    #       of the actual elevation of the terrain beneath the element. For
+    #       example, if you set the altitude of an overlay to 10 meters with an
+    #       absolute altitude mode, the overlay will appear to be at ground
+    #       level if the terrain beneath is also 10 meters above sea level. If
+    #       the terrain is 3 meters above sea level, the overlay will appear
+    #       elevated above the terrain by 7 meters.
+
+    # - LatLonBox -
+    # TODO: Convert this to it's own class?
+    # Specifies where the top, bottom, right, and left sides of a bounding box
+    # for the ground overlay are aligned. Also, optionally the rotation of the
+    # overlay.
+
+    _north = None
+    # Specifies the latitude of the north edge of the bounding box, in decimal
+    # degrees from 0 to ±90.
+
+    _south = None
+    # Specifies the latitude of the south edge of the bounding box, in decimal
+    # degrees from 0 to ±90.
+
+    _east = None
+    # Specifies the longitude of the east edge of the bounding box, in decimal
+    # degrees from 0 to ±180. (For overlays that overlap the meridian of 180°
+    # longitude, values can extend beyond that range.)
+
+    _west = None
+    # Specifies the longitude of the west edge of the bounding box, in decimal
+    # degrees from 0 to ±180. (For overlays that overlap the meridian of 180°
+    # longitude, values can extend beyond that range.)
+
+    _rotation = None
+    # Specifies a rotation of the overlay about its center, in degrees. Values
+    # can be ±180. The default is 0 (north). Rotations are specified in a
+    # counterclockwise direction.
+
+    # TODO: <gx:LatLonQuad>
+    # Used for nonrectangular quadrilateral ground overlays.
+    _lat_lon_quad = None
+
+    @property
+    def altitude(self) -> Optional[str]:
+        return self._altitude
+
+    @altitude.setter
+    def altitude(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._altitude = str(value)
+        elif value is None:
+            self._altitude = None
+        else:
+            raise ValueError
+
+    @property
+    def altitude_mode(self) -> str:
+        return self._altitude_mode
+
+    @altitude_mode.setter
+    def altitude_mode(self, mode) -> None:
+        if mode in ("clampToGround", "absolute"):
+            self._altitude_mode = str(mode)
+        else:
+            self._altitude_mode = "clampToGround"
+
+    @property
+    def north(self) -> Optional[str]:
+        return self._north
+
+    @north.setter
+    def north(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._north = str(value)
+        elif value is None:
+            self._north = None
+        else:
+            raise ValueError
+
+    @property
+    def south(self) -> Optional[str]:
+        return self._south
+
+    @south.setter
+    def south(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._south = str(value)
+        elif value is None:
+            self._south = None
+        else:
+            raise ValueError
+
+    @property
+    def east(self) -> Optional[str]:
+        return self._east
+
+    @east.setter
+    def east(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._east = str(value)
+        elif value is None:
+            self._east = None
+        else:
+            raise ValueError
+
+    @property
+    def west(self) -> Optional[str]:
+        return self._west
+
+    @west.setter
+    def west(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._west = str(value)
+        elif value is None:
+            self._west = None
+        else:
+            raise ValueError
+
+    @property
+    def rotation(self) -> Optional[str]:
+        return self._rotation
+
+    @rotation.setter
+    def rotation(self, value) -> None:
+        if isinstance(value, (str, int, float)):
+            self._rotation = str(value)
+        elif value is None:
+            self._rotation = None
+        else:
+            raise ValueError
+
+    def lat_lon_box(
+        self,
+        north: int,
+        south: int,
+        east: int,
+        west: int,
+        rotation: int = 0,
+    ) -> None:
+        if -90 <= float(north) <= 90:
+            self.north = north
+        else:
+            raise ValueError
+        if -90 <= float(south) <= 90:
+            self.south = south
+        else:
+            raise ValueError
+        if -180 <= float(east) <= 180:
+            self.east = east
+        else:
+            raise ValueError
+        if -180 <= float(west) <= 180:
+            self.west = west
+        else:
+            raise ValueError
+        if -180 <= float(rotation) <= 180:
+            self.rotation = rotation
+        else:
+            raise ValueError
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        if self._altitude:
+            altitude = config.etree.SubElement(element, f"{self.ns}altitude")
+            altitude.text = self._altitude
+            if self._altitude_mode:
+                altitude_mode = config.etree.SubElement(
+                    element,
+                    f"{self.ns}altitudeMode",
+                )
+                altitude_mode.text = self._altitude_mode
+        if all([self._north, self._south, self._east, self._west]):
+            lat_lon_box = config.etree.SubElement(element, f"{self.ns}LatLonBox")
+            north = config.etree.SubElement(lat_lon_box, f"{self.ns}north")
+            north.text = self._north
+            south = config.etree.SubElement(lat_lon_box, f"{self.ns}south")
+            south.text = self._south
+            east = config.etree.SubElement(lat_lon_box, f"{self.ns}east")
+            east.text = self._east
+            west = config.etree.SubElement(lat_lon_box, f"{self.ns}west")
+            west.text = self._west
+            if self._rotation:
+                rotation = config.etree.SubElement(lat_lon_box, f"{self.ns}rotation")
+                rotation.text = self._rotation
+        return element
+
+    def from_element(self, element: Element) -> None:
+        super().from_element(element)
+        altitude = element.find(f"{self.ns}altitude")
+        if altitude is not None:
+            self.altitude = altitude.text
+        altitude_mode = element.find(f"{self.ns}altitudeMode")
+        if altitude_mode is not None:
+            self.altitude_mode = altitude_mode.text
+        lat_lon_box = element.find(f"{self.ns}LatLonBox")
+        if lat_lon_box is not None:
+            north = lat_lon_box.find(f"{self.ns}north")
+            if north is not None:
+                self.north = north.text
+            south = lat_lon_box.find(f"{self.ns}south")
+            if south is not None:
+                self.south = south.text
+            east = lat_lon_box.find(f"{self.ns}east")
+            if east is not None:
+                self.east = east.text
+            west = lat_lon_box.find(f"{self.ns}west")
+            if west is not None:
+                self.west = west.text
+            rotation = lat_lon_box.find(f"{self.ns}rotation")
+            if rotation is not None:
+                self.rotation = rotation.text

From c0337ec411d85d0595e77889842a30e34c730a0a Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Wed, 22 Nov 2023 18:58:07 +0000
Subject: [PATCH 06/25] Add NetworkLink, improve handling of time span and
 stamp

---
 fastkml/features.py                  | 156 +++++----
 fastkml/mixins.py                    |  46 +--
 fastkml/overlays.py                  |  32 +-
 fastkml/views.py                     |  52 ++-
 tests/containers_test.py             |  40 +++
 tests/features_test.py               |  74 ++++
 tests/{kml_test.py => links_test.py} |   8 +-
 tests/oldunit_test.py                | 487 --------------------------
 tests/overlays_test.py               | 491 +++++++++++++++++++++++++++
 tests/times_test.py                  |  40 +--
 tests/views_test.py                  |   4 +-
 11 files changed, 760 insertions(+), 670 deletions(-)
 create mode 100644 tests/containers_test.py
 create mode 100644 tests/features_test.py
 rename tests/{kml_test.py => links_test.py} (95%)
 create mode 100644 tests/overlays_test.py

diff --git a/fastkml/features.py b/fastkml/features.py
index b911f359..3c909035 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -5,7 +5,6 @@
 """
 
 import logging
-from datetime import datetime
 from typing import Any
 from typing import Dict
 from typing import Iterator
@@ -131,14 +130,7 @@ class _Feature(TimeMixin, _BaseObject):
     # Placemark, or ScreenOverlay—the value for the Feature's inline
     # style takes precedence over the value for the shared style.
 
-    _timespan: Optional[TimeSpan]
-    # Associates this Feature with a period of time.
-    _timestamp: Optional[TimeStamp]
-    # Associates this Feature with a point in time.
-
-    _camera: Optional[Camera]
-
-    _look_at: Optional[LookAt]
+    _view: Union[Camera, LookAt, None]
 
     # TODO Region = None
     # Features and geometry associated with a Region are drawn only when
@@ -173,18 +165,17 @@ def __init__(
         styles: Optional[List[Style]] = None,
         style_url: Optional[str] = None,
         extended_data: None = None,
-        camera: Optional[Camera] = None,
-        look_at: Optional[LookAt] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
         address: Optional[str] = None,
         phone_number: Optional[str] = None,
+        times: Optional[Union[TimeSpan, TimeStamp]] = None,
     ) -> None:
         super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
         self.name = name
         self.description = description
         self.style_url = style_url
         self._styles = []
-        self._camera = camera
-        self._look_at = look_at
+        self._view = view
         self.visibility = visibility
         self.isopen = isopen
         self.snippet = snippet
@@ -196,6 +187,7 @@ def __init__(
             for style in styles:
                 self.append_style(style)
         self.extended_data = extended_data
+        self._times = times
 
     @property
     def style_url(self) -> Optional[str]:
@@ -221,22 +213,12 @@ def style_url(self, styleurl: Union[str, StyleUrl, None]) -> None:
             raise ValueError
 
     @property
-    def camera(self):
-        return self._camera
-
-    @camera.setter
-    def camera(self, camera) -> None:
-        if isinstance(camera, Camera):
-            self._camera = camera
-
-    @property
-    def look_at(self) -> datetime:
-        return self._look_at
+    def view(self) -> Optional[Union[Camera, LookAt]]:
+        return self._view
 
-    @look_at.setter
-    def look_at(self, look_at) -> None:
-        if isinstance(look_at, LookAt):
-            self._look_at = look_at
+    @view.setter
+    def view(self, camera: Optional[Union[Camera, LookAt]]) -> None:
+        self._view = camera
 
     @property
     def link(self):
@@ -331,34 +313,20 @@ def snippet(self, snip=None) -> None:
             )
 
     @property
-    def address(self) -> None:
-        if self._address:
-            return self._address
-        return None
+    def address(self) -> Optional[str]:
+        return self._address
 
     @address.setter
-    def address(self, address) -> None:
-        if isinstance(address, str):
-            self._address = address
-        elif address is None:
-            self._address = None
-        else:
-            raise ValueError
+    def address(self, address: Optional[str]) -> None:
+        self._address = address
 
     @property
-    def phone_number(self) -> None:
-        if self._phone_number:
-            return self._phone_number
-        return None
+    def phone_number(self) -> Optional[str]:
+        return self._phone_number
 
     @phone_number.setter
-    def phone_number(self, phone_number) -> None:
-        if isinstance(phone_number, str):
-            self._phone_number = phone_number
-        elif phone_number is None:
-            self._phone_number = None
-        else:
-            raise ValueError
+    def phone_number(self, phone_number: Optional[str]) -> None:
+        self._phone_number = phone_number
 
     def etree_element(
         self,
@@ -372,13 +340,8 @@ def etree_element(
         if self.description:
             description = config.etree.SubElement(element, f"{self.ns}description")
             description.text = self.description
-        if (self.camera is not None) and (self.look_at is not None):
-            msg = "Either Camera or LookAt can be defined, not both"
-            raise ValueError(msg)
-        if self.camera is not None:
-            element.append(self._camera.etree_element())
-        elif self.look_at is not None:
-            element.append(self._look_at.etree_element())
+        if self._view is not None:
+            element.append(self._view.etree_element())
         if self.visibility is not None:
             visibility = config.etree.SubElement(element, f"{self.ns}visibility")
             visibility.text = str(self.visibility)
@@ -398,13 +361,8 @@ def etree_element(
                 snippet.text = self.snippet["text"]
                 if self.snippet.get("maxLines"):
                     snippet.set("maxLines", str(self.snippet["maxLines"]))
-        if (self._timespan is not None) and (self._timestamp is not None):
-            msg = "Either Timestamp or Timespan can be defined, not both"
-            raise ValueError(msg)
-        elif self._timespan is not None:
-            element.append(self._timespan.etree_element())
-        elif self._timestamp is not None:
-            element.append(self._timestamp.etree_element())
+        elif self._times is not None:
+            element.append(self._times.etree_element())
         if self._atom_link is not None:
             element.append(self._atom_link.etree_element())
         if self._atom_author is not None:
@@ -512,9 +470,18 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             self.phone_number = phone_number.text
         camera = element.find(f"{self.ns}Camera")
         if camera is not None:
-            s = Camera(self.ns)
-            s.from_element(camera)
-            self.camera = s
+            self._view = Camera.class_from_element(
+                ns=self.ns,
+                element=camera,
+                strict=strict,
+            )
+        lookat = element.find(f"{self.ns}LookAt")
+        if lookat is not None:
+            self._view = LookAt.class_from_element(
+                ns=self.ns,
+                element=lookat,
+                strict=strict,
+            )
 
 
 class Placemark(_Feature):
@@ -632,3 +599,58 @@ def etree_element(
         else:
             logger.error("Object does not have a geometry")
         return element
+
+
+class NetworkLink(_Feature):
+    __name__ = "NetworkLink"
+    _nlink = None
+
+    def __init__(
+        self,
+        ns=None,
+        id=None,
+        name=None,
+        description=None,
+        styles=None,
+        styleUrl=None,
+    ):
+        super().__init__(ns, id, name, description, styles, styleUrl)
+
+    @property
+    def link(self):
+        return self._nlink.href
+
+    @link.setter
+    def link(self, url):
+        if isinstance(url, basestring):
+            self._nlink = atom.Link(href=url)
+        elif isinstance(url, Link):
+            self._nlink = url
+        elif url is None:
+            self._nlink = None
+        else:
+            raise TypeError
+
+    def etree_element(self):
+        element = super().etree_element()
+        if self._nlink is not None:
+            element.append(self._nlink.etree_element())
+        return element
+
+    def from_element(self, element):
+        super(_Feature, self).from_element(element)
+        name = element.find(f"{self.ns}name")
+        if name is not None:
+            self.name = name.text
+        id = element.find(f"{self.ns}id")
+        if id is not None:
+            self.id = id.text
+        visibility = element.find(f"{self.ns}visibility")
+        if visibility is not None:
+            self.visibility = visibility.text
+
+        link = element.find(f"{self.ns}Link")
+        if link is not None:
+            s = Link()
+            s.from_element(link)
+            self._nlink = s
diff --git a/fastkml/mixins.py b/fastkml/mixins.py
index cfc6adc7..37c63942 100644
--- a/fastkml/mixins.py
+++ b/fastkml/mixins.py
@@ -16,6 +16,7 @@
 """Mixins for the KML classes."""
 import logging
 from typing import Optional
+from typing import Union
 
 from fastkml.times import KmlDateTime
 from fastkml.times import TimeSpan
@@ -25,54 +26,17 @@
 
 
 class TimeMixin:
-    _timespan: Optional[TimeSpan] = None
-    _timestamp: Optional[TimeStamp] = None
+    _times: Optional[Union[TimeSpan, TimeStamp]] = None
 
     @property
     def time_stamp(self) -> Optional[KmlDateTime]:
         """This just returns the datetime portion of the timestamp."""
-        return self._timestamp.timestamp if self._timestamp is not None else None
-
-    @time_stamp.setter
-    def time_stamp(self, timestamp: Optional[KmlDateTime]) -> None:
-        if self._timestamp is None:
-            self._timestamp = TimeStamp(timestamp=timestamp)
-        elif timestamp is None:
-            self._timestamp = None
-        else:
-            self._timestamp.timestamp = timestamp
-        if self._timespan and self._timestamp:
-            logger.warning("Setting a TimeStamp, TimeSpan deleted")
-            self._timespan = None
+        return self._times.timestamp if isinstance(self._times, TimeStamp) else None
 
     @property
     def begin(self) -> Optional[KmlDateTime]:
-        return self._timespan.begin if self._timespan is not None else None
-
-    @begin.setter
-    def begin(self, dt: Optional[KmlDateTime]) -> None:
-        if self._timespan is None:
-            self._timespan = TimeSpan(begin=dt)
-        elif dt is None and self._timespan.end is None:
-            self._timespan = None
-        else:
-            self._timespan.begin = dt
-        if self._timespan and self._timestamp:
-            logger.warning("Setting a TimeSpan, TimeStamp deleted")
-            self._timestamp = None
+        return self._times.begin if isinstance(self._times, TimeSpan) else None
 
     @property
     def end(self) -> Optional[KmlDateTime]:
-        return self._timespan.end if self._timespan is not None else None
-
-    @end.setter
-    def end(self, dt: Optional[KmlDateTime]) -> None:
-        if self._timespan is None:
-            self._timespan = TimeSpan(end=dt)
-        elif dt is None and self._timespan.begin is None:
-            self._timespan = None
-        else:
-            self._timespan.end = dt
-        if self._timespan and self._timestamp:
-            logger.warning("Setting a TimeSpan, TimeStamp deleted")
-            self._timestamp = None
+        return self._times.end if isinstance(self._times, TimeSpan) else None
diff --git a/fastkml/overlays.py b/fastkml/overlays.py
index 49946c75..8565bb31 100644
--- a/fastkml/overlays.py
+++ b/fastkml/overlays.py
@@ -3,10 +3,13 @@
 """
 
 import logging
+from typing import Any
 from typing import Dict
+from typing import List
 from typing import Optional
 from typing import Union
 
+from fastkml import atom
 from fastkml import config
 from fastkml import gx
 from fastkml.enums import GridOrigin
@@ -19,7 +22,12 @@
 from fastkml.geometry import Point
 from fastkml.geometry import Polygon
 from fastkml.links import Icon
+from fastkml.styles import Style
+from fastkml.times import TimeSpan
+from fastkml.times import TimeStamp
 from fastkml.types import Element
+from fastkml.views import Camera
+from fastkml.views import LookAt
 
 logger = logging.getLogger(__name__)
 
@@ -70,9 +78,19 @@ def __init__(
         target_id: Optional[str] = None,
         name: Optional[str] = None,
         description: Optional[str] = None,
-        color: Optional[str] = None,
-        styles: None = None,
+        snippet: Optional[Union[str, Dict[str, Any]]] = None,
+        atom_author: Optional[atom.Author] = None,
+        atom_link: Optional[atom.Link] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
+        styles: Optional[List[Style]] = None,
         style_url: Optional[str] = None,
+        extended_data: None = None,
+        view: Optional[Union[Camera, LookAt]] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
+        times: Optional[Union[TimeSpan, TimeStamp]] = None,
+        color: Optional[str] = None,
         draw_order: Optional[str] = None,
         icon: Optional[Icon] = None,
     ) -> None:
@@ -85,6 +103,16 @@ def __init__(
             description=description,
             styles=styles,
             style_url=style_url,
+            snippet=snippet,
+            atom_author=atom_author,
+            atom_link=atom_link,
+            visibility=visibility,
+            isopen=isopen,
+            extended_data=extended_data,
+            view=view,
+            address=address,
+            phone_number=phone_number,
+            times=times,
         )
         self._icon = icon
         self._color = color
diff --git a/fastkml/views.py b/fastkml/views.py
index dac97d72..dd178a73 100644
--- a/fastkml/views.py
+++ b/fastkml/views.py
@@ -85,10 +85,7 @@ def __init__(
         self._heading = heading
         self._tilt = tilt
         self._altitude_mode = altitude_mode
-        if isinstance(time_primitive, TimeSpan):
-            self._timespan = time_primitive
-        elif isinstance(time_primitive, TimeStamp):
-            self._timestamp = time_primitive
+        self._times = time_primitive
 
     @property
     def longitude(self) -> Optional[float]:
@@ -199,31 +196,28 @@ def etree_element(
                 f"{self.ns}tilt",
             )
             tilt.text = str(self.tilt)
-        if self.altitude_mode in (
-            AltitudeMode.clamp_to_ground,
-            AltitudeMode.relative_to_ground,
-            AltitudeMode.absolute,
-        ):
-            altitude_mode = config.etree.SubElement(  # type: ignore[attr-defined]
-                element,
-                f"{self.ns}altitudeMode",
-            )
-        elif self.altitude_mode in (
-            AltitudeMode.clamp_to_sea_floor,
-            AltitudeMode.relative_to_sea_floor,
-        ):
-            altitude_mode = config.etree.SubElement(  # type: ignore[attr-defined]
-                element,
-                f"{self.name_spaces['gx']}altitudeMode",
-            )
-        altitude_mode.text = self.altitude_mode.value
-        if (self._timespan is not None) and (self._timestamp is not None):
-            msg = "Either Timestamp or Timespan can be defined, not both"
-            raise ValueError(msg)
-        if self._timespan is not None:
-            element.append(self._timespan.etree_element())
-        elif self._timestamp is not None:
-            element.append(self._timestamp.etree_element())
+        if self.altitude_mode:
+            if self.altitude_mode in (
+                AltitudeMode.clamp_to_ground,
+                AltitudeMode.relative_to_ground,
+                AltitudeMode.absolute,
+            ):
+                altitude_mode = config.etree.SubElement(  # type: ignore[attr-defined]
+                    element,
+                    f"{self.ns}altitudeMode",
+                )
+            elif self.altitude_mode in (
+                AltitudeMode.clamp_to_sea_floor,
+                AltitudeMode.relative_to_sea_floor,
+            ):
+                altitude_mode = config.etree.SubElement(  # type: ignore[attr-defined]
+                    element,
+                    f"{self.name_spaces['gx']}altitudeMode",
+                )
+            altitude_mode.text = self.altitude_mode.value
+
+        if self._times is not None:
+            element.append(self._times.etree_element())
         return element
 
     # TODO: <gx:ViewerOptions>
diff --git a/tests/containers_test.py b/tests/containers_test.py
new file mode 100644
index 00000000..b166aba6
--- /dev/null
+++ b/tests/containers_test.py
@@ -0,0 +1,40 @@
+# Copyright (C) 2021 - 2023 Christian Ledermann
+#
+# This library is free software; you can redistribute it and/or modify it under
+# the terms of the GNU Lesser General Public License as published by the Free
+# Software Foundation; either version 2.1 of the License, or (at your option)
+# any later version.
+#
+# This library is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more
+# details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this library; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+
+"""Test the kml classes."""
+import pytest
+
+from fastkml import containers
+from fastkml import features
+from tests.base import Lxml
+from tests.base import StdLibrary
+
+
+class TestStdLibrary(StdLibrary):
+    """Test with the standard library."""
+
+    def test_container_base(self) -> None:
+        f = containers._Container(name="A Container")
+        # apparently you can add documents to containes
+        # d = kml.Document()
+        # self.assertRaises(TypeError, f.append, d)
+        p = features.Placemark()
+        f.append(p)
+        pytest.raises(NotImplementedError, f.etree_element)
+
+
+class TestLxml(Lxml, TestStdLibrary):
+    """Test with lxml."""
diff --git a/tests/features_test.py b/tests/features_test.py
new file mode 100644
index 00000000..05e13a2f
--- /dev/null
+++ b/tests/features_test.py
@@ -0,0 +1,74 @@
+# Copyright (C) 2021 -2023  Christian Ledermann
+#
+# This library is free software; you can redistribute it and/or modify it under
+# the terms of the GNU Lesser General Public License as published by the Free
+# Software Foundation; either version 2.1 of the License, or (at your option)
+# any later version.
+#
+# This library is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more
+# details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this library; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+
+"""Test the kml classes."""
+import pytest
+
+from fastkml import features
+from tests.base import Lxml
+from tests.base import StdLibrary
+
+
+class TestStdLibrary(StdLibrary):
+    """Test with the standard library."""
+
+    def test_feature_base(self) -> None:
+        f = features._Feature(name="A Feature")
+        pytest.raises(NotImplementedError, f.etree_element)
+        assert f.name == "A Feature"
+        assert f.visibility is None
+        assert f.isopen is None
+        assert f._atom_author is None
+        assert f._atom_link is None
+        assert f.address is None
+        # self.assertEqual(f.phoneNumber, None)
+        assert f._snippet is None
+        assert f.description is None
+        assert f._style_url is None
+        assert f._styles == []
+        assert f._times is None
+        # self.assertEqual(f.region, None)
+        # self.assertEqual(f.extended_data, None)
+
+        f.__name__ = "Feature"
+        f.style_url = "#default"
+        assert "Feature>" in str(f.to_string())
+        assert "#default" in str(f.to_string())
+
+    def test_address_string(self) -> None:
+        f = features._Feature()
+        address = "1600 Amphitheatre Parkway, Mountain View, CA 94043, USA"
+        f.address = address
+        assert f.address == address
+
+    def test_address_none(self) -> None:
+        f = features._Feature()
+        f.address = None
+        assert f.address is None
+
+    def test_phone_number_string(self) -> None:
+        f = features._Feature()
+        f.phone_number = "+1-234-567-8901"
+        assert f.phone_number == "+1-234-567-8901"
+
+    def test_phone_number_none(self) -> None:
+        f = features._Feature()
+        f.phone_number = None
+        assert f.phone_number is None
+
+
+class TestLxml(Lxml, TestStdLibrary):
+    """Test with lxml."""
diff --git a/tests/kml_test.py b/tests/links_test.py
similarity index 95%
rename from tests/kml_test.py
rename to tests/links_test.py
index c371d846..83278f7d 100644
--- a/tests/kml_test.py
+++ b/tests/links_test.py
@@ -15,7 +15,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
 
 """Test the kml classes."""
-from fastkml import kml
+from fastkml import links
 from fastkml.enums import RefreshMode
 from fastkml.enums import ViewRefreshMode
 from tests.base import Lxml
@@ -27,7 +27,7 @@ class TestStdLibrary(StdLibrary):
 
     def test_icon(self) -> None:
         """Test the Icon class."""
-        icon = kml.Icon(
+        icon = links.Icon(
             id="icon-01",
             href="http://maps.google.com/mapfiles/kml/paddle/red-circle.png",
             refresh_mode="onInterval",
@@ -51,7 +51,7 @@ def test_icon(self) -> None:
 
     def test_icon_read(self) -> None:
         """Test the Icon class."""
-        icon = kml.Icon.class_from_string(
+        icon = links.Icon.class_from_string(
             """
             <kml:Icon xmlns:kml="http://www.opengis.net/kml/2.2" id="icon-01">
             <kml:href>http://maps.google.com/mapfiles/kml/paddle/red-circle.png</kml:href>
@@ -76,7 +76,7 @@ def test_icon_read(self) -> None:
         assert icon.view_format == "BBOX=[bboxWest],[bboxSouth],[bboxEast],[bboxNorth]"
         assert icon.http_query == "clientName=fastkml"
 
-        icon2 = kml.Icon.class_from_string(icon.to_string())
+        icon2 = links.Icon.class_from_string(icon.to_string())
 
         assert icon2.to_string() == icon.to_string()
 
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index 44d8117e..d3f33b22 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -25,7 +25,6 @@
 from fastkml import config
 from fastkml import kml
 from fastkml import styles
-from fastkml.enums import AltitudeMode
 from fastkml.enums import ColorMode
 from fastkml.enums import DisplayMode
 
@@ -75,39 +74,6 @@ def test_base_object(self) -> None:
         assert bo.etree_element() is not None
         assert len(bo.to_string()) > 1
 
-    def test_feature(self) -> None:
-        f = kml._Feature(name="A Feature")
-        pytest.raises(NotImplementedError, f.etree_element)
-        assert f.name == "A Feature"
-        assert f.visibility is None
-        assert f.isopen is None
-        assert f._atom_author is None
-        assert f._atom_link is None
-        assert f.address is None
-        # self.assertEqual(f.phoneNumber, None)
-        assert f._snippet is None
-        assert f.description is None
-        assert f._style_url is None
-        assert f._styles == []
-        assert f._timespan is None
-        assert f._timestamp is None
-        # self.assertEqual(f.region, None)
-        # self.assertEqual(f.extended_data, None)
-
-        f.__name__ = "Feature"
-        f.style_url = "#default"
-        assert "Feature>" in str(f.to_string())
-        assert "#default" in str(f.to_string())
-
-    def test_container(self) -> None:
-        f = kml._Container(name="A Container")
-        # apparently you can add documents to containes
-        # d = kml.Document()
-        # self.assertRaises(TypeError, f.append, d)
-        p = kml.Placemark()
-        f.append(p)
-        pytest.raises(NotImplementedError, f.etree_element)
-
     def test_overlay(self) -> None:
         o = kml._Overlay(name="An Overlay")
         assert o._color is None
@@ -1310,456 +1276,3 @@ def test_nested_multigeometry(self) -> None:
             g for g in first_multigeometry.geoms if g.geom_type == "GeometryCollection"
         )
         assert len(list(second_multigeometry.geoms)) == 2
-
-
-class TestBaseFeature:
-    def test_address_string(self) -> None:
-        f = kml._Feature()
-        address = "1600 Amphitheatre Parkway, Mountain View, CA 94043, USA"
-        f.address = address
-        assert f.address == address
-
-    def test_address_none(self) -> None:
-        f = kml._Feature()
-        f.address = None
-        assert f.address is None
-
-    def test_address_value_error(self) -> None:
-        f = kml._Feature()
-        with pytest.raises(ValueError):
-            f.address = 123
-
-    def test_phone_number_string(self) -> None:
-        f = kml._Feature()
-        f.phone_number = "+1-234-567-8901"
-        assert f.phone_number == "+1-234-567-8901"
-
-    def test_phone_number_none(self) -> None:
-        f = kml._Feature()
-        f.phone_number = None
-        assert f.phone_number is None
-
-    def test_phone_number_value_error(self) -> None:
-        f = kml._Feature()
-        with pytest.raises(ValueError):
-            f.phone_number = 123
-
-
-class TestBaseOverlay:
-    def test_color_string(self) -> None:
-        o = kml._Overlay(name="An Overlay")
-        o.color = "00010203"
-        assert o.color == "00010203"
-
-    def test_color_none(self) -> None:
-        o = kml._Overlay(name="An Overlay")
-        o.color = "00010203"
-        assert o.color == "00010203"
-        o.color = None
-        assert o.color is None
-
-    def test_color_value_error(self) -> None:
-        o = kml._Overlay(name="An Overlay")
-        with pytest.raises(ValueError):
-            o.color = object()
-
-    def test_draw_order_string(self) -> None:
-        o = kml._Overlay(name="An Overlay")
-        o.draw_order = "1"
-        assert o.draw_order == "1"
-
-    def test_draw_order_int(self) -> None:
-        o = kml._Overlay(name="An Overlay")
-        o.draw_order = 1
-        assert o.draw_order == "1"
-
-    def test_draw_order_none(self) -> None:
-        o = kml._Overlay(name="An Overlay")
-        o.draw_order = "1"
-        assert o.draw_order == "1"
-        o.draw_order = None
-        assert o.draw_order is None
-
-    def test_draw_order_value_error(self) -> None:
-        o = kml._Overlay(name="An Overlay")
-        with pytest.raises(ValueError):
-            o.draw_order = object()
-
-    def test_icon_raise_exception(self) -> None:
-        o = kml._Overlay(name="An Overlay")
-        with pytest.raises(ValueError):
-            o.icon = 12345
-
-
-class TestGroundOverlay:
-    def setup_method(self) -> None:
-        self.g = kml.GroundOverlay()
-
-    def test_altitude_int(self) -> None:
-        self.g.altitude = 123
-        assert self.g.altitude == "123"
-
-    def test_altitude_float(self) -> None:
-        self.g.altitude = 123.4
-        assert self.g.altitude == "123.4"
-
-    def test_altitude_string(self) -> None:
-        self.g.altitude = "123"
-        assert self.g.altitude == "123"
-
-    def test_altitude_value_error(self) -> None:
-        with pytest.raises(ValueError):
-            self.g.altitude = object()
-
-    def test_altitude_none(self) -> None:
-        self.g.altitude = "123"
-        assert self.g.altitude == "123"
-        self.g.altitude = None
-        assert self.g.altitude is None
-
-    def test_altitude_mode_default(self) -> None:
-        assert self.g.altitude_mode == "clampToGround"
-
-    def test_altitude_mode_error(self) -> None:
-        self.g.altitude_mode = ""
-        assert self.g.altitude_mode == "clampToGround"
-
-    def test_altitude_mode_clamp(self) -> None:
-        self.g.altitude_mode = "clampToGround"
-        assert self.g.altitude_mode == "clampToGround"
-
-    def test_altitude_mode_absolute(self) -> None:
-        self.g.altitude_mode = "absolute"
-        assert self.g.altitude_mode == "absolute"
-
-    def test_latlonbox_function(self) -> None:
-        self.g.lat_lon_box(10, 20, 30, 40, 50)
-
-        assert self.g.north == "10"
-        assert self.g.south == "20"
-        assert self.g.east == "30"
-        assert self.g.west == "40"
-        assert self.g.rotation == "50"
-
-    def test_latlonbox_string(self) -> None:
-        self.g.north = "10"
-        self.g.south = "20"
-        self.g.east = "30"
-        self.g.west = "40"
-        self.g.rotation = "50"
-
-        assert self.g.north == "10"
-        assert self.g.south == "20"
-        assert self.g.east == "30"
-        assert self.g.west == "40"
-        assert self.g.rotation == "50"
-
-    def test_latlonbox_int(self) -> None:
-        self.g.north = 10
-        self.g.south = 20
-        self.g.east = 30
-        self.g.west = 40
-        self.g.rotation = 50
-
-        assert self.g.north == "10"
-        assert self.g.south == "20"
-        assert self.g.east == "30"
-        assert self.g.west == "40"
-        assert self.g.rotation == "50"
-
-    def test_latlonbox_float(self) -> None:
-        self.g.north = 10.0
-        self.g.south = 20.0
-        self.g.east = 30.0
-        self.g.west = 40.0
-        self.g.rotation = 50.0
-
-        assert self.g.north == "10.0"
-        assert self.g.south == "20.0"
-        assert self.g.east == "30.0"
-        assert self.g.west == "40.0"
-        assert self.g.rotation == "50.0"
-
-    def test_latlonbox_value_error(self) -> None:
-        with pytest.raises(ValueError):
-            self.g.north = object()
-
-        with pytest.raises(ValueError):
-            self.g.south = object()
-
-        with pytest.raises(ValueError):
-            self.g.east = object()
-
-        with pytest.raises(ValueError):
-            self.g.west = object()
-
-        with pytest.raises(ValueError):
-            self.g.rotation = object()
-
-        assert self.g.north is None
-        assert self.g.south is None
-        assert self.g.east is None
-        assert self.g.west is None
-        assert self.g.rotation is None
-
-    def test_latlonbox_empty_string(self) -> None:
-        self.g.north = ""
-        self.g.south = ""
-        self.g.east = ""
-        self.g.west = ""
-        self.g.rotation = ""
-
-        assert not self.g.north
-        assert not self.g.south
-        assert not self.g.east
-        assert not self.g.west
-        assert not self.g.rotation
-
-    def test_latlonbox_none(self) -> None:
-        self.g.north = None
-        self.g.south = None
-        self.g.east = None
-        self.g.west = None
-        self.g.rotation = None
-
-        assert self.g.north is None
-        assert self.g.south is None
-        assert self.g.east is None
-        assert self.g.west is None
-        assert self.g.rotation is None
-
-
-class TestGroundOverlayString:
-    def test_default_to_string(self) -> None:
-        g = kml.GroundOverlay()
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "</kml:GroundOverlay>",
-        )
-        assert g.to_string() == expected.to_string()
-
-    def test_to_string(self) -> None:
-        g = kml.GroundOverlay()
-        icon = kml.Icon(href="http://example.com")
-        g.icon = icon
-        g.draw_order = 1
-        g.color = "00010203"
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:color>00010203</kml:color>"
-            "<kml:drawOrder>1</kml:drawOrder>"
-            "<kml:Icon>"
-            "<kml:href>http://example.com</kml:href>"
-            "</kml:Icon>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_altitude_from_int(self) -> None:
-        g = kml.GroundOverlay()
-        g.altitude = 123
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:altitude>123</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_altitude_from_float(self) -> None:
-        g = kml.GroundOverlay()
-        g.altitude = 123.4
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:altitude>123.4</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_altitude_from_string(self) -> None:
-        g = kml.GroundOverlay()
-        g.altitude = "123.4"
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:altitude>123.4</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_altitude_mode_absolute(self) -> None:
-        g = kml.GroundOverlay()
-        g.altitude = "123.4"
-        g.altitude_mode = "absolute"
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:altitude>123.4</kml:altitude>"
-            "<kml:altitudeMode>absolute</kml:altitudeMode>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_altitude_mode_unknown_string(self) -> None:
-        g = kml.GroundOverlay()
-        g.altitude = "123.4"
-        g.altitudeMode = "unknown string"
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:altitude>123.4</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_altitude_mode_value(self) -> None:
-        g = kml.GroundOverlay()
-        g.altitude = "123.4"
-        g.altitudeMode = 1234
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:altitude>123.4</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_latlonbox_no_rotation(self) -> None:
-        g = kml.GroundOverlay()
-        g.lat_lon_box(10, 20, 30, 40)
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:LatLonBox>"
-            "<kml:north>10</kml:north>"
-            "<kml:south>20</kml:south>"
-            "<kml:east>30</kml:east>"
-            "<kml:west>40</kml:west>"
-            "<kml:rotation>0</kml:rotation>"
-            "</kml:LatLonBox>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_latlonbox_rotation(self) -> None:
-        g = kml.GroundOverlay()
-        g.lat_lon_box(10, 20, 30, 40, 50)
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:LatLonBox>"
-            "<kml:north>10</kml:north>"
-            "<kml:south>20</kml:south>"
-            "<kml:east>30</kml:east>"
-            "<kml:west>40</kml:west>"
-            "<kml:rotation>50</kml:rotation>"
-            "</kml:LatLonBox>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_latlonbox_nswer(self) -> None:
-        g = kml.GroundOverlay()
-        g.north = 10
-        g.south = 20
-        g.east = 30
-        g.west = 40
-        g.rotation = 50
-
-        expected = kml.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:LatLonBox>"
-            "<kml:north>10</kml:north>"
-            "<kml:south>20</kml:south>"
-            "<kml:east>30</kml:east>"
-            "<kml:west>40</kml:west>"
-            "<kml:rotation>50</kml:rotation>"
-            "</kml:LatLonBox>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-
-class TestPhotoOverlay:
-    def setup_method(self) -> None:
-        self.p = kml.PhotoOverlay()
-        self.p.camera = kml.Camera()
-
-    def test_camera_altitude_int(self) -> None:
-        self.p.camera.altitude = 123
-        assert self.p.camera.altitude == 123
-
-    def test_camera_altitude_float(self) -> None:
-        self.p.camera.altitude = 123.4
-        assert self.p.camera.altitude == 123.4
-
-    def test_camera_altitude_string(self) -> None:
-        self.p.camera.altitude = 123
-        assert self.p.camera.altitude == 123
-
-    def test_camera_altitude_value_error(self) -> None:
-        with pytest.raises(ValueError):
-            self.p.camera.altitude = object()
-
-    def test_camera_altitude_none(self) -> None:
-        self.p.camera.altitude = 123
-        assert self.p.camera.altitude == 123
-        self.p.camera.altitude = None
-        assert self.p.camera.altitude is None
-
-    def test_camera_altitude_mode_default(self) -> None:
-        assert self.p.camera.altitude_mode == AltitudeMode("relativeToGround")
-
-    def test_camera_altitude_mode_clamp(self) -> None:
-        self.p.camera.altitude_mode = AltitudeMode("clampToGround")
-        assert self.p.camera.altitude_mode == AltitudeMode("clampToGround")
-
-    def test_camera_altitude_mode_absolute(self) -> None:
-        self.p.camera.altitude_mode = "absolute"
-        assert self.p.camera.altitude_mode == "absolute"
-
-    def test_camera_initialization(self) -> None:
-        self.p.camera = kml.Camera(
-            longitude=10,
-            latitude=20,
-            altitude=30,
-            heading=40,
-            tilt=50,
-            roll=60,
-        )
-        assert self.p.camera.longitude == 10
-        assert self.p.camera.latitude == 20
-        assert self.p.camera.altitude == 30
-        assert self.p.camera.heading == 40
-        assert self.p.camera.tilt == 50
-        assert self.p.camera.roll == 60
-        assert self.p.camera.altitude_mode == AltitudeMode("relativeToGround")
diff --git a/tests/overlays_test.py b/tests/overlays_test.py
new file mode 100644
index 00000000..43baebeb
--- /dev/null
+++ b/tests/overlays_test.py
@@ -0,0 +1,491 @@
+# Copyright (C) 2021 - 2023  Christian Ledermann
+#
+# This library is free software; you can redistribute it and/or modify it under
+# the terms of the GNU Lesser General Public License as published by the Free
+# Software Foundation; either version 2.1 of the License, or (at your option)
+# any later version.
+#
+# This library is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more
+# details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this library; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+
+"""Test the kml classes."""
+import pytest
+
+from fastkml import links
+from fastkml import overlays
+from fastkml import views
+from fastkml.enums import AltitudeMode
+from tests.base import Lxml
+from tests.base import StdLibrary
+
+
+class TestBaseOverlay(StdLibrary):
+    def test_color_string(self) -> None:
+        o = overlays._Overlay(name="An Overlay")
+        o.color = "00010203"
+        assert o.color == "00010203"
+
+    def test_color_none(self) -> None:
+        o = overlays._Overlay(name="An Overlay")
+        o.color = "00010203"
+        assert o.color == "00010203"
+        o.color = None
+        assert o.color is None
+
+    def test_color_value_error(self) -> None:
+        o = overlays._Overlay(name="An Overlay")
+        with pytest.raises(ValueError):
+            o.color = object()
+
+    def test_draw_order_string(self) -> None:
+        o = overlays._Overlay(name="An Overlay")
+        o.draw_order = "1"
+        assert o.draw_order == "1"
+
+    def test_draw_order_int(self) -> None:
+        o = overlays._Overlay(name="An Overlay")
+        o.draw_order = 1
+        assert o.draw_order == "1"
+
+    def test_draw_order_none(self) -> None:
+        o = overlays._Overlay(name="An Overlay")
+        o.draw_order = "1"
+        assert o.draw_order == "1"
+        o.draw_order = None
+        assert o.draw_order is None
+
+    def test_draw_order_value_error(self) -> None:
+        o = overlays._Overlay(name="An Overlay")
+        with pytest.raises(ValueError):
+            o.draw_order = object()
+
+    def test_icon_raise_exception(self) -> None:
+        o = overlays._Overlay(name="An Overlay")
+        with pytest.raises(ValueError):
+            o.icon = 12345
+
+
+class TestGroundOverlay(StdLibrary):
+    def test_altitude_int(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.altitude = 123
+        assert go.altitude == "123"
+
+    def test_altitude_float(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.altitude = 123.4
+        assert go.altitude == "123.4"
+
+    def test_altitude_string(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.altitude = "123"
+        assert go.altitude == "123"
+
+    def test_altitude_value_error(self) -> None:
+        go = overlays.GroundOverlay()
+
+        with pytest.raises(ValueError):
+            go.altitude = object()
+
+    def test_altitude_none(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.altitude = "123"
+        assert go.altitude == "123"
+        go.altitude = None
+        assert go.altitude is None
+
+    def test_altitude_mode_default(self) -> None:
+        go = overlays.GroundOverlay()
+
+        assert go.altitude_mode == "clampToGround"
+
+    def test_altitude_mode_error(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.altitude_mode = ""
+        assert go.altitude_mode == "clampToGround"
+
+    def test_altitude_mode_clamp(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.altitude_mode = "clampToGround"
+        assert go.altitude_mode == "clampToGround"
+
+    def test_altitude_mode_absolute(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.altitude_mode = "absolute"
+        assert go.altitude_mode == "absolute"
+
+    def test_latlonbox_function(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.lat_lon_box(10, 20, 30, 40, 50)
+
+        assert go.north == "10"
+        assert go.south == "20"
+        assert go.east == "30"
+        assert go.west == "40"
+        assert go.rotation == "50"
+
+    def test_latlonbox_string(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.north = "10"
+        go.south = "20"
+        go.east = "30"
+        go.west = "40"
+        go.rotation = "50"
+
+        assert go.north == "10"
+        assert go.south == "20"
+        assert go.east == "30"
+        assert go.west == "40"
+        assert go.rotation == "50"
+
+    def test_latlonbox_int(self) -> None:
+        go = overlays.GroundOverlay()
+
+        go.north = 10
+        go.south = 20
+        go.east = 30
+        go.west = 40
+        go.rotation = 50
+
+        assert go.north == "10"
+        assert go.south == "20"
+        assert go.east == "30"
+        assert go.west == "40"
+        assert go.rotation == "50"
+
+    def test_latlonbox_float(self) -> None:
+        go = overlays.GroundOverlay()
+        go.north = 10.0
+        go.south = 20.0
+        go.east = 30.0
+        go.west = 40.0
+        go.rotation = 50.0
+
+        assert go.north == "10.0"
+        assert go.south == "20.0"
+        assert go.east == "30.0"
+        assert go.west == "40.0"
+        assert go.rotation == "50.0"
+
+    def test_latlonbox_value_error(self) -> None:
+        go = overlays.GroundOverlay()
+        with pytest.raises(ValueError):
+            go.north = object()
+
+        with pytest.raises(ValueError):
+            go.south = object()
+
+        with pytest.raises(ValueError):
+            go.east = object()
+
+        with pytest.raises(ValueError):
+            go.west = object()
+
+        with pytest.raises(ValueError):
+            go.rotation = object()
+
+        assert go.north is None
+        assert go.south is None
+        assert go.east is None
+        assert go.west is None
+        assert go.rotation is None
+
+    def test_latlonbox_empty_string(self) -> None:
+        go = overlays.GroundOverlay()
+        go.north = ""
+        go.south = ""
+        go.east = ""
+        go.west = ""
+        go.rotation = ""
+
+        assert not go.north
+        assert not go.south
+        assert not go.east
+        assert not go.west
+        assert not go.rotation
+
+    def test_latlonbox_none(self) -> None:
+        go = overlays.GroundOverlay()
+        go.north = None
+        go.south = None
+        go.east = None
+        go.west = None
+        go.rotation = None
+
+        assert go.north is None
+        assert go.south is None
+        assert go.east is None
+        assert go.west is None
+        assert go.rotation is None
+
+
+class TestGroundOverlayString(StdLibrary):
+    def test_default_to_string(self) -> None:
+        g = overlays.GroundOverlay()
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "</kml:GroundOverlay>",
+        )
+        assert g.to_string() == expected.to_string()
+
+    def test_to_string(self) -> None:
+        g = overlays.GroundOverlay()
+        icon = links.Icon(href="http://example.com")
+        g.icon = icon
+        g.draw_order = 1
+        g.color = "00010203"
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:color>00010203</kml:color>"
+            "<kml:drawOrder>1</kml:drawOrder>"
+            "<kml:Icon>"
+            "<kml:href>http://example.com</kml:href>"
+            "</kml:Icon>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_altitude_from_int(self) -> None:
+        g = overlays.GroundOverlay()
+        g.altitude = 123
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:altitude>123</kml:altitude>"
+            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_altitude_from_float(self) -> None:
+        g = overlays.GroundOverlay()
+        g.altitude = 123.4
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:altitude>123.4</kml:altitude>"
+            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_altitude_from_string(self) -> None:
+        g = overlays.GroundOverlay()
+        g.altitude = "123.4"
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:altitude>123.4</kml:altitude>"
+            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_altitude_mode_absolute(self) -> None:
+        g = overlays.GroundOverlay()
+        g.altitude = "123.4"
+        g.altitude_mode = "absolute"
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:altitude>123.4</kml:altitude>"
+            "<kml:altitudeMode>absolute</kml:altitudeMode>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_altitude_mode_unknown_string(self) -> None:
+        g = overlays.GroundOverlay()
+        g.altitude = "123.4"
+        g.altitudeMode = "unknown string"
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:altitude>123.4</kml:altitude>"
+            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_altitude_mode_value(self) -> None:
+        g = overlays.GroundOverlay()
+        g.altitude = "123.4"
+        g.altitudeMode = 1234
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:altitude>123.4</kml:altitude>"
+            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_latlonbox_no_rotation(self) -> None:
+        g = overlays.GroundOverlay()
+        g.lat_lon_box(10, 20, 30, 40)
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:LatLonBox>"
+            "<kml:north>10</kml:north>"
+            "<kml:south>20</kml:south>"
+            "<kml:east>30</kml:east>"
+            "<kml:west>40</kml:west>"
+            "<kml:rotation>0</kml:rotation>"
+            "</kml:LatLonBox>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_latlonbox_rotation(self) -> None:
+        g = overlays.GroundOverlay()
+        g.lat_lon_box(10, 20, 30, 40, 50)
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:LatLonBox>"
+            "<kml:north>10</kml:north>"
+            "<kml:south>20</kml:south>"
+            "<kml:east>30</kml:east>"
+            "<kml:west>40</kml:west>"
+            "<kml:rotation>50</kml:rotation>"
+            "</kml:LatLonBox>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+    def test_latlonbox_nswer(self) -> None:
+        g = overlays.GroundOverlay()
+        g.north = 10
+        g.south = 20
+        g.east = 30
+        g.west = 40
+        g.rotation = 50
+
+        expected = overlays.GroundOverlay()
+        expected.from_string(
+            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
+            "<kml:LatLonBox>"
+            "<kml:north>10</kml:north>"
+            "<kml:south>20</kml:south>"
+            "<kml:east>30</kml:east>"
+            "<kml:west>40</kml:west>"
+            "<kml:rotation>50</kml:rotation>"
+            "</kml:LatLonBox>"
+            "</kml:GroundOverlay>",
+        )
+
+        assert g.to_string() == expected.to_string()
+
+
+class TestPhotoOverlay(StdLibrary):
+    def test_camera_altitude_int(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        po.view.altitude = 123
+        assert po.view.altitude == 123
+
+    def test_camera_altitude_float(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        po.view.altitude = 123.4
+        assert po.view.altitude == 123.4
+
+    def test_camera_altitude_string(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        po.view.altitude = 123
+        assert po.view.altitude == 123
+
+    def test_camera_altitude_value_error(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        with pytest.raises(ValueError):
+            po.view.altitude = object()
+
+    def test_camera_altitude_none(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        po.view.altitude = 123
+        assert po.view.altitude == 123
+        po.view.altitude = None
+        assert po.view.altitude is None
+
+    def test_camera_altitude_mode_default(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        assert po.view.altitude_mode == AltitudeMode("relativeToGround")
+
+    def test_camera_altitude_mode_clamp(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        po.view.altitude_mode = AltitudeMode("clampToGround")
+        assert po.view.altitude_mode == AltitudeMode("clampToGround")
+
+    def test_camera_altitude_mode_absolute(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        po.view.altitude_mode = "absolute"
+        assert po.view.altitude_mode == "absolute"
+
+    def test_camera_initialization(self) -> None:
+        po = overlays.PhotoOverlay(view=views.Camera())
+        po.view = views.Camera(
+            longitude=10,
+            latitude=20,
+            altitude=30,
+            heading=40,
+            tilt=50,
+            roll=60,
+        )
+        assert po.view.longitude == 10
+        assert po.view.latitude == 20
+        assert po.view.altitude == 30
+        assert po.view.heading == 40
+        assert po.view.tilt == 50
+        assert po.view.roll == 60
+        assert po.view.altitude_mode == AltitudeMode("relativeToGround")
+
+
+class TestBaseOverlayLxml(Lxml, TestBaseOverlay):
+    """Test with lxml."""
+
+
+class TestGroundOverlayLxml(Lxml, TestGroundOverlay):
+    """Test with lxml."""
+
+
+class TestGroundOverlayStringLxml(Lxml, TestGroundOverlay):
+    """Test with lxml."""
+
+
+class TestPhotoOverlayLxml(Lxml, TestPhotoOverlay):
+    """Test with lxml."""
diff --git a/tests/times_test.py b/tests/times_test.py
index 5fc46851..f986b35b 100644
--- a/tests/times_test.py
+++ b/tests/times_test.py
@@ -222,6 +222,7 @@ def test_timespan(self) -> None:
         ts.begin = None
         pytest.raises(ValueError, ts.to_string)
 
+    @pytest.mark.skip(reason="not yet implemented")
     def test_feature_timestamp(self) -> None:
         now = datetime.datetime.now()
         f = kml.Document()
@@ -236,6 +237,7 @@ def test_feature_timestamp(self) -> None:
         f.time_stamp = None
         assert "TimeStamp>" not in str(f.to_string())
 
+    @pytest.mark.skip(reason="not yet implemented")
     def test_feature_timespan(self) -> None:
         now = datetime.datetime.now()
         y2k = datetime.datetime(2000, 1, 1)
@@ -258,44 +260,6 @@ def test_feature_timespan(self) -> None:
         f.begin = None
         assert "TimeSpan>" not in str(f.to_string())
 
-    def test_feature_timespan_stamp(self) -> None:
-        now = datetime.datetime.now()
-        y2k = datetime.date(2000, 1, 1)
-        f = kml.Document()
-        f.begin = KmlDateTime(y2k)
-        f.end = KmlDateTime(now)
-        assert now.isoformat() in str(f.to_string())
-        assert "2000-01-01" in str(f.to_string())
-        assert "TimeSpan>" in str(f.to_string())
-        assert "begin>" in str(f.to_string())
-        assert "end>" in str(f.to_string())
-        assert "TimeStamp>" not in str(f.to_string())
-        assert "when>" not in str(f.to_string())
-        # when we set a timestamp an existing timespan will be deleted
-        f.time_stamp = KmlDateTime(now)
-        assert now.isoformat() in str(f.to_string())
-        assert "TimeStamp>" in str(f.to_string())
-        assert "when>" in str(f.to_string())
-        assert "2000-01-01" not in str(f.to_string())
-        assert "TimeSpan>" not in str(f.to_string())
-        assert "begin>" not in str(f.to_string())
-        assert "end>" not in str(f.to_string())
-        # when we set a timespan an existing timestamp will be deleted
-        f.end = y2k
-        assert now.isoformat() not in str(f.to_string())
-        assert "2000-01-01" in str(f.to_string())
-        assert "TimeSpan>" in str(f.to_string())
-        assert "begin>" not in str(f.to_string())
-        assert "end>" in str(f.to_string())
-        assert "TimeStamp>" not in str(f.to_string())
-        assert "when>" not in str(f.to_string())
-        # We manipulate our Feature so it has timespan and stamp
-        ts = kml.TimeStamp(timestamp=now)
-        f._timestamp = ts
-        # this raises an exception as only either timespan or timestamp
-        # are allowed not both
-        pytest.raises(ValueError, f.to_string)
-
     def test_read_timestamp_year(self) -> None:
         doc = """
         <TimeStamp>
diff --git a/tests/views_test.py b/tests/views_test.py
index 4a9cd8f2..ace14449 100644
--- a/tests/views_test.py
+++ b/tests/views_test.py
@@ -131,7 +131,7 @@ def test_create_look_at(self) -> None:
         assert look_at.longitude == 60
         assert look_at.id == "look-at-id"
         assert look_at.target_id == "target-look-at-id"
-        assert look_at._timestamp.timestamp.dt == datetime.datetime(
+        assert look_at._times.timestamp.dt == datetime.datetime(
             2019,
             1,
             1,
@@ -166,7 +166,7 @@ def test_look_at_read(self) -> None:
         assert look_at.longitude == 60
         assert look_at.id == "look-at-id"
         assert look_at.target_id == "target-look-at-id"
-        assert look_at._timestamp.timestamp.dt == datetime.datetime(
+        assert look_at._times.timestamp.dt == datetime.datetime(
             2019,
             1,
             1,

From 773c45ad60087709d9adaf4269e7a2a8cd0ef625 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Wed, 22 Nov 2023 20:08:39 +0000
Subject: [PATCH 07/25] Add Region class to fastkml.views.py #20 #212

---
 fastkml/features.py |  18 +++--
 fastkml/views.py    | 185 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 195 insertions(+), 8 deletions(-)

diff --git a/fastkml/features.py b/fastkml/features.py
index 3c909035..fd7bf5d3 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -34,6 +34,7 @@
 from fastkml.types import Element
 from fastkml.views import Camera
 from fastkml.views import LookAt
+from fastkml.views import Region
 
 logger = logging.getLogger(__name__)
 
@@ -156,19 +157,20 @@ def __init__(
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         name: Optional[str] = None,
-        description: Optional[str] = None,
-        snippet: Optional[Union[str, Dict[str, Any]]] = None,
-        atom_author: Optional[atom.Author] = None,
-        atom_link: Optional[atom.Link] = None,
         visibility: Optional[bool] = None,
         isopen: Optional[bool] = None,
-        styles: Optional[List[Style]] = None,
-        style_url: Optional[str] = None,
-        extended_data: None = None,
-        view: Optional[Union[Camera, LookAt]] = None,
+        atom_link: Optional[atom.Link] = None,
+        atom_author: Optional[atom.Author] = None,
         address: Optional[str] = None,
         phone_number: Optional[str] = None,
+        snippet: Optional[Union[str, Dict[str, Any]]] = None,
+        description: Optional[str] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
+        style_url: Optional[str] = None,
+        styles: Optional[List[Style]] = None,
+        region: Optional[Region] = None,
+        extended_data: None = None,
     ) -> None:
         super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
         self.name = name
diff --git a/fastkml/views.py b/fastkml/views.py
index dd178a73..ca161da1 100644
--- a/fastkml/views.py
+++ b/fastkml/views.py
@@ -1,4 +1,5 @@
 import logging
+from dataclasses import dataclass
 from typing import Any
 from typing import Dict
 from typing import Optional
@@ -464,7 +465,191 @@ def _get_kwargs(
         return kwargs
 
 
+@dataclass(frozen=True)
+class LatLonAltBox:
+    """
+    A bounding box defined by geographic coordinates and altitudes.
+
+    https://developers.google.com/kml/documentation/kmlreference#latlonaltbox
+    """
+
+    north: float
+    south: float
+    east: float
+    west: float
+    min_altitude: Optional[float]
+    max_altitude: Optional[float]
+    altitude_mode: Optional[AltitudeMode]
+
+    def etree_element(
+        self,
+        *,
+        ns: str,
+        precision: Optional[int],
+        verbosity: Verbosity,
+    ) -> Element:
+        element = config.etree.Element(  # type: ignore[attr-defined]
+            f"{ns}LatLonAltBox",
+        )
+        north = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{ns}north",
+        )
+        north.text = str(self.north)
+        south = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{ns}south",
+        )
+        south.text = str(self.south)
+        east = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{ns}east",
+        )
+        east.text = str(self.east)
+        west = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{ns}west",
+        )
+        west.text = str(self.west)
+        if self.min_altitude is not None:
+            min_altitude = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{ns}minAltitude",
+            )
+            min_altitude.text = str(self.min_altitude)
+        if self.max_altitude is not None:
+            max_altitude = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{ns}maxAltitude",
+            )
+            max_altitude.text = str(self.max_altitude)
+        if self.altitude_mode:
+            altitude_mode = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{ns}altitudeMode",
+            )
+            altitude_mode.text = self.altitude_mode.value
+        return element
+
+
+@dataclass(frozen=True)
+class Lod:
+    """
+    Lod is an abbreviation for Level of Detail.
+    <Lod> describes the size of the projected region on the screen that is required in
+    order for the region to be considered "active."
+    Also specifies the size of the pixel ramp used for fading in
+    (from transparent to opaque) and fading out (from opaque to transparent).
+
+    https://developers.google.com/kml/documentation/kmlreference#elements-specific-to-region
+    """
+
+    min_lod_pixels: float
+    max_lod_pixels: float
+    min_fade_extent: float
+    max_fade_extent: float
+
+    def etree_element(
+        self,
+        *,
+        ns: str,
+        precision: Optional[int],
+        verbosity: Verbosity,
+    ) -> Element:
+        element = config.etree.Element(f"{ns}Lod")  # type: ignore[attr-defined]
+        min_lod = config.etree.SubElement(  # type: ignore[attr-defined]
+            f"{ns}minLodPixels",
+        )
+        min_lod.text = str(self.min_lod_pixels)
+        max_lod = config.etree.SubElement(  # type: ignore[attr-defined]
+            f"{ns}maxLodPixels",
+        )
+        max_lod.text = str(self.max_lod_pixels)
+        min_fade = config.etree.SubElement(  # type: ignore[attr-defined]
+            f"{ns}minFadeExtent",
+        )
+        min_fade.text = str(self.min_fade_extent)
+        max_fade = config.etree.SubElement(  # type: ignore[attr-defined]
+            f"{ns}maxFadeExtent",
+        )
+        max_fade.text = str(self.max_fade_extent)
+        return element
+
+
+class Region(_BaseObject):
+    """
+    A <Region> contains a bounding box (<LatLonAltBox>) that describes an area of
+    interest defined by geographic coordinates and altitudes.
+
+    In addition, a Region contains an LOD (level of detail) extent (<Lod>),
+    which is a pair of projected coordinate bounding boxes that describe
+    the area that should be loaded in the viewport corresponding to a given
+    level of detail.
+
+    https://developers.google.com/kml/documentation/kmlreference#region
+    """
+
+    __name__ = "Region"
+
+    _lat_lon_alt_box: Optional[LatLonAltBox] = None
+    _lod: Optional[Lod] = None
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        lat_lon_alt_box: Optional[LatLonAltBox] = None,
+        lod: Optional[Lod] = None,
+    ) -> None:
+        super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
+        self._lat_lon_alt_box = lat_lon_alt_box
+        self._lod = lod
+
+    @property
+    def lat_lon_alt_box(self) -> Optional[LatLonAltBox]:
+        return self._lat_lon_alt_box
+
+    @lat_lon_alt_box.setter
+    def lat_lon_alt_box(self, value: LatLonAltBox) -> None:
+        self._lat_lon_alt_box = value
+
+    @property
+    def lod(self) -> Optional[Lod]:
+        return self._lod
+
+    @lod.setter
+    def lod(self, value: Lod) -> None:
+        self._lod = value
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        if self.lat_lon_alt_box:
+            element.append(
+                self.lat_lon_alt_box.etree_element(
+                    ns=self.ns,
+                    precision=precision,
+                    verbosity=verbosity,
+                ),
+            )
+        if self.lod:
+            element.append(
+                self.lod.etree_element(
+                    ns=self.ns,
+                    precision=precision,
+                    verbosity=verbosity,
+                ),
+            )
+        return element
+
+
 __all__ = [
     "Camera",
     "LookAt",
+    "Region",
 ]

From 42e5061180984d6ee1db750f3bd65aed2a554779 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Thu, 23 Nov 2023 11:42:22 +0000
Subject: [PATCH 08/25] implement Region, Link and NetworkLink fixes #212
 closes #20

---
 fastkml/containers.py |   4 +-
 fastkml/features.py   | 195 ++++++++++++++++++++++++++++++++----------
 fastkml/links.py      |  36 +++++---
 fastkml/overlays.py   |   4 +-
 4 files changed, 174 insertions(+), 65 deletions(-)

diff --git a/fastkml/containers.py b/fastkml/containers.py
index b0285a6c..e467734b 100644
--- a/fastkml/containers.py
+++ b/fastkml/containers.py
@@ -1,6 +1,4 @@
-"""
-Container classes for KML elements.
-"""
+"""Container classes for KML elements."""
 import logging
 import urllib.parse as urlparse
 from typing import Dict
diff --git a/fastkml/features.py b/fastkml/features.py
index fd7bf5d3..49135eec 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -24,6 +24,7 @@
 from fastkml.geometry import MultiGeometry
 from fastkml.geometry import Point
 from fastkml.geometry import Polygon
+from fastkml.links import Link
 from fastkml.mixins import TimeMixin
 from fastkml.styles import Style
 from fastkml.styles import StyleMap
@@ -133,11 +134,11 @@ class _Feature(TimeMixin, _BaseObject):
 
     _view: Union[Camera, LookAt, None]
 
-    # TODO Region = None
+    region: Optional[Region]
     # Features and geometry associated with a Region are drawn only when
     # the Region is active.
 
-    # TODO ExtendedData = None
+    extended_data: Optional[ExtendedData]
     # Allows you to add custom data to a KML file. This data can be
     # (1) data that references an external XML schema,
     # (2) untyped data/value pairs, or
@@ -148,7 +149,6 @@ class _Feature(TimeMixin, _BaseObject):
     # (2) is already implemented, see UntypedExtendedData
     #
     # <Metadata> (deprecated in KML 2.2; use <ExtendedData> instead)
-    extended_data: Optional[ExtendedData]
 
     def __init__(
         self,
@@ -170,7 +170,7 @@ def __init__(
         style_url: Optional[str] = None,
         styles: Optional[List[Style]] = None,
         region: Optional[Region] = None,
-        extended_data: None = None,
+        extended_data: Optional[ExtendedData] = None,
     ) -> None:
         super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
         self.name = name
@@ -185,6 +185,7 @@ def __init__(
         self._atom_link = atom_link
         self.address = address
         self.phone_number = phone_number
+        self.region = region
         if styles:
             for style in styles:
                 self.append_style(style)
@@ -495,7 +496,7 @@ class Placemark(_Feature):
     """
 
     __name__ = "Placemark"
-    _geometry = None
+    _geometry: Optional[KmlGeometry]
 
     def __init__(
         self,
@@ -504,10 +505,21 @@ def __init__(
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         name: Optional[str] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
+        atom_link: Optional[atom.Link] = None,
+        atom_author: Optional[atom.Author] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
+        snippet: Optional[Union[str, Dict[str, Any]]] = None,
         description: Optional[str] = None,
-        styles: Optional[List[Style]] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
+        times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[str] = None,
-        extended_data: None = None,
+        styles: Optional[List[Style]] = None,
+        region: Optional[Region] = None,
+        extended_data: Optional[ExtendedData] = None,
+        # Placemark specific
         geometry: Optional[KmlGeometry] = None,
     ) -> None:
         super().__init__(
@@ -516,9 +528,19 @@ def __init__(
             id=id,
             target_id=target_id,
             name=name,
+            visibility=visibility,
+            isopen=isopen,
+            atom_link=atom_link,
+            atom_author=atom_author,
+            address=address,
+            phone_number=phone_number,
+            snippet=snippet,
             description=description,
-            styles=styles,
+            view=view,
+            times=times,
             style_url=style_url,
+            styles=styles,
+            region=region,
             extended_data=extended_data,
         )
         self._geometry = geometry
@@ -604,55 +626,136 @@ def etree_element(
 
 
 class NetworkLink(_Feature):
+    """
+    References a KML file or KMZ archive on a local or remote network.
+
+    Use the <Link> element to specify the location of the KML file.
+    Within that element, you can define the refresh options for updating the file,
+    based on time and camera change.
+    NetworkLinks can be used in combination with Regions to handle very large datasets
+    efficiently.
+    https://developers.google.com/kml/documentation/kmlreference#networklink
+
+
+    Elements Specific to NetworkLink
+    <refreshVisibility>
+    Boolean value.
+    A value of 0 leaves the visibility of features within the control of the
+    Google Earth user.
+    Set the value to 1 to reset the visibility of features each time the NetworkLink is
+    refreshed.
+    For example, suppose a Placemark within the linked KML file has <visibility>
+    set to 1 and the NetworkLink has <refreshVisibility> set to 1.
+    When the file is first loaded into Google Earth, the user can clear the check box
+    next to the item to turn off display in the 3D viewer.
+    However, when the NetworkLink is refreshed, the Placemark will be made
+    visible again, since its original visibility state was TRUE.
+    <flyToView>
+    Boolean value.
+    A value of 1 causes Google Earth to fly to the view of the LookAt or Camera in the
+    NetworkLinkControl (if it exists).
+    If the NetworkLinkControl does not contain an AbstractView element,
+    Google Earth flies to the LookAt or Camera element in the Feature child
+    within the <kml> element in the refreshed file.
+    If the <kml> element does not have a LookAt or Camera specified,
+    the view is unchanged.
+    For example, Google Earth would fly to the <LookAt> view of the parent Document,
+    not the <LookAt> of the Placemarks contained within the Document.
+    <Link>(required)
+       https://developers.google.com/kml/documentation/kmlreference#link
+    """
+
+    refresh_visibility: Optional[bool]
+    fly_to_view: Optional[bool]
+    link: Optional[Link]
+
     __name__ = "NetworkLink"
-    _nlink = None
 
     def __init__(
         self,
-        ns=None,
-        id=None,
-        name=None,
-        description=None,
-        styles=None,
-        styleUrl=None,
-    ):
-        super().__init__(ns, id, name, description, styles, styleUrl)
-
-    @property
-    def link(self):
-        return self._nlink.href
-
-    @link.setter
-    def link(self, url):
-        if isinstance(url, basestring):
-            self._nlink = atom.Link(href=url)
-        elif isinstance(url, Link):
-            self._nlink = url
-        elif url is None:
-            self._nlink = None
-        else:
-            raise TypeError
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        name: Optional[str] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
+        atom_link: Optional[atom.Link] = None,
+        atom_author: Optional[atom.Author] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
+        snippet: Optional[Union[str, Dict[str, Any]]] = None,
+        description: Optional[str] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
+        times: Optional[Union[TimeSpan, TimeStamp]] = None,
+        style_url: Optional[str] = None,
+        styles: Optional[List[Style]] = None,
+        region: Optional[Region] = None,
+        extended_data: Optional[ExtendedData] = None,
+        # NetworkLink specific
+        refresh_visibility: Optional[bool] = None,
+        fly_to_view: Optional[bool] = None,
+        link: Optional[Link] = None,
+    ) -> None:
+        super().__init__(
+            ns=ns,
+            name_spaces=name_spaces,
+            id=id,
+            target_id=target_id,
+            name=name,
+            visibility=visibility,
+            isopen=isopen,
+            atom_link=atom_link,
+            atom_author=atom_author,
+            address=address,
+            phone_number=phone_number,
+            snippet=snippet,
+            description=description,
+            view=view,
+            times=times,
+            style_url=style_url,
+            styles=styles,
+            region=region,
+            extended_data=extended_data,
+        )
+        self.refresh_visibility = refresh_visibility
+        self.fly_to_view = fly_to_view
+        self.link = link
 
     def etree_element(self):
         element = super().etree_element()
-        if self._nlink is not None:
-            element.append(self._nlink.etree_element())
+        if self.refresh_visibility is not None:
+            refresh_visibility = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}refreshVisibility",
+            )
+            refresh_visibility.text = str(int(self.refresh_visibility))
+
+        if self.fly_to_view is not None:
+            fly_to_view = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}flyToView",
+            )
+            fly_to_view.text = str(int(self.fly_to_view))
+        if self.link is not None:
+            element.append(self.link.etree_element())
         return element
 
-    def from_element(self, element):
+    def from_element(self, element, strict=False):
         super(_Feature, self).from_element(element)
-        name = element.find(f"{self.ns}name")
-        if name is not None:
-            self.name = name.text
-        id = element.find(f"{self.ns}id")
-        if id is not None:
-            self.id = id.text
-        visibility = element.find(f"{self.ns}visibility")
+
+        visibility = element.find(f"{self.ns}refreshVisibility")
         if visibility is not None:
-            self.visibility = visibility.text
+            self.visibility = bool(int(visibility.text))
+        flyto = element.find(f"{self.ns}flyToView")
+        if flyto is not None:
+            self.fly_to_view = bool(int(flyto.text))
 
         link = element.find(f"{self.ns}Link")
         if link is not None:
-            s = Link()
-            s.from_element(link)
-            self._nlink = s
+            self.link = Link.class_from_element(
+                ns=self.ns,
+                name_spaces=self.name_spaces,
+                element=link,
+                strict=strict,
+            )
diff --git a/fastkml/links.py b/fastkml/links.py
index 4a70bfad..50cd1dfe 100644
--- a/fastkml/links.py
+++ b/fastkml/links.py
@@ -27,23 +27,14 @@
 from fastkml.types import Element
 
 
-class Icon(_BaseObject):
+class Link(_BaseObject):
     """
-    Represents an <Icon> element used in Overlays.
-
-    Defines an image associated with an Icon style or overlay.
-    The required <href> child element defines the location
-    of the image to be used as the overlay or as the icon for the placemark.
-    This location can either be on a local file system or a remote web server.
+    Represents a <Link> element.
 
-    Todo:
-    ----
-    The <gx:x>, <gx:y>, <gx:w>, and <gx:h> elements are used to select one
-    icon from an image that contains multiple icons
-    (often referred to as an icon palette).
+    A URL can be passed to the constructor, or the href can be set later.
     """
 
-    __name__ = "Icon"
+    __name__ = "Link"
 
     _href: Optional[str]
     _refresh_mode: Optional[RefreshMode]
@@ -316,3 +307,22 @@ def _get_kwargs(
         if http_query is not None:
             kwargs["http_query"] = http_query.text
         return kwargs
+
+
+class Icon(Link):
+    """
+    Represents an <Icon> element used in Overlays.
+
+    Defines an image associated with an Icon style or overlay.
+    The required <href> child element defines the location
+    of the image to be used as the overlay or as the icon for the placemark.
+    This location can either be on a local file system or a remote web server.
+
+    Todo:
+    ----
+    The <gx:x>, <gx:y>, <gx:w>, and <gx:h> elements are used to select one
+    icon from an image that contains multiple icons
+    (often referred to as an icon palette).
+    """
+
+    __name__ = "Icon"
diff --git a/fastkml/overlays.py b/fastkml/overlays.py
index 8565bb31..f966581b 100644
--- a/fastkml/overlays.py
+++ b/fastkml/overlays.py
@@ -1,6 +1,4 @@
-"""
-Overlays.
-"""
+"""Overlays."""
 
 import logging
 from typing import Any

From 262050a0f164c3e4d4acacab15fb16a8dd793a7b Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Thu, 23 Nov 2023 13:18:37 +0000
Subject: [PATCH 09/25] LatLonBox and Lod inherit from _XMLObject

---
 fastkml/views.py | 192 +++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 162 insertions(+), 30 deletions(-)

diff --git a/fastkml/views.py b/fastkml/views.py
index ca161da1..27b8ecbd 100644
--- a/fastkml/views.py
+++ b/fastkml/views.py
@@ -1,5 +1,4 @@
 import logging
-from dataclasses import dataclass
 from typing import Any
 from typing import Dict
 from typing import Optional
@@ -9,6 +8,7 @@
 
 from fastkml import config
 from fastkml.base import _BaseObject
+from fastkml.base import _XMLObject
 from fastkml.enums import AltitudeMode
 from fastkml.enums import Verbosity
 from fastkml.mixins import TimeMixin
@@ -465,8 +465,7 @@ def _get_kwargs(
         return kwargs
 
 
-@dataclass(frozen=True)
-class LatLonAltBox:
+class LatLonAltBox(_XMLObject):
     """
     A bounding box defined by geographic coordinates and altitudes.
 
@@ -481,59 +480,113 @@ class LatLonAltBox:
     max_altitude: Optional[float]
     altitude_mode: Optional[AltitudeMode]
 
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        north: float = 0.0,
+        south: float = 0.0,
+        east: float = 0.0,
+        west: float = 0.0,
+        min_altitude: Optional[float] = None,
+        max_altitude: Optional[float] = None,
+        altitude_mode: Optional[AltitudeMode] = None,
+    ) -> None:
+        super().__init__(ns=ns, name_spaces=name_spaces)
+        self.north = north
+        self.south = south
+        self.east = east
+        self.west = west
+        self.min_altitude = min_altitude
+        self.max_altitude = max_altitude
+        self.altitude_mode = altitude_mode
+
     def etree_element(
         self,
-        *,
-        ns: str,
-        precision: Optional[int],
-        verbosity: Verbosity,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
     ) -> Element:
-        element = config.etree.Element(  # type: ignore[attr-defined]
-            f"{ns}LatLonAltBox",
-        )
+        element = super().etree_element(precision=precision, verbosity=verbosity)
         north = config.etree.SubElement(  # type: ignore[attr-defined]
             element,
-            f"{ns}north",
+            f"{self.ns}north",
         )
         north.text = str(self.north)
         south = config.etree.SubElement(  # type: ignore[attr-defined]
             element,
-            f"{ns}south",
+            f"{self.ns}south",
         )
         south.text = str(self.south)
         east = config.etree.SubElement(  # type: ignore[attr-defined]
             element,
-            f"{ns}east",
+            f"{self.ns}east",
         )
         east.text = str(self.east)
         west = config.etree.SubElement(  # type: ignore[attr-defined]
             element,
-            f"{ns}west",
+            f"{self.ns}west",
         )
         west.text = str(self.west)
         if self.min_altitude is not None:
             min_altitude = config.etree.SubElement(  # type: ignore[attr-defined]
                 element,
-                f"{ns}minAltitude",
+                f"{self.ns}minAltitude",
             )
             min_altitude.text = str(self.min_altitude)
         if self.max_altitude is not None:
             max_altitude = config.etree.SubElement(  # type: ignore[attr-defined]
                 element,
-                f"{ns}maxAltitude",
+                f"{self.ns}maxAltitude",
             )
             max_altitude.text = str(self.max_altitude)
         if self.altitude_mode:
             altitude_mode = config.etree.SubElement(  # type: ignore[attr-defined]
                 element,
-                f"{ns}altitudeMode",
+                f"{self.ns}altitudeMode",
             )
             altitude_mode.text = self.altitude_mode.value
         return element
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        north = element.find(f"{ns}north")
+        if north is not None:
+            kwargs["north"] = float(north.text)
+        south = element.find(f"{ns}south")
+        if south is not None:
+            kwargs["south"] = float(south.text)
+        east = element.find(f"{ns}east")
+        if east is not None:
+            kwargs["east"] = float(east.text)
+        west = element.find(f"{ns}west")
+        if west is not None:
+            kwargs["west"] = float(west.text)
+        min_altitude = element.find(f"{ns}minAltitude")
+        if min_altitude is not None:
+            kwargs["min_altitude"] = float(min_altitude.text)
+        max_altitude = element.find(f"{ns}maxAltitude")
+        if max_altitude is not None:
+            kwargs["max_altitude"] = float(max_altitude.text)
+        altitude_mode = element.find(f"{ns}altitudeMode")
+        if altitude_mode is not None:
+            kwargs["altitude_mode"] = AltitudeMode(altitude_mode.text)
+        return kwargs
+
 
-@dataclass(frozen=True)
-class Lod:
+class Lod(_XMLObject):
     """
     Lod is an abbreviation for Level of Detail.
     <Lod> describes the size of the projected region on the screen that is required in
@@ -549,32 +602,74 @@ class Lod:
     min_fade_extent: float
     max_fade_extent: float
 
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        min_lod_pixels: float = 0.0,
+        max_lod_pixels: float = -1.0,
+        min_fade_extent: float = 0.0,
+        max_fade_extent: float = 0.0,
+    ) -> None:
+        super().__init__(ns=ns, name_spaces=name_spaces)
+        self.min_lod_pixels = min_lod_pixels
+        self.max_lod_pixels = max_lod_pixels
+        self.min_fade_extent = min_fade_extent
+        self.max_fade_extent = max_fade_extent
+
     def etree_element(
         self,
-        *,
-        ns: str,
-        precision: Optional[int],
-        verbosity: Verbosity,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
     ) -> Element:
-        element = config.etree.Element(f"{ns}Lod")  # type: ignore[attr-defined]
+        element = super().etree_element(precision=precision, verbosity=verbosity)
         min_lod = config.etree.SubElement(  # type: ignore[attr-defined]
-            f"{ns}minLodPixels",
+            f"{self.ns}minLodPixels",
         )
         min_lod.text = str(self.min_lod_pixels)
         max_lod = config.etree.SubElement(  # type: ignore[attr-defined]
-            f"{ns}maxLodPixels",
+            f"{self.ns}maxLodPixels",
         )
         max_lod.text = str(self.max_lod_pixels)
         min_fade = config.etree.SubElement(  # type: ignore[attr-defined]
-            f"{ns}minFadeExtent",
+            f"{self.ns}minFadeExtent",
         )
         min_fade.text = str(self.min_fade_extent)
         max_fade = config.etree.SubElement(  # type: ignore[attr-defined]
-            f"{ns}maxFadeExtent",
+            f"{self.ns}maxFadeExtent",
         )
         max_fade.text = str(self.max_fade_extent)
         return element
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        min_lod = element.find(f"{ns}minLodPixels")
+        if min_lod is not None:
+            kwargs["min_lod_pixels"] = float(min_lod.text)
+        max_lod = element.find(f"{ns}maxLodPixels")
+        if max_lod is not None:
+            kwargs["max_lod_pixels"] = float(max_lod.text)
+        min_fade = element.find(f"{ns}minFadeExtent")
+        if min_fade is not None:
+            kwargs["min_fade_extent"] = float(min_fade.text)
+        max_fade = element.find(f"{ns}maxFadeExtent")
+        if max_fade is not None:
+            kwargs["max_fade_extent"] = float(max_fade.text)
+        return kwargs
+
 
 class Region(_BaseObject):
     """
@@ -632,7 +727,6 @@ def etree_element(
         if self.lat_lon_alt_box:
             element.append(
                 self.lat_lon_alt_box.etree_element(
-                    ns=self.ns,
                     precision=precision,
                     verbosity=verbosity,
                 ),
@@ -640,13 +734,51 @@ def etree_element(
         if self.lod:
             element.append(
                 self.lod.etree_element(
-                    ns=self.ns,
                     precision=precision,
                     verbosity=verbosity,
                 ),
             )
         return element
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        lat_lon_alt_box = element.find(f"{ns}LatLonAltBox")
+        if lat_lon_alt_box is not None:
+            kwargs["lat_lon_alt_box"] = cast(
+                LatLonAltBox,
+                LatLonAltBox.class_from_element(
+                    ns=ns,
+                    name_spaces=name_spaces,
+                    element=lat_lon_alt_box,
+                    strict=strict,
+                ),
+            )
+        lod = element.find(f"{ns}Lod")
+        if lod is not None:
+            kwargs["lod"] = cast(
+                Lod,
+                Lod.class_from_element(
+                    ns=ns,
+                    name_spaces=name_spaces,
+                    element=lod,
+                    strict=strict,
+                ),
+            )
+        return kwargs
+
 
 __all__ = [
     "Camera",

From 2b64050ee7ce9c43c8205c4f16ebacad4f0e5ad2 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Thu, 23 Nov 2023 14:34:49 +0000
Subject: [PATCH 10/25] make Snippet s dataclass

---
 fastkml/features.py   | 72 +++++++++++++------------------------------
 fastkml/types.py      |  2 +-
 tests/oldunit_test.py | 18 ++++++-----
 3 files changed, 32 insertions(+), 60 deletions(-)

diff --git a/fastkml/features.py b/fastkml/features.py
index 49135eec..721f27b4 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -5,6 +5,7 @@
 """
 
 import logging
+from dataclasses import dataclass
 from typing import Any
 from typing import Dict
 from typing import Iterator
@@ -50,6 +51,12 @@
 ]
 
 
+@dataclass(frozen=True)
+class Snippet:
+    text: str
+    max_lines: Optional[int] = None
+
+
 class _Feature(TimeMixin, _BaseObject):
     """
     abstract element; do not create
@@ -95,7 +102,7 @@ class _Feature(TimeMixin, _BaseObject):
     # A string value representing a telephone number.
     # This element is used by Google Maps Mobile only.
 
-    _snippet: Optional[Union[str, Dict[str, Any]]]
+    _snippet: Optional[Snippet]
     # _snippet is either a tuple of a string Snippet.text and an integer
     # Snippet.maxLines or a string
     #
@@ -163,7 +170,7 @@ def __init__(
         atom_author: Optional[atom.Author] = None,
         address: Optional[str] = None,
         phone_number: Optional[str] = None,
-        snippet: Optional[Union[str, Dict[str, Any]]] = None,
+        snippet: Optional[Snippet] = None,
         description: Optional[str] = None,
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
@@ -274,46 +281,12 @@ def styles(self) -> Iterator[Union[Style, StyleMap]]:
                 raise TypeError
 
     @property
-    def snippet(self) -> Optional[Dict[str, Any]]:
-        if not self._snippet:
-            return None
-        if isinstance(self._snippet, dict):
-            text = self._snippet.get("text")
-            if text:
-                assert isinstance(text, str)
-                max_lines = self._snippet.get("maxLines", None)
-                if max_lines is None:
-                    return {"text": text}
-                elif int(max_lines) > 0:
-                    # if maxLines <=0 ignore it
-                    return {"text": text, "maxLines": max_lines}
-                return None
-            return None
-        elif isinstance(self._snippet, str):
-            return self._snippet
-        else:
-            msg = "Snippet must be dict of {'text':t, 'maxLines':i} or string"
-            raise ValueError(
-                msg,
-            )
+    def snippet(self) -> Optional[Snippet]:
+        return self._snippet
 
     @snippet.setter
-    def snippet(self, snip=None) -> None:
-        self._snippet = {}
-        if isinstance(snip, dict):
-            self._snippet["text"] = snip.get("text")
-            max_lines = snip.get("maxLines")
-            if max_lines is not None:
-                self._snippet["maxLines"] = int(snip["maxLines"])
-        elif isinstance(snip, str):
-            self._snippet["text"] = snip
-        elif snip is None:
-            self._snippet = None
-        else:
-            msg = "Snippet must be dict of {'text':t, 'maxLines':i} or string"
-            raise ValueError(
-                msg,
-            )
+    def snippet(self, snippet: Optional[Snippet]) -> None:
+        self._snippet = snippet
 
     @property
     def address(self) -> Optional[str]:
@@ -357,13 +330,9 @@ def etree_element(
             element.append(style.etree_element())
         if self.snippet:
             snippet = config.etree.SubElement(element, f"{self.ns}Snippet")
-            if isinstance(self.snippet, str):
-                snippet.text = self.snippet
-            else:
-                assert isinstance(self.snippet["text"], str)
-                snippet.text = self.snippet["text"]
-                if self.snippet.get("maxLines"):
-                    snippet.set("maxLines", str(self.snippet["maxLines"]))
+            snippet.text = self.snippet.text
+            if self.snippet.max_lines:
+                snippet.set("maxLines", str(self.snippet.max_lines))
         elif self._times is not None:
             element.append(self._times.etree_element())
         if self._atom_link is not None:
@@ -422,10 +391,11 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             )
         snippet = element.find(f"{self.ns}Snippet")
         if snippet is not None:
-            _snippet = {"text": snippet.text}
-            if snippet.get("maxLines"):
-                _snippet["maxLines"] = int(snippet.get("maxLines"))
-            self.snippet = _snippet
+            max_lines = snippet.get("maxLines")
+            if max_lines is not None:
+                self.snippet = Snippet(text=snippet.text, max_lines=int(max_lines))
+            else:
+                self.snippet = Snippet(text=snippet.text)
         timespan = element.find(f"{self.ns}TimeSpan")
         if timespan is not None:
             self._timespan = TimeSpan.class_from_element(
diff --git a/fastkml/types.py b/fastkml/types.py
index 0088ecf2..2c0b7cfd 100644
--- a/fastkml/types.py
+++ b/fastkml/types.py
@@ -29,7 +29,7 @@ class Element(Protocol):
     tag: str
     text: str
 
-    def set(self, tag: str, value: str) -> None:
+    def set(self, tag: str, value: str) -> None:  # noqa: A003
         """Set the value of the tag."""
 
     def get(self, tag: str) -> str:
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index d3f33b22..05d512c3 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -23,6 +23,7 @@
 from fastkml import atom
 from fastkml import base
 from fastkml import config
+from fastkml import features
 from fastkml import kml
 from fastkml import styles
 from fastkml.enums import ColorMode
@@ -534,17 +535,18 @@ def test_snippet(self) -> None:
 
         k = kml.KML()
         k.from_string(doc)
-        assert next(iter(k.features())).snippet["text"] == "Short Desc"
-        assert next(iter(k.features())).snippet["maxLines"] == 2
-        next(iter(k.features()))._snippet["maxLines"] = 3
-        assert next(iter(k.features())).snippet["maxLines"] == 3
+        assert next(iter(k.features())).snippet.text == "Short Desc"
+        assert next(iter(k.features())).snippet.max_lines == 2
+        next(iter(k.features()))._snippet = features.Snippet(
+            text="Another Snippet", max_lines=3
+        )
         assert 'maxLines="3"' in k.to_string()
-        next(iter(k.features())).snippet = {"text": "Annother Snippet"}
+        next(iter(k.features())).snippet = features.Snippet(text="Another Snippet")
         assert "maxLines" not in k.to_string()
-        assert "Annother Snippet" in k.to_string()
-        next(iter(k.features())).snippet = "Diffrent Snippet"
+        assert "Another Snippet" in k.to_string()
+        next(iter(k.features())).snippet = features.Snippet("Different Snippet")
         assert "maxLines" not in k.to_string()
-        assert "Diffrent Snippet" in k.to_string()
+        assert "Different Snippet" in k.to_string()
 
     def test_from_wrong_string(self) -> None:
         doc = kml.KML()

From 4c29a816b09b1584e590f3a31c66c4ba9e9599fd Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Thu, 23 Nov 2023 15:17:12 +0000
Subject: [PATCH 11/25] take and return atom author and link rather than
 strings

---
 fastkml/features.py   | 41 ++++++++++-------------------------------
 tests/oldunit_test.py | 12 +++++++-----
 2 files changed, 17 insertions(+), 36 deletions(-)

diff --git a/fastkml/features.py b/fastkml/features.py
index 721f27b4..7d6702a8 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -6,7 +6,6 @@
 
 import logging
 from dataclasses import dataclass
-from typing import Any
 from typing import Dict
 from typing import Iterator
 from typing import List
@@ -64,7 +63,6 @@ class _Feature(TimeMixin, _BaseObject):
         * Container (Document, Folder)
         * Placemark
         * Overlay
-    Not Implemented Yet:
         * NetworkLink.
     """
 
@@ -231,39 +229,20 @@ def view(self, camera: Optional[Union[Camera, LookAt]]) -> None:
         self._view = camera
 
     @property
-    def link(self):
-        return self._atom_link.href
+    def link(self) -> atom.Link:
+        return self._atom_link
 
     @link.setter
-    def link(self, url) -> None:
-        if isinstance(url, str):
-            self._atom_link = atom.Link(href=url)
-        elif isinstance(url, atom.Link):
-            self._atom_link = url
-        elif url is None:
-            self._atom_link = None
-        else:
-            raise TypeError
+    def link(self, link: Optional[atom.Link]) -> None:
+        self._atom_link = link
 
     @property
-    def author(self) -> None:
-        if self._atom_author:
-            return self._atom_author.name
-        return None
+    def author(self) -> Optional[atom.Author]:
+        return self._atom_author
 
     @author.setter
-    def author(self, name) -> None:
-        if isinstance(name, atom.Author):
-            self._atom_author = name
-        elif isinstance(name, str):
-            if self._atom_author is None:
-                self._atom_author = atom.Author(ns=config.ATOMNS, name=name)
-            else:
-                self._atom_author.name = name
-        elif name is None:
-            self._atom_author = None
-        else:
-            raise TypeError
+    def author(self, author: Optional[atom.Author]) -> None:
+        self._atom_author = author
 
     def append_style(self, style: Union[Style, StyleMap]) -> None:
         """Append a style to the feature."""
@@ -481,7 +460,7 @@ def __init__(
         atom_author: Optional[atom.Author] = None,
         address: Optional[str] = None,
         phone_number: Optional[str] = None,
-        snippet: Optional[Union[str, Dict[str, Any]]] = None,
+        snippet: Optional[Snippet] = None,
         description: Optional[str] = None,
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
@@ -654,7 +633,7 @@ def __init__(
         atom_author: Optional[atom.Author] = None,
         address: Optional[str] = None,
         phone_number: Optional[str] = None,
-        snippet: Optional[Union[str, Dict[str, Any]]] = None,
+        snippet: Optional[Snippet] = None,
         description: Optional[str] = None,
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index 05d512c3..454cd95a 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -169,7 +169,10 @@ def test_document(self) -> None:
 
     def test_author(self) -> None:
         d = kml.Document()
-        d.author = "Christian Ledermann"
+        d.author = atom.Author(
+            ns="{http://www.w3.org/2005/Atom}",
+            name="Christian Ledermann",
+        )
         assert "Christian Ledermann" in str(d.to_string())
         a = atom.Author(
             ns="{http://www.w3.org/2005/Atom}",
@@ -178,7 +181,6 @@ def test_author(self) -> None:
             email="cl@donotreply.com",
         )
         d.author = a
-        assert d.author == "Nobody"
         assert "Christian Ledermann" not in str(d.to_string())
         assert "Nobody" in str(d.to_string())
         assert "http://localhost" in str(d.to_string())
@@ -190,11 +192,10 @@ def test_author(self) -> None:
 
     def test_link(self) -> None:
         d = kml.Document()
-        d.link = "http://localhost"
+        d.link = atom.Link(ns=config.ATOMNS, href="http://localhost")
         assert "http://localhost" in str(d.to_string())
         d.link = atom.Link(ns=config.ATOMNS, href="#here")
         assert "#here" in str(d.to_string())
-        # pytest.raises(TypeError, d.link, object)
         d2 = kml.Document()
         d2.from_string(d.to_string())
         assert d.to_string() == d2.to_string()
@@ -538,7 +539,8 @@ def test_snippet(self) -> None:
         assert next(iter(k.features())).snippet.text == "Short Desc"
         assert next(iter(k.features())).snippet.max_lines == 2
         next(iter(k.features()))._snippet = features.Snippet(
-            text="Another Snippet", max_lines=3
+            text="Another Snippet",
+            max_lines=3,
         )
         assert 'maxLines="3"' in k.to_string()
         next(iter(k.features())).snippet = features.Snippet(text="Another Snippet")

From 0cf42fa78ae94c000b5145e4823a033a0bbdf91a Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Thu, 23 Nov 2023 16:00:42 +0000
Subject: [PATCH 12/25] update type hints

---
 fastkml/features.py | 48 ++++++++++++++++++++++++++-------------------
 1 file changed, 28 insertions(+), 20 deletions(-)

diff --git a/fastkml/features.py b/fastkml/features.py
index 7d6702a8..0b224651 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -11,6 +11,7 @@
 from typing import List
 from typing import Optional
 from typing import Union
+from typing import cast
 
 from fastkml import atom
 from fastkml import config
@@ -117,7 +118,7 @@ class _Feature(TimeMixin, _BaseObject):
     description: Optional[str]
     # User-supplied content that appears in the description balloon.
 
-    _style_url: Optional[Union[Style, StyleMap]]
+    _style_url: Optional[StyleUrl]
     # URL of a <Style> or <StyleMap> defined in a Document.
     # If the style is in the same file, use a # reference.
     # If the style is defined in an external file, use a full URL
@@ -172,7 +173,7 @@ def __init__(
         description: Optional[str] = None,
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
-        style_url: Optional[str] = None,
+        style_url: Optional[StyleUrl] = None,
         styles: Optional[List[Style]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
@@ -180,7 +181,7 @@ def __init__(
         super().__init__(ns=ns, name_spaces=name_spaces, id=id, target_id=target_id)
         self.name = name
         self.description = description
-        self.style_url = style_url
+        self._style_url = style_url
         self._styles = []
         self._view = view
         self.visibility = visibility
@@ -229,7 +230,7 @@ def view(self, camera: Optional[Union[Camera, LookAt]]) -> None:
         self._view = camera
 
     @property
-    def link(self) -> atom.Link:
+    def link(self) -> Optional[atom.Link]:
         return self._atom_link
 
     @link.setter
@@ -338,10 +339,10 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             self.description = description.text
         visibility = element.find(f"{self.ns}visibility")
         if visibility is not None and visibility.text:
-            self.visibility = 1 if visibility.text in ["1", "true"] else 0
+            self.visibility = True if visibility.text in ["1", "true"] else False
         isopen = element.find(f"{self.ns}open")
         if isopen is not None:
-            self.isopen = 1 if isopen.text in ["1", "true"] else 0
+            self.isopen = True if isopen.text in ["1", "true"] else False
         styles = element.findall(f"{self.ns}Style")
         for style in styles:
             s = Style.class_from_element(
@@ -350,7 +351,7 @@ def from_element(self, element: Element, strict: bool = False) -> None:
                 element=style,
                 strict=strict,
             )
-            self.append_style(s)
+            self.append_style(cast(Style, s))
         styles = element.findall(f"{self.ns}StyleMap")
         for style in styles:
             s = StyleMap.class_from_element(
@@ -359,14 +360,17 @@ def from_element(self, element: Element, strict: bool = False) -> None:
                 element=style,
                 strict=strict,
             )
-            self.append_style(s)
+            self.append_style(cast(StyleMap, s))
         style_url = element.find(f"{self.ns}styleUrl")
         if style_url is not None:
-            self._style_url = StyleUrl.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=style_url,
-                strict=strict,
+            self._style_url = cast(
+                StyleUrl,
+                StyleUrl.class_from_element(
+                    ns=self.ns,
+                    name_spaces=self.name_spaces,
+                    element=style_url,
+                    strict=strict,
+                ),
             )
         snippet = element.find(f"{self.ns}Snippet")
         if snippet is not None:
@@ -374,7 +378,7 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             if max_lines is not None:
                 self.snippet = Snippet(text=snippet.text, max_lines=int(max_lines))
             else:
-                self.snippet = Snippet(text=snippet.text)
+                self.snippet = Snippet(text=snippet.text)  # type: ignore[unreachable]
         timespan = element.find(f"{self.ns}TimeSpan")
         if timespan is not None:
             self._timespan = TimeSpan.class_from_element(
@@ -464,7 +468,7 @@ def __init__(
         description: Optional[str] = None,
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
-        style_url: Optional[str] = None,
+        style_url: Optional[StyleUrl] = None,
         styles: Optional[List[Style]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
@@ -500,7 +504,7 @@ def geometry(self) -> Optional[AnyGeometryType]:
             return self._geometry.geometry
         return None
 
-    def from_element(self, element: Element, strict=False) -> None:
+    def from_element(self, element: Element, strict: bool = False) -> None:
         super().from_element(element)
         point = element.find(f"{self.ns}Point")
         if point is not None:
@@ -637,7 +641,7 @@ def __init__(
         description: Optional[str] = None,
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
-        style_url: Optional[str] = None,
+        style_url: Optional[StyleUrl] = None,
         styles: Optional[List[Style]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
@@ -671,8 +675,12 @@ def __init__(
         self.fly_to_view = fly_to_view
         self.link = link
 
-    def etree_element(self):
-        element = super().etree_element()
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
         if self.refresh_visibility is not None:
             refresh_visibility = config.etree.SubElement(  # type: ignore[attr-defined]
                 element,
@@ -690,7 +698,7 @@ def etree_element(self):
             element.append(self.link.etree_element())
         return element
 
-    def from_element(self, element, strict=False):
+    def from_element(self, element: Element, strict=False) -> None:
         super(_Feature, self).from_element(element)
 
         visibility = element.find(f"{self.ns}refreshVisibility")

From b9767c0df35dac2ee4342caadf56e22fa2f4258b Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Thu, 23 Nov 2023 19:41:34 +0000
Subject: [PATCH 13/25] fix type annotations for container

---
 fastkml/containers.py  | 152 ++++++++++++++++++--------
 fastkml/features.py    | 199 ++++++++++++++++++++++------------
 fastkml/overlays.py    | 236 ++++++++++++++++++++++++++++-------------
 tests/overlays_test.py |  25 +----
 4 files changed, 404 insertions(+), 208 deletions(-)

diff --git a/fastkml/containers.py b/fastkml/containers.py
index e467734b..4bf54a55 100644
--- a/fastkml/containers.py
+++ b/fastkml/containers.py
@@ -2,25 +2,35 @@
 import logging
 import urllib.parse as urlparse
 from typing import Dict
+from typing import Iterable
 from typing import Iterator
 from typing import List
 from typing import Optional
 from typing import Union
+from typing import cast
 
+from fastkml import atom
 from fastkml import gx
+from fastkml.data import ExtendedData
 from fastkml.data import Schema
 from fastkml.enums import Verbosity
 from fastkml.features import Placemark
+from fastkml.features import Snippet
 from fastkml.features import _Feature
 from fastkml.geometry import LinearRing
 from fastkml.geometry import LineString
 from fastkml.geometry import MultiGeometry
 from fastkml.geometry import Point
 from fastkml.geometry import Polygon
-from fastkml.overlays import _Overlay
 from fastkml.styles import Style
 from fastkml.styles import StyleMap
+from fastkml.styles import StyleUrl
+from fastkml.times import TimeSpan
+from fastkml.times import TimeStamp
 from fastkml.types import Element
+from fastkml.views import Camera
+from fastkml.views import LookAt
+from fastkml.views import Region
 
 logger = logging.getLogger(__name__)
 
@@ -45,7 +55,7 @@ class _Container(_Feature):
     Folder.
     """
 
-    _features = []
+    _features: Optional[List[_Feature]]
 
     def __init__(
         self,
@@ -54,10 +64,22 @@ def __init__(
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         name: Optional[str] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
+        atom_link: Optional[atom.Link] = None,
+        atom_author: Optional[atom.Author] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
+        snippet: Optional[Snippet] = None,
         description: Optional[str] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
+        times: Optional[Union[TimeSpan, TimeStamp]] = None,
+        style_url: Optional[StyleUrl] = None,
         styles: Optional[List[Style]] = None,
-        style_url: Optional[str] = None,
-        features: None = None,
+        region: Optional[Region] = None,
+        extended_data: Optional[ExtendedData] = None,
+        # Container specific
+        features: Optional[List[_Feature]] = None,
     ) -> None:
         super().__init__(
             ns=ns,
@@ -65,25 +87,27 @@ def __init__(
             id=id,
             target_id=target_id,
             name=name,
+            visibility=visibility,
+            isopen=isopen,
+            atom_link=atom_link,
+            atom_author=atom_author,
+            address=address,
+            phone_number=phone_number,
+            snippet=snippet,
             description=description,
-            styles=styles,
+            view=view,
+            times=times,
             style_url=style_url,
+            styles=styles,
+            region=region,
+            extended_data=extended_data,
         )
         self._features = features or []
 
     def features(self) -> Iterator[_Feature]:
         """Iterate over features."""
-        for feature in self._features:
-            if isinstance(feature, (Folder, Placemark, Document, _Overlay)):
-                yield feature
-            else:
-                msg = (
-                    "Features must be instances of "
-                    "(Folder, Placemark, Document, Overlay)"
-                )
-                raise TypeError(
-                    msg,
-                )
+        assert self._features is not None
+        yield from self._features
 
     def etree_element(
         self,
@@ -97,16 +121,11 @@ def etree_element(
 
     def append(self, kmlobj: _Feature) -> None:
         """Append a feature."""
-        if id(kmlobj) == id(self):
+        if kmlobj is self:
             msg = "Cannot append self"
             raise ValueError(msg)
-        if isinstance(kmlobj, (Folder, Placemark, Document, _Overlay)):
-            self._features.append(kmlobj)
-        else:
-            msg = "Features must be instances of (Folder, Placemark, Document, Overlay)"
-            raise TypeError(
-                msg,
-            )
+        assert self._features is not None
+        self._features.append(kmlobj)
 
 
 class Folder(_Container):
@@ -117,7 +136,7 @@ class Folder(_Container):
 
     __name__ = "Folder"
 
-    def from_element(self, element: Element) -> None:
+    def from_element(self, element: Element, strict: bool = False) -> None:
         super().from_element(element)
         folders = element.findall(f"{self.ns}Folder")
         for folder in folders:
@@ -126,12 +145,12 @@ def from_element(self, element: Element) -> None:
             self.append(feature)
         placemarks = element.findall(f"{self.ns}Placemark")
         for placemark in placemarks:
-            feature = Placemark(self.ns)
+            feature = Placemark(self.ns)  # type: ignore[assignment]
             feature.from_element(placemark)
             self.append(feature)
         documents = element.findall(f"{self.ns}Document")
         for document in documents:
-            feature = Document(self.ns)
+            feature = Document(self.ns)  # type: ignore[assignment]
             feature.from_element(document)
             self.append(feature)
 
@@ -144,20 +163,63 @@ class Document(_Container):
     """
 
     __name__ = "Document"
-    _schemata = None
+    _schemata: Optional[List[Schema]]
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        name: Optional[str] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
+        atom_link: Optional[atom.Link] = None,
+        atom_author: Optional[atom.Author] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
+        snippet: Optional[Snippet] = None,
+        description: Optional[str] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
+        times: Optional[Union[TimeSpan, TimeStamp]] = None,
+        style_url: Optional[StyleUrl] = None,
+        styles: Optional[List[Style]] = None,
+        region: Optional[Region] = None,
+        extended_data: Optional[ExtendedData] = None,
+        features: Optional[List[_Feature]] = None,
+        schemata: Optional[Iterable[Schema]] = None,
+    ) -> None:
+        super().__init__(
+            ns=ns,
+            name_spaces=name_spaces,
+            id=id,
+            target_id=target_id,
+            name=name,
+            visibility=visibility,
+            isopen=isopen,
+            atom_link=atom_link,
+            atom_author=atom_author,
+            address=address,
+            phone_number=phone_number,
+            snippet=snippet,
+            description=description,
+            view=view,
+            times=times,
+            style_url=style_url,
+            styles=styles,
+            region=region,
+            extended_data=extended_data,
+            features=features,
+        )
+        self._schemata = list(schemata) if schemata else []
 
-    def schemata(self) -> Iterator["Schema"]:
+    def schemata(self) -> Iterator[Schema]:
         if self._schemata:
             yield from self._schemata
 
-    def append_schema(self, schema: "Schema") -> None:
-        if self._schemata is None:
-            self._schemata = []
-        if isinstance(schema, Schema):
-            self._schemata.append(schema)
-        else:
-            s = Schema(schema)
-            self._schemata.append(s)
+    def append_schema(self, schema: Schema) -> None:
+        assert self._schemata is not None
+        self._schemata.append(schema)
 
     def from_element(self, element: Element, strict: bool = False) -> None:
         super().from_element(element)
@@ -168,17 +230,20 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             self.append(feature)
         folders = element.findall(f"{self.ns}Folder")
         for folder in folders:
-            feature = Folder(self.ns)
+            feature = Folder(self.ns)  # type: ignore[assignment]
             feature.from_element(folder)
             self.append(feature)
         placemarks = element.findall(f"{self.ns}Placemark")
         for placemark in placemarks:
-            feature = Placemark(self.ns)
+            feature = Placemark(self.ns)  # type: ignore[assignment]
             feature.from_element(placemark)
             self.append(feature)
         schemata = element.findall(f"{self.ns}Schema")
         for schema in schemata:
-            s = Schema.class_from_element(ns=self.ns, element=schema, strict=strict)
+            s = cast(
+                Schema,
+                Schema.class_from_element(ns=self.ns, element=schema, strict=strict),
+            )
             self.append_schema(s)
 
     def etree_element(
@@ -193,8 +258,5 @@ def etree_element(
         return element
 
     def get_style_by_url(self, style_url: str) -> Optional[Union[Style, StyleMap]]:
-        id = urlparse.urlparse(style_url).fragment
-        for style in self.styles():
-            if style.id == id:
-                return style
-        return None
+        id_ = urlparse.urlparse(style_url).fragment
+        return next((style for style in self.styles() if style.id == id_), None)
diff --git a/fastkml/features.py b/fastkml/features.py
index 0b224651..be40f1b5 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -291,25 +291,40 @@ def etree_element(
     ) -> Element:
         element = super().etree_element(precision=precision, verbosity=verbosity)
         if self.name:
-            name = config.etree.SubElement(element, f"{self.ns}name")
+            name = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}name",
+            )
             name.text = self.name
         if self.description:
-            description = config.etree.SubElement(element, f"{self.ns}description")
+            description = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}description",
+            )
             description.text = self.description
         if self._view is not None:
             element.append(self._view.etree_element())
         if self.visibility is not None:
-            visibility = config.etree.SubElement(element, f"{self.ns}visibility")
-            visibility.text = str(self.visibility)
+            visibility = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}visibility",
+            )
+            visibility.text = str(int(self.visibility))
         if self.isopen:
-            isopen = config.etree.SubElement(element, f"{self.ns}open")
-            isopen.text = str(self.isopen)
+            isopen = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}open",
+            )
+            isopen.text = str(int(self.isopen))
         if self._style_url is not None:
             element.append(self._style_url.etree_element())
         for style in self.styles():
             element.append(style.etree_element())
         if self.snippet:
-            snippet = config.etree.SubElement(element, f"{self.ns}Snippet")
+            snippet = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}Snippet",
+            )
             snippet.text = self.snippet.text
             if self.snippet.max_lines:
                 snippet.set("maxLines", str(self.snippet.max_lines))
@@ -322,10 +337,16 @@ def etree_element(
         if self.extended_data is not None:
             element.append(self.extended_data.etree_element())
         if self._address is not None:
-            address = config.etree.SubElement(element, f"{self.ns}address")
+            address = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}address",
+            )
             address.text = self._address
         if self._phone_number is not None:
-            phone_number = config.etree.SubElement(element, f"{self.ns}phoneNumber")
+            phone_number = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}phoneNumber",
+            )
             phone_number.text = self._phone_number
         return element
 
@@ -397,26 +418,35 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             )
         atom_link = element.find(f"{atom.NS}link")
         if atom_link is not None:
-            self._atom_link = atom.Link.class_from_element(
-                ns=atom.NS,
-                name_spaces=self.name_spaces,
-                element=atom_link,
-                strict=strict,
+            self._atom_link = cast(
+                atom.Link,
+                atom.Link.class_from_element(
+                    ns=atom.NS,
+                    name_spaces=self.name_spaces,
+                    element=atom_link,
+                    strict=strict,
+                ),
             )
         atom_author = element.find(f"{atom.NS}author")
         if atom_author is not None:
-            self._atom_author = atom.Author.class_from_element(
-                ns=atom.NS,
-                name_spaces=self.name_spaces,
-                element=atom_author,
-                strict=strict,
+            self._atom_author = cast(
+                atom.Author,
+                atom.Author.class_from_element(
+                    ns=atom.NS,
+                    name_spaces=self.name_spaces,
+                    element=atom_author,
+                    strict=strict,
+                ),
             )
         extended_data = element.find(f"{self.ns}ExtendedData")
         if extended_data is not None:
-            self.extended_data = ExtendedData.class_from_element(
-                ns=self.ns,
-                element=extended_data,
-                strict=strict,
+            self.extended_data = cast(
+                ExtendedData,
+                ExtendedData.class_from_element(
+                    ns=self.ns,
+                    element=extended_data,
+                    strict=strict,
+                ),
             )
         address = element.find(f"{self.ns}address")
         if address is not None:
@@ -426,17 +456,23 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             self.phone_number = phone_number.text
         camera = element.find(f"{self.ns}Camera")
         if camera is not None:
-            self._view = Camera.class_from_element(
-                ns=self.ns,
-                element=camera,
-                strict=strict,
+            self._view = cast(
+                Camera,
+                Camera.class_from_element(
+                    ns=self.ns,
+                    element=camera,
+                    strict=strict,
+                ),
             )
         lookat = element.find(f"{self.ns}LookAt")
         if lookat is not None:
-            self._view = LookAt.class_from_element(
-                ns=self.ns,
-                element=lookat,
-                strict=strict,
+            self._view = cast(
+                LookAt,
+                LookAt.class_from_element(
+                    ns=self.ns,
+                    element=lookat,
+                    strict=strict,
+                ),
             )
 
 
@@ -508,62 +544,86 @@ def from_element(self, element: Element, strict: bool = False) -> None:
         super().from_element(element)
         point = element.find(f"{self.ns}Point")
         if point is not None:
-            self._geometry = Point.class_from_element(
-                ns=self.ns,
-                element=point,
-                strict=strict,
+            self._geometry = cast(
+                Point,
+                Point.class_from_element(
+                    ns=self.ns,
+                    element=point,
+                    strict=strict,
+                ),
             )
             return
         line = element.find(f"{self.ns}LineString")
         if line is not None:
-            self._geometry = LineString.class_from_element(
-                ns=self.ns,
-                element=line,
-                strict=strict,
+            self._geometry = cast(
+                LineString,
+                LineString.class_from_element(
+                    ns=self.ns,
+                    element=line,
+                    strict=strict,
+                ),
             )
             return
         polygon = element.find(f"{self.ns}Polygon")
         if polygon is not None:
-            self._geometry = Polygon.class_from_element(
-                ns=self.ns,
-                element=polygon,
-                strict=strict,
+            self._geometry = cast(
+                Polygon,
+                Polygon.class_from_element(
+                    ns=self.ns,
+                    element=polygon,
+                    strict=strict,
+                ),
             )
             return
         linearring = element.find(f"{self.ns}LinearRing")
         if linearring is not None:
-            self._geometry = LinearRing.class_from_element(
-                ns=self.ns,
-                element=linearring,
-                strict=strict,
+            self._geometry = cast(
+                LinearRing,
+                LinearRing.class_from_element(
+                    ns=self.ns,
+                    element=linearring,
+                    strict=strict,
+                ),
             )
             return
         multigeometry = element.find(f"{self.ns}MultiGeometry")
         if multigeometry is not None:
-            self._geometry = MultiGeometry.class_from_element(
-                ns=self.ns,
-                element=multigeometry,
-                strict=strict,
+            self._geometry = cast(
+                MultiGeometry,
+                MultiGeometry.class_from_element(
+                    ns=self.ns,
+                    element=multigeometry,
+                    strict=strict,
+                ),
             )
             return
         track = element.find(f"{self.ns}Track")
         if track is not None:
-            self._geometry = gx.Track.class_from_element(
-                ns=config.GXNS,
-                element=track,
-                strict=strict,
+            self._geometry = cast(
+                gx.Track,
+                gx.Track.class_from_element(
+                    ns=config.GXNS,
+                    element=track,
+                    strict=strict,
+                ),
             )
             return
         multitrack = element.find(f"{self.ns}MultiTrack")
         if multitrack is not None:
-            self._geometry = gx.MultiTrack.class_from_element(
-                ns=config.GXNS,
-                element=multitrack,
-                strict=strict,
+            self._geometry = cast(
+                gx.MultiTrack,
+                gx.MultiTrack.class_from_element(
+                    ns=config.GXNS,
+                    element=multitrack,
+                    strict=strict,
+                ),
             )
             return
         logger.warning("No geometries found")
-        logger.debug("Problem with element: %", config.etree.tostring(element))
+        logger.debug(
+            "Problem with element: %",
+            config.etree.tostring(element),  # type: ignore[attr-defined]
+        )
 
     def etree_element(
         self,
@@ -620,7 +680,7 @@ class NetworkLink(_Feature):
 
     refresh_visibility: Optional[bool]
     fly_to_view: Optional[bool]
-    link: Optional[Link]
+    _link: Optional[Link]
 
     __name__ = "NetworkLink"
 
@@ -673,7 +733,7 @@ def __init__(
         )
         self.refresh_visibility = refresh_visibility
         self.fly_to_view = fly_to_view
-        self.link = link
+        self._link = link
 
     def etree_element(
         self,
@@ -698,7 +758,7 @@ def etree_element(
             element.append(self.link.etree_element())
         return element
 
-    def from_element(self, element: Element, strict=False) -> None:
+    def from_element(self, element: Element, strict: bool = False) -> None:
         super(_Feature, self).from_element(element)
 
         visibility = element.find(f"{self.ns}refreshVisibility")
@@ -710,9 +770,12 @@ def from_element(self, element: Element, strict=False) -> None:
 
         link = element.find(f"{self.ns}Link")
         if link is not None:
-            self.link = Link.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=link,
-                strict=strict,
+            self._link = cast(
+                Link,
+                Link.class_from_element(
+                    ns=self.ns,
+                    name_spaces=self.name_spaces,
+                    element=link,
+                    strict=strict,
+                ),
             )
diff --git a/fastkml/overlays.py b/fastkml/overlays.py
index f966581b..65325083 100644
--- a/fastkml/overlays.py
+++ b/fastkml/overlays.py
@@ -1,18 +1,21 @@
 """Overlays."""
 
 import logging
-from typing import Any
 from typing import Dict
 from typing import List
 from typing import Optional
 from typing import Union
+from typing import cast
 
 from fastkml import atom
 from fastkml import config
 from fastkml import gx
+from fastkml.base import _XMLObject
+from fastkml.data import ExtendedData
 from fastkml.enums import GridOrigin
 from fastkml.enums import Shape
 from fastkml.enums import Verbosity
+from fastkml.features import Snippet
 from fastkml.features import _Feature
 from fastkml.geometry import LinearRing
 from fastkml.geometry import LineString
@@ -21,11 +24,13 @@
 from fastkml.geometry import Polygon
 from fastkml.links import Icon
 from fastkml.styles import Style
+from fastkml.styles import StyleUrl
 from fastkml.times import TimeSpan
 from fastkml.times import TimeStamp
 from fastkml.types import Element
 from fastkml.views import Camera
 from fastkml.views import LookAt
+from fastkml.views import Region
 
 logger = logging.getLogger(__name__)
 
@@ -75,19 +80,21 @@ def __init__(
         id: Optional[str] = None,
         target_id: Optional[str] = None,
         name: Optional[str] = None,
-        description: Optional[str] = None,
-        snippet: Optional[Union[str, Dict[str, Any]]] = None,
-        atom_author: Optional[atom.Author] = None,
-        atom_link: Optional[atom.Link] = None,
         visibility: Optional[bool] = None,
         isopen: Optional[bool] = None,
-        styles: Optional[List[Style]] = None,
-        style_url: Optional[str] = None,
-        extended_data: None = None,
-        view: Optional[Union[Camera, LookAt]] = None,
+        atom_link: Optional[atom.Link] = None,
+        atom_author: Optional[atom.Author] = None,
         address: Optional[str] = None,
         phone_number: Optional[str] = None,
+        snippet: Optional[Snippet] = None,
+        description: Optional[str] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
+        style_url: Optional[StyleUrl] = None,
+        styles: Optional[List[Style]] = None,
+        region: Optional[Region] = None,
+        extended_data: Optional[ExtendedData] = None,
+        # Overlay specific
         color: Optional[str] = None,
         draw_order: Optional[str] = None,
         icon: Optional[Icon] = None,
@@ -98,62 +105,48 @@ def __init__(
             id=id,
             target_id=target_id,
             name=name,
-            description=description,
-            styles=styles,
-            style_url=style_url,
-            snippet=snippet,
-            atom_author=atom_author,
-            atom_link=atom_link,
             visibility=visibility,
             isopen=isopen,
-            extended_data=extended_data,
-            view=view,
+            atom_link=atom_link,
+            atom_author=atom_author,
             address=address,
             phone_number=phone_number,
+            snippet=snippet,
+            description=description,
+            view=view,
             times=times,
+            style_url=style_url,
+            styles=styles,
+            region=region,
+            extended_data=extended_data,
         )
         self._icon = icon
         self._color = color
         self._draw_order = draw_order
 
     @property
-    def color(self):
+    def color(self) -> Optional[str]:
         return self._color
 
     @color.setter
-    def color(self, color) -> None:
-        if isinstance(color, str):
-            self._color = color
-        elif color is None:
-            self._color = None
-        else:
-            raise ValueError
+    def color(self, color: Optional[str]) -> None:
+        self._color = color
 
     @property
     def draw_order(self) -> Optional[str]:
         return self._draw_order
 
     @draw_order.setter
-    def draw_order(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._draw_order = str(value)
-        elif value is None:
-            self._draw_order = None
-        else:
-            raise ValueError
+    def draw_order(self, value: Optional[str]) -> None:
+        self._draw_order = value
 
     @property
     def icon(self) -> Optional[Icon]:
         return self._icon
 
     @icon.setter
-    def icon(self, value) -> None:
-        if isinstance(value, Icon):
-            self._icon = value
-        elif value is None:
-            self._icon = None
-        else:
-            raise ValueError
+    def icon(self, value: Optional[Icon]) -> None:
+        self._icon = value
 
     def etree_element(
         self,
@@ -162,17 +155,23 @@ def etree_element(
     ) -> Element:
         element = super().etree_element(precision=precision, verbosity=verbosity)
         if self._color:
-            color = config.etree.SubElement(element, f"{self.ns}color")
+            color = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}color",
+            )
             color.text = self._color
         if self._draw_order:
-            draw_order = config.etree.SubElement(element, f"{self.ns}drawOrder")
-            draw_order.text = self._draw_order
+            draw_order = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}drawOrder",
+            )
+            draw_order.text = str(self._draw_order)
         if self._icon:
             element.append(self._icon.etree_element())
         return element
 
-    def from_element(self, element: Element) -> None:
-        super().from_element(element)
+    def from_element(self, element: Element, strict: bool = False) -> None:
+        super().from_element(element=element, strict=strict)
         color = element.find(f"{self.ns}color")
         if color is not None:
             self.color = color.text
@@ -181,14 +180,67 @@ def from_element(self, element: Element) -> None:
             self.draw_order = draw_order.text
         icon = element.find(f"{self.ns}Icon")
         if icon is not None:
-            self._icon = Icon.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=icon,
-                strict=False,
+            self._icon = cast(
+                Icon,
+                Icon.class_from_element(
+                    ns=self.ns,
+                    name_spaces=self.name_spaces,
+                    element=icon,
+                    strict=False,
+                ),
             )
 
 
+class ViewVolume(_XMLObject):
+    """
+    The ViewVolume defines how much of the current scene is visible.
+
+    Specifying the field of view is analogous to specifying the lens opening in a
+    physical camera.
+    A small field of view, like a telephoto lens, focuses on a small part of the scene.
+    A large field of view, like a wide-angle lens, focuses on a large part of the scene.
+
+    https://developers.google.com/kml/documentation/kmlreference#viewvolume
+    """
+
+    left_fow: Optional[float]
+    # Angle, in degrees, between the camera's viewing direction and the left side
+    # of the view volume.
+
+    right_fov: Optional[float]
+    # Angle, in degrees, between the camera's viewing direction and the right side
+    # of the view volume.
+
+    bottom_fov: Optional[float]
+    # Angle, in degrees, between the camera's viewing direction and the bottom side
+    # of the view volume.
+
+    top_fov: Optional[float]
+    # Angle, in degrees, between the camera's viewing direction and the top side
+    # of the view volume.
+
+    near: Optional[float]
+    # Measurement in meters along the viewing direction from the camera viewpoint
+    # to the PhotoOverlay shape.
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        left_fov: Optional[float] = None,
+        right_fov: Optional[float] = None,
+        bottom_fov: Optional[float] = None,
+        top_fov: Optional[float] = None,
+        near: Optional[float] = None,
+    ) -> None:
+        super().__init__(ns=ns, name_spaces=name_spaces)
+        self.left_fov = left_fov
+        self.right_fov = right_fov
+        self.bottom_fov = bottom_fov
+        self.top_fov = top_fov
+        self.near = near
+
+
 class PhotoOverlay(_Overlay):
     """
     The <PhotoOverlay> element allows you to geographically locate a photograph
@@ -211,41 +263,23 @@ class PhotoOverlay(_Overlay):
     element that specifies the image file to use for the PhotoOverlay.
     In the case of a very large image, the <href> is a special URL that
     indexes into a pyramid of images of varying resolutions (see ImagePyramid).
+
+    https://developers.google.com/kml/documentation/kmlreference#photooverlay
     """
 
     __name__ = "PhotoOverlay"
 
-    _rotation = None
+    _rotation: Optional[float]
     # Adjusts how the photo is placed inside the field of view. This element is
     # useful if your photo has been rotated and deviates slightly from a desired
     # horizontal view.
 
-    # - ViewVolume -
-    # Defines how much of the current scene is visible. Specifying the field of
-    # view is analogous to specifying the lens opening in a physical camera.
-    # A small field of view, like a telephoto lens, focuses on a small part of
-    # the scene. A large field of view, like a wide-angle lens, focuses on a
-    # large part of the scene.
+    _view_volume: Optional[ViewVolume]
+    # Defines how much of the current scene is visible.
 
-    _left_fow = None
-    # Angle, in degrees, between the camera's viewing direction and the left side
-    # of the view volume.
-
-    _right_fov = None
-    # Angle, in degrees, between the camera's viewing direction and the right side
-    # of the view volume.
-
-    _bottom_fov = None
-    # Angle, in degrees, between the camera's viewing direction and the bottom side
-    # of the view volume.
-
-    _top_fov = None
-    # Angle, in degrees, between the camera's viewing direction and the top side
-    # of the view volume.
-
-    _near = None
-    # Measurement in meters along the viewing direction from the camera viewpoint
-    # to the PhotoOverlay shape.
+    # _image_pyramid: Optional[ImagePyramid]
+    # Defines the format, resolution, and refresh rate for images that are
+    # displayed in the PhotoOverlay.
 
     _tile_size = "256"
     # Size of the tiles, in pixels. Tiles must be square, and <tileSize> must
@@ -279,6 +313,58 @@ class PhotoOverlay(_Overlay):
     #   sphere -
     #       for spherical panoramas
 
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        name: Optional[str] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
+        atom_link: Optional[atom.Link] = None,
+        atom_author: Optional[atom.Author] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
+        snippet: Optional[Snippet] = None,
+        description: Optional[str] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
+        times: Optional[Union[TimeSpan, TimeStamp]] = None,
+        style_url: Optional[StyleUrl] = None,
+        styles: Optional[List[Style]] = None,
+        region: Optional[Region] = None,
+        extended_data: Optional[ExtendedData] = None,
+        color: Optional[str] = None,
+        draw_order: Optional[str] = None,
+        icon: Optional[Icon] = None,
+        # Photo Overlay specific
+    ) -> None:
+        super().__init__(
+            ns=ns,
+            name_spaces=name_spaces,
+            id=id,
+            target_id=target_id,
+            name=name,
+            visibility=visibility,
+            isopen=isopen,
+            atom_link=atom_link,
+            atom_author=atom_author,
+            address=address,
+            phone_number=phone_number,
+            snippet=snippet,
+            description=description,
+            view=view,
+            times=times,
+            style_url=style_url,
+            styles=styles,
+            region=region,
+            extended_data=extended_data,
+            color=color,
+            draw_order=draw_order,
+            icon=icon,
+        )
+        self._rotation = None
+
     @property
     def rotation(self) -> Optional[str]:
         return self._rotation
diff --git a/tests/overlays_test.py b/tests/overlays_test.py
index 43baebeb..afb2b804 100644
--- a/tests/overlays_test.py
+++ b/tests/overlays_test.py
@@ -38,38 +38,23 @@ def test_color_none(self) -> None:
         o.color = None
         assert o.color is None
 
-    def test_color_value_error(self) -> None:
-        o = overlays._Overlay(name="An Overlay")
-        with pytest.raises(ValueError):
-            o.color = object()
-
     def test_draw_order_string(self) -> None:
         o = overlays._Overlay(name="An Overlay")
-        o.draw_order = "1"
-        assert o.draw_order == "1"
+        o.draw_order = 1
+        assert o.draw_order == 1
 
     def test_draw_order_int(self) -> None:
         o = overlays._Overlay(name="An Overlay")
         o.draw_order = 1
-        assert o.draw_order == "1"
+        assert o.draw_order == 1
 
     def test_draw_order_none(self) -> None:
         o = overlays._Overlay(name="An Overlay")
-        o.draw_order = "1"
-        assert o.draw_order == "1"
+        o.draw_order = 1
+        assert o.draw_order == 1
         o.draw_order = None
         assert o.draw_order is None
 
-    def test_draw_order_value_error(self) -> None:
-        o = overlays._Overlay(name="An Overlay")
-        with pytest.raises(ValueError):
-            o.draw_order = object()
-
-    def test_icon_raise_exception(self) -> None:
-        o = overlays._Overlay(name="An Overlay")
-        with pytest.raises(ValueError):
-            o.icon = 12345
-
 
 class TestGroundOverlay(StdLibrary):
     def test_altitude_int(self) -> None:

From a9bd4aa5e4b7585b6213cba333c367efb02bf4e9 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Thu, 23 Nov 2023 21:55:03 +0000
Subject: [PATCH 14/25] refactor overlays

---
 fastkml/overlays.py    | 901 +++++++++++++++++++++--------------------
 tests/overlays_test.py | 243 ++---------
 2 files changed, 504 insertions(+), 640 deletions(-)

diff --git a/fastkml/overlays.py b/fastkml/overlays.py
index 65325083..8b1ab757 100644
--- a/fastkml/overlays.py
+++ b/fastkml/overlays.py
@@ -1,6 +1,7 @@
 """Overlays."""
 
 import logging
+from typing import Any
 from typing import Dict
 from typing import List
 from typing import Optional
@@ -12,6 +13,7 @@
 from fastkml import gx
 from fastkml.base import _XMLObject
 from fastkml.data import ExtendedData
+from fastkml.enums import AltitudeMode
 from fastkml.enums import GridOrigin
 from fastkml.enums import Shape
 from fastkml.enums import Verbosity
@@ -240,6 +242,201 @@ def __init__(
         self.top_fov = top_fov
         self.near = near
 
+    def __bool__(self) -> bool:
+        return all(
+            [
+                self.left_fov is not None,
+                self.right_fov is not None,
+                self.bottom_fov is not None,
+                self.top_fov is not None,
+                self.near is not None,
+            ],
+        )
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        left_fov = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}leftFov",
+        )
+        left_fov.text = str(self.left_fov)
+        right_fov = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}rightFov",
+        )
+        right_fov.text = str(self.right_fov)
+        bottom_fov = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}bottomFov",
+        )
+        bottom_fov.text = str(self.bottom_fov)
+        top_fov = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}topFov",
+        )
+        top_fov.text = str(self.top_fov)
+        near = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}near",
+        )
+        near.text = str(self.near)
+        return element
+
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        left_fov = element.find(f"{ns}leftFov")
+        if left_fov is not None:
+            kwargs["left_fov"] = float(left_fov.text)
+        right_fov = element.find(f"{ns}rightFov")
+        if right_fov is not None:
+            kwargs["right_fov"] = float(right_fov.text)
+        bottom_fov = element.find(f"{ns}bottomFov")
+        if bottom_fov is not None:
+            kwargs["bottom_fov"] = float(bottom_fov.text)
+        top_fov = element.find(f"{ns}topFov")
+        if top_fov is not None:
+            kwargs["top_fov"] = float(top_fov.text)
+        near = element.find(f"{ns}near")
+        if near is not None:
+            kwargs["near"] = float(near.text)
+        return kwargs
+
+
+class ImagePyramid(_XMLObject):
+    """
+    For very large images, you'll need to construct an image pyramid.
+
+    An ImagePyramid is a hierarchical set of images, each of which is an increasingly
+    lower resolution version of the original image.
+    Each image in the pyramid is subdivided into tiles, so that only the portions in
+    view need to be loaded.
+    Google Earth calculates the current viewpoint and loads the tiles that are
+    appropriate to the user's distance from the image.
+    As the viewpoint moves closer to the PhotoOverlay, Google Earth loads higher
+    resolution tiles.
+    Since all the pixels in the original image can't be viewed on the screen at once,
+    this preprocessing allows Google Earth to achieve maximum performance because it
+    loads only the portions of the image that are in view, and only the pixel details
+    that can be discerned by the user at the current viewpoint.
+
+    When you specify an image pyramid, you also need to modify the <href> in the <Icon>
+    element to include specifications for which tiles to load.
+    """
+
+    tile_size: Optional[int]
+    # Size of the tiles, in pixels. Tiles must be square, and <tileSize> must be a power
+    # of 2. A tile size of 256 (the default) or 512 is recommended.
+    # The original image is divided into tiles of this size, at varying resolutions.
+
+    max_width: Optional[int]
+    # Width in pixels of the original image.
+
+    max_height: Optional[int]
+    # Height in pixels of the original image.
+
+    grid_origin: Optional[GridOrigin]
+    # Specifies where to begin numbering the tiles in each layer of the pyramid.
+    # A value of lowerLeft specifies that row 1, column 1 of each layer is in
+    # the bottom left corner of the grid.
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        tile_size: Optional[int] = None,
+        max_width: Optional[int] = None,
+        max_height: Optional[int] = None,
+        grid_origin: Optional[GridOrigin] = None,
+    ) -> None:
+        super().__init__(ns=ns, name_spaces=name_spaces)
+        self.tile_size = tile_size
+        self.max_width = max_width
+        self.max_height = max_height
+        self.grid_origin = grid_origin
+
+    def __bool__(self) -> bool:
+        return (
+            self.tile_size is not None
+            and self.max_width is not None
+            and self.max_height is not None
+            and self.grid_origin is not None
+        )
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        tile_size = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}tileSize",
+        )
+        tile_size.text = str(self.tile_size)
+        max_width = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}maxWidth",
+        )
+        max_width.text = str(self.max_width)
+        max_height = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}maxHeight",
+        )
+        max_height.text = str(self.max_height)
+        grid_origin = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}gridOrigin",
+        )
+        assert self.grid_origin is not None
+        grid_origin.text = self.grid_origin.value
+        return element
+
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        tile_size = element.find(f"{ns}tileSize")
+        if tile_size is not None:
+            kwargs["tile_size"] = int(tile_size.text)
+        max_width = element.find(f"{ns}maxWidth")
+        if max_width is not None:
+            kwargs["max_width"] = int(max_width.text)
+        max_height = element.find(f"{ns}maxHeight")
+        if max_height is not None:
+            kwargs["max_height"] = int(max_height.text)
+        grid_origin = element.find(f"{ns}gridOrigin")
+        if grid_origin is not None:
+            kwargs["grid_origin"] = GridOrigin(grid_origin.text)
+        return kwargs
+
 
 class PhotoOverlay(_Overlay):
     """
@@ -269,41 +466,26 @@ class PhotoOverlay(_Overlay):
 
     __name__ = "PhotoOverlay"
 
-    _rotation: Optional[float]
+    rotation: Optional[float]
     # Adjusts how the photo is placed inside the field of view. This element is
     # useful if your photo has been rotated and deviates slightly from a desired
     # horizontal view.
 
-    _view_volume: Optional[ViewVolume]
+    view_volume: Optional[ViewVolume]
     # Defines how much of the current scene is visible.
 
-    # _image_pyramid: Optional[ImagePyramid]
+    image_pyramid: Optional[ImagePyramid]
     # Defines the format, resolution, and refresh rate for images that are
     # displayed in the PhotoOverlay.
 
-    _tile_size = "256"
-    # Size of the tiles, in pixels. Tiles must be square, and <tileSize> must
-    # be a power of 2. A tile size of 256 (the default) or 512 is recommended.
-    # The original image is divided into tiles of this size, at varying resolutions.
-
-    _max_width = None
-    # Width in pixels of the original image.
-
-    _max_height = None
-    # Height in pixels of the original image.
-
-    _grid_origin: Optional[GridOrigin]
-    # Specifies where to begin numbering the tiles in each layer of the pyramid.
-    # A value of lowerLeft specifies that row 1, column 1 of each layer is in
-    # the bottom left corner of the grid.
-
-    _point: Optional[Point]
-    # The <Point> element acts as a <Point> inside a <Placemark> element.
-    # It draws an icon to mark the position of the PhotoOverlay.
-    # The icon drawn is specified by the <styleUrl> and <StyleSelector> fields,
-    # just as it is for <Placemark>.
+    point: Optional[Point]
+    # Defines the exact coordinates of the PhotoOverlay's origin, in latitude
+    # and longitude, and in meters. Latitude and longitude measurements are
+    # standard lat-lon projection with WGS84 datum. Altitude is distance above
+    # the earth's surface, in meters, and is interpreted according to
+    # altitudeMode.
 
-    _shape: Optional[Shape]
+    shape: Optional[Shape]
     # The PhotoOverlay is projected onto the <shape>.
     # The <shape> can be one of the following:
     #   rectangle (default) -
@@ -338,6 +520,11 @@ def __init__(
         draw_order: Optional[str] = None,
         icon: Optional[Icon] = None,
         # Photo Overlay specific
+        rotation: Optional[float] = None,
+        view_volume: Optional[ViewVolume] = None,
+        image_pyramid: Optional[ImagePyramid] = None,
+        point: Optional[Point] = None,
+        shape: Optional[Shape] = None,
     ) -> None:
         super().__init__(
             ns=ns,
@@ -363,164 +550,11 @@ def __init__(
             draw_order=draw_order,
             icon=icon,
         )
-        self._rotation = None
-
-    @property
-    def rotation(self) -> Optional[str]:
-        return self._rotation
-
-    @rotation.setter
-    def rotation(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._rotation = str(value)
-        elif value is None:
-            self._rotation = None
-        else:
-            raise ValueError
-
-    @property
-    def left_fov(self) -> Optional[str]:
-        return self._left_fow
-
-    @left_fov.setter
-    def left_fov(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._left_fow = str(value)
-        elif value is None:
-            self._left_fow = None
-        else:
-            raise ValueError
-
-    @property
-    def right_fov(self) -> Optional[str]:
-        return self._right_fov
-
-    @right_fov.setter
-    def right_fov(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._right_fov = str(value)
-        elif value is None:
-            self._right_fov = None
-        else:
-            raise ValueError
-
-    @property
-    def bottom_fov(self) -> Optional[str]:
-        return self._bottom_fov
-
-    @bottom_fov.setter
-    def bottom_fov(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._bottom_fov = str(value)
-        elif value is None:
-            self._bottom_fov = None
-        else:
-            raise ValueError
-
-    @property
-    def top_fov(self) -> Optional[str]:
-        return self._top_fov
-
-    @top_fov.setter
-    def top_fov(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._top_fov = str(value)
-        elif value is None:
-            self._top_fov = None
-        else:
-            raise ValueError
-
-    @property
-    def near(self) -> Optional[str]:
-        return self._near
-
-    @near.setter
-    def near(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._near = str(value)
-        elif value is None:
-            self._near = None
-        else:
-            raise ValueError
-
-    @property
-    def tile_size(self) -> Optional[str]:
-        return self._tile_size
-
-    @tile_size.setter
-    def tile_size(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._tile_size = str(value)
-        elif value is None:
-            self._tile_size = None
-        else:
-            raise ValueError
-
-    @property
-    def max_width(self) -> Optional[str]:
-        return self._max_width
-
-    @max_width.setter
-    def max_width(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._max_width = str(value)
-        elif value is None:
-            self._max_width = None
-        else:
-            raise ValueError
-
-    @property
-    def max_height(self) -> Optional[str]:
-        return self._max_height
-
-    @max_height.setter
-    def max_height(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._max_height = str(value)
-        elif value is None:
-            self._max_height = None
-        else:
-            raise ValueError
-
-    @property
-    def grid_origin(self) -> Optional[GridOrigin]:
-        return self._grid_origin
-
-    @grid_origin.setter
-    def grid_origin(self, value: Optional[GridOrigin]) -> None:
-        self._grid_origin = value
-
-    @property
-    def point(self) -> str:
-        return self._point
-
-    @point.setter
-    def point(self, value) -> None:
-        if isinstance(value, (str, tuple)):
-            self._point = str(value)
-        else:
-            raise ValueError
-
-    @property
-    def shape(self) -> Optional[Shape]:
-        return self._shape
-
-    @shape.setter
-    def shape(self, value: Optional[Shape]) -> None:
-        self._shape = value
-
-    def view_volume(self, left_fov, right_fov, bottom_fov, top_fov, near) -> None:
-        self.left_fov = left_fov
-        self.right_fov = right_fov
-        self.bottom_fov = bottom_fov
-        self.top_fov = top_fov
-        self.near = near
-
-    def image_pyramid(self, tile_size, max_width, max_height, grid_origin) -> None:
-        self.tile_size = tile_size
-        self.max_width = max_width
-        self.max_height = max_height
-        self.grid_origin = grid_origin
+        self.rotation = rotation
+        self.view_volume = view_volume
+        self.image_pyramid = image_pyramid
+        self.point = point
+        self.shape = shape
 
     def etree_element(
         self,
@@ -528,83 +562,191 @@ def etree_element(
         verbosity: Verbosity = Verbosity.normal,
     ) -> Element:
         element = super().etree_element(precision=precision, verbosity=verbosity)
-        if self._rotation:
-            rotation = config.etree.SubElement(element, f"{self.ns}rotation")
-            rotation.text = self._rotation
-        if all(
-            [
-                self._left_fow,
-                self._right_fov,
-                self._bottom_fov,
-                self._top_fov,
-                self._near,
-            ],
-        ):
-            view_volume = config.etree.SubElement(element, f"{self.ns}ViewVolume")
-            left_fov = config.etree.SubElement(view_volume, f"{self.ns}leftFov")
-            left_fov.text = self._left_fow
-            right_fov = config.etree.SubElement(view_volume, f"{self.ns}rightFov")
-            right_fov.text = self._right_fov
-            bottom_fov = config.etree.SubElement(view_volume, f"{self.ns}bottomFov")
-            bottom_fov.text = self._bottom_fov
-            top_fov = config.etree.SubElement(view_volume, f"{self.ns}topFov")
-            top_fov.text = self._top_fov
-            near = config.etree.SubElement(view_volume, f"{self.ns}near")
-            near.text = self._near
-        if all([self._tile_size, self._max_width, self._max_height, self._grid_origin]):
-            image_pyramid = config.etree.SubElement(element, f"{self.ns}ImagePyramid")
-            tile_size = config.etree.SubElement(image_pyramid, f"{self.ns}tileSize")
-            tile_size.text = self._tile_size
-            max_width = config.etree.SubElement(image_pyramid, f"{self.ns}maxWidth")
-            max_width.text = self._max_width
-            max_height = config.etree.SubElement(image_pyramid, f"{self.ns}maxHeight")
-            max_height.text = self._max_height
-            grid_origin = config.etree.SubElement(image_pyramid, f"{self.ns}gridOrigin")
-            grid_origin.text = self._grid_origin
+        if self.rotation is not None:
+            rotation = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}rotation",
+            )
+            rotation.text = str(self.rotation)
+        if self.view_volume:
+            element.append(self.view_volume.etree_element())
+        if self.image_pyramid:
+            element.append(self.image_pyramid.etree_element())
+        if self.point:
+            element.append(self.point.etree_element())
+        if self.shape:
+            shape = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}shape",
+            )
+            shape.text = self.shape.value
         return element
 
-    def from_element(self, element) -> None:
+    def from_element(self, element: Element, strict: bool = True) -> None:
         super().from_element(element)
         rotation = element.find(f"{self.ns}rotation")
         if rotation is not None:
-            self.rotation = rotation.text
+            self.rotation = float(rotation.text)
         view_volume = element.find(f"{self.ns}ViewVolume")
         if view_volume is not None:
-            left_fov = view_volume.find(f"{self.ns}leftFov")
-            if left_fov is not None:
-                self.left_fov = left_fov.text
-            right_fov = view_volume.find(f"{self.ns}rightFov")
-            if right_fov is not None:
-                self.right_fov = right_fov.text
-            bottom_fov = view_volume.find(f"{self.ns}bottomFov")
-            if bottom_fov is not None:
-                self.bottom_fov = bottom_fov.text
-            top_fov = view_volume.find(f"{self.ns}topFov")
-            if top_fov is not None:
-                self.top_fov = top_fov.text
-            near = view_volume.find(f"{self.ns}near")
-            if near is not None:
-                self.near = near.text
+            self.view_volume = cast(
+                ViewVolume,
+                ViewVolume.class_from_element(
+                    ns=self.ns,
+                    name_spaces=self.name_spaces,
+                    element=view_volume,
+                    strict=False,
+                ),
+            )
         image_pyramid = element.find(f"{self.ns}ImagePyramid")
         if image_pyramid is not None:
-            tile_size = image_pyramid.find(f"{self.ns}tileSize")
-            if tile_size is not None:
-                self.tile_size = tile_size.text
-            max_width = image_pyramid.find(f"{self.ns}maxWidth")
-            if max_width is not None:
-                self.max_width = max_width.text
-            max_height = image_pyramid.find(f"{self.ns}maxHeight")
-            if max_height is not None:
-                self.max_height = max_height.text
-            grid_origin = image_pyramid.find(f"{self.ns}gridOrigin")
-            if grid_origin is not None:
-                self.grid_origin = grid_origin.text
+            self.image_pyramid = cast(
+                ImagePyramid,
+                ImagePyramid.class_from_element(
+                    ns=self.ns,
+                    name_spaces=self.name_spaces,
+                    element=image_pyramid,
+                    strict=False,
+                ),
+            )
         point = element.find(f"{self.ns}Point")
         if point is not None:
-            self.point = point.text
+            self.point = cast(
+                Point,
+                Point.class_from_element(
+                    ns=self.ns,
+                    name_spaces=self.name_spaces,
+                    element=point,
+                    strict=False,
+                ),
+            )
         shape = element.find(f"{self.ns}shape")
         if shape is not None:
-            self.shape = shape.text
+            self.shape = Shape(shape.text)
+
+
+class LatLonBox(_XMLObject):
+    """
+    Specifies where the top, bottom, right, and left sides of a bounding box for the
+    ground overlay are aligned.
+    Also, optionally the rotation of the overlay.
+
+    <north> Specifies the latitude of the north edge of the bounding box,
+    in decimal degrees from 0 to ±90.
+    <south> Specifies the latitude of the south edge of the bounding box,
+    in decimal degrees from 0 to ±90.
+    <east> Specifies the longitude of the east edge of the bounding box,
+    in decimal degrees from 0 to ±180.
+    (For overlays that overlap the meridian of 180° longitude,
+    values can extend beyond that range.)
+    <west> Specifies the longitude of the west edge of the bounding box,
+    in decimal degrees from 0 to ±180.
+    (For overlays that overlap the meridian of 180° longitude,
+    values can extend beyond that range.)
+    <rotation> Specifies a rotation of the overlay about its center, in degrees.
+    Values can be ±180. The default is 0 (north).
+    Rotations are specified in a counterclockwise direction.
+    """
+
+    __name__ = "LatLonBox"
+    north: Optional[float]
+    south: Optional[float]
+    east: Optional[float]
+    west: Optional[float]
+    rotation: Optional[float]
+
+    def __init__(
+        self,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        north: Optional[float] = None,
+        south: Optional[float] = None,
+        east: Optional[float] = None,
+        west: Optional[float] = None,
+        rotation: Optional[float] = None,
+    ) -> None:
+        super().__init__(ns=ns, name_spaces=name_spaces)
+        self.north = north
+        self.south = south
+        self.east = east
+        self.west = west
+        self.rotation = rotation
+
+    def __bool__(self) -> bool:
+        return all(
+            [
+                self.north is not None,
+                self.south is not None,
+                self.east is not None,
+                self.west is not None,
+            ],
+        )
+
+    def etree_element(
+        self,
+        precision: Optional[int] = None,
+        verbosity: Verbosity = Verbosity.normal,
+    ) -> Element:
+        element = super().etree_element(precision=precision, verbosity=verbosity)
+        north = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}north",
+        )
+        north.text = str(self.north)
+        south = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}south",
+        )
+        south.text = str(self.south)
+        east = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}east",
+        )
+        east.text = str(self.east)
+        west = config.etree.SubElement(  # type: ignore[attr-defined]
+            element,
+            f"{self.ns}west",
+        )
+        west.text = str(self.west)
+        if self.rotation is not None:
+            rotation = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}rotation",
+            )
+            rotation.text = str(self.rotation)
+        return element
+
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        north = element.find(f"{ns}north")
+        if north is not None:
+            kwargs["north"] = float(north.text)
+        south = element.find(f"{ns}south")
+        if south is not None:
+            kwargs["south"] = float(south.text)
+        east = element.find(f"{ns}east")
+        if east is not None:
+            kwargs["east"] = float(east.text)
+        west = element.find(f"{ns}west")
+        if west is not None:
+            kwargs["west"] = float(west.text)
+        rotation = element.find(f"{ns}rotation")
+        if rotation is not None:
+            kwargs["rotation"] = float(rotation.text)
+        return kwargs
 
 
 class GroundOverlay(_Overlay):
@@ -614,15 +756,17 @@ class GroundOverlay(_Overlay):
     can be either on a local file system or on a web server. If this element
     is omitted or contains no <href>, a rectangle is drawn using the color and
     LatLonBox bounds defined by the ground overlay.
+
+    https://developers.google.com/kml/documentation/kmlreference#groundoverlay
     """
 
     __name__ = "GroundOverlay"
 
-    _altitude = None
+    altitude: Optional[float]
     # Specifies the distance above the earth's surface, in meters, and is
     # interpreted according to the altitude mode.
 
-    _altitude_mode = "clampToGround"
+    altitude_mode: Optional[AltitudeMode]
     # Specifies how the <altitude> is interpreted. Possible values are:
     #   clampToGround -
     #       (default) Indicates to ignore the altitude specification and drape
@@ -636,156 +780,67 @@ class GroundOverlay(_Overlay):
     #       the terrain is 3 meters above sea level, the overlay will appear
     #       elevated above the terrain by 7 meters.
 
-    # - LatLonBox -
-    # TODO: Convert this to it's own class?
+    lat_lon_box: Optional[LatLonBox]
     # Specifies where the top, bottom, right, and left sides of a bounding box
     # for the ground overlay are aligned. Also, optionally the rotation of the
     # overlay.
 
-    _north = None
-    # Specifies the latitude of the north edge of the bounding box, in decimal
-    # degrees from 0 to ±90.
-
-    _south = None
-    # Specifies the latitude of the south edge of the bounding box, in decimal
-    # degrees from 0 to ±90.
-
-    _east = None
-    # Specifies the longitude of the east edge of the bounding box, in decimal
-    # degrees from 0 to ±180. (For overlays that overlap the meridian of 180°
-    # longitude, values can extend beyond that range.)
-
-    _west = None
-    # Specifies the longitude of the west edge of the bounding box, in decimal
-    # degrees from 0 to ±180. (For overlays that overlap the meridian of 180°
-    # longitude, values can extend beyond that range.)
-
-    _rotation = None
-    # Specifies a rotation of the overlay about its center, in degrees. Values
-    # can be ±180. The default is 0 (north). Rotations are specified in a
-    # counterclockwise direction.
-
-    # TODO: <gx:LatLonQuad>
-    # Used for nonrectangular quadrilateral ground overlays.
-    _lat_lon_quad = None
-
-    @property
-    def altitude(self) -> Optional[str]:
-        return self._altitude
-
-    @altitude.setter
-    def altitude(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._altitude = str(value)
-        elif value is None:
-            self._altitude = None
-        else:
-            raise ValueError
-
-    @property
-    def altitude_mode(self) -> str:
-        return self._altitude_mode
-
-    @altitude_mode.setter
-    def altitude_mode(self, mode) -> None:
-        if mode in ("clampToGround", "absolute"):
-            self._altitude_mode = str(mode)
-        else:
-            self._altitude_mode = "clampToGround"
-
-    @property
-    def north(self) -> Optional[str]:
-        return self._north
-
-    @north.setter
-    def north(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._north = str(value)
-        elif value is None:
-            self._north = None
-        else:
-            raise ValueError
-
-    @property
-    def south(self) -> Optional[str]:
-        return self._south
-
-    @south.setter
-    def south(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._south = str(value)
-        elif value is None:
-            self._south = None
-        else:
-            raise ValueError
-
-    @property
-    def east(self) -> Optional[str]:
-        return self._east
-
-    @east.setter
-    def east(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._east = str(value)
-        elif value is None:
-            self._east = None
-        else:
-            raise ValueError
-
-    @property
-    def west(self) -> Optional[str]:
-        return self._west
-
-    @west.setter
-    def west(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._west = str(value)
-        elif value is None:
-            self._west = None
-        else:
-            raise ValueError
-
-    @property
-    def rotation(self) -> Optional[str]:
-        return self._rotation
-
-    @rotation.setter
-    def rotation(self, value) -> None:
-        if isinstance(value, (str, int, float)):
-            self._rotation = str(value)
-        elif value is None:
-            self._rotation = None
-        else:
-            raise ValueError
-
-    def lat_lon_box(
+    def __init__(
         self,
-        north: int,
-        south: int,
-        east: int,
-        west: int,
-        rotation: int = 0,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        id: Optional[str] = None,
+        target_id: Optional[str] = None,
+        name: Optional[str] = None,
+        visibility: Optional[bool] = None,
+        isopen: Optional[bool] = None,
+        atom_link: Optional[atom.Link] = None,
+        atom_author: Optional[atom.Author] = None,
+        address: Optional[str] = None,
+        phone_number: Optional[str] = None,
+        snippet: Optional[Snippet] = None,
+        description: Optional[str] = None,
+        view: Optional[Union[Camera, LookAt]] = None,
+        times: Optional[Union[TimeSpan, TimeStamp]] = None,
+        style_url: Optional[StyleUrl] = None,
+        styles: Optional[List[Style]] = None,
+        region: Optional[Region] = None,
+        extended_data: Optional[ExtendedData] = None,
+        color: Optional[str] = None,
+        draw_order: Optional[str] = None,
+        icon: Optional[Icon] = None,
+        # Ground Overlay specific
+        altitude: Optional[float] = None,
+        altitude_mode: Optional[AltitudeMode] = None,
+        lat_lon_box: Optional[LatLonBox] = None,
     ) -> None:
-        if -90 <= float(north) <= 90:
-            self.north = north
-        else:
-            raise ValueError
-        if -90 <= float(south) <= 90:
-            self.south = south
-        else:
-            raise ValueError
-        if -180 <= float(east) <= 180:
-            self.east = east
-        else:
-            raise ValueError
-        if -180 <= float(west) <= 180:
-            self.west = west
-        else:
-            raise ValueError
-        if -180 <= float(rotation) <= 180:
-            self.rotation = rotation
-        else:
-            raise ValueError
+        super().__init__(
+            ns=ns,
+            name_spaces=name_spaces,
+            id=id,
+            target_id=target_id,
+            name=name,
+            visibility=visibility,
+            isopen=isopen,
+            atom_link=atom_link,
+            atom_author=atom_author,
+            address=address,
+            phone_number=phone_number,
+            snippet=snippet,
+            description=description,
+            view=view,
+            times=times,
+            style_url=style_url,
+            styles=styles,
+            region=region,
+            extended_data=extended_data,
+            color=color,
+            draw_order=draw_order,
+            icon=icon,
+        )
+        self.altitude = altitude
+        self.altitude_mode = altitude_mode
+        self.lat_lon_box = lat_lon_box
 
     def etree_element(
         self,
@@ -793,52 +848,38 @@ def etree_element(
         verbosity: Verbosity = Verbosity.normal,
     ) -> Element:
         element = super().etree_element(precision=precision, verbosity=verbosity)
-        if self._altitude:
-            altitude = config.etree.SubElement(element, f"{self.ns}altitude")
-            altitude.text = self._altitude
-            if self._altitude_mode:
-                altitude_mode = config.etree.SubElement(
+        if self.altitude:
+            altitude = config.etree.SubElement(  # type: ignore[attr-defined]
+                element,
+                f"{self.ns}altitude",
+            )
+            altitude.text = str(self.altitude)
+            if self.altitude_mode:
+                altitude_mode = config.etree.SubElement(  # type: ignore[attr-defined]
                     element,
                     f"{self.ns}altitudeMode",
                 )
-                altitude_mode.text = self._altitude_mode
-        if all([self._north, self._south, self._east, self._west]):
-            lat_lon_box = config.etree.SubElement(element, f"{self.ns}LatLonBox")
-            north = config.etree.SubElement(lat_lon_box, f"{self.ns}north")
-            north.text = self._north
-            south = config.etree.SubElement(lat_lon_box, f"{self.ns}south")
-            south.text = self._south
-            east = config.etree.SubElement(lat_lon_box, f"{self.ns}east")
-            east.text = self._east
-            west = config.etree.SubElement(lat_lon_box, f"{self.ns}west")
-            west.text = self._west
-            if self._rotation:
-                rotation = config.etree.SubElement(lat_lon_box, f"{self.ns}rotation")
-                rotation.text = self._rotation
+                altitude_mode.text = self.altitude_mode.value
+        if self.lat_lon_box:
+            element.append(self.lat_lon_box.etree_element())
         return element
 
-    def from_element(self, element: Element) -> None:
+    def from_element(self, element: Element, strict: bool = False) -> None:
         super().from_element(element)
         altitude = element.find(f"{self.ns}altitude")
         if altitude is not None:
-            self.altitude = altitude.text
+            self.altitude = float(altitude.text)
         altitude_mode = element.find(f"{self.ns}altitudeMode")
         if altitude_mode is not None:
-            self.altitude_mode = altitude_mode.text
+            self.altitude_mode = AltitudeMode(altitude_mode.text)
         lat_lon_box = element.find(f"{self.ns}LatLonBox")
         if lat_lon_box is not None:
-            north = lat_lon_box.find(f"{self.ns}north")
-            if north is not None:
-                self.north = north.text
-            south = lat_lon_box.find(f"{self.ns}south")
-            if south is not None:
-                self.south = south.text
-            east = lat_lon_box.find(f"{self.ns}east")
-            if east is not None:
-                self.east = east.text
-            west = lat_lon_box.find(f"{self.ns}west")
-            if west is not None:
-                self.west = west.text
-            rotation = lat_lon_box.find(f"{self.ns}rotation")
-            if rotation is not None:
-                self.rotation = rotation.text
+            self.lat_lon_box = cast(
+                LatLonBox,
+                LatLonBox.class_from_element(
+                    ns=self.ns,
+                    name_spaces=self.name_spaces,
+                    element=lat_lon_box,
+                    strict=False,
+                ),
+            )
diff --git a/tests/overlays_test.py b/tests/overlays_test.py
index afb2b804..df0e35bd 100644
--- a/tests/overlays_test.py
+++ b/tests/overlays_test.py
@@ -57,166 +57,7 @@ def test_draw_order_none(self) -> None:
 
 
 class TestGroundOverlay(StdLibrary):
-    def test_altitude_int(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.altitude = 123
-        assert go.altitude == "123"
-
-    def test_altitude_float(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.altitude = 123.4
-        assert go.altitude == "123.4"
-
-    def test_altitude_string(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.altitude = "123"
-        assert go.altitude == "123"
-
-    def test_altitude_value_error(self) -> None:
-        go = overlays.GroundOverlay()
-
-        with pytest.raises(ValueError):
-            go.altitude = object()
-
-    def test_altitude_none(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.altitude = "123"
-        assert go.altitude == "123"
-        go.altitude = None
-        assert go.altitude is None
-
-    def test_altitude_mode_default(self) -> None:
-        go = overlays.GroundOverlay()
-
-        assert go.altitude_mode == "clampToGround"
-
-    def test_altitude_mode_error(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.altitude_mode = ""
-        assert go.altitude_mode == "clampToGround"
-
-    def test_altitude_mode_clamp(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.altitude_mode = "clampToGround"
-        assert go.altitude_mode == "clampToGround"
-
-    def test_altitude_mode_absolute(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.altitude_mode = "absolute"
-        assert go.altitude_mode == "absolute"
-
-    def test_latlonbox_function(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.lat_lon_box(10, 20, 30, 40, 50)
-
-        assert go.north == "10"
-        assert go.south == "20"
-        assert go.east == "30"
-        assert go.west == "40"
-        assert go.rotation == "50"
-
-    def test_latlonbox_string(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.north = "10"
-        go.south = "20"
-        go.east = "30"
-        go.west = "40"
-        go.rotation = "50"
-
-        assert go.north == "10"
-        assert go.south == "20"
-        assert go.east == "30"
-        assert go.west == "40"
-        assert go.rotation == "50"
-
-    def test_latlonbox_int(self) -> None:
-        go = overlays.GroundOverlay()
-
-        go.north = 10
-        go.south = 20
-        go.east = 30
-        go.west = 40
-        go.rotation = 50
-
-        assert go.north == "10"
-        assert go.south == "20"
-        assert go.east == "30"
-        assert go.west == "40"
-        assert go.rotation == "50"
-
-    def test_latlonbox_float(self) -> None:
-        go = overlays.GroundOverlay()
-        go.north = 10.0
-        go.south = 20.0
-        go.east = 30.0
-        go.west = 40.0
-        go.rotation = 50.0
-
-        assert go.north == "10.0"
-        assert go.south == "20.0"
-        assert go.east == "30.0"
-        assert go.west == "40.0"
-        assert go.rotation == "50.0"
-
-    def test_latlonbox_value_error(self) -> None:
-        go = overlays.GroundOverlay()
-        with pytest.raises(ValueError):
-            go.north = object()
-
-        with pytest.raises(ValueError):
-            go.south = object()
-
-        with pytest.raises(ValueError):
-            go.east = object()
-
-        with pytest.raises(ValueError):
-            go.west = object()
-
-        with pytest.raises(ValueError):
-            go.rotation = object()
-
-        assert go.north is None
-        assert go.south is None
-        assert go.east is None
-        assert go.west is None
-        assert go.rotation is None
-
-    def test_latlonbox_empty_string(self) -> None:
-        go = overlays.GroundOverlay()
-        go.north = ""
-        go.south = ""
-        go.east = ""
-        go.west = ""
-        go.rotation = ""
-
-        assert not go.north
-        assert not go.south
-        assert not go.east
-        assert not go.west
-        assert not go.rotation
-
-    def test_latlonbox_none(self) -> None:
-        go = overlays.GroundOverlay()
-        go.north = None
-        go.south = None
-        go.east = None
-        go.west = None
-        go.rotation = None
-
-        assert go.north is None
-        assert go.south is None
-        assert go.east is None
-        assert go.west is None
-        assert go.rotation is None
+    pass
 
 
 class TestGroundOverlayString(StdLibrary):
@@ -252,13 +93,12 @@ def test_to_string(self) -> None:
 
     def test_altitude_from_int(self) -> None:
         g = overlays.GroundOverlay()
-        g.altitude = 123
+        g.altitude = 123.0
 
         expected = overlays.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:altitude>123</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
             "</kml:GroundOverlay>",
         )
 
@@ -272,15 +112,16 @@ def test_altitude_from_float(self) -> None:
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:altitude>123.4</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
             "</kml:GroundOverlay>",
         )
 
         assert g.to_string() == expected.to_string()
 
     def test_altitude_from_string(self) -> None:
-        g = overlays.GroundOverlay()
-        g.altitude = "123.4"
+        g = overlays.GroundOverlay(
+            altitude=123.4,
+            altitude_mode=AltitudeMode.clamp_to_ground,
+        )
 
         expected = overlays.GroundOverlay()
         expected.from_string(
@@ -293,10 +134,7 @@ def test_altitude_from_string(self) -> None:
         assert g.to_string() == expected.to_string()
 
     def test_altitude_mode_absolute(self) -> None:
-        g = overlays.GroundOverlay()
-        g.altitude = "123.4"
-        g.altitude_mode = "absolute"
-
+        g = overlays.GroundOverlay(altitude=123.4, altitude_mode=AltitudeMode.absolute)
         expected = overlays.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
@@ -307,39 +145,15 @@ def test_altitude_mode_absolute(self) -> None:
 
         assert g.to_string() == expected.to_string()
 
-    def test_altitude_mode_unknown_string(self) -> None:
-        g = overlays.GroundOverlay()
-        g.altitude = "123.4"
-        g.altitudeMode = "unknown string"
-
-        expected = overlays.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:altitude>123.4</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
-    def test_altitude_mode_value(self) -> None:
-        g = overlays.GroundOverlay()
-        g.altitude = "123.4"
-        g.altitudeMode = 1234
-
-        expected = overlays.GroundOverlay()
-        expected.from_string(
-            '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
-            "<kml:altitude>123.4</kml:altitude>"
-            "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
-            "</kml:GroundOverlay>",
-        )
-
-        assert g.to_string() == expected.to_string()
-
     def test_latlonbox_no_rotation(self) -> None:
-        g = overlays.GroundOverlay()
-        g.lat_lon_box(10, 20, 30, 40)
+        llb = overlays.LatLonBox(
+            ns="{http://www.opengis.net/kml/2.2}",
+            north=10.0,
+            south=20.0,
+            east=30.0,
+            west=40.0,
+        )
+        g = overlays.GroundOverlay(lat_lon_box=llb)
 
         expected = overlays.GroundOverlay()
         expected.from_string(
@@ -349,7 +163,6 @@ def test_latlonbox_no_rotation(self) -> None:
             "<kml:south>20</kml:south>"
             "<kml:east>30</kml:east>"
             "<kml:west>40</kml:west>"
-            "<kml:rotation>0</kml:rotation>"
             "</kml:LatLonBox>"
             "</kml:GroundOverlay>",
         )
@@ -357,8 +170,15 @@ def test_latlonbox_no_rotation(self) -> None:
         assert g.to_string() == expected.to_string()
 
     def test_latlonbox_rotation(self) -> None:
-        g = overlays.GroundOverlay()
-        g.lat_lon_box(10, 20, 30, 40, 50)
+        llb = overlays.LatLonBox(
+            ns="{http://www.opengis.net/kml/2.2}",
+            north=10.0,
+            south=20.0,
+            east=30.0,
+            west=40.0,
+            rotation=50.0,
+        )
+        g = overlays.GroundOverlay(lat_lon_box=llb)
 
         expected = overlays.GroundOverlay()
         expected.from_string(
@@ -376,13 +196,16 @@ def test_latlonbox_rotation(self) -> None:
         assert g.to_string() == expected.to_string()
 
     def test_latlonbox_nswer(self) -> None:
+        llb = overlays.LatLonBox(
+            ns="{http://www.opengis.net/kml/2.2}",
+            north=10.0,
+            south=20.0,
+            east=30.0,
+            west=40.0,
+            rotation=50.0,
+        )
         g = overlays.GroundOverlay()
-        g.north = 10
-        g.south = 20
-        g.east = 30
-        g.west = 40
-        g.rotation = 50
-
+        g.lat_lon_box = llb
         expected = overlays.GroundOverlay()
         expected.from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'

From 6877c42ef3ddb69987a9cdf4cb7e31c699917cb5 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Thu, 23 Nov 2023 22:01:38 +0000
Subject: [PATCH 15/25] fix super call

---
 fastkml/features.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fastkml/features.py b/fastkml/features.py
index be40f1b5..f7745c7a 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -759,7 +759,7 @@ def etree_element(
         return element
 
     def from_element(self, element: Element, strict: bool = False) -> None:
-        super(_Feature, self).from_element(element)
+        super().from_element(element)
 
         visibility = element.find(f"{self.ns}refreshVisibility")
         if visibility is not None:

From 40d350697a59ba6abded74baab38a6f20fd76933 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Fri, 24 Nov 2023 00:13:07 +0000
Subject: [PATCH 16/25] Refactor _get_kwargs method in containers.py and
 overlays.py

---
 fastkml/containers.py |  56 +++++++++++
 fastkml/features.py   | 219 +++++++++++++++++++++++++++++++++++++++++-
 fastkml/overlays.py   | 124 ++++++++++++++++++++++++
 3 files changed, 397 insertions(+), 2 deletions(-)

diff --git a/fastkml/containers.py b/fastkml/containers.py
index 4bf54a55..dbb7771e 100644
--- a/fastkml/containers.py
+++ b/fastkml/containers.py
@@ -1,6 +1,7 @@
 """Container classes for KML elements."""
 import logging
 import urllib.parse as urlparse
+from typing import Any
 from typing import Dict
 from typing import Iterable
 from typing import Iterator
@@ -127,6 +128,39 @@ def append(self, kmlobj: _Feature) -> None:
         assert self._features is not None
         self._features.append(kmlobj)
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        kwargs["features"] = []
+        folders = element.findall(f"{ns}Folder")
+        kwargs["features"] += [
+            Folder.class_from_element(ns=ns, element=folder, strict=strict)
+            for folder in folders
+        ]
+        placemarks = element.findall(f"{ns}Placemark")
+        kwargs["features"] += [
+            Placemark.class_from_element(ns=ns, element=placemark, strict=strict)
+            for placemark in placemarks
+        ]
+        documents = element.findall(f"{ns}Document")
+        kwargs["features"] += [
+            Document.class_from_element(ns=ns, element=document, strict=strict)
+            for document in documents
+        ]
+        return kwargs
+
 
 class Folder(_Container):
     """
@@ -260,3 +294,25 @@ def etree_element(
     def get_style_by_url(self, style_url: str) -> Optional[Union[Style, StyleMap]]:
         id_ = urlparse.urlparse(style_url).fragment
         return next((style for style in self.styles() if style.id == id_), None)
+
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        schemata = element.findall(f"{ns}Schema")
+        kwargs["schemata"] = [
+            Schema.class_from_element(ns=ns, element=schema, strict=strict)
+            for schema in schemata
+        ]
+        return kwargs
diff --git a/fastkml/features.py b/fastkml/features.py
index f7745c7a..4412047c 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -6,6 +6,7 @@
 
 import logging
 from dataclasses import dataclass
+from typing import Any
 from typing import Dict
 from typing import Iterator
 from typing import List
@@ -360,10 +361,10 @@ def from_element(self, element: Element, strict: bool = False) -> None:
             self.description = description.text
         visibility = element.find(f"{self.ns}visibility")
         if visibility is not None and visibility.text:
-            self.visibility = True if visibility.text in ["1", "true"] else False
+            self.visibility = visibility.text in ["1", "true"]
         isopen = element.find(f"{self.ns}open")
         if isopen is not None:
-            self.isopen = True if isopen.text in ["1", "true"] else False
+            self.isopen = isopen.text in ["1", "true"]
         styles = element.findall(f"{self.ns}Style")
         for style in styles:
             s = Style.class_from_element(
@@ -475,6 +476,111 @@ def from_element(self, element: Element, strict: bool = False) -> None:
                 ),
             )
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        name = element.find(f"{ns}name")
+        if name is not None:
+            kwargs["name"] = name.text
+        description = element.find(f"{ns}description")
+        if description is not None:
+            kwargs["description"] = description.text
+        visibility = element.find(f"{ns}visibility")
+        if visibility is not None and visibility.text:
+            kwargs["visibility"] = visibility.text in ["1", "true"]
+        isopen = element.find(f"{ns}open")
+        if isopen is not None:
+            kwargs["isopen"] = isopen.text in ["1", "true"]
+        style_url = element.find(f"{ns}styleUrl")
+        if style_url is not None:
+            kwargs["style_url"] = StyleUrl.class_from_element(
+                ns=ns,
+                name_spaces=name_spaces,
+                element=style_url,
+                strict=strict,
+            )
+        snippet = element.find(f"{ns}Snippet")
+        if snippet is not None:
+            max_lines = snippet.get("maxLines")
+            if max_lines is not None:
+                kwargs["snippet"] = Snippet(text=snippet.text, max_lines=int(max_lines))
+            else:
+                kwargs["snippet"] = Snippet(  # type: ignore[unreachable]
+                    text=snippet.text
+                )
+        timespan = element.find(f"{ns}TimeSpan")
+        if timespan is not None:
+            kwargs["times"] = TimeSpan.class_from_element(
+                ns=ns,
+                name_spaces=name_spaces,
+                element=timespan,
+                strict=strict,
+            )
+        timestamp = element.find(f"{ns}TimeStamp")
+        if timestamp is not None:
+            kwargs["times"] = TimeStamp.class_from_element(
+                ns=ns,
+                name_spaces=name_spaces,
+                element=timestamp,
+                strict=strict,
+            )
+        atom_link = element.find(f"{atom.NS}link")
+        if atom_link is not None:
+            kwargs["atom_link"] = atom.Link.class_from_element(
+                ns=atom.NS,
+                name_spaces=name_spaces,
+                element=atom_link,
+                strict=strict,
+            )
+        atom_author = element.find(f"{atom.NS}author")
+        if atom_author is not None:
+            kwargs["atom_author"] = atom.Author.class_from_element(
+                ns=atom.NS,
+                name_spaces=name_spaces,
+                element=atom_author,
+                strict=strict,
+            )
+        extended_data = element.find(f"{ns}ExtendedData")
+        if extended_data is not None:
+            kwargs["extended_data"] = ExtendedData.class_from_element(
+                ns=ns,
+                element=extended_data,
+                strict=strict,
+            )
+        address = element.find(f"{ns}address")
+        if address is not None:
+            kwargs["address"] = address.text
+        phone_number = element.find(f"{ns}phoneNumber")
+        if phone_number is not None:
+            kwargs["phone_number"] = phone_number.text
+        camera = element.find(f"{ns}Camera")
+        if camera is not None:
+            kwargs["view"] = Camera.class_from_element(
+                ns=ns,
+                element=camera,
+                strict=strict,
+            )
+        lookat = element.find(f"{ns}LookAt")
+        if lookat is not None:
+            kwargs["view"] = LookAt.class_from_element(
+                ns=ns,
+                element=lookat,
+                strict=strict,
+            )
+        return kwargs
+
 
 class Placemark(_Feature):
     """
@@ -637,6 +743,84 @@ def etree_element(
             logger.error("Object does not have a geometry")
         return element
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        point = element.find(f"{ns}Point")
+        if point is not None:
+            kwargs["geometry"] = Point.class_from_element(
+                ns=ns,
+                element=point,
+                strict=strict,
+            )
+            return kwargs
+        line = element.find(f"{ns}LineString")
+        if line is not None:
+            kwargs["geometry"] = LineString.class_from_element(
+                ns=ns,
+                element=line,
+                strict=strict,
+            )
+            return kwargs
+        polygon = element.find(f"{ns}Polygon")
+        if polygon is not None:
+            kwargs["geometry"] = Polygon.class_from_element(
+                ns=ns,
+                element=polygon,
+                strict=strict,
+            )
+            return kwargs
+        linearring = element.find(f"{ns}LinearRing")
+        if linearring is not None:
+            kwargs["geometry"] = LinearRing.class_from_element(
+                ns=ns,
+                element=linearring,
+                strict=strict,
+            )
+            return kwargs
+        multigeometry = element.find(f"{ns}MultiGeometry")
+        if multigeometry is not None:
+            kwargs["geometry"] = MultiGeometry.class_from_element(
+                ns=ns,
+                element=multigeometry,
+                strict=strict,
+            )
+            return kwargs
+        track = element.find(f"{ns}Track")
+        if track is not None:
+            kwargs["geometry"] = gx.Track.class_from_element(
+                ns=config.GXNS,
+                element=track,
+                strict=strict,
+            )
+            return kwargs
+        multitrack = element.find(f"{ns}MultiTrack")
+        if multitrack is not None:
+            kwargs["geometry"] = gx.MultiTrack.class_from_element(
+                ns=config.GXNS,
+                element=multitrack,
+                strict=strict,
+            )
+            return kwargs
+        logger.warning("No geometries found")
+        logger.debug(
+            "Problem with element: %",
+            config.etree.tostring(element),  # type: ignore[attr-defined]
+        )
+        return kwargs
+
 
 class NetworkLink(_Feature):
     """
@@ -779,3 +963,34 @@ def from_element(self, element: Element, strict: bool = False) -> None:
                     strict=strict,
                 ),
             )
+
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        visibility = element.find(f"{ns}refreshVisibility")
+        if visibility is not None:
+            kwargs["refresh_visibility"] = bool(int(visibility.text))
+        flyto = element.find(f"{ns}flyToView")
+        if flyto is not None:
+            kwargs["fly_to_view"] = bool(int(flyto.text))
+        link = element.find(f"{ns}Link")
+        if link is not None:
+            kwargs["link"] = Link.class_from_element(
+                ns=ns,
+                name_spaces=name_spaces,
+                element=link,
+                strict=strict,
+            )
+        return kwargs
diff --git a/fastkml/overlays.py b/fastkml/overlays.py
index 8b1ab757..f2cd16e7 100644
--- a/fastkml/overlays.py
+++ b/fastkml/overlays.py
@@ -192,6 +192,40 @@ def from_element(self, element: Element, strict: bool = False) -> None:
                 ),
             )
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        color = element.find(f"{ns}color")
+        if color is not None:
+            kwargs["color"] = color.text
+        draw_order = element.find(f"{ns}drawOrder")
+        if draw_order is not None:
+            kwargs["draw_order"] = draw_order.text
+        icon = element.find(f"{ns}Icon")
+        if icon is not None:
+            kwargs["icon"] = cast(
+                Icon,
+                Icon.class_from_element(
+                    ns=ns,
+                    name_spaces=name_spaces,
+                    element=icon,
+                    strict=strict,
+                ),
+            )
+        return kwargs
+
 
 class ViewVolume(_XMLObject):
     """
@@ -624,6 +658,62 @@ def from_element(self, element: Element, strict: bool = True) -> None:
         if shape is not None:
             self.shape = Shape(shape.text)
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        rotation = element.find(f"{ns}rotation")
+        if rotation is not None:
+            kwargs["rotation"] = float(rotation.text)
+        view_volume = element.find(f"{ns}ViewVolume")
+        if view_volume is not None:
+            kwargs["view_volume"] = cast(
+                ViewVolume,
+                ViewVolume.class_from_element(
+                    ns=ns,
+                    name_spaces=name_spaces,
+                    element=view_volume,
+                    strict=strict,
+                ),
+            )
+        image_pyramid = element.find(f"{ns}ImagePyramid")
+        if image_pyramid is not None:
+            kwargs["image_pyramid"] = cast(
+                ImagePyramid,
+                ImagePyramid.class_from_element(
+                    ns=ns,
+                    name_spaces=name_spaces,
+                    element=image_pyramid,
+                    strict=strict,
+                ),
+            )
+        point = element.find(f"{ns}Point")
+        if point is not None:
+            kwargs["point"] = cast(
+                Point,
+                Point.class_from_element(
+                    ns=ns,
+                    name_spaces=name_spaces,
+                    element=point,
+                    strict=strict,
+                ),
+            )
+        shape = element.find(f"{ns}shape")
+        if shape is not None:
+            kwargs["shape"] = Shape(shape.text)
+        return kwargs
+
 
 class LatLonBox(_XMLObject):
     """
@@ -883,3 +973,37 @@ def from_element(self, element: Element, strict: bool = False) -> None:
                     strict=False,
                 ),
             )
+
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Optional[Dict[str, str]] = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        altitude = element.find(f"{ns}altitude")
+        if altitude is not None:
+            kwargs["altitude"] = float(altitude.text)
+        altitude_mode = element.find(f"{ns}altitudeMode")
+        if altitude_mode is not None:
+            kwargs["altitude_mode"] = AltitudeMode(altitude_mode.text)
+        lat_lon_box = element.find(f"{ns}LatLonBox")
+        if lat_lon_box is not None:
+            kwargs["lat_lon_box"] = cast(
+                LatLonBox,
+                LatLonBox.class_from_element(
+                    ns=ns,
+                    name_spaces=name_spaces,
+                    element=lat_lon_box,
+                    strict=strict,
+                ),
+            )
+        return kwargs

From 4909d9d31ef016ecf42b0d8bbf5123bca7766a2c Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Fri, 24 Nov 2023 00:13:58 +0000
Subject: [PATCH 17/25] Refactor _get_kwargs method in containers.py and
 overlays.py

---
 fastkml/features.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fastkml/features.py b/fastkml/features.py
index 4412047c..29569a8b 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -518,7 +518,7 @@ def _get_kwargs(
                 kwargs["snippet"] = Snippet(text=snippet.text, max_lines=int(max_lines))
             else:
                 kwargs["snippet"] = Snippet(  # type: ignore[unreachable]
-                    text=snippet.text
+                    text=snippet.text,
                 )
         timespan = element.find(f"{ns}TimeSpan")
         if timespan is not None:

From 9bd8afcf0d728d82089fd9bf4fce69d6c4e19c75 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Fri, 24 Nov 2023 19:51:43 +0000
Subject: [PATCH 18/25] remove from_element in feattures, containers, overlays

---
 fastkml/containers.py  |  48 +-------
 fastkml/features.py    | 268 +++++------------------------------------
 fastkml/kml.py         | 117 +++++++++++++++---
 fastkml/overlays.py    | 105 ++--------------
 tests/oldunit_test.py  |  61 +++++-----
 tests/overlays_test.py |  27 ++---
 6 files changed, 179 insertions(+), 447 deletions(-)

diff --git a/fastkml/containers.py b/fastkml/containers.py
index dbb7771e..0f039a75 100644
--- a/fastkml/containers.py
+++ b/fastkml/containers.py
@@ -8,7 +8,6 @@
 from typing import List
 from typing import Optional
 from typing import Union
-from typing import cast
 
 from fastkml import atom
 from fastkml import gx
@@ -76,7 +75,7 @@ def __init__(
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[StyleUrl] = None,
-        styles: Optional[List[Style]] = None,
+        styles: Optional[Iterable[Union[Style, StyleMap]]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
         # Container specific
@@ -170,24 +169,6 @@ class Folder(_Container):
 
     __name__ = "Folder"
 
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element)
-        folders = element.findall(f"{self.ns}Folder")
-        for folder in folders:
-            feature = Folder(self.ns)
-            feature.from_element(folder)
-            self.append(feature)
-        placemarks = element.findall(f"{self.ns}Placemark")
-        for placemark in placemarks:
-            feature = Placemark(self.ns)  # type: ignore[assignment]
-            feature.from_element(placemark)
-            self.append(feature)
-        documents = element.findall(f"{self.ns}Document")
-        for document in documents:
-            feature = Document(self.ns)  # type: ignore[assignment]
-            feature.from_element(document)
-            self.append(feature)
-
 
 class Document(_Container):
     """
@@ -217,7 +198,7 @@ def __init__(
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[StyleUrl] = None,
-        styles: Optional[List[Style]] = None,
+        styles: Optional[Iterable[Union[Style, StyleMap]]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
         features: Optional[List[_Feature]] = None,
@@ -255,31 +236,6 @@ def append_schema(self, schema: Schema) -> None:
         assert self._schemata is not None
         self._schemata.append(schema)
 
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element)
-        documents = element.findall(f"{self.ns}Document")
-        for document in documents:
-            feature = Document(self.ns)
-            feature.from_element(document)
-            self.append(feature)
-        folders = element.findall(f"{self.ns}Folder")
-        for folder in folders:
-            feature = Folder(self.ns)  # type: ignore[assignment]
-            feature.from_element(folder)
-            self.append(feature)
-        placemarks = element.findall(f"{self.ns}Placemark")
-        for placemark in placemarks:
-            feature = Placemark(self.ns)  # type: ignore[assignment]
-            feature.from_element(placemark)
-            self.append(feature)
-        schemata = element.findall(f"{self.ns}Schema")
-        for schema in schemata:
-            s = cast(
-                Schema,
-                Schema.class_from_element(ns=self.ns, element=schema, strict=strict),
-            )
-            self.append_schema(s)
-
     def etree_element(
         self,
         precision: Optional[int] = None,
diff --git a/fastkml/features.py b/fastkml/features.py
index 29569a8b..7f7b059d 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -8,11 +8,11 @@
 from dataclasses import dataclass
 from typing import Any
 from typing import Dict
+from typing import Iterable
 from typing import Iterator
 from typing import List
 from typing import Optional
 from typing import Union
-from typing import cast
 
 from fastkml import atom
 from fastkml import config
@@ -175,7 +175,7 @@ def __init__(
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[StyleUrl] = None,
-        styles: Optional[List[Style]] = None,
+        styles: Optional[Iterable[Union[Style, StyleMap]]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
     ) -> None:
@@ -183,7 +183,7 @@ def __init__(
         self.name = name
         self.description = description
         self._style_url = style_url
-        self._styles = []
+        self._styles = list(styles) if styles else []
         self._view = view
         self.visibility = visibility
         self.isopen = isopen
@@ -193,9 +193,6 @@ def __init__(
         self.address = address
         self.phone_number = phone_number
         self.region = region
-        if styles:
-            for style in styles:
-                self.append_style(style)
         self.extended_data = extended_data
         self._times = times
 
@@ -351,131 +348,6 @@ def etree_element(
             phone_number.text = self._phone_number
         return element
 
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element)
-        name = element.find(f"{self.ns}name")
-        if name is not None:
-            self.name = name.text
-        description = element.find(f"{self.ns}description")
-        if description is not None:
-            self.description = description.text
-        visibility = element.find(f"{self.ns}visibility")
-        if visibility is not None and visibility.text:
-            self.visibility = visibility.text in ["1", "true"]
-        isopen = element.find(f"{self.ns}open")
-        if isopen is not None:
-            self.isopen = isopen.text in ["1", "true"]
-        styles = element.findall(f"{self.ns}Style")
-        for style in styles:
-            s = Style.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=style,
-                strict=strict,
-            )
-            self.append_style(cast(Style, s))
-        styles = element.findall(f"{self.ns}StyleMap")
-        for style in styles:
-            s = StyleMap.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=style,
-                strict=strict,
-            )
-            self.append_style(cast(StyleMap, s))
-        style_url = element.find(f"{self.ns}styleUrl")
-        if style_url is not None:
-            self._style_url = cast(
-                StyleUrl,
-                StyleUrl.class_from_element(
-                    ns=self.ns,
-                    name_spaces=self.name_spaces,
-                    element=style_url,
-                    strict=strict,
-                ),
-            )
-        snippet = element.find(f"{self.ns}Snippet")
-        if snippet is not None:
-            max_lines = snippet.get("maxLines")
-            if max_lines is not None:
-                self.snippet = Snippet(text=snippet.text, max_lines=int(max_lines))
-            else:
-                self.snippet = Snippet(text=snippet.text)  # type: ignore[unreachable]
-        timespan = element.find(f"{self.ns}TimeSpan")
-        if timespan is not None:
-            self._timespan = TimeSpan.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=timespan,
-                strict=strict,
-            )
-        timestamp = element.find(f"{self.ns}TimeStamp")
-        if timestamp is not None:
-            self._timestamp = TimeStamp.class_from_element(
-                ns=self.ns,
-                name_spaces=self.name_spaces,
-                element=timestamp,
-                strict=strict,
-            )
-        atom_link = element.find(f"{atom.NS}link")
-        if atom_link is not None:
-            self._atom_link = cast(
-                atom.Link,
-                atom.Link.class_from_element(
-                    ns=atom.NS,
-                    name_spaces=self.name_spaces,
-                    element=atom_link,
-                    strict=strict,
-                ),
-            )
-        atom_author = element.find(f"{atom.NS}author")
-        if atom_author is not None:
-            self._atom_author = cast(
-                atom.Author,
-                atom.Author.class_from_element(
-                    ns=atom.NS,
-                    name_spaces=self.name_spaces,
-                    element=atom_author,
-                    strict=strict,
-                ),
-            )
-        extended_data = element.find(f"{self.ns}ExtendedData")
-        if extended_data is not None:
-            self.extended_data = cast(
-                ExtendedData,
-                ExtendedData.class_from_element(
-                    ns=self.ns,
-                    element=extended_data,
-                    strict=strict,
-                ),
-            )
-        address = element.find(f"{self.ns}address")
-        if address is not None:
-            self.address = address.text
-        phone_number = element.find(f"{self.ns}phoneNumber")
-        if phone_number is not None:
-            self.phone_number = phone_number.text
-        camera = element.find(f"{self.ns}Camera")
-        if camera is not None:
-            self._view = cast(
-                Camera,
-                Camera.class_from_element(
-                    ns=self.ns,
-                    element=camera,
-                    strict=strict,
-                ),
-            )
-        lookat = element.find(f"{self.ns}LookAt")
-        if lookat is not None:
-            self._view = cast(
-                LookAt,
-                LookAt.class_from_element(
-                    ns=self.ns,
-                    element=lookat,
-                    strict=strict,
-                ),
-            )
-
     @classmethod
     def _get_kwargs(
         cls,
@@ -511,6 +383,29 @@ def _get_kwargs(
                 element=style_url,
                 strict=strict,
             )
+        styles = element.findall(f"{ns}Style")
+        kwargs["styles"] = []
+        if styles is not None:
+            for style in styles:
+                kwargs["styles"].append(
+                    Style.class_from_element(
+                        ns=ns,
+                        name_spaces=name_spaces,
+                        element=style,
+                        strict=strict,
+                    ),
+                )
+        stylemaps = element.findall(f"{ns}StyleMap")
+        if stylemaps is not None:
+            for stylemap in stylemaps:
+                kwargs["styles"].append(
+                    StyleMap.class_from_element(
+                        ns=ns,
+                        name_spaces=name_spaces,
+                        element=stylemap,
+                        strict=strict,
+                    ),
+                )
         snippet = element.find(f"{ns}Snippet")
         if snippet is not None:
             max_lines = snippet.get("maxLines")
@@ -611,7 +506,7 @@ def __init__(
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[StyleUrl] = None,
-        styles: Optional[List[Style]] = None,
+        styles: Optional[Iterable[Union[Style, StyleMap]]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
         # Placemark specific
@@ -646,91 +541,6 @@ def geometry(self) -> Optional[AnyGeometryType]:
             return self._geometry.geometry
         return None
 
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element)
-        point = element.find(f"{self.ns}Point")
-        if point is not None:
-            self._geometry = cast(
-                Point,
-                Point.class_from_element(
-                    ns=self.ns,
-                    element=point,
-                    strict=strict,
-                ),
-            )
-            return
-        line = element.find(f"{self.ns}LineString")
-        if line is not None:
-            self._geometry = cast(
-                LineString,
-                LineString.class_from_element(
-                    ns=self.ns,
-                    element=line,
-                    strict=strict,
-                ),
-            )
-            return
-        polygon = element.find(f"{self.ns}Polygon")
-        if polygon is not None:
-            self._geometry = cast(
-                Polygon,
-                Polygon.class_from_element(
-                    ns=self.ns,
-                    element=polygon,
-                    strict=strict,
-                ),
-            )
-            return
-        linearring = element.find(f"{self.ns}LinearRing")
-        if linearring is not None:
-            self._geometry = cast(
-                LinearRing,
-                LinearRing.class_from_element(
-                    ns=self.ns,
-                    element=linearring,
-                    strict=strict,
-                ),
-            )
-            return
-        multigeometry = element.find(f"{self.ns}MultiGeometry")
-        if multigeometry is not None:
-            self._geometry = cast(
-                MultiGeometry,
-                MultiGeometry.class_from_element(
-                    ns=self.ns,
-                    element=multigeometry,
-                    strict=strict,
-                ),
-            )
-            return
-        track = element.find(f"{self.ns}Track")
-        if track is not None:
-            self._geometry = cast(
-                gx.Track,
-                gx.Track.class_from_element(
-                    ns=config.GXNS,
-                    element=track,
-                    strict=strict,
-                ),
-            )
-            return
-        multitrack = element.find(f"{self.ns}MultiTrack")
-        if multitrack is not None:
-            self._geometry = cast(
-                gx.MultiTrack,
-                gx.MultiTrack.class_from_element(
-                    ns=config.GXNS,
-                    element=multitrack,
-                    strict=strict,
-                ),
-            )
-            return
-        logger.warning("No geometries found")
-        logger.debug(
-            "Problem with element: %",
-            config.etree.tostring(element),  # type: ignore[attr-defined]
-        )
-
     def etree_element(
         self,
         precision: Optional[int] = None,
@@ -886,7 +696,7 @@ def __init__(
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[StyleUrl] = None,
-        styles: Optional[List[Style]] = None,
+        styles: Optional[Iterable[Union[Style, StyleMap]]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
         # NetworkLink specific
@@ -942,28 +752,6 @@ def etree_element(
             element.append(self.link.etree_element())
         return element
 
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element)
-
-        visibility = element.find(f"{self.ns}refreshVisibility")
-        if visibility is not None:
-            self.visibility = bool(int(visibility.text))
-        flyto = element.find(f"{self.ns}flyToView")
-        if flyto is not None:
-            self.fly_to_view = bool(int(flyto.text))
-
-        link = element.find(f"{self.ns}Link")
-        if link is not None:
-            self._link = cast(
-                Link,
-                Link.class_from_element(
-                    ns=self.ns,
-                    name_spaces=self.name_spaces,
-                    element=link,
-                    strict=strict,
-                ),
-            )
-
     @classmethod
     def _get_kwargs(
         cls,
diff --git a/fastkml/kml.py b/fastkml/kml.py
index c8dae9da..31810ba1 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -25,6 +25,7 @@
 
 """
 import logging
+from typing import Any
 from typing import Dict
 from typing import Iterable
 from typing import Iterator
@@ -32,6 +33,7 @@
 from typing import Union
 
 from fastkml import config
+from fastkml.base import _XMLObject
 from fastkml.containers import Document
 from fastkml.containers import Folder
 from fastkml.enums import Verbosity
@@ -44,7 +46,7 @@
 logger = logging.getLogger(__name__)
 
 
-class KML:
+class KML(_XMLObject):
     """represents a KML File."""
 
     _features = []
@@ -82,29 +84,50 @@ def from_string(self, xml_string: str) -> None:
         ns = element.tag.rstrip("kml")
         documents = element.findall(f"{ns}Document")
         for document in documents:
-            feature = Document(ns)
-            feature.from_element(document)
-            self.append(feature)
+            self.append(
+                Document.class_from_element(
+                    ns=ns,
+                    element=document,
+                    strict=False,
+                ),
+            )
         folders = element.findall(f"{ns}Folder")
         for folder in folders:
-            feature = Folder(ns)
-            feature.from_element(folder)
-            self.append(feature)
+            self.append(
+                Folder.class_from_element(
+                    ns=ns,
+                    element=folder,
+                    strict=False,
+                ),
+            )
         placemarks = element.findall(f"{ns}Placemark")
         for placemark in placemarks:
-            feature = Placemark(ns)
-            feature.from_element(placemark)
-            self.append(feature)
+            self.append(
+                Placemark.class_from_element(
+                    ns=ns,
+                    element=placemark,
+                    strict=False,
+                ),
+            )
         groundoverlays = element.findall(f"{ns}GroundOverlay")
         for groundoverlay in groundoverlays:
-            feature = GroundOverlay(ns)
-            feature.from_element(groundoverlay)
-            self.append(feature)
+            self.append(
+                GroundOverlay.class_from_element(
+                    ns=ns,
+                    element=groundoverlay,
+                    strict=False,
+                ),
+            )
+
         photo_overlays = element.findall(f"{ns}PhotoOverlay")
         for photo_overlay in photo_overlays:
-            feature = PhotoOverlay(ns)
-            feature.from_element(photo_overlay)
-            self.append(feature)
+            self.append(
+                PhotoOverlay.class_from_element(
+                    ns=ns,
+                    element=photo_overlay,
+                    strict=False,
+                ),
+            )
 
     def etree_element(
         self,
@@ -167,6 +190,68 @@ def append(self, kmlobj: Union[Folder, Document, Placemark]) -> None:
                 msg,
             )
 
+    @classmethod
+    def _get_kwargs(
+        cls,
+        *,
+        ns: str,
+        name_spaces: Dict[str, str] | None = None,
+        element: Element,
+        strict: bool,
+    ) -> Dict[str, Any]:
+        kwargs = super()._get_kwargs(
+            ns=ns,
+            name_spaces=name_spaces,
+            element=element,
+            strict=strict,
+        )
+        documents = element.findall(f"{ns}Document")
+        for document in documents:
+            kwargs["features"].append(
+                Document.class_from_element(
+                    ns=ns,
+                    element=document,
+                    strict=False,
+                ),
+            )
+        folders = element.findall(f"{ns}Folder")
+        for folder in folders:
+            kwargs["features"].append(
+                Folder.class_from_element(
+                    ns=ns,
+                    element=folder,
+                    strict=False,
+                ),
+            )
+        placemarks = element.findall(f"{ns}Placemark")
+        for placemark in placemarks:
+            kwargs["features"].append(
+                Placemark.class_from_element(
+                    ns=ns,
+                    element=placemark,
+                    strict=False,
+                ),
+            )
+        groundoverlays = element.findall(f"{ns}GroundOverlay")
+        for groundoverlay in groundoverlays:
+            kwargs["features"].append(
+                GroundOverlay.class_from_element(
+                    ns=ns,
+                    element=groundoverlay,
+                    strict=False,
+                ),
+            )
+        photo_overlays = element.findall(f"{ns}PhotoOverlay")
+        for photo_overlay in photo_overlays:
+            kwargs["features"].append(
+                PhotoOverlay.class_from_element(
+                    ns=ns,
+                    element=photo_overlay,
+                    strict=False,
+                ),
+            )
+        return kwargs
+
 
 __all__ = [
     "Document",
diff --git a/fastkml/overlays.py b/fastkml/overlays.py
index f2cd16e7..eae0eb33 100644
--- a/fastkml/overlays.py
+++ b/fastkml/overlays.py
@@ -3,7 +3,7 @@
 import logging
 from typing import Any
 from typing import Dict
-from typing import List
+from typing import Iterable
 from typing import Optional
 from typing import Union
 from typing import cast
@@ -26,6 +26,7 @@
 from fastkml.geometry import Polygon
 from fastkml.links import Icon
 from fastkml.styles import Style
+from fastkml.styles import StyleMap
 from fastkml.styles import StyleUrl
 from fastkml.times import TimeSpan
 from fastkml.times import TimeStamp
@@ -63,7 +64,7 @@ class _Overlay(_Feature):
     # (AABBGGRR). The range of values for any one color is 0 to 255 (00 to ff).
     # For opacity, 00 is fully transparent and ff is fully opaque.
 
-    _draw_order: Optional[str]
+    _draw_order: Optional[int]
     # Defines the stacking order for the images in overlapping overlays.
     # Overlays with higher <drawOrder> values are drawn on top of those with
     # lower <drawOrder> values.
@@ -93,12 +94,12 @@ def __init__(
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[StyleUrl] = None,
-        styles: Optional[List[Style]] = None,
+        styles: Optional[Iterable[Union[Style, StyleMap]]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
         # Overlay specific
         color: Optional[str] = None,
-        draw_order: Optional[str] = None,
+        draw_order: Optional[int] = None,
         icon: Optional[Icon] = None,
     ) -> None:
         super().__init__(
@@ -135,11 +136,11 @@ def color(self, color: Optional[str]) -> None:
         self._color = color
 
     @property
-    def draw_order(self) -> Optional[str]:
+    def draw_order(self) -> Optional[int]:
         return self._draw_order
 
     @draw_order.setter
-    def draw_order(self, value: Optional[str]) -> None:
+    def draw_order(self, value: Optional[int]) -> None:
         self._draw_order = value
 
     @property
@@ -172,26 +173,6 @@ def etree_element(
             element.append(self._icon.etree_element())
         return element
 
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element=element, strict=strict)
-        color = element.find(f"{self.ns}color")
-        if color is not None:
-            self.color = color.text
-        draw_order = element.find(f"{self.ns}drawOrder")
-        if draw_order is not None:
-            self.draw_order = draw_order.text
-        icon = element.find(f"{self.ns}Icon")
-        if icon is not None:
-            self._icon = cast(
-                Icon,
-                Icon.class_from_element(
-                    ns=self.ns,
-                    name_spaces=self.name_spaces,
-                    element=icon,
-                    strict=False,
-                ),
-            )
-
     @classmethod
     def _get_kwargs(
         cls,
@@ -212,7 +193,7 @@ def _get_kwargs(
             kwargs["color"] = color.text
         draw_order = element.find(f"{ns}drawOrder")
         if draw_order is not None:
-            kwargs["draw_order"] = draw_order.text
+            kwargs["draw_order"] = int(draw_order.text)
         icon = element.find(f"{ns}Icon")
         if icon is not None:
             kwargs["icon"] = cast(
@@ -547,11 +528,11 @@ def __init__(
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[StyleUrl] = None,
-        styles: Optional[List[Style]] = None,
+        styles: Optional[Iterable[Union[Style, StyleMap]]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
         color: Optional[str] = None,
-        draw_order: Optional[str] = None,
+        draw_order: Optional[int] = None,
         icon: Optional[Icon] = None,
         # Photo Overlay specific
         rotation: Optional[float] = None,
@@ -616,48 +597,6 @@ def etree_element(
             shape.text = self.shape.value
         return element
 
-    def from_element(self, element: Element, strict: bool = True) -> None:
-        super().from_element(element)
-        rotation = element.find(f"{self.ns}rotation")
-        if rotation is not None:
-            self.rotation = float(rotation.text)
-        view_volume = element.find(f"{self.ns}ViewVolume")
-        if view_volume is not None:
-            self.view_volume = cast(
-                ViewVolume,
-                ViewVolume.class_from_element(
-                    ns=self.ns,
-                    name_spaces=self.name_spaces,
-                    element=view_volume,
-                    strict=False,
-                ),
-            )
-        image_pyramid = element.find(f"{self.ns}ImagePyramid")
-        if image_pyramid is not None:
-            self.image_pyramid = cast(
-                ImagePyramid,
-                ImagePyramid.class_from_element(
-                    ns=self.ns,
-                    name_spaces=self.name_spaces,
-                    element=image_pyramid,
-                    strict=False,
-                ),
-            )
-        point = element.find(f"{self.ns}Point")
-        if point is not None:
-            self.point = cast(
-                Point,
-                Point.class_from_element(
-                    ns=self.ns,
-                    name_spaces=self.name_spaces,
-                    element=point,
-                    strict=False,
-                ),
-            )
-        shape = element.find(f"{self.ns}shape")
-        if shape is not None:
-            self.shape = Shape(shape.text)
-
     @classmethod
     def _get_kwargs(
         cls,
@@ -893,11 +832,11 @@ def __init__(
         view: Optional[Union[Camera, LookAt]] = None,
         times: Optional[Union[TimeSpan, TimeStamp]] = None,
         style_url: Optional[StyleUrl] = None,
-        styles: Optional[List[Style]] = None,
+        styles: Optional[Iterable[Union[Style, StyleMap]]] = None,
         region: Optional[Region] = None,
         extended_data: Optional[ExtendedData] = None,
         color: Optional[str] = None,
-        draw_order: Optional[str] = None,
+        draw_order: Optional[int] = None,
         icon: Optional[Icon] = None,
         # Ground Overlay specific
         altitude: Optional[float] = None,
@@ -954,26 +893,6 @@ def etree_element(
             element.append(self.lat_lon_box.etree_element())
         return element
 
-    def from_element(self, element: Element, strict: bool = False) -> None:
-        super().from_element(element)
-        altitude = element.find(f"{self.ns}altitude")
-        if altitude is not None:
-            self.altitude = float(altitude.text)
-        altitude_mode = element.find(f"{self.ns}altitudeMode")
-        if altitude_mode is not None:
-            self.altitude_mode = AltitudeMode(altitude_mode.text)
-        lat_lon_box = element.find(f"{self.ns}LatLonBox")
-        if lat_lon_box is not None:
-            self.lat_lon_box = cast(
-                LatLonBox,
-                LatLonBox.class_from_element(
-                    ns=self.ns,
-                    name_spaces=self.name_spaces,
-                    element=lat_lon_box,
-                    strict=False,
-                ),
-            )
-
     @classmethod
     def _get_kwargs(
         cls,
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index 454cd95a..3c4fc0e4 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -185,8 +185,7 @@ def test_author(self) -> None:
         assert "Nobody" in str(d.to_string())
         assert "http://localhost" in str(d.to_string())
         assert "cl@donotreply.com" in str(d.to_string())
-        d2 = kml.Document()
-        d2.from_string(d.to_string())
+        d2 = kml.Document.class_from_string(d.to_string())
         assert d.to_string() == d2.to_string()
         d.author = None
 
@@ -196,8 +195,7 @@ def test_link(self) -> None:
         assert "http://localhost" in str(d.to_string())
         d.link = atom.Link(ns=config.ATOMNS, href="#here")
         assert "#here" in str(d.to_string())
-        d2 = kml.Document()
-        d2.from_string(d.to_string())
+        d2 = kml.Document.class_from_string(d.to_string())
         assert d.to_string() == d2.to_string()
         d.link = None
 
@@ -571,9 +569,7 @@ def test_from_string_with_unbound_prefix(self) -> None:
         pytest.raises(xml.etree.ElementTree.ParseError, k.from_string, doc)
 
     def test_address(self) -> None:
-        doc = kml.Document()
-
-        doc.from_string(
+        doc = kml.Document.class_from_string(
             """
         <kml:Document xmlns:kml="http://www.opengis.net/kml/2.2" id="pm-id">
             <kml:name>pm-name</kml:name>
@@ -584,14 +580,11 @@ def test_address(self) -> None:
         """,
         )
 
-        doc2 = kml.Document()
-        doc2.from_string(doc.to_string())
+        doc2 = kml.Document.class_from_string(doc.to_string())
         assert doc.to_string() == doc2.to_string()
 
     def test_phone_number(self) -> None:
-        doc = kml.Document()
-
-        doc.from_string(
+        doc = kml.Document.class_from_string(
             """
         <kml:Document xmlns:kml="http://www.opengis.net/kml/2.2" id="pm-id">
             <kml:name>pm-name</kml:name>
@@ -602,8 +595,7 @@ def test_phone_number(self) -> None:
         """,
         )
 
-        doc2 = kml.Document()
-        doc2.from_string(doc.to_string())
+        doc2 = kml.Document.class_from_string(doc.to_string())
         assert doc.to_string() == doc2.to_string()
 
     def test_groundoverlay(self) -> None:
@@ -665,16 +657,14 @@ def test_styleurl(self) -> None:
         f.style_url = s
         assert isinstance(f._style_url, styles.StyleUrl)
         assert f.style_url == "#otherstyle"
-        f2 = kml.Document()
-        f2.from_string(f.to_string())
+        f2 = kml.Document.class_from_string(f.to_string())
         assert f.to_string() == f2.to_string()
 
     def test_style(self) -> None:
         lstyle = styles.LineStyle(color="red", width=2.0)
         style = styles.Style(styles=[lstyle])
         f = kml.Document(styles=[style])
-        f2 = kml.Document()
-        f2.from_string(f.to_string(prettyprint=True))
+        f2 = kml.Document.class_from_string(f.to_string(prettyprint=True))
         assert f.to_string() == f2.to_string()
 
     def test_polystyle_fill(self) -> None:
@@ -706,8 +696,7 @@ def test_create_document_style(self) -> None:
             </kml:Document>
         """
 
-        doc3 = kml.Document()
-        doc3.from_string(expected)
+        doc3 = kml.Document.class_from_string(expected)
 
         assert doc.to_string() == doc2.to_string()
         assert doc2.to_string() == doc3.to_string()
@@ -733,8 +722,7 @@ def test_create_placemark_style(self) -> None:
             </kml:Placemark>
         """
 
-        place3 = kml.Placemark()
-        place3.from_string(expected)
+        place3 = kml.Placemark.class_from_string(expected)
         assert place.to_string() == place2.to_string()
         assert place2.to_string() == place3.to_string()
         assert place.to_string() == place3.to_string()
@@ -787,15 +775,17 @@ def test_balloonstyle(self) -> None:
 
         k = kml.KML()
         k.from_string(doc)
-        assert len(list(k.features())) == 1
-        assert isinstance(next(iter(next(iter(k.features())).styles())), styles.Style)
-        style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
-        assert isinstance(style, styles.BalloonStyle)
-        assert style.bg_color == "ffffffbb"
-        assert style.text_color == "ff000000"
-        assert style.display_mode == DisplayMode.default
-        assert "$[geDirections]" in style.text
-        assert "$[description]" in style.text
+        features = list(k.features())
+        assert len(features) == 1
+        style = list(features[0].styles())[0]
+        assert isinstance(style, styles.Style)
+        style_1 = list(style.styles())[0]
+        assert isinstance(style_1, styles.BalloonStyle)
+        assert style_1.bg_color == "ffffffbb"
+        assert style_1.text_color == "ff000000"
+        assert style_1.display_mode == DisplayMode.default
+        assert "$[geDirections]" in style_1.text
+        assert "$[description]" in style_1.text
         k2 = kml.KML()
         k2.from_string(k.to_string())
         assert k2.to_string() == k.to_string()
@@ -1079,12 +1069,15 @@ def test_stylemapurl(self) -> None:
 
         k = kml.KML()
         k.from_string(doc)
-        assert len(list(k.features())) == 1
+        features = list(k.features())
+        assert len(features) == 1
+        feature_styles = list(features[0].styles())
         assert isinstance(
-            next(iter(next(iter(k.features())).styles())),
+            feature_styles[0],
             styles.StyleMap,
         )
-        sm = next(iter(next(iter(k.features())).styles()))
+        sm = feature_styles[0]
+
         assert isinstance(sm.normal, styles.StyleUrl)
         assert sm.normal.url == "#normalState"
         assert isinstance(sm.highlight, styles.StyleUrl)
diff --git a/tests/overlays_test.py b/tests/overlays_test.py
index df0e35bd..2fcb4889 100644
--- a/tests/overlays_test.py
+++ b/tests/overlays_test.py
@@ -64,8 +64,7 @@ class TestGroundOverlayString(StdLibrary):
     def test_default_to_string(self) -> None:
         g = overlays.GroundOverlay()
 
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "</kml:GroundOverlay>",
         )
@@ -78,8 +77,7 @@ def test_to_string(self) -> None:
         g.draw_order = 1
         g.color = "00010203"
 
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:color>00010203</kml:color>"
             "<kml:drawOrder>1</kml:drawOrder>"
@@ -95,8 +93,7 @@ def test_altitude_from_int(self) -> None:
         g = overlays.GroundOverlay()
         g.altitude = 123.0
 
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:altitude>123</kml:altitude>"
             "</kml:GroundOverlay>",
@@ -108,8 +105,7 @@ def test_altitude_from_float(self) -> None:
         g = overlays.GroundOverlay()
         g.altitude = 123.4
 
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:altitude>123.4</kml:altitude>"
             "</kml:GroundOverlay>",
@@ -123,8 +119,7 @@ def test_altitude_from_string(self) -> None:
             altitude_mode=AltitudeMode.clamp_to_ground,
         )
 
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:altitude>123.4</kml:altitude>"
             "<kml:altitudeMode>clampToGround</kml:altitudeMode>"
@@ -135,8 +130,7 @@ def test_altitude_from_string(self) -> None:
 
     def test_altitude_mode_absolute(self) -> None:
         g = overlays.GroundOverlay(altitude=123.4, altitude_mode=AltitudeMode.absolute)
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:altitude>123.4</kml:altitude>"
             "<kml:altitudeMode>absolute</kml:altitudeMode>"
@@ -155,8 +149,7 @@ def test_latlonbox_no_rotation(self) -> None:
         )
         g = overlays.GroundOverlay(lat_lon_box=llb)
 
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:LatLonBox>"
             "<kml:north>10</kml:north>"
@@ -180,8 +173,7 @@ def test_latlonbox_rotation(self) -> None:
         )
         g = overlays.GroundOverlay(lat_lon_box=llb)
 
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:LatLonBox>"
             "<kml:north>10</kml:north>"
@@ -206,8 +198,7 @@ def test_latlonbox_nswer(self) -> None:
         )
         g = overlays.GroundOverlay()
         g.lat_lon_box = llb
-        expected = overlays.GroundOverlay()
-        expected.from_string(
+        expected = overlays.GroundOverlay.class_from_string(
             '<kml:GroundOverlay xmlns:kml="http://www.opengis.net/kml/2.2">'
             "<kml:LatLonBox>"
             "<kml:north>10</kml:north>"

From 283bf25ca396ff6b0962dfe8c14c486bba74304a Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Fri, 24 Nov 2023 20:54:34 +0000
Subject: [PATCH 19/25] Old style type annotation for python 3.8

---
 fastkml/kml.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/fastkml/kml.py b/fastkml/kml.py
index 31810ba1..ccf07aaf 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -62,12 +62,13 @@ def __init__(
         The namespace (ns) may be empty ('') if the 'kml:' prefix is
         undesired. Note that all child elements like Document or Placemark need
         to be initialized with empty namespace as well in this case.
-
         """
+        super().__init__(
+            ns=ns,
+            name_spaces=name_spaces,
+        )
         self._features = list(features) if features is not None else []
 
-        self.ns = config.KMLNS if ns is None else ns
-
     def from_string(self, xml_string: str) -> None:
         """Create a KML object from a xml string."""
         try:
@@ -149,7 +150,7 @@ def etree_element(
             except TypeError:
                 root = config.etree.Element(f"{self.ns}kml")
         for feature in self.features():
-            root.append(feature.etree_element())
+            root.append(feature.etree_element(precision=precision, verbosity=verbosity))
         return root
 
     def to_string(self, prettyprint: bool = False) -> str:
@@ -195,7 +196,7 @@ def _get_kwargs(
         cls,
         *,
         ns: str,
-        name_spaces: Dict[str, str] | None = None,
+        name_spaces: Optional[Dict[str, str]] = None,
         element: Element,
         strict: bool,
     ) -> Dict[str, Any]:

From 6f0cb5284358e9987b1525a00f1aa9287f7536af Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Sat, 25 Nov 2023 00:08:48 +0000
Subject: [PATCH 20/25] fix parsing for KML.class_from_string

---
 fastkml/kml.py        |  39 ++++++++++
 tests/data_test.py    |  12 +--
 tests/oldunit_test.py | 176 ++++++++++++++----------------------------
 3 files changed, 101 insertions(+), 126 deletions(-)

diff --git a/fastkml/kml.py b/fastkml/kml.py
index ccf07aaf..c1ac2357 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -206,6 +206,7 @@ def _get_kwargs(
             element=element,
             strict=strict,
         )
+        kwargs["features"] = []
         documents = element.findall(f"{ns}Document")
         for document in documents:
             kwargs["features"].append(
@@ -253,6 +254,44 @@ def _get_kwargs(
             )
         return kwargs
 
+    @classmethod
+    def class_from_string(
+        cls,
+        string: str,
+        *,
+        ns: Optional[str] = None,
+        name_spaces: Optional[Dict[str, str]] = None,
+        strict: bool = True,
+    ) -> "_XMLObject":
+        """
+        Creates a geometry object from a string.
+
+        Args:
+        ----
+            string: String representation of the geometry object
+
+        Returns:
+        -------
+            Geometry object
+        """
+        try:
+            element = config.etree.fromstring(
+                string,
+                parser=config.etree.XMLParser(huge_tree=True, recover=True),
+            )
+        except TypeError:
+            element = config.etree.XML(string)
+        if not element.tag.endswith("kml"):
+            raise TypeError
+        if ns is None:
+            ns = element.tag.rstrip("kml") or None
+        return cls.class_from_element(
+            ns=ns,
+            name_spaces=name_spaces,
+            strict=strict,
+            element=element,
+        )
+
 
 __all__ = [
     "Document",
diff --git a/tests/data_test.py b/tests/data_test.py
index fabc6484..ce5bb268 100644
--- a/tests/data_test.py
+++ b/tests/data_test.py
@@ -77,19 +77,13 @@ def test_schema_from_string(self) -> None:
         assert s1.simple_fields[1].name == "TrailLength"
         assert s1.simple_fields[2].display_name == "<i>change in altitude</i>"
         assert s.to_string() == s1.to_string()
-        doc1 = f"""<kml>
-            <Document>
-            {doc}
-        </Document>
-        </kml>"""
-        k = kml.KML(ns="")
-        k.from_string(doc1)
+        doc1 = f"<kml><Document>{doc}</Document></kml>"
+        k = kml.KML.class_from_string(doc1, ns="")
         d = next(iter(k.features()))
         s2 = next(iter(d.schemata()))
         # s.ns = config.KMLNS
         assert s.to_string() == s2.to_string()
-        k1 = kml.KML()
-        k1.from_string(k.to_string())
+        k1 = kml.KML.class_from_string(k.to_string())
         assert "Schema" in k1.to_string()
         assert "SimpleField" in k1.to_string()
         assert k1.to_string().replace("kml:", "").replace(
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index 3c4fc0e4..5fb7f5a2 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -97,19 +97,18 @@ def test_kml(self) -> None:
         assert not list(k.features())
         assert (
             str(k.to_string())[:51]
-            == '<kml:kml xmlns:kml="http://www.opengis.net/kml/2.2" />'[:51]
+            == '<kml xmlns="http://www.opengis.net/kml/2.2" />'[:51]
         )
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string(), ns="")
         assert k.to_string() == k2.to_string()
 
     def test_folder(self) -> None:
         """KML file with folders."""
         ns = "{http://www.opengis.net/kml/2.2}"
-        k = kml.KML()
-        f = kml.Folder(ns, id="id", name="name", description="description")
+        k = kml.KML(ns=ns)
+        f = kml.Folder(ns=ns, id="id", name="name", description="description")
         nf = kml.Folder(
-            ns,
+            ns=ns,
             id="nested-id",
             name="nested-name",
             description="nested-description",
@@ -120,9 +119,8 @@ def test_folder(self) -> None:
         k.append(f2)
         assert len(list(k.features())) == 2
         assert len(list(next(iter(k.features())).features())) == 1
-        k2 = kml.KML()
         s = k.to_string()
-        k2.from_string(s)
+        k2 = kml.KML.class_from_string(s, ns=ns)
         assert s == k2.to_string()
 
     def test_placemark(self) -> None:
@@ -135,13 +133,12 @@ def test_placemark(self) -> None:
         k.append(p)
         k.append(p2)
         assert len(list(k.features())) == 2
-        k2 = kml.KML()
-        k2.from_string(k.to_string(prettyprint=True))
+        k2 = kml.KML.class_from_string(k.to_string(prettyprint=True), ns=ns)
         assert k.to_string() == k2.to_string()
 
     def test_document(self) -> None:
-        k = kml.KML()
         ns = "{http://www.opengis.net/kml/2.2}"
+        k = kml.KML(ns=ns)
         d = kml.Document(ns, id="docid", name="doc name", description="doc description")
         f = kml.Folder(ns, id="fid", name="f name", description="f description")
         k.append(d)
@@ -163,8 +160,7 @@ def test_document(self) -> None:
         nf.append(p2)
         assert len(list(k.features())) == 1
         assert len(list(next(iter(k.features())).features())) == 2
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_author(self) -> None:
@@ -242,12 +238,10 @@ def test_document(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert len(list(next(iter(k.features())).features())) == 2
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_document_booleans(self) -> None:
@@ -259,8 +253,7 @@ def test_document_booleans(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert next(iter(k.features())).visibility == 1
         assert next(iter(k.features())).isopen == 1
         doc = """<kml xmlns="http://www.opengis.net/kml/2.2">
@@ -271,8 +264,7 @@ def test_document_booleans(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert next(iter(k.features())).visibility == 0
         assert next(iter(k.features())).isopen == 0
 
@@ -317,12 +309,10 @@ def test_folders(self) -> None:
         </Folder>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert len(list(next(iter(k.features())).features())) == 3
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_placemark(self) -> None:
@@ -337,12 +327,10 @@ def test_placemark(self) -> None:
           </Placemark>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert next(iter(k.features())).name == "Simple placemark"
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_polygon(self) -> None:
@@ -461,12 +449,10 @@ def test_polygon(self) -> None:
           </Placemark>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(next(iter(k.features())).geometry, Polygon)
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_multipoints(self) -> None:
@@ -514,13 +500,11 @@ def test_multipoints(self) -> None:
             </MultiGeometry>
         </Placemark></kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(next(iter(k.features())).geometry, MultiPoint)
         assert len(list(next(iter(k.features())).geometry.geoms)) == 12
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_atom(self) -> None:
@@ -532,8 +516,7 @@ def test_snippet(self) -> None:
         <Snippet maxLines="2" >Short Desc</Snippet>
         </Placemark> </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert next(iter(k.features())).snippet.text == "Short Desc"
         assert next(iter(k.features())).snippet.max_lines == 2
         next(iter(k.features()))._snippet = features.Snippet(
@@ -549,8 +532,7 @@ def test_snippet(self) -> None:
         assert "Different Snippet" in k.to_string()
 
     def test_from_wrong_string(self) -> None:
-        doc = kml.KML()
-        pytest.raises(TypeError, doc.from_string, "<xml></xml>")
+        pytest.raises(TypeError, kml.KML.class_from_string, "<xml></xml>")
 
     def test_from_string_with_unbound_prefix(self) -> None:
         doc = """<kml xmlns="http://www.opengis.net/kml/2.2">
@@ -561,12 +543,8 @@ def test_from_string_with_unbound_prefix(self) -> None:
         </Placemark> </kml>"""
         if LXML:
             config.set_etree_implementation(lxml.etree)
-            k = kml.KML()
-            k.from_string(doc)
+            k = kml.KML.class_from_string(doc)
             assert len(list(k.features())) == 1
-        config.set_etree_implementation(xml.etree.ElementTree)
-        k = kml.KML()
-        pytest.raises(xml.etree.ElementTree.ParseError, k.from_string, doc)
 
     def test_address(self) -> None:
         doc = kml.Document.class_from_string(
@@ -599,9 +577,7 @@ def test_phone_number(self) -> None:
         assert doc.to_string() == doc2.to_string()
 
     def test_groundoverlay(self) -> None:
-        doc = kml.KML()
-
-        doc.from_string(
+        doc = kml.KML.class_from_string(
             """
             <kml xmlns="http://www.opengis.net/kml/2.2">
               <Folder>
@@ -627,13 +603,11 @@ def test_groundoverlay(self) -> None:
             """,
         )
 
-        doc2 = kml.KML()
-        doc2.from_string(doc.to_string())
+        doc2 = kml.KML.class_from_string(doc.to_string())
         assert doc.to_string() == doc2.to_string()
 
     def test_linarring_placemark(self) -> None:
-        doc = kml.KML()
-        doc.from_string(
+        doc = kml.KML.class_from_string(
             """<kml xmlns="http://www.opengis.net/kml/2.2">
         <Placemark>
           <LinearRing>
@@ -641,8 +615,7 @@ def test_linarring_placemark(self) -> None:
           </LinearRing>
         </Placemark> </kml>""",
         )
-        doc2 = kml.KML()
-        doc2.from_string(doc.to_string())
+        doc2 = kml.KML.class_from_string(doc.to_string())
         assert isinstance(next(iter(doc.features())).geometry, LinearRing)
         assert doc.to_string() == doc2.to_string()
 
@@ -738,12 +711,10 @@ def test_styleurl(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert next(iter(k.features())).style_url == "#default"
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_balloonstyle(self) -> None:
@@ -773,8 +744,7 @@ def test_balloonstyle(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         features = list(k.features())
         assert len(features) == 1
         style = list(features[0].styles())[0]
@@ -786,8 +756,7 @@ def test_balloonstyle(self) -> None:
         assert style_1.display_mode == DisplayMode.default
         assert "$[geDirections]" in style_1.text
         assert "$[description]" in style_1.text
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k2.to_string() == k.to_string()
 
     def test_balloonstyle_old_color(self) -> None:
@@ -803,15 +772,13 @@ def test_balloonstyle_old_color(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(next(iter(next(iter(k.features())).styles())), styles.Style)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
         assert isinstance(style, styles.BalloonStyle)
         assert style.bg_color == "ffffffbb"
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k2.to_string() == k.to_string()
 
     def test_labelstyle(self) -> None:
@@ -827,16 +794,14 @@ def test_labelstyle(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(next(iter(next(iter(k.features())).styles())), styles.Style)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
         assert isinstance(style, styles.LabelStyle)
         assert style.color == "ff0000cc"
         assert style.color_mode is None
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_iconstyle(self) -> None:
@@ -856,8 +821,7 @@ def test_iconstyle(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(next(iter(next(iter(k.features())).styles())), styles.Style)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
@@ -867,8 +831,7 @@ def test_iconstyle(self) -> None:
         assert style.color_mode == ColorMode.random
         assert style.heading == 0.0
         assert style.icon_href == "http://maps.google.com/icon21.png"
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_linestyle(self) -> None:
@@ -885,16 +848,14 @@ def test_linestyle(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(next(iter(next(iter(k.features())).styles())), styles.Style)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
         assert isinstance(style, styles.LineStyle)
         assert style.color == "7f0000ff"
         assert style.width == 4
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_polystyle(self) -> None:
@@ -912,16 +873,14 @@ def test_polystyle(self) -> None:
         </kml>"""
 
         # XXX fill and outline
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(next(iter(next(iter(k.features())).styles())), styles.Style)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
         assert isinstance(style, styles.PolyStyle)
         assert style.color == "ff0000cc"
         assert style.color_mode == ColorMode.random
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_polystyle_boolean_fill(self) -> None:
@@ -937,13 +896,11 @@ def test_polystyle_boolean_fill(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
         assert isinstance(style, styles.PolyStyle)
         assert style.fill == 0
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_polystyle_boolean_outline(self) -> None:
@@ -959,13 +916,11 @@ def test_polystyle_boolean_outline(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
         assert isinstance(style, styles.PolyStyle)
         assert style.outline == 0
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_polystyle_float_fill(self) -> None:
@@ -981,13 +936,11 @@ def test_polystyle_float_fill(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
         assert isinstance(style, styles.PolyStyle)
         assert style.fill == 0
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_polystyle_float_outline(self) -> None:
@@ -1003,13 +956,11 @@ def test_polystyle_float_outline(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         style = next(iter(next(iter(next(iter(k.features())).styles())).styles()))
         assert isinstance(style, styles.PolyStyle)
         assert style.outline == 0
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_styles(self) -> None:
@@ -1041,14 +992,12 @@ def test_styles(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(next(iter(next(iter(k.features())).styles())), styles.Style)
         style = list(next(iter(next(iter(k.features())).styles())).styles())
         assert len(style) == 4
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_stylemapurl(self) -> None:
@@ -1067,8 +1016,7 @@ def test_stylemapurl(self) -> None:
           </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         features = list(k.features())
         assert len(features) == 1
         feature_styles = list(features[0].styles())
@@ -1082,8 +1030,7 @@ def test_stylemapurl(self) -> None:
         assert sm.normal.url == "#normalState"
         assert isinstance(sm.highlight, styles.StyleUrl)
         assert sm.highlight.url == "#highlightState"
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_stylemapstyles(self) -> None:
@@ -1115,8 +1062,7 @@ def test_stylemapstyles(self) -> None:
           </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         assert isinstance(
             next(iter(next(iter(k.features())).styles())),
@@ -1131,8 +1077,7 @@ def test_stylemapstyles(self) -> None:
         assert len(list(sm.highlight.styles())) == 2
         assert isinstance(next(iter(sm.highlight.styles())), styles.LineStyle)
         assert isinstance(list(sm.highlight.styles())[1], styles.PolyStyle)
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
         assert k.to_string() == k2.to_string()
 
     def test_get_style_by_url(self) -> None:
@@ -1164,8 +1109,7 @@ def test_get_style_by_url(self) -> None:
         </Document>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         assert len(list(k.features())) == 1
         document = next(iter(k.features()))
         style = document.get_style_by_url(
@@ -1213,8 +1157,7 @@ def test_nested_multigeometry() -> None:
         </Placemark></Document></kml>
         """
 
-    k = kml.KML()
-    k.from_string(doc)
+    k = kml.KML.class_from_string(doc)
     placemark = next(iter(next(iter(k.features())).features()))
 
     first_multigeometry = placemark.geometry
@@ -1262,8 +1205,7 @@ def test_nested_multigeometry(self) -> None:
         </Placemark></Document></kml>
         """
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
         placemark = next(iter(next(iter(k.features())).features()))
 
         first_multigeometry = placemark.geometry

From 1aa798a0f006517e5c0c2c57f6ccd3b388ee3b29 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Sat, 25 Nov 2023 00:12:59 +0000
Subject: [PATCH 21/25] remove KML.from_string

---
 fastkml/kml.py     | 61 ----------------------------------------------
 tests/data_test.py |  9 +++----
 2 files changed, 3 insertions(+), 67 deletions(-)

diff --git a/fastkml/kml.py b/fastkml/kml.py
index c1ac2357..fb9ac02b 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -69,67 +69,6 @@ def __init__(
         )
         self._features = list(features) if features is not None else []
 
-    def from_string(self, xml_string: str) -> None:
-        """Create a KML object from a xml string."""
-        try:
-            element = config.etree.fromstring(
-                xml_string,
-                parser=config.etree.XMLParser(huge_tree=True, recover=True),
-            )
-        except TypeError:
-            element = config.etree.XML(xml_string)
-
-        if not element.tag.endswith("kml"):
-            raise TypeError
-
-        ns = element.tag.rstrip("kml")
-        documents = element.findall(f"{ns}Document")
-        for document in documents:
-            self.append(
-                Document.class_from_element(
-                    ns=ns,
-                    element=document,
-                    strict=False,
-                ),
-            )
-        folders = element.findall(f"{ns}Folder")
-        for folder in folders:
-            self.append(
-                Folder.class_from_element(
-                    ns=ns,
-                    element=folder,
-                    strict=False,
-                ),
-            )
-        placemarks = element.findall(f"{ns}Placemark")
-        for placemark in placemarks:
-            self.append(
-                Placemark.class_from_element(
-                    ns=ns,
-                    element=placemark,
-                    strict=False,
-                ),
-            )
-        groundoverlays = element.findall(f"{ns}GroundOverlay")
-        for groundoverlay in groundoverlays:
-            self.append(
-                GroundOverlay.class_from_element(
-                    ns=ns,
-                    element=groundoverlay,
-                    strict=False,
-                ),
-            )
-
-        photo_overlays = element.findall(f"{ns}PhotoOverlay")
-        for photo_overlay in photo_overlays:
-            self.append(
-                PhotoOverlay.class_from_element(
-                    ns=ns,
-                    element=photo_overlay,
-                    strict=False,
-                ),
-            )
-
     def etree_element(
         self,
         precision: Optional[int] = None,
diff --git a/tests/data_test.py b/tests/data_test.py
index ce5bb268..d09a1e65 100644
--- a/tests/data_test.py
+++ b/tests/data_test.py
@@ -134,8 +134,7 @@ def test_untyped_extended_data(self) -> None:
         assert len(p.extended_data.elements) == 2
         k.append(p)
 
-        k2 = kml.KML()
-        k2.from_string(k.to_string(prettyprint=True))
+        k2 = kml.KML.class_from_string(k.to_string(prettyprint=True))
         k.to_string()
 
         extended_data = next(iter(k2.features())).extended_data
@@ -167,8 +166,7 @@ def test_untyped_extended_data_nested(self) -> None:
         k.append(d)
         d.append(f)
 
-        k2 = kml.KML()
-        k2.from_string(k.to_string())
+        k2 = kml.KML.class_from_string(k.to_string())
 
         document_data = next(iter(k2.features())).extended_data
         folder_data = next(iter(next(iter(k2.features())).features())).extended_data
@@ -209,8 +207,7 @@ def test_extended_data(self) -> None:
           </Placemark>
         </kml>"""
 
-        k = kml.KML()
-        k.from_string(doc)
+        k = kml.KML.class_from_string(doc)
 
         extended_data = next(iter(k.features())).extended_data
 

From 07f9a767f393c7ee8a33296b6956e991e995ec95 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Sat, 25 Nov 2023 00:45:06 +0000
Subject: [PATCH 22/25] Fix type hints and import statements

---
 fastkml/kml.py        | 61 ++++++++++++++-----------------------------
 tests/oldunit_test.py |  3 ++-
 2 files changed, 22 insertions(+), 42 deletions(-)

diff --git a/fastkml/kml.py b/fastkml/kml.py
index fb9ac02b..cc8e0c8f 100644
--- a/fastkml/kml.py
+++ b/fastkml/kml.py
@@ -29,8 +29,10 @@
 from typing import Dict
 from typing import Iterable
 from typing import Iterator
+from typing import List
 from typing import Optional
 from typing import Union
+from typing import cast
 
 from fastkml import config
 from fastkml.base import _XMLObject
@@ -40,7 +42,6 @@
 from fastkml.features import Placemark
 from fastkml.overlays import GroundOverlay
 from fastkml.overlays import PhotoOverlay
-from fastkml.overlays import _Overlay
 from fastkml.types import Element
 
 logger = logging.getLogger(__name__)
@@ -49,8 +50,8 @@
 class KML(_XMLObject):
     """represents a KML File."""
 
-    _features = []
-    ns = None
+    _features: List[Union[Folder, Document, Placemark]]
+    ns: str
 
     def __init__(
         self,
@@ -78,57 +79,32 @@ def etree_element(
         # However, in this case the xlmns should still be mentioned on the kml
         # element, just without prefix.
         if not self.ns:
-            root = config.etree.Element(f"{self.ns}kml")
+            root = config.etree.Element(f"{self.ns}kml")  # type: ignore[attr-defined]
             root.set("xmlns", config.KMLNS[1:-1])
         else:
             try:
-                root = config.etree.Element(
+                root = config.etree.Element(  # type: ignore[attr-defined]
                     f"{self.ns}kml",
                     # nsmap={None: self.ns[1:-1]},
                 )
             except TypeError:
-                root = config.etree.Element(f"{self.ns}kml")
+                root = config.etree.Element(  # type: ignore[attr-defined]
+                    f"{self.ns}kml",
+                )
         for feature in self.features():
             root.append(feature.etree_element(precision=precision, verbosity=verbosity))
-        return root
-
-    def to_string(self, prettyprint: bool = False) -> str:
-        """Return the KML Object as serialized xml."""
-        try:
-            return config.etree.tostring(
-                self.etree_element(),
-                encoding="UTF-8",
-                pretty_print=prettyprint,
-            ).decode("UTF-8")
-        except TypeError:
-            return config.etree.tostring(self.etree_element(), encoding="UTF-8").decode(
-                "UTF-8",
-            )
+        return cast(Element, root)
 
     def features(self) -> Iterator[Union[Folder, Document, Placemark]]:
         """Iterate over features."""
-        for feature in self._features:
-            if isinstance(feature, (Document, Folder, Placemark, _Overlay)):
-                yield feature
-            else:
-                msg = (
-                    "Features must be instances of "
-                    "(Document, Folder, Placemark, Overlay)"
-                )
-                raise TypeError(msg)
+        yield from self._features
 
     def append(self, kmlobj: Union[Folder, Document, Placemark]) -> None:
         """Append a feature."""
         if id(kmlobj) == id(self):
             msg = "Cannot append self"
             raise ValueError(msg)
-        if isinstance(kmlobj, (Document, Folder, Placemark, _Overlay)):
-            self._features.append(kmlobj)
-        else:
-            msg = "Features must be instances of (Document, Folder, Placemark, Overlay)"
-            raise TypeError(
-                msg,
-            )
+        self._features.append(kmlobj)
 
     @classmethod
     def _get_kwargs(
@@ -201,7 +177,7 @@ def class_from_string(
         ns: Optional[str] = None,
         name_spaces: Optional[Dict[str, str]] = None,
         strict: bool = True,
-    ) -> "_XMLObject":
+    ) -> _XMLObject:
         """
         Creates a geometry object from a string.
 
@@ -214,16 +190,19 @@ def class_from_string(
             Geometry object
         """
         try:
-            element = config.etree.fromstring(
+            element = config.etree.fromstring(  # type: ignore[attr-defined]
                 string,
-                parser=config.etree.XMLParser(huge_tree=True, recover=True),
+                parser=config.etree.XMLParser(  # type: ignore[attr-defined]
+                    huge_tree=True,
+                    recover=True,
+                ),
             )
         except TypeError:
-            element = config.etree.XML(string)
+            element = config.etree.XML(string)  # type: ignore[attr-defined]
         if not element.tag.endswith("kml"):
             raise TypeError
         if ns is None:
-            ns = element.tag.rstrip("kml") or None
+            ns = cast(str, element.tag.rstrip("kml"))
         return cls.class_from_element(
             ns=ns,
             name_spaces=name_spaces,
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index 5fb7f5a2..cdfb15cd 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -25,6 +25,7 @@
 from fastkml import config
 from fastkml import features
 from fastkml import kml
+from fastkml import overlays
 from fastkml import styles
 from fastkml.enums import ColorMode
 from fastkml.enums import DisplayMode
@@ -76,7 +77,7 @@ def test_base_object(self) -> None:
         assert len(bo.to_string()) > 1
 
     def test_overlay(self) -> None:
-        o = kml._Overlay(name="An Overlay")
+        o = overlays._Overlay(name="An Overlay")
         assert o._color is None
         assert o._draw_order is None
         assert o._icon is None

From ed7f69ee496660dd55241cdb1267ca23293fb4c7 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Sat, 25 Nov 2023 01:04:35 +0000
Subject: [PATCH 23/25] Update import statements in fastkml/__init__.py

---
 .pre-commit-config.yaml |  5 +++++
 fastkml/__init__.py     | 10 +++++++---
 pyproject.toml          |  6 ------
 3 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 6d9169f0..b81b021b 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -73,6 +73,11 @@ repos:
     rev: "v6.2.0"
     hooks:
       - id: rstcheck
+  - repo: https://github.com/pre-commit/mirrors-mypy
+    rev: v1.7.0
+    hooks:
+      - id: mypy
+        additional_dependencies: [pygeoif]
   # - repo: https://github.com/mgedmin/check-manifest
   #   rev: "0.49"
   #   hooks:
diff --git a/fastkml/__init__.py b/fastkml/__init__.py
index 21365bbd..a6ca8b7e 100644
--- a/fastkml/__init__.py
+++ b/fastkml/__init__.py
@@ -28,14 +28,16 @@
 from fastkml.atom import Author
 from fastkml.atom import Contributor
 from fastkml.atom import Link
+from fastkml.containers import Document
+from fastkml.containers import Folder
 from fastkml.data import Data
 from fastkml.data import ExtendedData
 from fastkml.data import Schema
 from fastkml.data import SchemaData
+from fastkml.features import Placemark
 from fastkml.kml import KML
-from fastkml.kml import Document
-from fastkml.kml import Folder
-from fastkml.kml import Placemark
+from fastkml.overlays import GroundOverlay
+from fastkml.overlays import PhotoOverlay
 from fastkml.styles import BalloonStyle
 from fastkml.styles import IconStyle
 from fastkml.styles import LabelStyle
@@ -53,11 +55,13 @@
     "KML",
     "Document",
     "Folder",
+    "GroundOverlay",
     "Placemark",
     "TimeSpan",
     "TimeStamp",
     "ExtendedData",
     "Data",
+    "PhotoOverlay",
     "Schema",
     "SchemaData",
     "StyleUrl",
diff --git a/pyproject.toml b/pyproject.toml
index 8622b116..88ef042d 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -136,12 +136,6 @@ warn_unreachable = true
 warn_unused_configs = true
 warn_unused_ignores = true
 
-[[tool.mypy.overrides]]
-ignore_errors = true
-module = [
-    "fastkml.kml",
-]
-
 [tool.pyright]
 exclude = [
     "**/__pycache__",

From 1264e2aa27d94c2db6f693201e57f87a9c02b268 Mon Sep 17 00:00:00 2001
From: Christian Ledermann <christian.ledermann@gmail.com>
Date: Sat, 25 Nov 2023 16:30:00 +0000
Subject: [PATCH 24/25] remove from_element, activate skipped tests

---
 .pre-commit-config.yaml |  6 +-----
 fastkml/base.py         | 30 ------------------------------
 tests/base_test.py      | 36 ++++--------------------------------
 tests/oldunit_test.py   | 16 +---------------
 tests/times_test.py     | 20 ++++++++++++++------
 5 files changed, 20 insertions(+), 88 deletions(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index b81b021b..ab852cda 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -77,7 +77,7 @@ repos:
     rev: v1.7.0
     hooks:
       - id: mypy
-        additional_dependencies: [pygeoif]
+        additional_dependencies: [pygeoif, arrow]
   # - repo: https://github.com/mgedmin/check-manifest
   #   rev: "0.49"
   #   hooks:
@@ -86,8 +86,4 @@ repos:
   #   rev: v1.0.1
   #   hooks:
   #     - id: rst-linter
-  # - repo: https://github.com/pre-commit/mirrors-mypy
-  #   rev: v0.910
-  #   hooks:
-  #     - id: mypy
 ...
diff --git a/fastkml/base.py b/fastkml/base.py
index 49e519b9..754534f4 100644
--- a/fastkml/base.py
+++ b/fastkml/base.py
@@ -69,28 +69,6 @@ def etree_element(
             )
         return element
 
-    def from_element(self, element: Element) -> None:
-        """
-        Load the KML Object from an Element.
-
-        This implementation is deprecated and will be replaced by class_from_element
-        making it a classmethod.
-        """
-        if f"{self.ns}{self.__name__}" != element.tag:
-            msg = "Call of abstract base class, subclasses implement this!"
-            raise TypeError(msg)
-
-    def from_string(self, xml_string: str) -> None:
-        """
-        Load the KML Object from serialized xml.
-
-        This implementation is deprecated and will be replaced by class_from_string
-        making it a classmethod.
-        """
-        self.from_element(
-            cast(Element, config.etree.XML(xml_string)),  # type: ignore[attr-defined]
-        )
-
     def to_string(
         self,
         *,
@@ -252,14 +230,6 @@ def etree_element(
             element.set("targetId", self.target_id)
         return element
 
-    def from_element(self, element: Element) -> None:
-        """Load the KML Object from an Element."""
-        super().from_element(element)
-        if element.get("id"):
-            self.id = element.get("id")
-        if element.get("targetId"):
-            self.target_id = element.get("targetId")
-
     @classmethod
     def _get_id(cls, element: Element, strict: bool) -> str:
         return element.get("id") or ""
diff --git a/tests/base_test.py b/tests/base_test.py
index 0ab1b2fa..d46d3555 100644
--- a/tests/base_test.py
+++ b/tests/base_test.py
@@ -15,13 +15,10 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
 
 """Test the base classes."""
-from typing import cast
 
 import pytest
 
 from fastkml import base
-from fastkml import config
-from fastkml import types
 from tests.base import Lxml
 from tests.base import StdLibrary
 
@@ -48,16 +45,12 @@ def test_to_str_empty_ns(self) -> None:
         ) == '<test id="id-0" targetId="target-id-0" />'.replace(" ", "")
 
     def test_from_string(self) -> None:
-        be = base._BaseObject()
-        be.__name__ = "test"
-
-        be.from_string(
-            xml_string=(
+        be = base._BaseObject.class_from_string(
+            string=(
                 '<kml:test xmlns:kml="http://www.opengis.net/kml/2.2" '
                 'id="id-0" targetId="target-id-0" />'
             ),
         )
-
         assert be.id == "id-0"
         assert be.target_id == "target-id-0"
 
@@ -74,24 +67,6 @@ class Test(base._BaseObject):
         with pytest.raises(NotImplementedError):
             Test().etree_element()
 
-    def test_base_from_element_raises(self) -> None:
-        be = base._BaseObject()
-        element = cast(
-            types.Element,
-            config.etree.Element(config.KMLNS + "Base"),  # type: ignore[attr-defined]
-        )
-
-        with pytest.raises(TypeError):
-            be.from_element(element=element)
-
-    def test_base_from_string_raises(self) -> None:
-        be = base._BaseObject()
-
-        with pytest.raises(TypeError):
-            be.from_string(
-                '<kml:test xmlns:kml="http://www.opengis.net/kml/2.2" id="id-0" />',
-            )
-
     def test_base_class_from_string(self) -> None:
         be = base._BaseObject.class_from_string('<test id="id-0" targetId="td-00" />')
 
@@ -120,11 +95,8 @@ def test_to_string(self) -> None:
         )
 
     def test_from_string(self) -> None:
-        be = base._BaseObject()
-        be.__name__ = "test"
-
-        be.from_string(
-            xml_string=(
+        be = base._BaseObject.class_from_string(
+            string=(
                 '<kml:test xmlns:kml="http://www.opengis.net/kml/2.2" '
                 'id="id-0" targetId="target-id-0"/>\n'
             ),
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index cdfb15cd..8a324096 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -40,8 +40,7 @@
 
 class TestBaseClasses:
     """
-    BaseClasses  must raise a NotImplementedError on etree_element
-    and a TypeError on from_element.
+    BaseClasses  must raise a NotImplementedError on etree_element.
     """
 
     def setup_method(self) -> None:
@@ -62,19 +61,6 @@ def test_base_object(self) -> None:
         assert bo.id is None
         assert not bo.ns
         pytest.raises(NotImplementedError, bo.etree_element)
-        element = config.etree.Element(f"{config.KMLNS}Base")
-        pytest.raises(TypeError, bo.from_element)
-        pytest.raises(TypeError, bo.from_element, element)
-        bo.__name__ = "NotABaseObject"
-        pytest.raises(TypeError, bo.from_element, element)
-        # Note that we can coax baseclasses not to throw errors
-        bo.__name__ = "Base"
-        bo.ns = config.KMLNS
-        bo.from_element(element)
-        assert bo.id is None
-        assert bo.ns == config.KMLNS
-        assert bo.etree_element() is not None
-        assert len(bo.to_string()) > 1
 
     def test_overlay(self) -> None:
         o = overlays._Overlay(name="An Overlay")
diff --git a/tests/times_test.py b/tests/times_test.py
index f986b35b..33fdb674 100644
--- a/tests/times_test.py
+++ b/tests/times_test.py
@@ -222,19 +222,18 @@ def test_timespan(self) -> None:
         ts.begin = None
         pytest.raises(ValueError, ts.to_string)
 
-    @pytest.mark.skip(reason="not yet implemented")
     def test_feature_timestamp(self) -> None:
         now = datetime.datetime.now()
         f = kml.Document()
-        f.time_stamp = KmlDateTime(now)
+        f._times = kml.TimeStamp(timestamp=KmlDateTime(now))
         assert f.time_stamp.dt == now
         assert now.isoformat() in str(f.to_string())
         assert "TimeStamp>" in str(f.to_string())
         assert "when>" in str(f.to_string())
-        f.time_stamp = KmlDateTime(now.date())
+        f._times = kml.TimeStamp(timestamp=KmlDateTime(now.date()))
         assert now.date().isoformat() in str(f.to_string())
         assert now.isoformat() not in str(f.to_string())
-        f.time_stamp = None
+        f._times = None
         assert "TimeStamp>" not in str(f.to_string())
 
     @pytest.mark.skip(reason="not yet implemented")
@@ -367,7 +366,6 @@ def test_read_timespan(self) -> None:
         assert ts.end.dt == datetime.datetime(1997, 7, 16, 7, 30, 15, tzinfo=tzutc())
 
     def test_featurefromstring(self) -> None:
-        d = kml.Document(ns="")
         doc = """<Document>
           <name>Document.kml</name>
           <open>1</open>
@@ -380,7 +378,17 @@ def test_featurefromstring(self) -> None:
           </TimeSpan>
         </Document>"""
 
-        d.from_string(doc)
+        d = kml.Document.class_from_string(doc, ns="")
+
+        assert d.time_stamp.dt == datetime.datetime(
+            1997,
+            7,
+            16,
+            10,
+            30,
+            15,
+            tzinfo=tzoffset(None, 10800),
+        )
 
 
 class TestLxml(Lxml, TestStdLibrary):

From b8adec883cb75fb6944a773545e7704e6130685c Mon Sep 17 00:00:00 2001
From: Sourcery AI <>
Date: Sat, 25 Nov 2023 16:38:14 +0000
Subject: [PATCH 25/25] 'Refactored by Sourcery'

---
 fastkml/features.py   | 8 ++------
 tests/oldunit_test.py | 6 +++---
 2 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/fastkml/features.py b/fastkml/features.py
index 7f7b059d..2259d544 100644
--- a/fastkml/features.py
+++ b/fastkml/features.py
@@ -202,9 +202,7 @@ def style_url(self) -> Optional[str]:
         Returns the url only, not a full StyleUrl object.
         if you need the full StyleUrl object use _style_url.
         """
-        if isinstance(self._style_url, StyleUrl):
-            return self._style_url.url
-        return None
+        return self._style_url.url if isinstance(self._style_url, StyleUrl) else None
 
     @style_url.setter
     def style_url(self, styleurl: Union[str, StyleUrl, None]) -> None:
@@ -537,9 +535,7 @@ def __init__(
 
     @property
     def geometry(self) -> Optional[AnyGeometryType]:
-        if self._geometry is not None:
-            return self._geometry.geometry
-        return None
+        return self._geometry.geometry if self._geometry is not None else None
 
     def etree_element(
         self,
diff --git a/tests/oldunit_test.py b/tests/oldunit_test.py
index 8a324096..51915156 100644
--- a/tests/oldunit_test.py
+++ b/tests/oldunit_test.py
@@ -522,14 +522,14 @@ def test_from_wrong_string(self) -> None:
         pytest.raises(TypeError, kml.KML.class_from_string, "<xml></xml>")
 
     def test_from_string_with_unbound_prefix(self) -> None:
-        doc = """<kml xmlns="http://www.opengis.net/kml/2.2">
+        if LXML:
+            config.set_etree_implementation(lxml.etree)
+            doc = """<kml xmlns="http://www.opengis.net/kml/2.2">
         <Placemark>
         <ExtendedData>
           <lc:attachment>image.png</lc:attachment>
         </ExtendedData>
         </Placemark> </kml>"""
-        if LXML:
-            config.set_etree_implementation(lxml.etree)
             k = kml.KML.class_from_string(doc)
             assert len(list(k.features())) == 1