Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: ブラウザ遷移の時はLineIDをハッシュ化して扱う #28

Open
claustra01 opened this issue Apr 15, 2024 · 0 comments
Open

Enhancement: ブラウザ遷移の時はLineIDをハッシュ化して扱う #28

claustra01 opened this issue Apr 15, 2024 · 0 comments
Labels
priority: low We would do it, but not urgent problem: vulnerability Features witch have some security issues type: enchancement Enhance or modify existing features

Comments

@claustra01
Copy link
Owner

Overview / 概要

Google認証の時にブラウザ遷移を行うが、その時のクエリパラメータにそのままのLineIDを含まないようにする

Motivation / 動機

LineIDがそのままクエリパラメータに含まれており、ログなどにLineIDが残ってしまう可能性があるため、セキュリティ上の懸念がある

Current Behavior / 現在の動作

No response

Suggested Solution / 提案される解決策

ハッシュ化されたLineIDを別で保持しておき、その比較によってID一致を検知する

Alternatives / 代替案

No response
@claustra01 claustra01 added priority: low We would do it, but not urgent type: enchancement Enhance or modify existing features problem: vulnerability Features witch have some security issues labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low We would do it, but not urgent problem: vulnerability Features witch have some security issues type: enchancement Enhance or modify existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@claustra01