Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dire Maul Fixes #113

Closed
scotty0100 opened this issue Sep 4, 2013 · 11 comments
Closed

Dire Maul Fixes #113

scotty0100 opened this issue Sep 4, 2013 · 11 comments

Comments

@scotty0100
Copy link
Contributor

Ironbark the Redeemed wasn't spawning after Zanzil's death.

The door after the final boss (Alzzin) wasn't opening after his death.

INSERT INTO dbscripts_on_creature_death (id, delay, command, datalong, datalong2, buddy_entry, search_radius, data_flags, dataint, dataint2, dataint3, dataint4, x, y, z, o, comments) VALUES
(11492, 0, 11, 14813, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 'Open Crumble Wall after Alzzin's Death'),
(11490, 0, 18, 0, 0, 11491, 138118, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Despawn Old Ironbark after Zanzil's Death'),
(11490, 0, 10, 14241, 0, 0, 0, 0, 0, 0, 0, 0, -72.171898, -283.252014, -57.749699, 4.084070, 'Spawn ironbark the redeemed after Zanzils death');

@Schmoozerd
Copy link
Contributor

no, none of these fixes is proper i think.
See https://github.com/scriptdev2/scriptdev2/blob/master/scripts/kalimdor/dire_maul/instance_dire_maul.cpp

I cannot tell what is going on directly, but the door after alzzin is supported with sd2.

case TYPE_ALZZIN: // This Encounter is expected to be handled within Acid (reason handling at 50% hp)
..
DoUseDoorOrButton(GO_CRUMBLE_WALL);

Maybe there is some mismatch with zanzil and zevrim?

case TYPE_ZEVRIM:
...
pIronbark->UpdateEntry(NPC_IRONBARK_REDEEMED);

@cala
Copy link
Member

cala commented Sep 5, 2013

I was thinking the same. Maybe something in the database is wrong/missing and prevent SD2 from working as intended?
Now that version 1.2.0 is released, I will have a better look on DM and UBRS/LBRS that had many reports lately.

@scotty0100
Copy link
Contributor Author

Apologies, I should have looked in further into SD2. However, on the topic of dire maul fixes then, I'll add them to here if I see anything that doesn't look right. I'm looking at old dire maul instance run videos and comparing them to cMangos core.

First one I noticed so far is Guard Fengus at the moment stands over the box; however on retail he seems to wonder around the platform and then seems to charge the center if the box gets looted.

Source 1: https://www.youtube.com/watch?feature=player_detailpage&v=KVyqLWOWPZ0#t=356
Source 2: https://www.youtube.com/watch?feature=player_detailpage&v=iSumJg7dm1c#t=140
Source 3: https://www.youtube.com/watch?feature=player_detailpage&v=aOb8qB8G4x4#t=348

On source 2 it looks like he is avoidable also. So maybe can have him charge to the location rather than to the player.

Will continue to add dire maul issues here if that's OK 👍

EDIT: I don't think he charges when the box is looted actually, looking at source 2 again he is just walking slowly, it's just because the video is sped up it looks faster, I think he just paths across there as well.

@scotty0100
Copy link
Contributor Author

Lethtendris & Pimgib pathing around the campfire. Source: http://www.youtube.com/watch?feature=player_detailpage&v=hdU-IWdLZ54#t=131

Currently they stand still.

@scotty0100
Copy link
Contributor Author

Fairly big bug in Dire Maul also; after killing King Gordok and speaking to Mizzle the Crafty, you can spawn an unlimited amount of chests by keep going back and talking to him.

Would you rather me separate these bugs in new issues or this OK?

@scotty0100
Copy link
Contributor Author

Knot Thimblejack's Cache is currently located underneath Immolthar. I believe it should spawn next to Knot after you complete the "Free Knot" quest.

@cala
Copy link
Member

cala commented Sep 12, 2013

Thank you for all these reports. I prefer you open separate issues, it is easier to keep track of it.
There is also a big report already opened about Dire Maul: #77

I tested yesterday the first ones: I confirm Ironbark/Zevrim/Alzzin events work as intented with SD2. The only errors I noticed were Alzzin using only partially its ACID script (to be checked further).

Many creature movements/patrols are missing in DM, flags are not OK or positions wrong. I'm slowly working on everyone of these. Thank you. 👍

@cala
Copy link
Member

cala commented Oct 27, 2013

Lethtendris & Pimgib pathing around the campfire. Currently they stand still.

Is fixed by 3871dac

@cala cala modified the milestone: Eldre'Thalas May 7, 2014
@cala
Copy link
Member

cala commented Jan 2, 2015

First one I noticed so far is Guard Fengus at the moment stands over the box; however on retail he seems to wonder around the platform and then seems to charge the center if the box gets looted.

Fixed in 9dfad04

@cala
Copy link
Member

cala commented Mar 25, 2015

Mizzle and Gordok's cache are fixed by 94a05ca

@cala cala closed this as completed in f17b780 Apr 27, 2015
@cala
Copy link
Member

cala commented Apr 27, 2015

All sub issues described in this thread are now fixed. Thanks everyone.

cala added a commit that referenced this issue Sep 9, 2016
* Fixed quest 5525 (Free Knot!) and its repeatable follow up 7429 (Free
Knot!) in Dire Maul North
This closes #746 and closes #113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants