Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagefactory 1.1.11 breaks with oz-0.17.x API issue #276

Open
spstarr opened this issue Nov 4, 2019 · 3 comments
Open

Imagefactory 1.1.11 breaks with oz-0.17.x API issue #276

spstarr opened this issue Nov 4, 2019 · 3 comments

Comments

@spstarr
Copy link

spstarr commented Nov 4, 2019

2019-11-04 14:58:14,670 ERROR imgfac.Builder.Builder thread(6195c89c) Message: __init__() takes exactly 13 arguments (12 given)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/imgfac/Builder.py", line 132, in _build_image_from_template
    self.os_plugin.create_base_image(self, template, parameters)
  File "/usr/lib/python2.7/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 322, in create_base_image
    self._init_oz()
  File "/usr/lib/python2.7/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 299, in _init_oz
    self.init_guest()
  File "/usr/lib/python2.7/site-packages/imagefactory_plugins/TinMan/TinMan.py", line 408, in init_guest
    self.guest = oz.GuestFactory.guest_factory(self.tdlobj, self.oz_config, install_script_name)
  File "/usr/lib/python2.7/site-packages/oz/GuestFactory.py", line 106, in guest_factory
    diskbus, macaddress)
  File "/usr/lib/python2.7/site-packages/oz/RHEL_7.py", line 79, in get_class
    return RHEL7Guest(tdl, config, auto, output_disk, netdev) #, diskbus)
  File "/usr/lib/python2.7/site-packages/oz/RHEL_7.py", line 38, in __init__

I was unable to run imagefactory to make an OVA.

Downgrading Oz to 0.16.x worked... unsure whats going on debugging the python code here.

@spstarr spstarr changed the title Imagefactory 1.1.11 break with oz-0.17.x Imagefactory 1.1.11 breaks with oz-0.17.x API issue Nov 4, 2019
@spstarr
Copy link
Author

spstarr commented Nov 4, 2019

I would have assumed 0.16 -> 0.17 is a minor change vs API change :(

@clalancette
Copy link
Owner

I would have assumed 0.16 -> 0.17 is a minor change vs API change :(

Yep, and it is. We generally take API backwards compatibility seriously, not sure what is going on there.

@spstarr
Copy link
Author

spstarr commented Nov 7, 2019

Neither, I've downgraded for now, at least i can build OVA images now, tried debugging the code, but I don't understand why that class import is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants