Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra <br data-cke-filler> element added where it is not supposted to be compared to the original content #17243

Open
Sanderovich opened this issue Oct 9, 2024 · 0 comments
Labels
support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Sanderovich
Copy link

πŸ“ Provide detailed reproduction steps (if any)

  1. Copy the rendered html <p>Hello!</p><br><h1>Heading</h1> or Hello!<br><h1>Heading</h1> into the CKEditor Demo.

βœ”οΈ Expected result

Hello!

Heading

❌ Actual result

Extra space between Hello! and Heading.

Hello!


Heading

❓ Possible solution

In the DomConverter viewChildrenToDom it asks for the fillerPositionOfset and the ContainerElement always gives a filler when it ends with a <br>. Near the code is the following comment: // Block filler is required after a
if it's the last element in its container. See #1422. which points me to a irrelvant pull request (#1422), so I can not determine why it was added, but if I remove the related code I get the expected result.

πŸ“ƒ Other details

  • Browser: Firefox, Chromium
  • OS: Wndow, Linux
  • Tested on CKEditor Demo

If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@Sanderovich Sanderovich added the type:bug This issue reports a buggy (incorrect) behavior. label Oct 9, 2024
@aldonace-wu aldonace-wu added the support:2 An issue reported by a commercially licensed client. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants