Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ckeditor 5 custom build in angular 16 library (ng-packagr) #399

Open
Dovernh opened this issue Nov 25, 2023 · 5 comments
Open

Ckeditor 5 custom build in angular 16 library (ng-packagr) #399

Dovernh opened this issue Nov 25, 2023 · 5 comments

Comments

@Dovernh
Copy link

Dovernh commented Nov 25, 2023

I have created an angular 16 library with a custom ckeditor5 build.

  • ckeditor5-custom-build
  • projects
  •  abc-editor
    
  •      lib
    
  •         abc-editor
    
  •             component
    
  •                 abc-component.ts
    
  •                 abc-component.html
    
  •  showcase
    
  •      src
    
  •          app
    
  •              editor
    
  •                  editor.component.ts
    
  •                  editor.component,html
    

If I run the showcase the editor works, no issues
If I try and build the abc-editor it fails

✔ Compiling with Angular sources in Ivy partial compilation mode.
✖ Generating FESM bundles
Could not load C:\appdev\otised\ABC.Editor\ckeditor5-custom-build\build\ckeditor.js (imported by dist/abc-editor/esm2022/lib/abc-editor/component/abc-editor.component.mjs): Could not load 'C:\appdev\otised\OtisEd.Editor\ckeditor5-custom-build\build\ckeditor.js' from memory.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this com

@Witoso
Copy link
Member

Witoso commented Nov 27, 2023

@mremiszewski do you have some thoughts here?

@Dovernh
Copy link
Author

Dovernh commented Nov 27, 2023

mremiszewski
if i add ckeditor as a component in app, everything is good.
if ckeditor is run from the showcase (above), everything is good.
if it is not a custom ckeditor build in a library, everything is good
i have other components that follow the same structure as above, they work w/o issue

i think something is not correct between the custom build of ckeditor.js and ng-packagr. I found something w/ same error, but not specific to ckeditor: ng-packagr/ng-packagr#2666.

@Witoso
Copy link
Member

Witoso commented Nov 28, 2023

I'm afraid it will be extremely hard for us to debug what happens in some third-party packaging solution :(

@Dovernh
Copy link
Author

Dovernh commented Nov 29, 2023

What do u mean by third party packaging solutions? ng-packagr or a custom ckeditor build or my library? I do not mean to be argumentative, just looking for my next steps to resolve this issue

@Witoso Witoso changed the title Ckeditor 5 custom build in angular 16 library Ckeditor 5 custom build in angular 16 library (ng-packagr) Dec 4, 2023
@Witoso
Copy link
Member

Witoso commented Dec 4, 2023

Sorry! I meant ng-packagr is not an official Angular library, but I checked it again, and it's recommended in the Angular docs.

I am uncertain whether we will be able to troubleshoot it as we currently lack the time or a deeper understanding of the Angular domain. Maybe someone in the community will come to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants