Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroller issue when resizing #55

Closed
ccorcos opened this issue Jul 17, 2017 · 5 comments
Closed

Scroller issue when resizing #55

ccorcos opened this issue Jul 17, 2017 · 5 comments
Labels

Comments

@ccorcos
Copy link
Contributor

ccorcos commented Jul 17, 2017

I've created a minimal reproduction here:

https://github.com/ccorcos/cordova-scroller

Its just a screen with an input (1). However, when the keyboard shrinks the view, the scrollView somehow thinks that there's room to scroll and when you attempt to scroll, it shows a scrollbar on the side (2). This is really annoying when you have actual content onscreen because if you overscroll, this scrollbar turns on and you cant continue scrolling your content until the momentum dies on the scrollview.

(1)
image

(2)
image

@ccorcos
Copy link
Contributor Author

ccorcos commented Jul 17, 2017

Some things I've notices as well:

  • this is not an issue in landscape mode
  • if I got to landscape mode and back again while the keyboard is open, the scroller isnt there anymore.

@ccorcos
Copy link
Contributor Author

ccorcos commented Jul 17, 2017

  • It appears the scrollView.contentSize isnt updated properly

@cjpearson
Copy link
Owner

Removing the iOS version check here seems to solve the issue for me. The window.innerHeight bug was fixed in iOS 10, but perhaps this method is causing issues with the scroll view.

@cjpearson cjpearson added the bug label Jul 25, 2017
@ccorcos
Copy link
Contributor Author

ccorcos commented Jul 25, 2017

Hmm. So should we remove that in this library as well?

ccorcos added a commit to ccorcos/cordova-plugin-keyboard that referenced this issue Jul 25, 2017
cjpearson pushed a commit that referenced this issue Sep 18, 2017
(cherry picked from commit cf6d21c)
@cjpearson
Copy link
Owner

Merged in that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants