-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upgrade artifact actions to v4 #1399
base: main
Are you sure you want to change the base?
Conversation
{% raw %} | ||
name: coverage-data-${{ matrix.python }}-${{ matrix.os }} | ||
{% endraw %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these % raw tags needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise the line would look like this:
name: coverage-data-${{"{{"}} matrix.python {{"}}"}}-${{"{{"}} matrix.os {{"}}"}}
This was suggested by @webknjaz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bosd it's usually cleaner to wrap chunks of mustache that shouldn't be rendered this way. I find that seeing {{ '{{' }}
all over the place doesn't help readability.
I think a codecov token should be added as well. |
Shouldn't this be done in a separate pull request as it is about bumping |
@gatoniel tokens are mandatory in v4 and v5 of the action (by the way, v5 was released several days ago so maybe you could bump to that). Though, secrets are inaccesible in forks and this upload method tends to make uploads in PRs from forks less stable. The solution many have found is storing the token in plain text instead of repo secrets. It's not that secret, anyway. I like putting it into the config file OTOH, Codecov has recently introduced an org-level toggle on the web UI to disable requiring tokens for uploads. I haven't tried it but it seems like it might eliminate the need to use tokens again.. |
I can try to also add the |
Oh, I got confused and thought you were bumping codecov for a minute. I that case, it's out of the scope, you're right. |
I don't mind doing it, in a separate PR. But is this project going to be continued or are there other cookiecutters getting more attention for python projects as this one is not supporting major new developments in the python community? I am too outside of the active community to see these developments :( But, I've heard people stop using |
There's one by Simon Willison: https://github.com/simonw/python-lib |
fixes #1398