Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change favicon #52

Open
gregjd opened this issue Mar 7, 2017 · 5 comments
Open

Change favicon #52

gregjd opened this issue Mar 7, 2017 · 5 comments
Labels
beginner ready

Comments

@gregjd
Copy link
Member

gregjd commented Mar 7, 2017

screen shot 2017-03-06 at 8 39 50 pm

Currently the favicon is white and squished. At the very least, we don't want it to look squished.

But we also may not want it to be white. Do we want it to be red, since it is Code for DC's? This semi-relates to the overall design of the site. (See also: #47)

This might help for changing the favicon: http://docs.ckan.org/en/latest/maintaining/configuration.html#ckan-favicon
@gregjd
Copy link
Member Author

gregjd commented Mar 7, 2017

I have no idea where the favicon is being drawn from. We don't seem to have a file in the location specified by that link. It looks like we're using logo.png from this directory, but it doesn't seem to be referenced in the site's HTML (see search results here).

@jalbertbowden
Copy link
Collaborator

i submitted a pull request to the main site's repository with a directory of assets. there's a bunch of favicons in it.

@jalbertbowden
Copy link
Collaborator

here's the url of where it is pulling from:
http://data.codefordc.org/c4dc-logo-white-30x58.png

@mcculleydj
Copy link

We can and I think should just make this a static resource. In our extension we can add an icon file to .../public/base/images with a unique name. Public resources added to extensions are combined with the resources CKAN ships with e.g. ckan.ico. So in the .ini you can just use the same path /base/images/<file_name> to set the icon we want to use. I'm not actually seeing how this:

<head>
    ...
    <link rel="shortcut icon" href="/c4dc-logo-white-30x58.png">
<head/>

is getting set. Nothing greps from the src files I'm looking at.

Any chance we have an image that is circular or square (to prevent the squish problem)?

@jalbertbowden
Copy link
Collaborator

https://github.com/codefordc/codefordc.github.com/tree/master/assets/img/logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jalbertbowden @mkalish @gregjd @mcculleydj