Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with 5.60+ ? #594

Closed
jofranz opened this issue Sep 4, 2023 · 2 comments
Closed

Incompatible with 5.60+ ? #594

jofranz opened this issue Sep 4, 2023 · 2 comments

Comments

@jofranz
Copy link

jofranz commented Sep 4, 2023

These methods got removed from core:

org.civicrm.volunteer/CRM/Volunteer/BAO/Project.php:          $roles[$role_id] = CRM_Core_OptionGroup::getLabel(
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerNeedTest.php:      "visibility_id" => CRM_Core_OptionGroup::getValue('visibility', 'public', 'name'),
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectContactTest.php:      'relationship_type_id' => CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, 'volunteer_owner', 'name'),
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectContactTest.php:    $relTypeId = CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, 'volunteer_owner', 'name');
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectContactTest.php:    $relTypeLabel = CRM_Core_OptionGroup::getLabel(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, $relTypeId);
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectTest.php:    $bao->relationship_type_id = CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, 'volunteer_owner', 'name');
org.civicrm.volunteer/tests/phpunit/api/v3/VolunteerProjectTest.php:    $bao->relationship_type_id = CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP, 'volunteer_manager', 'name');
org.civicrm.volunteer/tests/phpunit/CRM/Volunteer/BAO/AssignmentTest.php:      'relationship_type_id' => CRM_Core_OptionGroup::getValue('volunteer_project_relationship', 'volunteer_beneficiary', 'name'),
org.civicrm.volunteer/tests/phpunit/CRM/Volunteer/BAO/ProjectTest.php:    $relType = CRM_Core_OptionGroup::getValue(CRM_Volunteer_BAO_ProjectContact::RELATIONSHIP_OPTION_GROUP,

@MegaphoneJon
Copy link
Contributor

#589 fixes the getValue() references, which gets it working for my client, though they're admittedly a light user.

@mlutfy
Copy link
Member

mlutfy commented Oct 24, 2024

Since the PR 589 was merged, I will take the liberty of closing this issue.

@mlutfy mlutfy closed this as completed Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants