Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Angular Module into Public and Admin #509

Open
ginkgomzd opened this issue May 13, 2019 · 0 comments
Open

Separate Angular Module into Public and Admin #509

ginkgomzd opened this issue May 13, 2019 · 0 comments

Comments

@ginkgomzd
Copy link
Contributor

As found in #494 , the Manage Projects UI is rendered with the public theme.
This is because the CiviCRM Menu (route) for the base-page is configured for public because it is expected that the Opportunity Search is wanted as a public page.

Because the Manage Projects UI is implemented as a route in the same angular module as the Opportunity Search, they must share the public-visibility config.

Solution will probably require three or more separate angular modules, one for Manage, one for Opportunities, and one for shared.

I do know that there was a lot of discussion about packaging of angular modules, so there are probably devils in the details to be flushed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant