Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow + for deep customizations on core:install #183

Open
totten opened this issue Nov 9, 2023 · 3 comments
Open

Allow + for deep customizations on core:install #183

totten opened this issue Nov 9, 2023 · 3 comments

Comments

@totten
Copy link
Member

totten commented Nov 9, 2023

Background: In several commands (api3, api4, setting:set), there are two kinds of options:

  • Control options: Arguments like --level, --out, -T, --user, --cwd, --hostname influence the way that cv works. The naming / formatting / behavior of the options are primarily driven by cv.
  • Data model options: Arguments like +s field_1,field2 influence the data that cv passes through to civicrm.The naming / formatting / behavior are primarily driven by CiviCRM's model. The convention here is tuned for "adding data to a request-document". If you need to get really detailed, it allows JSON.

Problem: The core:install command has a mix of control options and data model options. But the data-model options don't follow the + convention; they miss a bunch of edge-cases; and they don't allow JSON. The same is true of core:check-req and core:uninstall.

Example: Currently, you can use cv path -m X=Y, but there's no way to set a value for $setup->model['paths']['civicrm.files'].

Idea: In the same vein as SettingArgParser or Api4ArgParser, add a SetupModelParser to allow more inputs. Follow the same + conventions as the other commands.

@demeritcowboy
Copy link
Contributor

Related, or actually probably the same thing: #72

@totten
Copy link
Member Author

totten commented Nov 10, 2023

Right as usual @demeritcowboy. The first issue says, "I'm hungry"; and the second issue says, "Get a slice of pizza".

@demeritcowboy
Copy link
Contributor

🇭🇺 🍕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants