dev/core#5622 Afform conditionals: loosen type comparison on "CONTAINS"

[highfalutin]

Overview

Too-strict comparison was causing FormBuilder conditional field behavior to fail. See dev/core#5622

Before

Conditional fields don't work when they depend on a multi-select field using an integer data type.

After

Conditionals work.

Technical Details

The problem was here:

Note that val1[0] is a string, and val2 is an int. The includes function uses strict comparison, so it was returning a non-match.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5622

[colemanw]

@highfalutin I don't mind merging this, but my general approach to this perennial problem has been to track down where the type mismatch originates from and fix it there. For example:

• Afform - Fix display value in select & autocomplete widgets #30915
• APIv4 - Ensure dataType of option id matches dataType of field #30727

I thought I had whacked all the moles but I guess you've found one more (unless you created this form before those fixes were merged).

[highfalutin]

I agree, better to fix the problem higher upstream if possible. But I don't know the upstream code well enough to do that. In the angularjs data model, the form field's value is an array of strings, even though it should be an array of integers.

I reproduced the problem on master, so yes I think unfortunately those two other fixes don't apply to it.