Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the return value of admin address #99

Open
timmyz opened this issue Jan 30, 2019 · 3 comments
Open

the return value of admin address #99

timmyz opened this issue Jan 30, 2019 · 3 comments

Comments

@timmyz
Copy link

timmyz commented Jan 30, 2019

image

the image above should have described the issue clearly. well, i'm not quite familiar with rust grammar, i guess this line (cita-cli/src/cli/contract_command.rs) should be modified:
      ("admin", Some(m)) => AdminClient::create(client).admin(m.value_of("height")),

make the return value remove the prefix 00000..., maybe some method named wrap()?

@driftluo
Copy link
Collaborator

In fact, the idea is not to change the admin contract, but to change the address verification, attempt to remove the prefix 00... of the address.

Because the return value on the chain is indeed like this, I feel that as a tool, I can't change the return data on the chain at will.

@timmyz
Copy link
Author

timmyz commented Jan 30, 2019 via email

@driftluo
Copy link
Collaborator

Well, this really can be considered. However, this may require a lot of work. It may need to refactor some code.
I may not have time on this matter. Currently, I am working hard on the construction of the p2p framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants