Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search & Remove reductant api's in utill.rs #233

Open
KnowWhoami opened this issue Aug 14, 2024 · 1 comment
Open

Search & Remove reductant api's in utill.rs #233

KnowWhoami opened this issue Aug 14, 2024 · 1 comment
Labels
BDK-Wallet enhancement This enhances the code and improves stuffs good first issue Good for newcomers
Milestone

Comments

@KnowWhoami
Copy link
Collaborator

In the utill.rs file, there are several functions that perform tasks for which APIs already exist in the dependency libraries.

For example

pub fn read_bitcoin_network_string(network: &str) -> Result<Network, String> {

  • This function converts a network string into a Network struct. However, we don't need to create a separate API for this functionality, as it can be accomplished using the existing Network::from_str() method from rust-bitcoin.

  • Thus we have to find all such functions and remove them and directly call corresponding built-in apis.

@KnowWhoami KnowWhoami changed the title Search & Remove reduanctant api's in utill.rs Search & Remove reductant api's in utill.rs Aug 14, 2024
@KnowWhoami KnowWhoami added good first issue Good for newcomers enhancement This enhances the code and improves stuffs labels Aug 14, 2024
@KnowWhoami KnowWhoami added this to the v0.1.0 milestone Aug 14, 2024
@KnowWhoami
Copy link
Collaborator Author

  • For BDK related api's -> do not remove those functions now as that must be done while integrating our wallet with BDK.
  • Just raise another issue for them.

@mojoX911 mojoX911 linked a pull request Oct 6, 2024 that will close this issue
@mojoX911 mojoX911 modified the milestones: v0.1.0, v0.1.1 Oct 7, 2024
@mojoX911 mojoX911 removed a link to a pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BDK-Wallet enhancement This enhances the code and improves stuffs good first issue Good for newcomers
Projects
Status: todo
Development

No branches or pull requests

2 participants