forked from bitcoin-teleport/teleport-transactions
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search & Remove reductant api's in utill.rs
#233
Labels
BDK-Wallet
enhancement
This enhances the code and improves stuffs
good first issue
Good for newcomers
Milestone
Comments
KnowWhoami
changed the title
Search & Remove reduanctant api's in
Search & Remove reductant api's in Aug 14, 2024
utill.rs
utill.rs
KnowWhoami
added
good first issue
Good for newcomers
enhancement
This enhances the code and improves stuffs
labels
Aug 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
BDK-Wallet
enhancement
This enhances the code and improves stuffs
good first issue
Good for newcomers
In the utill.rs file, there are several functions that perform tasks for which APIs already exist in the dependency libraries.
For example
coinswap/src/utill.rs
Line 465 in 691c937
This function converts a network string into a Network struct. However, we don't need to create a separate API for this functionality, as it can be accomplished using the existing
Network::from_str()
method fromrust-bitcoin
.Thus we have to find all such functions and remove them and directly call corresponding built-in apis.
The text was updated successfully, but these errors were encountered: