-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto-js rather then crypto #394
Comments
@arun3528 Hi, I have located the object construction builder in algorithms/helpers and replaced the require statement "crypto" to "crypto-js". Any suggestions on testing within the library, might just be late, will have to come back and review. |
This is the sdk we use it in https://github.com/webex/webex-js-sdk |
`50 results - 12 files lib/algorithms/aes-cbc-hmac-sha2.js: 185 var name = "AES-" + size + "-CBC"; lib/algorithms/aes-gcm.js: 325 try { lib/algorithms/aes-kw.js: 254 B = Buffer.concat([B, R[idx], iv]); lib/algorithms/ecdh.js: 166 // {pubKey} is "buffer" lib/algorithms/ecdsa.js: 91 var promise; 198 var nodeHash = hash.toLowerCase().replace("-", ""); 217 var promise; lib/algorithms/helpers.js: 80 94 lib/algorithms/hmac.js: 171 lib/algorithms/pbes2.js: 134 } lib/algorithms/rsaes.js: 92 169 key = rsaUtil.convertToPem(key, false); lib/algorithms/rsassa.js: 68 var nodeHash = "RSA-" + hash.replace("-", ""); 139 var nodejs; 221 nodejs = function(key, pdata) { 226 key: rsaUtil.convertToPem(key, false), 307 nodejs = function(key, pdata, mac) { 312 key: rsaUtil.convertToPem(key, true), lib/algorithms/sha.js: lib/jwk/rsakey.js: 262 |
Is there a PR to change the require from crypto to crypto-js. This is breaking when we are using the esbuild preprocessor. |
@justaugustus , Is it okay to change the require from crypto to crypto-js? This line would change. |
client does not have to do node pollyfills if we move to use the js version
The text was updated successfully, but these errors were encountered: