Add the docker portions of pca-report-library #10
Conversation
The --version command came from skeleton-python-library and will not work anymore. The updated command comes from pca-report-library and will work.
ameliav
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
…generator-docker into PCADEV-197-customize
| @@ -1,4 +1,4 @@ | |||
| # pca-report-generator-docker 💀🐳 # | |||
| # pca-report-generator-docker # | |||
There was a problem hiding this comment.
Some of the recent items that I noted have made me realize that this repo should really be called pca-report-library-docker, since it containerizes pca-report-library. Let's take care of that name change (and the related changes to the README) as the final step after all of the other conversations in this PR have been resolved.
There was a problem hiding this comment.
@dav3r okay- please let me know when and how to take care of this or if you will
There was a problem hiding this comment.
Hi @dav3r when you are back from vacation, please let me know if everything else has been resolved and then how to take care of the repo name change, thanks.
There was a problem hiding this comment.
Will do @ameliav - I am going try to get back to you on this tomorrow.
There was a problem hiding this comment.
The repo name change is pretty simple- I'm thinking we should change the repo name as soon as this PR is merged. I can take care of the renaming. In the meantime, you should update the README and change anything that says pca-report-generator-docker to pca-report-library-docker.
In addition to that, you still have to get the failing tests to pass. Let me know if you need any help there.
There was a problem hiding this comment.
Hi @dav3r thanks for getting back. I've been assigned to another task so this has been put on hold for me. Will comment again when I'm able to work on this again.
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
Co-authored-by: dav3r <[email protected]>
🗣 Description
Add the docker portions of pca-report-library into this repository
💭 Motivation and context
This change is required to get it up to speed with cisagov coding standards and is part of the plan to fully modernize pca-report-library. This repository will house the docker portions of pca-report-library while also maintaining the base skeleton-docker.
Resolves #2
🧪 Testing
Using pytest to test changes and pre-commit
✅ Checklist
in code comments.
to reflect the changes in this PR.