Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool-build problem #31

Open
atoy40 opened this issue Apr 5, 2019 · 1 comment
Open

pool-build problem #31

atoy40 opened this issue Apr 5, 2019 · 1 comment

Comments

@atoy40
Copy link
Contributor

atoy40 commented Apr 5, 2019

Hi,
in the pool provider, virsh pool-build is always called after virsh pool-define. But in some cases, you don't want to build the pool. For example, when you define a LVM group pool, the LVM group in most situation already exists on the system, so, pool-build raise an error.
The error is caught and simply noticed by the provider, so it works btw, but it can be very dangerous to call it : who know the behavior of libvirt in the future, and so the risk of losing data.
May be it can be a good idea to add a "build" (or nobuild) boolean parameter to the pool type ? or at least to add the "--no-overwrite" flag to pool-build to be sure libvirt will never try something .... dangerous :)

What do you think about ?

Anthony.

@trefzer
Copy link
Contributor

trefzer commented Aug 2, 2019

I do not use this functionality currently. But adding a build parameter seems to be a good idea
as far as I understand the problem.
I would be happy to merge a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants