Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage pool source name checking #17

Open
kokey opened this issue Apr 25, 2018 · 1 comment
Open

storage pool source name checking #17

kokey opened this issue Apr 25, 2018 · 1 comment

Comments

@kokey
Copy link

kokey commented Apr 25, 2018

If a storage pool source name does not exist, then the module stops being able to modify it.
E.g.

libvirt_pool { 'default' :
	ensure     => present,
	type       => 'logical',
	autostart  => true,
	sourcedev  => '/dev/sda5',
	sourcename => 'this_name_is_nonsense',
	target     => '/dev/vm',
}

After trying to apply that, the pool is created but not active, but also can't be updated by the module to fix it, or any other libvirt_pool created on the same device. Ideally there should be a sanity check on sourcename to name sure it exists, then it would avoid getting into this situation.

The way to work around it is to virsh pool-edit and fix the name, then pool-start, then fix the name in the declaration.

@trefzer
Copy link
Contributor

trefzer commented May 13, 2018

I do not have time to look at this issue, if anyone, please submit a pull request !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants