Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Ensure that only config from the local project is loaded. #6

Open
gordonsyme opened this issue May 15, 2017 · 2 comments
Open

Ensure that only config from the local project is loaded. #6

gordonsyme opened this issue May 15, 2017 · 2 comments

Comments

@gordonsyme
Copy link
Member

It may be possible for a malicious jar to include a circleci_test/config.clj resource. Since config.clj contains arbitrary code and is evaluated we need to ensure that only a config.clj from the local project will ever be read.

@technomancy
Copy link
Member

It may be possible for a malicious jar to include their own version of clojure/core.clj too. If an attacker can get files onto your classpath, it's already game over. It's difficult to imagine a scenario where an attacker would be foiled by a check on this file and not be able to trivially work around it by replacing a different file.

@gordonsyme
Copy link
Member Author

Sure makes sense, it'd be nice to protect against accidental inclusion of test config in a library at any rate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants