Do not allow a negative indentLevel to throw RangeError: Invalid arra… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y length - force count to zero if negative
finom
added a commit
that referenced
this pull request
Dec 8, 2015
Do not allow a negative indentLevel to throw RangeError: Invalid arra…
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realised I forgot to PR this. It's an upstream bug in jsonlint, see zaach/jsonlint#73
Simplest replication I can find:
Which gives
Uncaught TypeError: Cannot read property 'top' of undefinedfrom main.js:1186. I've not checked other browsers but as it's a bug in jsonlint itself I'm sure it will be present.My fix is to force the count value to zero inside jsl.format.repeat if it happens to be negative.