-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support default values for case class members #12
Comments
As a user I dont think this should be on by default. I dont think its a feature most dev's expect and can lead to surprises. |
I came here to open an issue about exactly that. |
For me it's important because upickle does that. Upickle is deprecated and right now I'm looking for replacement. |
Curious what's the rationale for defaulting to making it a breaking change from being a drop-in replacement for generic/semi-auto (and also < 12) |
@shrynx To be honest my own work on circe-derivation has mostly been focused on supporting the needs of my current employer (originally Stripe, now Permutive). This is why there are only milestone releases and zero binary compatibility guarantees, etc. Matching the behavior of circe-generic and circe-generic-extras as closely as possible is one of the goals of the project, but for me at least a secondary one. I think we started using default values by default because that's what what @aparo did in #91, it worked for me, and nobody complained at the time. We can definitely revisit that decision, so please feel free to open a new issue or PR! |
There are (at least) two questions about how this should work:
cats.kernel.Eq
?The text was updated successfully, but these errors were encountered: