Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PlantUML user preferences on the CIMTool Preferences dialog #172

Open
tviegut opened this issue Oct 16, 2024 · 3 comments
Open

Support PlantUML user preferences on the CIMTool Preferences dialog #172

tviegut opened this issue Oct 16, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tviegut
Copy link
Contributor

tviegut commented Oct 16, 2024

With the introduction of PlantUML diagram generation in 2.2.0 the ability to support end-user preferences on the CIMTool Preference dialog is desirable. This issue is for introducing the following configurable PlantUML preferences for the diagrams generated in CIMTool:

  • Configurability of the color of concrete classes within diagrams (default preference should be #lightyellow)
  • Configurability of the color of abstract classes within diagrams (default preference should be #lightgrey)
  • Configurability of the color of enumeration classes within diagrams (default preference should be #lightgreen)
  • Configurability of whether or not to display the cardinality (e.g. [1] or [0..1]) for required attributes in a class. Not showing the cardinality aligns with common UML class diagram conventions where cardinalities of 1 are not explicitly shown and when not shown are assumed as required. (default preference for this should be to display cardinality for required attributes)

The configured values for these preferences would, in turn, need to be passed along to the new PlantUML builders to use during generation of any diagrams.

@tviegut tviegut added the bug Something isn't working label Oct 16, 2024
@tviegut tviegut self-assigned this Oct 16, 2024
@tviegut tviegut moved this to Backlog in CIMTool 2.3.0 Oct 16, 2024
@tviegut tviegut moved this from Backlog to Ready in CIMTool 2.3.0 Oct 16, 2024
@tviegut tviegut moved this from Ready to In progress in CIMTool 2.3.0 Oct 16, 2024
@tviegut tviegut moved this from In progress to In review in CIMTool 2.3.0 Oct 16, 2024
@tviegut tviegut changed the title The puml.xsl builder requires additional updates. The puml-t2b.xsl and puml-l2r.xsl builders require updates Oct 16, 2024
tviegut added a commit that referenced this issue Oct 16, 2024
@Sveino
Copy link

Sveino commented Oct 16, 2024

Would it make sense to have this as an option? I just think that in the case of domain expert that shall read the UML model they might not know that the default is 1..1.

@tviegut
Copy link
Contributor Author

tviegut commented Oct 16, 2024

Would it make sense to have this as an option? I just think that in the case of domain expert that shall read the UML model they might not know that the default is 1..1.

@Sveino : Thanks for the quick feedback. Ironically, I just finished adding end-user preference to change the default colors for concrete, abstract and enumerations in the CIMTool preferences screen. I just went ahead and added this also as a preferences setting based on your feedback:

image

image

@tviegut tviegut added enhancement New feature or request and removed bug Something isn't working labels Oct 16, 2024
@tviegut tviegut moved this from In review to In progress in CIMTool 2.3.0 Oct 16, 2024
@tviegut tviegut changed the title The puml-t2b.xsl and puml-l2r.xsl builders require updates Support PlantUML user preferences on the CIMTool Preferences dialog Oct 16, 2024
@tviegut tviegut removed the status in CIMTool 2.3.0 Oct 16, 2024
@Sveino
Copy link

Sveino commented Oct 17, 2024

Great! This is like order on Amazon Prime - next day delivery :-)

@tviegut tviegut moved this to Backlog in CIMTool 2.3.0 Oct 19, 2024
@tviegut tviegut moved this from Backlog to Ready in CIMTool 2.3.0 Oct 19, 2024
@tviegut tviegut moved this from Ready to In progress in CIMTool 2.3.0 Oct 19, 2024
tviegut added a commit that referenced this issue Oct 24, 2024
tviegut added a commit that referenced this issue Oct 24, 2024
@tviegut tviegut moved this from In progress to In review in CIMTool 2.3.0 Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In review
Development

No branches or pull requests

2 participants