Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize common metrics labels #2786

Open
3 tasks
lambdanis opened this issue Aug 9, 2024 · 0 comments
Open
3 tasks

Standardize common metrics labels #2786

lambdanis opened this issue Aug 9, 2024 · 0 comments
Labels
area/metrics Related to prometheus metrics

Comments

@lambdanis
Copy link
Contributor

lambdanis commented Aug 9, 2024

There are labels shared by multiple metrics, but using different names. Using the same name across metrics would make metrics more intuitive and easier to correlate.

Such shared labels should be defined in a shared library (pkg/metrics most likely), so that they can be easily reused.

Any changes made to the existing metrics must be documented in upgrade notes.

  • Use opcode for ops.OpCode (rather than msg_op or op)
  • Add op label in addition to opcode with a human-readable string
  • Use event_type for EventType (rather than event or type)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Related to prometheus metrics
Projects
Development

No branches or pull requests

1 participant