-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix codecov in person test #909
Comments
Hey @cieslarmichal, can I be assigned to this issue? |
Yeah, assigned |
Hello @cieslarmichal are there any errors with ASSERT_TRUE in person_test.cpp on your end? Should I look into it as part of this issue or is it being handled as part of another? |
It should not have any errors, build project first, maybe you dont have c++ compiler? |
Hey @cieslarmichal, unsure why the errors are occurring, I do have a compiler (using Apple Clang version 19.1.1), and my C++ is up to date (version 23). I have rebuilt the project with different compilers and C++ versions in case that is an issue, however, the errors are not disappearing. Since there are no errors on the build or when I run the tests, however, I assume it's an issue with the build settings on my end. |
Still don't know why it is occurring, The build settings seem to match and nothing changed when reinstalling the program. The original issue seems to be fixed in the meantime (errors from the screenshot in the issue are no longer appearing). I'll create the PR now as the above ASSERT TRUE errors don't seem to be affecting the build or execution of the tests. |
The text was updated successfully, but these errors were encountered: