Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codecov in person test #909

Open
cieslarmichal opened this issue Sep 7, 2024 · 6 comments
Open

fix codecov in person test #909

cieslarmichal opened this issue Sep 7, 2024 · 6 comments
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@cieslarmichal
Copy link
Owner

image

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Sep 7, 2024
@cieslarmichal cieslarmichal added this to the 100% codecov milestone Oct 9, 2024
@MichaScant
Copy link
Contributor

Hey @cieslarmichal, can I be assigned to this issue?

@cieslarmichal
Copy link
Owner Author

Yeah, assigned

@MichaScant
Copy link
Contributor

Hello @cieslarmichal are there any errors with ASSERT_TRUE in person_test.cpp on your end?
In addition to the issue displayed on the screenshot, I've been getting the following errors throughout the file.

Should I look into it as part of this issue or is it being handled as part of another?

Screenshot 2024-10-14 at 3 04 02 PM

@cieslarmichal
Copy link
Owner Author

It should not have any errors, build project first, maybe you dont have c++ compiler?

@MichaScant
Copy link
Contributor

Hey @cieslarmichal, unsure why the errors are occurring, I do have a compiler (using Apple Clang version 19.1.1), and my C++ is up to date (version 23). I have rebuilt the project with different compilers and C++ versions in case that is an issue, however, the errors are not disappearing. Since there are no errors on the build or when I run the tests, however, I assume it's an issue with the build settings on my end.

For context here is the error that occurs
Screenshot 2024-10-15 at 10 23 05 AM

@MichaScant
Copy link
Contributor

MichaScant commented Oct 15, 2024

Still don't know why it is occurring, The build settings seem to match and nothing changed when reinstalling the program.

The original issue seems to be fixed in the meantime (errors from the screenshot in the issue are no longer appearing). I'll create the PR now as the above ASSERT TRUE errors don't seem to be affecting the build or execution of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants