Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crypto module #245

Closed
cieslarmichal opened this issue Nov 12, 2023 · 6 comments · Fixed by #309
Closed

Add Crypto module #245

cieslarmichal opened this issue Nov 12, 2023 · 6 comments · Fixed by #309
Assignees
Labels
good first issue Good for newcomers

Comments

@cieslarmichal
Copy link
Owner

Add Crypto module with following functionalities:

-md5 (optional data arg, if not provided hash randomized data)
-sha256 (optional data arg, if not provided hash randomized data)

@cieslarmichal cieslarmichal added the good first issue Good for newcomers label Nov 12, 2023
@SunHashira
Copy link
Contributor

Hi, if I understand correctly, you want to hash data which is supposed to be some string or something else ? If so, is using openssl/md5.h and sha.h okay ? And if data are not provided, is hashing generated random word with Word.h enough to get needed hash ?

@cieslarmichal
Copy link
Owner Author

Hello, if data is not provided, some words are fine. I would like to avoid additional libs dependecies so maybe we could copy those algorithms from internet to our codebase? What do you think?

@SunHashira
Copy link
Contributor

I don't think it will be a problem to find some algorithms and use them but, I'm not proficient with copyright so I'm not exactly sure where to find freely available ones.

@cieslarmichal
Copy link
Owner Author

Here it is:

https://github.com/flexxxxer/md5_hash

https://github.com/System-Glitch/SHA256

Please add file ExternalLicenses.txt and copy their LICENSE file contents into it like:

External repositories licenses:

  1. flexxxxer/md5_hash:

license...

  1. System-Glitch/SHA256:

license...

@SunHashira
Copy link
Contributor

Okay, thanks for help, you can assign me this module and im going to do it now. Dumb question but just to be clear, ExternalLicenses.txt should be in module crypto folder ?

@cieslarmichal
Copy link
Owner Author

Assigned. In project root so we can add all future external licenses there

@cieslarmichal cieslarmichal linked a pull request Nov 21, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants