Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values and tags in spec test #148

Open
ExpHP opened this issue Jan 17, 2020 · 0 comments
Open

Values and tags in spec test #148

ExpHP opened this issue Jan 17, 2020 · 0 comments

Comments

@ExpHP
Copy link

ExpHP commented Jan 17, 2020

Looking at the tests, I see this file:

https://github.com/chyh1990/yaml-rust/blob/360a34d75bb64357cfdbc5bb706bcde9a0ecbc23/tests/spec_test.rs.inc

which appears to be generated from this file:

https://github.com/chyh1990/yaml-rust/blob/360a34d75bb64357cfdbc5bb706bcde9a0ecbc23/tests/specs/handler_spec_test.cpp

However, much of the information tested by the C++ tests is lost in this transformation. Most notably, the contents of scalar values and tags are not tested. Is there a reason for this? I think it would be nice to see this information included in the tests performed by the crate.

(I'm guessing this is due to technical difficulties with parsing the arguments in the conversion script, and/or converting them from C++ syntax to rust?)

(while trying to think through how I could implement this, I found it also unclear why untagged values in the C++ tests sometimes have a tag of "?" and other times a tag of "!"... Ahh, that's covered in section 3.3.2 (Resolved Tags) of the spec)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant